GitLab

Ctrl+Command+D pops up a dictionary at current mouse location for the underlying text.
To implement this for OOPIF, the following changes where made:
+ Add a method to RenderWidgetHostInputEventRouter to return the RenderWidgetHost at the given location.
+ Move TextInputClientObserver logic to RenderFrameImpl
+ Pass both WebWidget and WebView to WebSubStringUtil so that it can query the string for both main frame and sub frames.

Ideally, TextInputClientObserver should belong to RenderWidget. But due to protected inheritance of WebViewImpl form
WebWidget, this would not work for main frame which still holds a WebViewImpl as its WebWidget.

BUG=640355

Review-Url: https://codereview.chromium.org/2278283002
Cr-Commit-Position: refs/heads/master@{#420656}

https://pdfium.googlesource.com/pdfium.git/+log/3f4111fbff12..4dd613cb51c1

$ git log 3f4111fbf..4dd613cb5 --date=short --no-merges --format='%ad %ae %s'
2016-09-23 kcwu Bail out on bad width and height in CCodec_FaxDecoder::CreateDecoder

BUG=648935,649436

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2364973002
Cr-Commit-Position: refs/heads/master@{#420655}

1) Create persistent histogram records in an atomic manner
so there are no half-filled entries left around should the
process crash before it completes.

2) Validate the ID is non-zero before trying to access a
histogram from persistent storage.

BUG=649371

Review-Url: https://codereview.chromium.org/2367503002
Cr-Commit-Position: refs/heads/master@{#420654}

Turns out NetworkState was only needed for the current default network,
so simplify unnecessary pieces.  This is in preparation for adding
WiFi SSID to NetworkState, so I wanted to reduce the dependence on
NetworkState so the code wouldn't be required to fetch the Wifi
SSID as much.

BUG=647691
R=xunjieli

Review-Url: https://codereview.chromium.org/2361563003
Cr-Commit-Position: refs/heads/master@{#420653}

NOTRY=true

Review-Url: https://codereview.chromium.org/2357263005
Cr-Commit-Position: refs/heads/master@{#420652}

BUG=555865

Review-Url: https://codereview.chromium.org/2318303002
Cr-Commit-Position: refs/heads/master@{#420651}

These are flaky tests detected by chromium-try-flakes.appspot.com
in the last day.

Roughly same number of tests as yesterday. So possibly reached a steady
state now.

BUG=619055
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2365783003
Cr-Commit-Position: refs/heads/master@{#420650}

BUG=641626

Review-Url: https://codereview.chromium.org/2352393004
Cr-Commit-Position: refs/heads/master@{#420649}

BUG=642920

Review-Url: https://codereview.chromium.org/2357363002
Cr-Commit-Position: refs/heads/master@{#420648}

Code that follows assumes samples have some non-zero size.
Failing to skip causes unsafe memory de-references and
decoder errors (observed in email thread with twitch.tv

Review-Url: https://codereview.chromium.org/2361903002
Cr-Commit-Position: refs/heads/master@{#420647}

BUG=644932

Review-Url: https://codereview.chromium.org/2363843002
Cr-Commit-Position: refs/heads/master@{#420646}

Made sure that the menubar state is correct when the active space is
changed

BUG=647111

Review-Url: https://codereview.chromium.org/2351283004
Cr-Commit-Position: refs/heads/master@{#420645}

This is part 2 of removing non-material top chrome support.

BUG=649368

Review-Url: https://codereview.chromium.org/2360343003
Cr-Commit-Position: refs/heads/master@{#420644}

This CL is adding support for shipping type. The API allows the page to
influence how the shipping address is described.

Related spec change:
  https://github.com/w3c/browser-payment-api/pull/270
  https://github.com/w3c/browser-payment-api/pull/285

BUG=648052

Review-Url: https://codereview.chromium.org/2351533002
Cr-Commit-Position: refs/heads/master@{#420643}

Currently in ConsoleViewMessage, there is confusion because
message.element() !== message._element
message.element() returns message._wrapperElement
message.contentElement() returns message._element

It should be the case that:
message.element() === message._element, which contains our contentElement()

This CL renames:
_element >> _contentElement
_wrapperElement >> _element

BUG=

Review-Url: https://codereview.chromium.org/2349143006
Cr-Commit-Position: refs/heads/master@{#420642}

Language pak files were moved to res/raw when split apks was being implemented.
Moving them to assets with a java constant keeping track of pak file locations
will improve lookup time and save some space (no more xml files and
resources.arsc).

BUG=529604

Review-Url: https://codereview.chromium.org/2345143002
Cr-Commit-Position: refs/heads/master@{#420641}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/af393fa0a2ff683726f673fd6c773e723cb2468d Add ChromiumOS waterfalls to LogDog. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:638366

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2367713003
Cr-Commit-Position: refs/heads/master@{#420640}

BUG=646677

Review-Url: https://codereview.chromium.org/2362143002
Cr-Commit-Position: refs/heads/master@{#420639}

OtherFormsOfHistoryDialogFragment.show() can throw an IllegalStateException
if it's called after the Activity's onSaveInstanceState(). New fragments
cannot be added after the Acitvity state was saved, as these changes to
the state would be lost.

This CL fixes the problem by only attempting to show the fragment if the
Activity is not in a background state.

BUG=648515

Review-Url: https://codereview.chromium.org/2359753002
Cr-Commit-Position: refs/heads/master@{#420638}

BUG=635947

Review-Url: https://codereview.chromium.org/2367863002
Cr-Commit-Position: refs/heads/master@{#420637}

from a non-top-level WebContents (<webview>).

CreateWebModalDialogViews and ShowModalDialog should only be called with
a top-level WebContents since they assume the existence of
WebContentsModalDialogManager. For non-autoresizable dialogs, this is
already taken care of by ShowWebModalDialogViews(). For resizable
dialogs, these 2 functions have to be called separately. Introduce a
helper function GetTopLevelWebContents that can be used by the
autoresize logic as well as ShowWebModalDialogViews().

BUG=649191

Review-Url: https://codereview.chromium.org/2357243003
Cr-Commit-Position: refs/heads/master@{#420636}

BUG=649684
TBR=courage@chromium.org

Review-Url: https://codereview.chromium.org/2366953002
Cr-Commit-Position: refs/heads/master@{#420635}

BUG=649389

Review-Url: https://codereview.chromium.org/2360733002
Cr-Commit-Position: refs/heads/master@{#420634}

BUG=627517
TBR=(api change)

Review-Url: https://codereview.chromium.org/2361613002
Cr-Commit-Position: refs/heads/master@{#420633}

https://chromium.googlesource.com/skia.git/+log/5a9c2f110e4f..1cd88c4b759b

$ git log 5a9c2f110..1cd88c4b7 --date=short --no-merges --format='%ad %ae %s'
2016-09-23 reed use SkCanvas::ClipOp
2016-09-23 bungeman Json ide script for gn to output cmake.
2016-09-23 brianosman Change SkSpecialImage::makeSurface and makeTightSurface to take output properties (color space), bounds, and (optional) alphaType.
2016-09-23 brianosman Make GrRenderableConfigForColorSpace argument const
2016-09-23 borenet Add swarming task for nanobench upload
2016-09-23 caryclark split tight quads and conics

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2363103002
Cr-Commit-Position: refs/heads/master@{#420632}

PolicyTest.FullscreenAllowedApp: after r349290, the ScriptContext is delayed until navigation commits. So the test has to wait for navigation first before executing the JS in the app, or else it fails because the chrome app bindings aren't registered yet.

AppWindowAPITest.TestCreate: the badWindow part of this test isn't compatible with PlzNavigate. Or more specifically, the condition isn't possible with it. Without PlzNavigate, creating an app window with an invalid URL would first create that frame with the provisional load URL of the chrome app. So the chrome apps ScriptContext would be setup correctly and view.chrome.app.window.initializeAppWindow would be called with an undefined window. However with PlzNavigate, the frame isn't created until after the navigation commits. At that point, we know that it failed and the URL of the frame becomes the error page url, and as such the chrome apps ScriptContext isn't used since the (error page) url isn't an extension. This can't even be fixed by adding a null check in app_window_custom_bindings.js because the security origin of the background page and the error page is different so Blink disallows the scripting call.

BUG=504347

Review-Url: https://codereview.chromium.org/2366843002
Cr-Commit-Position: refs/heads/master@{#420631}

BUG=617971

Review-Url: https://codereview.chromium.org/2366533002
Cr-Commit-Position: refs/heads/master@{#420630}

Intel devices put CPU temperatures in a devices/ sub directory of hwmon*. ARM
devices and non-CPU sensors on Intel don't use a devices directory and also may
not contain labels. Use the name file for a label if label doesn't exist.

BUG=530499
TEST=configure managed device to auto-start kiosk. ARM devices should show temps. Intel devices should show non-CPU temps.

Review-Url: https://codereview.chromium.org/2115723003
Cr-Commit-Position: refs/heads/master@{#420629}

File creation of tab states is done in an async fashion.
TabsTest should correspondingly use a polling mechanism
to verify files are actually being created.

BUG=649429

Review-Url: https://codereview.chromium.org/2362793002
Cr-Commit-Position: refs/heads/master@{#420628}

BUG=

Review-Url: https://codereview.chromium.org/2364953002
Cr-Commit-Position: refs/heads/master@{#420627}

The TODO in time.h was about removing time_t functions. When I wrote this I was optimistically thinking we wouldn't use time_t any more now that we have the awesome new Time class. This was fantasy so the TODO is removed.

SmallMap uses ManualConstructor. The TODO was that these could be removed when we have C++11 unions. This is true, but the syntax looked worse. There was a use in ConvertToRealMap that still required ManualConstructor for optimum allocations, so it seemed best to just keep using ManualConstructor.

However, the necessity of having the dummy value in the union due to an MSVC error seems no longer applicable. The dummy value is removed.

Review-Url: https://codereview.chromium.org/2363023002
Cr-Commit-Position: refs/heads/master@{#420626}

It is not safe to assume that ImageData::create always returns
a valid point.  Internally it uses DOMUint8ClampedArray::createOrNull
which returns null instead of crashing when allocation fails.
This change adds the appropriate null pointer checks to take
that into account.

BUG=647824
NOTRY=true

Review-Url: https://codereview.chromium.org/2361493003
Cr-Commit-Position: refs/heads/master@{#420625}

This removes the code to selectively enable reporting, and enables the
reporting. It was blocked by crbug.com/630303, which is now fixed.

BUG=630303

Review-Url: https://codereview.chromium.org/2364033002
Cr-Commit-Position: refs/heads/master@{#420624}

BUG=641413

Review-Url: https://codereview.chromium.org/2367543002
Cr-Commit-Position: refs/heads/master@{#420623}

Because Chooser tests interact with the UI they should be marked as
@LargeTests

> As a rule of thumb most functional UI tests are large tests.

https://developer.android.com/reference/android/support/test/filters/LargeTest.html

Also remove the flaky and disabled annotations.

BUG=646097,629579

Review-Url: https://codereview.chromium.org/2354183002
Cr-Commit-Position: refs/heads/master@{#420622}

BUG=501432
R=csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2363743005
Cr-Commit-Position: refs/heads/master@{#420621}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/547cdab7f263971624422ea5b8ac665981c26514 Add Windows 10 location for debugger in process_dumps.py (pschmidt@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=649291

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2366883003
Cr-Commit-Position: refs/heads/master@{#420620}

Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.

BUG=635567

Review-Url: https://codereview.chromium.org/2327833002
Cr-Commit-Position: refs/heads/master@{#420619}

https://pdfium.googlesource.com/pdfium.git/+log/917d24852841..3f4111fbff12

$ git log 917d24852..3f4111fbf --date=short --no-merges --format='%ad %ae %s'
2016-09-23 tsepez Make CPDF_Font::Create() return a std::unique_ptr.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2361423002
Cr-Commit-Position: refs/heads/master@{#420618}

BUG=646384

Review-Url: https://codereview.chromium.org/2361643004
Cr-Commit-Position: refs/heads/master@{#420617}