GitLab

This requires a few changes to how we evaluate pages during the saving process.

1) Instead of ignoring forms where there are more than 3 password fields, assume that those fields are not related to actual passwords. Also change the case of 3 passwords to assume that if the first and second password match, that the third is not related. I don't have statistics on this, but I have seen security questions that are entered into password fields much more often than I have seen a new password entered before and old password (which was the previous assumption).

2) Move change password detection to work on the submitted password form instead of the observed form. The submitted form is more likely to be identified correctly because we have additional data after submission. This failed on Macy's because we incorrectly assume that, given the number of password fields, one of them is a current password field during parsing.

3) Don't require HTML field attributes to match for signup forms. This is normally required because otherwise we can't fill the password we have just saved. However in the case of signup forms this doesn't matter because we don't want to fill on the same form again anyway.

BUG=452306, 451631

Review URL: https://codereview.chromium.org/944163003

Cr-Commit-Position: refs/heads/master@{#318850}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/115b8ac..b2c2289

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/972103002

Cr-Commit-Position: refs/heads/master@{#318849}

BUG=461668
TEST=manually checked

Review URL: https://codereview.chromium.org/967513003

Cr-Commit-Position: refs/heads/master@{#318848}

This CL adds the same handling with https://codereview.chromium.org/937343002

BUG=461694
TEST=check the repro steps manually

Review URL: https://codereview.chromium.org/969763002

Cr-Commit-Position: refs/heads/master@{#318847}

CL generated with data from dead-code analysis using
.../scythe:remove_dead_code #codehealth

Merge internal change: 87564533
https://codereview.chromium.org/973683003/

Change QUIC's PrrSender::TimeUntilSend to accept bytes instead of
packets.  No functional change.

Merge internal change: 87535917
https://codereview.chromium.org/972033002/

Discard acks from QUIC's UnackedPacketMap when the map is larger than
one half of its max size(2500).  Was previously 200.

Merge internal change: 87419283
https://codereview.chromium.org/977453002/

Remove TCP and BBR's max congestion window.  No practical change,
because Chrome's receive window is the limiting factor.

Adds kMaxReportedCwnd and kMaxReorderingForRtt as constants to replace
the max CWND in classes that used to rely on max CWND.

Merge internal change: 87346681
https://codereview.chromium.org/968923005/

Minor simplification to QuicSentPacketManager::PendingRetransmission.
No functional change.

Merge internal change: 87254408
https://codereview.chromium.org/969153002/

Log the QUIC SRBF (socket receive buffer size) as an int instead of
hex value.

Merge internal change: 87247898
https://codereview.chromium.org/974593002/

Minimally test a few things to keep them from Scythe. test-only change.

Merge internal change: 87171236
https://codereview.chromium.org/971493003/

Deprecate FLAGS_quic_limit_time_wait_list_size.

Merge internal change: 87059868
https://codereview.chromium.org/968323002/

CL generated with data from dead-code analysis using
.../scythe:remove_dead_code #codehealth

Merge internal change: 86999211
https://codereview.chromium.org/974563002/

Remove unused ability to disable flow control in QUIC

QuicFlowController::Disable() is no longer called. It was used when we
disabled flow control for the headers and crypto streams, and for old
versions which did not support connection level flow control. Now that
we are on QUIC_VERSION_23, we now use flow control on all streams and
all connections, so this is safe to remove.

Thanks to tgreer@ for the scythe code removal in cl/86835556, and
alyssar@ for noticing that the removal of the dead
QuicFlowController:Disable() meant we could remove substantially more in
this CL.

Merge internal change: 86960342
https://codereview.chromium.org/969053004/

Remove unnecessary virtual CreateQuicConnection method.

Merge internal change: 86947282
https://codereview.chromium.org/972783002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/968233004

Cr-Commit-Position: refs/heads/master@{#318846}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3094822..115b8ac

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/974763002

Cr-Commit-Position: refs/heads/master@{#318845}

This handles the case where
SearchResultTileItemView::SetSearchResult(SearchResult*) may be called
from a nested run loop while its context menu is showing. This cancels
the menu (it's for the old item).

BUG=462470
TEST=Right-click on a start page app to get its context menu. On another
machine (with the same profile), uninstall the app. Context menu should
disappear. Chrome shouldn't crash.

Review URL: https://codereview.chromium.org/969953002

Cr-Commit-Position: refs/heads/master@{#318844}

https://codereview.chromium.org/965943002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/971863002

Cr-Commit-Position: refs/heads/master@{#318843}

As get removed in latest specs, removing it.
spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache-query-options-dictionary

PATCH 1: Chromium: [THIS PATCH]
PATCH 2: Blink: https://codereview.chromium.org/927723003/

BUG=462837

Review URL: https://codereview.chromium.org/941683002

Cr-Commit-Position: refs/heads/master@{#318842}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/405bb4b..3094822

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/973743002

Cr-Commit-Position: refs/heads/master@{#318841}

DeleteNamespace() is called during shutdown (in a call chain: DOMStorageSession::~DOMStorageSession() -> DOMStorageContextImpl::DeleteSessionNamespace() -> SessionStorageDatabase::DeleteNamespace()).

Trying to open DB during shutdown causes unnecessary disk access, and it results in slowing down Chrome shutdown.
On Chrome OS, this is observed as a crash because Chrome gets aborted when it cannot finish shutdown quickly. (http://crbug.com/418627)

BUG=462500

Review URL: https://codereview.chromium.org/968103002

Cr-Commit-Position: refs/heads/master@{#318840}

BUG=

Review URL: https://codereview.chromium.org/970993002

Cr-Commit-Position: refs/heads/master@{#318839}

Default vars (like run_jscompile) should only be defined in one place.
This cl adds remoting_options.gypi so that the variables can be used
by both DesktopRemoting and AppRemoting gyp files.

BUG=

Review URL: https://codereview.chromium.org/974673002

Cr-Commit-Position: refs/heads/master@{#318838}

BUG=461920

Review URL: https://codereview.chromium.org/974683002

Cr-Commit-Position: refs/heads/master@{#318837}

R=rockot@chromium.org

Review URL: https://codereview.chromium.org/971793002

Cr-Commit-Position: refs/heads/master@{#318836}

BUG=463053
TEST=manually tested as described in the issue.

Review URL: https://codereview.chromium.org/964393002

Cr-Commit-Position: refs/heads/master@{#318835}

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/971723002

Cr-Commit-Position: refs/heads/master@{#318834}

BUG=b/19370387

Review URL: https://codereview.chromium.org/972833002

Cr-Commit-Position: refs/heads/master@{#318833}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fcd7003..405bb4b

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/973433004

Cr-Commit-Position: refs/heads/master@{#318832}

Chrome is crashin'.

BUG=463346
TEST=trybots
TBR=nasko

Review URL: https://codereview.chromium.org/968283005

Cr-Commit-Position: refs/heads/master@{#318831}

BUG=462026
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/957113002

Cr-Commit-Position: refs/heads/master@{#318830}

The overwrite parameter determines whether the value_map_ member should be cleared.
The only time it is called with "false" is from the constructor at which point
value_map_ should be empty anyway. So we should be able just to remove this
parameter.

Review URL: https://codereview.chromium.org/965793003

Cr-Commit-Position: refs/heads/master@{#318829}

(in the top level Autofill Preferences page)

BUG=461006

Review URL: https://codereview.chromium.org/952613003

Cr-Commit-Position: refs/heads/master@{#318828}

Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.

BUG=334090
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/966433003

Cr-Commit-Position: refs/heads/master@{#318827}

Introduced in https://codereview.chromium.org/938873002/

R=piman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/967343003

Cr-Commit-Position: refs/heads/master@{#318826}

chrome.management.uninstall.

R=rdevlin.cronin@chromium.org
BUG=463003

Review URL: https://codereview.chromium.org/971993002

Cr-Commit-Position: refs/heads/master@{#318825}

This is a follow-up to https://codereview.chromium.org/874283006
which introduces the cr-network-icon Polymer element for
displaying an icon representing network state in web UI.

It also includes minor changes to the fake shill implementation to facilitate manual testing.

BUG=455499

Review URL: https://codereview.chromium.org/954293003

Cr-Commit-Position: refs/heads/master@{#318824}

This is part 1 (chromium),
part 2 (clank) is https://chrome-internal-review.googlesource.com/#/c/195455/

This CL is only about propagation/plumbing.
Neither the reporting of audible state my players nor the consumption
(UI notification) are implemented.

This patch creates a new object AudioMonitorAndroid and
attaches it to MediaWebContentsObserver. The AudioMonitorAndroid
maintains the audible state for the tab. It receives notifications
from MediaPlayerAndroid objects and sends the resulting
notification to the WebContents.

BUG=414810

Review URL: https://codereview.chromium.org/896673003

Cr-Commit-Position: refs/heads/master@{#318823}

The cl does 4 things:
(1) Adds a list (in gyp) for the feedback_consent js files.
(2) Uses build-html.py to build feedback_consent.html from a template.
(3) Adds an action to run jscompile over the feedback_consent js files.
(4) Fixes the errors/warnings reported by jscompile.

BUG=

Review URL: https://codereview.chromium.org/964403004

Cr-Commit-Position: refs/heads/master@{#318822}

(Views only for now.)

BUG=463291

Review URL: https://codereview.chromium.org/969223002

Cr-Commit-Position: refs/heads/master@{#318821}

R= bradnelson@chromium.org
BUG= none

Review URL: https://codereview.chromium.org/971493004

Cr-Commit-Position: refs/heads/master@{#318820}

BUG=463132

Review URL: https://codereview.chromium.org/969133002

Cr-Commit-Position: refs/heads/master@{#318819}

BUG=273710

Review URL: https://codereview.chromium.org/959123004

Cr-Commit-Position: refs/heads/master@{#318818}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3a0ba1e..fcd7003

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/967313005

Cr-Commit-Position: refs/heads/master@{#318817}

As the TODO in power_api_manager.h by derat@,
move PowerApiManager to power_api and rename to PowerAPI.

BUG=
R=derat@chromium.org

Review URL: https://codereview.chromium.org/958313002

Cr-Commit-Position: refs/heads/master@{#318816}

Similarly GbmWrapper to GbmDevice. This was done to better reflect their
role.

BUG=none

Review URL: https://codereview.chromium.org/908993003

Cr-Commit-Position: refs/heads/master@{#318815}

This CL causes the app list tab navigation to correctly cycle to and from
the custom launcher page. This has been fixed by adding a SearchBoxFocusHost
which directs the focus search to the search box.

BUG=462079

Review URL: https://codereview.chromium.org/960133005

Cr-Commit-Position: refs/heads/master@{#318814}

The #if around NativeWebContentsModalDialog is a problem for building
the MacViews browser. Unify them to be gfx::NativeWindow on all platforms.
Refactor the cocoa side to move code from ConstrainedWindowMac into
SingleWebContentsDialogManagerCocoa, while keeping
ConstrainedWindowMac's interface the same as before.
The Views side only needs simple changes from NativeView to NativeWindow.

BUG=425229

Review URL: https://codereview.chromium.org/866263008

Cr-Commit-Position: refs/heads/master@{#318813}

Use INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT instead of
INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT as the
final component to calculate input latency.

This will more accurately reflect latency regressions in the
code we have direct control of in Chrome.

Also make PassThroughImageTransportSurface::PostSubBuffer
add a INPUT_EVENT_GPU_SWAP_BUFFER_COMPONENT, which it
was missing before.

Followup patches will snap
INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT
to the next vsync to reflect the real display time.

The real display time can then be used for better
smoothness metrics and also to track latency regressions
at the OS/driver level for Ozone and potentially other
platforms where we can extract swap info.

BUG=360844

Review URL: https://codereview.chromium.org/918883002

Cr-Commit-Position: refs/heads/master@{#318812}

BUG=463184

Review URL: https://codereview.chromium.org/969063002

Cr-Commit-Position: refs/heads/master@{#318811}