- 15 Oct, 2019 40 commits
-
-
Kevin McNee authored
This reverts commit 5d01e87e. Reason for revert: Caused regression https://crbug.com/1014385 Original change's description: > Define guest view custom elements synchronously > > Previously, we've had to wait for readystatechange before defining > the guest view custom elements because > 1) there were circular dependencies that would cause errors if we > tried to perform the definition immediately, and > 2) the Custom Elements V0 registration context was scoped to the > document rather than the window, so if we defined the elements > while the document was still on about:blank, the definition would > be available on about:blank, but not for the extension. > > Now that the circular dependencies are fixed and guest view is > migrated to Custom Elements V1 (whose registration context is > scoped to the window), it is no longer necessary to wait for > readystatechange. > > We now perform the definition immediately. > > Bug: 810012 > Change-Id: Ib5e8ba6f4e302eaae56c5566765521d64b1a0e15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1278287 > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700425} TBR=wjmaclean@chromium.org,mcnee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 810012, 1014385 Change-Id: Ie43a88bc07036fc392079cc8f2593e28440de104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863691Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706200}
-
Gavin Williams authored
-In error input scenarios, current implementation will display useful error text but is not read out by screen readers. This change forces these alerts to be read by screen readers. Bug: 1012532 Change-Id: Iadd263d17bf648660f6e365495093543cab86666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854529Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#706199}
-
Aga Wronska authored
The feature is enabled since July 2018. Bug: 1013650 Change-Id: I23fdbb2a15ec68c6fc7f975c1d800dacb85ca5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857197Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#706198}
-
Tomasz Wiszkowski authored
The embedded change updates prefetch fake page classification from NTP to INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS to allow the request to be correctly categorized by ZeroSuggestProvider in cases where ZeroSuggestVariant:6 parameter (for INSTANT_NTP...) includes RemoteNoUrl source, whereas ZeroSuggestVariant:1 parameter (for NTP) doesn't. Bug: 1004932, 1004925 Change-Id: Ia797b490b90f1b596b1e175c91d37c975b0d45e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861099 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706197}
-
Marcin Wiącek authored
Add missed entry. Change-Id: I59d8ae5d67b42f8ea5cb52cae56d82db819ff8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829264Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#706196}
-
Lukasz Anforowicz authored
imported/wpt/html/syntax/parsing/html5lib_tests19.html used to be disabled in presence of site-per-process / Site Isolation, because it might trigger a crash. It seems that the crash is not happening anymore, so let's try removing the Crash/Failure expectations for the test from TestExpectations. This also means that running the test via not-site-per-process virtual test suite is not needed anymore. Note that this CL does not modify html5lib_tests19-expected.txt - some test cases inside tests19 are expected to fail. This expectation came from the very beginning - when WPT were being imported in https://codereview.chromium.org/1164243002 Bug: 645641 Change-Id: Ib0584faac35f09703821c441fdca10726ceb0d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863539 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706195}
-
tby authored
Because the Drive QuickAccess API starts up quite slowly, our attempt to warm the cache almost always fails. Let's remove it. Bug: 1011221 Change-Id: I59b4d3c1a24a81f5c343dd8d26c1f15442fe9876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861796 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706194}
-
Gabriel Charette authored
TBR=dcheng@chromium.org Bug: 992483 Change-Id: I20ab6c566d22994fd098a06e625aa9e7f1173e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863752Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#706193}
-
Robert Ma authored
The only remaining match was a dead link in common/net/file_uploader.py, which has been replaced with a permalink (pinned to the correct line & revision) to GitHub. Bug: 770329 Change-Id: I89d15897882c8e5b0d73ff61ff401c7f47ff6924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863072 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706192}
-
Wenbin Zhang authored
Currently most of the presubmit checks are following a similar routine. Per discussed in the following CL, we should refactor those functions. https://chromium-review.googlesource.com/c/chromium/src/+/1850353 Bug: 1006771 Change-Id: I380c9793f446b0c6e8ab814381b797d5f12ffff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857239 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706191}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43253cb0a391..a6dd74cc6ed0 Created with: gclient setdep -r src-internal@a6dd74cc6ed0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005965,chromium:None Change-Id: I3c7db353aef526dc4f64dfcd1ff8638a12355ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863122Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706190}
-
Peter Kasting authored
This simplifies the reasoning about when these are present, and will make managing them with a layout manager slightly easier. Bug: none Change-Id: I5868dbb31bd4022010936611fe794185014e878d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857195Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c594e6269813..b7c5bac9da28 git log c594e6269813..b7c5bac9da28 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 jvanverth@google.com Remove some more MoltenVK support 2019-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 8c5dee1e7fe2..8e28e18b5c9e (1 commits) 2019-10-15 csmartdalton@google.com Reland "ccpr: Unblacklist Qualcomm with msaa" 2019-10-15 egdaniel@google.com Remove some unneeded colortype format validation checks in ProxyProvider. 2019-10-15 csmartdalton@google.com Reland "Use GL_QCOM_TILED_RENDERING to explicitly discard stencil" Created with: gclient setdep -r src/third_party/skia@b7c5bac9da28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None Change-Id: I7140efc792695752f122e781c0f9e4749188a094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863124Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706188}
-
Kevin McNee authored
This test was flakily timing out waiting for the scroll to bubble. It now appears that input events are dropped before the first compositor commit, so even though the test does not need hit test data to be available, we wait for it anyway so that we know it's okay to start sending input events. Bug: 1014155 Change-Id: I6197fec56e29bf246b210cd4f71d6a84d49694fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863127Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706187}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d0e5b554d4f..81ab9c90998f git log 2d0e5b554d4f..81ab9c90998f --date=short --no-merges --format='%ad %ae %s' 2019-10-15 lsalzman@mozilla.com Use image upload workaround for Intel Ivy Bridge with D3D11 renderer. Created with: gclient setdep -r src/third_party/angle@81ab9c90998f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I2ef8ea16668610f14083241f558d91c84c901f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863123Reviewed-by:
-
Tommy Li authored
Currently, we trigger on-focus suggestions (ZeroSuggest) when the omnibox receives focus. But what about the case where the omnibox starts with focus, like the NTP? In the status quo, the user would have to blur and then re-focus the omnibox. This CL allows users to get on-focus suggestions by clicking or tapping the omnibox while already focused, assuming the textfield is empty. We restrict it to empty textfield because: 1) The only known use-case is the NTP so far. 2) We want to be conservative and not disrupt any user text selection or editing. Bug: 1010368, 996516 Change-Id: I2681c297c1372a5421f742bd0f18657f3c8603ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863589 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706185}
-
Rob Schonberger authored
Bug: 1009290 Change-Id: Ie3a17a6df2f7190cf9536e5414fc814f3d1f21e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846214Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706184}
-
Roman Sorokin authored
Bug: none Change-Id: I2e9c37a3f8c60c4e99d93ab06a26393e6115545d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847283Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706183}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3dbb965bdf76..0e17af90d4c9 git log 3dbb965bdf76..0e17af90d4c9 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 oysteine@google.com Merge "Fetch symbol names using the new symbol_table() during EXPORT_JSON" Created with: gclient setdep -r src/third_party/perfetto@0e17af90d4c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I611af35f6b97c708000991d3930e67f8ad68cf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863120Reviewed-by:
-
James Cook authored
DeviceSyncService runs in the browser process on the UI thread. It can directly use the Profile's PrefService*. This simplifies the code, and will reduce the amount of work rockot@ has to do for Service Manager cleanup. Delete the DeviceSyncService mojo interface and implementation object. They primarily existed to support wiring up the mojo pref service. Instead, directly connect the DeviceSyncClientImpl to the backing DeviceSyncImpl. Explicitly initialize the DeviceSyncImpl when the user's profile is ready. The old code had startup timing dependencies that assumed that DeviceSyncImpl was created after IdentityManager had information about the primary profile. The new code instantiates the DeviceSyncImpl object earlier, and IdentityManager may not be ready yet. Bug: 977637, 1012941 Test: bots Change-Id: Ia32b687404e5b68980cb3aecd3003e6f7e48ffcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849217 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706181}
-
Ken Rockot authored
This removes the generalized GetMany API from LevelDBDatabaseImpl, which was only used by session storage to fetch specific metadata fields. The database logic has been migrated fully into SessionStorageContextMojo. Bug: 1000959 Change-Id: Ie972684a5ccedfc879997540ea2b3d4ac6698dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859587Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706180}
-
James Hollyer authored
We are eliminating base::Bind in favor of base::BindOnce and base::BindRepeating in order to be more explicit. Bug: 1007811 Change-Id: I755a3b27dcfba2313a8c8f6c23b53a41525886d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863749Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706179}
-
Christopher Grant authored
BUG: None Change-Id: Ie3724fdc25171b5b5ce0fc1190498dbcaf2238fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863355Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#706178}
-
Hazem Ashmawy authored
Build boundary interfaces as a jar using java-library plugin instead of "com.android.library" plugin. This makes it simpler and easier to embed the compiled jar in webkit AAR file without any dirty workarounds like unzipping the AAR or accessing intermediates build files. Removing AndroidManifest.xml file since it's no longer needed by android library plugin. Bug: https://issuetracker.google.com/issues/142394338 Bug: https://issuetracker.google.com/issues/140178227 Test: manually cherry-pick change to //external and run gradlew :webkit:assembleRelease and gradlew :webview-support-interfaces:assembleRelease Change-Id: I1df2f04bb737c1f376d7d1a70c6c5d0664e2f39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859990Reviewed-by:
Aurimas Liutikas <aurimas@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#706177}
-
Thomas Tellier authored
see https://bugs.chromium.org/p/chromium/issues/detail?id=994492#c12 Bug: 994492 Change-Id: Icd4c1fa6ed5225092a5ca29eba2da07107e3876d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823876Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Daniel McArdle authored
Reduces complexity from O(n^2) to O(n). Prior to this commit, we were performing an O(n) vector::erase for each empty child, say O(n) of them. Now, we do an amortized constant vector::push_back for each child to keep, along with O(n) constant-time vector::swap operations. Bug: 1014388 Change-Id: I4e614463c5ac207dd036876a54e65cca8ce0ed25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863154 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
-
Nikita Podguzov authored
Bug: 992889 Change-Id: Ic2b8ff888960bfe23a4a1193db9002bb486e9393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847395Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706174}
-
Rakib M. Hasan authored
This CL will remove the property decorator from a couple of fields in the TestFailure class, add named parameters to the DriverOutput constructor in test_failures_unittest.py and changed parameter names for baseline output back to expected_driver_output. Bug: chromium:1014196 Change-Id: I54353c2a6c19588b116a9f2ad86dc17df89f0f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863572 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#706173}
-
Thomas Tellier authored
Bug: 1002107 Change-Id: I51f7cb640b9e7438b407cbdcfa9afaf4e57c4d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862453Reviewed-by:
-
Zhongyi Shi authored
Change-Id: I6533f0abcdaf5667d3f7e0d2fb047dd1042e8163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861279 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706171}
-
Rahul Arakeri authored
The test fails because it tries to dereference a raw pointer which points to layer that was destroyed. The fix is to set the pointer to null and add checks in scrollbar_controller.cc Bug: 1002828, 987115 Change-Id: I46efc7e35ee62bb36020a42aafbd75998728017c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854534 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706170}
-
meacer authored
This CL adds summaries and explanations for safety tips to the security tab of devtools. It assigns the precedence of warnings as SafeBrowsing > Safety Tips > Connection status. Bug: 1013374 Change-Id: I62524947a8c4588af78a430e0565e0969b8dc3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856680 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#706169}
-
Gary Kacmarcik authored
The new binaries don't work yet, so we need the installer to continue using the old binaries until we are ready to switch over. Change-Id: I776dcf8fcfe87cf12ac47ad1f48add85c58a178a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863732 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#706168}
-
Vladislav Kaznacheev authored
Bug: none Test: none Change-Id: Iee2fc67f7e9c25c3a8f745b0c316acdaf16b28ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859680 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706167}
-
Owen Min authored
The pref is registered with profile prefs. Also change the enterprise_reporting::RegisterPrefs to enterprise_reporting::RegisterLocalStatePrefs. Bug: 1006899 Change-Id: I8334229e585f088f0a5da8bd8d0545c5c9078ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854467Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
Mike Wiitala authored
Histogram to show distribution of Chrome OS users across wireless regulatory domains. Bug: chromium:950225 Test: Tested manually on DUT. Change-Id: I09718c854d435e2cffe5f8f2f2f79d56c48f3eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758401 Commit-Queue: Mike Wiitala <mwiitala@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#706165}
-
Adrian Taylor authored
Change-Id: I4e1c979b9980c458b7f0de5eee4beae93d1888a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848112 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706164}
-
Caroline Rising authored
Update an extension's position when it moves past the midway point between extensions. Bug: 1008538 Change-Id: I302bc0f4b50bb37999ce5c164a171ccd2eeeee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863509Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#706163}
-
Peter Kasting authored
I couldn't actually get this to trigger in practice; on trunk the button seems to snap between widths. That also seems like reasonable behavior and results in noticeably simpler code. Finally, when converting the result view to use layout managers, I couldn't find a way to produce an animation-based behavior anyway. Bug: none Change-Id: I4d2750b675de4bda8758eac2f530ee8b1467dd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854533 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706162}
-
Parastoo Geranmayeh authored
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest ::NestedSurfaceHitTestTest is flaky. TBR=kenrb@chromium.org Bug: 1014602 Change-Id: If7c69bcf4a50c8e7b2646ec8826ea0115018cca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862663 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706161}
-
