GitLab

When the root layer scroll offset delegate's scroll offset is bigger
than that of the outer viewport scroll layer, the root scroll offset is
distributed between inner and outer viewport scroll layer. However, the
layer that gets assigned a new scroll offset first will immediately
update the root layer delegate scroll offset without waiting for the
rest of the undistributed scrolls to be assigned to other layer. This
causes the associated bug 470360.

This CL simplified the logic around delegated scrolling by removing
LayerImpl::ScrollOffsetDelegate. LayerImpl will always have the most
recent and correct scroll offset.

LTHI and LTI still delegate the root layer scroll to an external source
(Android WebView).
There are 2 cases for a LayerImpl to change its scroll offset:
1. When the root layer scroll delegate scrolls, the new scroll offset will be
synchronously distributed to the inner and outer viewport scroll layer.
2. The LayerImpl scrolls by itself, like ScrollBy() or PushScrollOffset(). In
this case, root layer scroll delegate will be updated with the new scroll
offset.

BUG=470360

Review URL: https://codereview.chromium.org/1038173002

Cr-Commit-Position: refs/heads/master@{#324012}

TEST=Compiles and all current tests pass.
BUG=None

Review URL: https://codereview.chromium.org/1062853004

Cr-Commit-Position: refs/heads/master@{#324011}

BUG=440649

Review URL: https://codereview.chromium.org/1043373002

Cr-Commit-Position: refs/heads/master@{#324010}

Revert of C++ readability review (patchset #10 id:180001 of https://codereview.chromium.org/706993003/)

Reason for revert:
It looks like this broke tests the following tests on Linux Chromium OS:
AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired
AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired

Example output:
AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired (run #1):
[ RUN      ] AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired
[11334:11334:0406/201742:404219967:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument
[11334:11334:0406/201742:404230154:FATAL:timer.cc(116)] Check failed: !user_task_.is_null().

AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired (run #1):
[ RUN      ] AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired
[11382:11382:0406/201748:411022458:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument
../../components/timers/alarm_timer_unittest.cc:469: Failure
Value of: did_run
  Actual: true
Expected: false

Example build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/996

Original issue's description:
> C++ readability review
>
> BUG=b/18275087
>
> Committed: https://crrev.com/05e4d854dca737cfb43cd967cd72d024f6b1625b
> Cr-Commit-Position: refs/heads/master@{#324004}

TBR=derat@chromium.org,gromer@google.com,zea@chromium.org,chirantan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/18275087

Review URL: https://codereview.chromium.org/1058693003

Cr-Commit-Position: refs/heads/master@{#324009}

BUG=473561
TEST=none

Review URL: https://codereview.chromium.org/1061833002

Cr-Commit-Position: refs/heads/master@{#324008}

This reduces the complexity of the code needed to validate
internalformat and makes it easier to add new formats.

BUG=474280
TEST=gl_tests --gtest_filter=GpuMemoryBufferTests/GpuMemoryBufferTest.Lifecycle/*

Review URL: https://codereview.chromium.org/1068663002

Cr-Commit-Position: refs/heads/master@{#324007}

BUG=473471

Review URL: https://codereview.chromium.org/1060483002

Cr-Commit-Position: refs/heads/master@{#324006}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/efd7029..61c4468

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1060163003

Cr-Commit-Position: refs/heads/master@{#324005}

BUG=b/18275087

Review URL: https://codereview.chromium.org/706993003

Cr-Commit-Position: refs/heads/master@{#324004}

BUG=473370

Review URL: https://codereview.chromium.org/1058423002

Cr-Commit-Position: refs/heads/master@{#324003}

BUG=450641
Test=<TO_BE_FILLED_IN>

Review URL: https://codereview.chromium.org/1052343003

Cr-Commit-Position: refs/heads/master@{#324002}

This CL added a wrapper on top of quic_simple_server so that
Cronet tests can spin up a local quic server on the device.

BUG=411010

Review URL: https://codereview.chromium.org/1039693003

Cr-Commit-Position: refs/heads/master@{#324001}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/83c3890..efd7029

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1064683004

Cr-Commit-Position: refs/heads/master@{#324000}

Avoid calling the GetSystemMetrics API in the renderer process on Windows to get the scrollbar metrics.

It appears that this call takes a long time on certain Windows 8 configurations because the call triggers a load
of the uxtheme.dll which fails and retries every time. This is presumably due to the Win32K lockdown mode on Windows 8+.

Fix is to send the scrollbar metrics values we are interested in as part of the RendererPrefs structure. In the renderer
these are saved as static values in the WebThemeEngineImpl class.

1) Note that not all of the cache settings are currently used - SM_CYHSCROLL,
SM_CYVSCROLL, and SM_CXHSCROLL are cached for possible future usage.

2. These repeated attempts to load uxtheme.dll only occur in some (ill-defined)
situations, having to do with what theme is selected and other factors

BUG=472790

Review URL: https://codereview.chromium.org/1054243002

Cr-Commit-Position: refs/heads/master@{#323999}

base's MD5String() is a helper function that does exactly what this
piece of code in ReadData() is doing, so we can just call MD5String()
and simplify it instead.

BUG=None
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/1054433004

Cr-Commit-Position: refs/heads/master@{#323998}

Revert of bluetooth: Move requestDevice() to UI thread. (patchset #2 id:20001 of https://codereview.chromium.org/1058373002/)

Reason for revert:
The layout test bluetooth/requestDevice.html became flaky after this patch landed.

Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=bluetooth%2FrequestDevice.html

Example failure link:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/builds/35097

Failure output:
This is a testharness.js-based test.
PASS window.testRunner is required for the following tests.
PASS Reject with NotFoundError.
FAIL Reject with SecurityError. assert_unreached: Mock was set to reject. Reached unreachable code
PASS Mock will resolve.
Harness: the test ran to completion.

Original issue's description:
> bluetooth: Move requestDevice() to UI thread.
>
> BluetoothAdapter is not thread safe, this change moves the requestDevice() call to it onto the UI thread.
>
> BUG=420284
>
> Committed: https://crrev.com/8a72921779123fbd7a7f756f9683f4df8944ea9d
> Cr-Commit-Position: refs/heads/master@{#323919}

TBR=scheib@chromium.org,ortuno@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=420284

Review URL: https://codereview.chromium.org/1048313003

Cr-Commit-Position: refs/heads/master@{#323997}

BUG=409094,295137

Review URL: https://codereview.chromium.org/1067743002

Cr-Commit-Position: refs/heads/master@{#323996}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ddd534f1..d073ccb0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1060953003

Cr-Commit-Position: refs/heads/master@{#323995}

BUG=412078

Review URL: https://codereview.chromium.org/1065753002

Cr-Commit-Position: refs/heads/master@{#323994}

BUG=425672

Review URL: https://codereview.chromium.org/1059393002

Cr-Commit-Position: refs/heads/master@{#323993}

BUG=474299

Review URL: https://codereview.chromium.org/1059483004

Cr-Commit-Position: refs/heads/master@{#323992}

This custom polymer element is used to show issues related to casting. It is styled after the current cast extension's issue banner.

BUG=464222

Review URL: https://codereview.chromium.org/1023673008

Cr-Commit-Position: refs/heads/master@{#323991}

Add a histogram "Network.Shill.Wifi.UnreliableLinkSignalStrength"
for sampling WiFi signal strength when the WiFi network becomes
unreliable (experiencing multiple link failures in a short period
of time).

BUG=chromium:416631
TEST=pretty_print.py, validate_format.py

Review URL: https://codereview.chromium.org/1064693004

Cr-Commit-Position: refs/heads/master@{#323990}

This is to unbreak the some fyi bots, where failing to install the
webview test apks causes the whole run to be aborted.

All webview tests are annotated with
@MinAndroidSdkLevel(Build.VERSION_CODES.KITKAT) so in theory they should
never run on those older bots anyway.

BUG=474374

Review URL: https://codereview.chromium.org/1068633002

Cr-Commit-Position: refs/heads/master@{#323989}

Adding this whitelist will force additional review for new uses of this GN function. The current whitelist is just the current list of callers.

Review URL: https://codereview.chromium.org/1063873002

Cr-Commit-Position: refs/heads/master@{#323988}

After the method was moved off the IO thread, the scoped trackers were no
longer relevant.

BUG=466405

Review URL: https://codereview.chromium.org/1060173002

Cr-Commit-Position: refs/heads/master@{#323987}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ba9d195..83c3890

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1053323004

Cr-Commit-Position: refs/heads/master@{#323986}

BUG=

Review URL: https://codereview.chromium.org/1061053003

Cr-Commit-Position: refs/heads/master@{#323985}

Report durations of performLayout directly without doing any analysis.
Ignore other events.
Use interactions.
A "load" event may be implemented in another cl, possibly using https://code.google.com/p/chromium/issues/detail?id=345845

BUG=460208

Review URL: https://codereview.chromium.org/979243003

Cr-Commit-Position: refs/heads/master@{#323984}

This separates the Chromium side of requestMediaKeySystemAccess() into the Blink interface implementation (WebEncryptedMediaClientImpl), which also handles the UMAs, and the core algorithm (KeySystemConfigSelector). This should make it easy to test the core algorithm.

BUG=468912

Review URL: https://codereview.chromium.org/1052273004

Cr-Commit-Position: refs/heads/master@{#323983}

BUG=381338
TEST=ctrl+alt+z; navigate to html5demos.com/geo; observe speech is as expected (reads contents of bubble).

Review URL: https://codereview.chromium.org/1055883002

Cr-Commit-Position: refs/heads/master@{#323982}

The PaintContext may be backed by a DisplayItemList in the future so it
will not have a canvas(). Instead invoke a PaintRecorder to use a canvas
or another Recorder to do other operations such as clip or opacity.

This adds a CompositingRecorder for compositing operations like opacity.
It could also support effects like blend modes, and will generate
cc::CompositingDisplayItems in the future.

R=sky
BUG=466426

Review URL: https://codereview.chromium.org/1054783003

Cr-Commit-Position: refs/heads/master@{#323981}

Add an API to detect the host timezone to ICU. See

  https://chromium.googlesource.com/chromium/deps/icu/+log/e4c3143982..10834e84d2

BUG=406382
TEST=None
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1065723002

Cr-Commit-Position: refs/heads/master@{#323980}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/08b3249..ff271c2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1067673002

Cr-Commit-Position: refs/heads/master@{#323979}

The additional indirection foils clang's efforts...for now.

BUG=467929

Review URL: https://codereview.chromium.org/1064713003

Cr-Commit-Position: refs/heads/master@{#323978}

This gives a name to the event which otherwise will appear
on the histogram simply as a number.

BUG=chromium:431360
TEST=none

Review URL: https://codereview.chromium.org/1061933002

Cr-Commit-Position: refs/heads/master@{#323977}

CronetUrlRequest.java to reduce JNI code. After the
refactoring, cronet_url_request.cc is merged with
cronet_url_request_adapter.cc, since the former mostly
contains JNI code that can be generated by
@NativeClassQualifiedName.
This CL also inlines CronetUrlRequestAdapterDelegate, since
we have only one file now.

BUG=458276

Review URL: https://codereview.chromium.org/923213002

Cr-Commit-Position: refs/heads/master@{#323976}

BUG=none
R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/1016193002

Cr-Commit-Position: refs/heads/master@{#323975}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d982612..ba9d195

TBR=jsbell@chromium.org,falken@chromium.org

Review URL: https://codereview.chromium.org/1060183002

Cr-Commit-Position: refs/heads/master@{#323974}

BUG=472677

Review URL: https://codereview.chromium.org/1060163002

Cr-Commit-Position: refs/heads/master@{#323973}