- 25 Oct, 2018 40 commits
-
-
Sara Kato authored
Screen rotation may be triggered using Ctrl + Shift + Reload (F5). The screen will be rotated if the user presses "Continue". UI Strings for ash_strings are still in review. TEST: Manual Bug: 881929 Change-Id: Ie6c067f164b0a0d6f4d68f0d29360d7166937e70 Reviewed-on: https://chromium-review.googlesource.com/c/1272556Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602934}
-
Jun Mukai authored
When the window is moving across displays, GetBoundsInScreen() may return an incorrect location because it hasn't moved to the new display yet completely. This CL adds a new method to aura::Window to indicate this intermediate status so that ws::ClientRoot can wait slightly on sending the bounds change. ClientRoot still emits the OnWindowBoundsChanged synchronously upon bounds change, but it can wait for the new root window when moving across displays. See crrev.com/c/1284952 for my previous attempt. BUG=892714 TEST=the new test case covers Change-Id: I32fad8cc17c373705e1e27b46b4617784a15a869 Reviewed-on: https://chromium-review.googlesource.com/c/1298087 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602933}
-
Adrienne Walker authored
The jitter benchmark has been removed in issue 717217, and nobody is looking at these metrics. Just cleaning up old code. Bug: 542813,717217 Change-Id: I2d4d806d30ef98873fbf64629ddf5fb883756ca6 Reviewed-on: https://chromium-review.googlesource.com/c/1299925Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602932}
-
Thomas Tangl authored
When there is no spellcheck dictionary, the "Enhanced spellcheck" toggle is hidden. TBR=jochen@chromium.org Bug: 855945 Change-Id: I490abeba215382853462d092937f7e8607c84439 Reviewed-on: https://chromium-review.googlesource.com/c/1297140 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602931}
-
Hector Carmona authored
Bug: 889222 Change-Id: I3d6fbbef53796aac52dde832ed47a0ead12787ca Reviewed-on: https://chromium-review.googlesource.com/c/1285691 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Sandra Sun authored
There was a conflict in the scroll snap spec for the initial values of scroll-padding-top/bottom/left/right[1]. Some of the initial values were auto, while others were 0px. Now the conflict has been resolved with all the initial values set to auto[2], we should update the wpt test to reflect that. The current implementation in Blink already reflects the updated spec, so this patch also removes the expectations that were simply for the failures. [1] https://github.com/w3c/csswg-drafts/issues/3189 [2] https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding-top Bug: 891954 Change-Id: Ib9c2280590091be27127abeee0a611b687cd37a2 Reviewed-on: https://chromium-review.googlesource.com/c/1299605Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#602929}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/94f45b29897f..84a534d9473a git log 94f45b29897f..84a534d9473a --date=short --no-merges --format='%ad %ae %s' 2018-10-25 thestig@chromium.org Remove rarely used GDI+ using statements. 2018-10-25 thestig@chromium.org Remove unused GDI+ code. 2018-10-25 thestig@chromium.org Change DrawBitsWithMask() to take a matrix by const-ref. 2018-10-25 thestig@chromium.org Change StartDIBits() to take a matrix by reference. 2018-10-25 thestig@chromium.org Change FXDIB_BLEND_FOO typedefs to an enum class. Created with: gclient setdep -r src/third_party/pdfium@84a534d9473a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib3c1bb6258b57b8108912e60bc39f3f221bbeb26 Reviewed-on: https://chromium-review.googlesource.com/c/1299981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602928}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/197af6349288..c2540ca187ba Created with: gclient setdep -r src-internal@c2540ca187ba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id80dbb16b704475bd92c3342a8c3954fa224adde Reviewed-on: https://chromium-review.googlesource.com/c/1299980Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602927}
-
Ted Choc authored
It was unnecessarily bouncing into the ListView. BUG=898522 Change-Id: I7e03bc5ded06bf992907a10bfb478fa261ce65ac Reviewed-on: https://chromium-review.googlesource.com/c/1298202Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602926}
-
Erik Chen authored
The test runner now restarts content shell instead of passing this flag to content shell when the behavior is desired. Bug: 894527 Change-Id: I28bc74239c74cbcadcdcbc927eb213a07cbed5c0 Reviewed-on: https://chromium-review.googlesource.com/c/1296674 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#602925}
-
Zach Stein authored
Stats collector calls SocketAddress::ToString on remote candidate addresses that might contain .local hostnames. This changes causes ToString to output the hostname instead of the resolved IP. Bug: webrtc:9861 Change-Id: I24acdd555a66627749c25e36124b6c86a413c59a Reviewed-on: https://chromium-review.googlesource.com/c/1281142Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#602924}
-
Khushal authored
These are bitmaps so they don't need a seperate decode task. Avoid the additional task hop. R=ericrk@chromium.org Bug: 898886 Change-Id: I8b61b99e3f488d8def752b6ea1f3472be3723628 Reviewed-on: https://chromium-review.googlesource.com/c/1299782Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#602923}
-
Tibor Goldschwendt authored
With this CL we initate the module install once the user enters VR on a WebXR/VR page. In more detail this CL - Introduces native VrModuleDelegate used to request VR module from native, - Refactors GvrDevice to request the VR module as part of its initialization flow, - Adds native side of the VrModuleProvider for Java-native communication. Bug: 862689 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b Reviewed-on: https://chromium-review.googlesource.com/c/1241458 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602922}
-
Doug Arnett authored
No functional change here. Was recently asked about the commit priority order of previews. Occurred to me that listing them in priority order on interventions-internals might be more helpful in the future rather than the order that they are introduced. Change-Id: I277ecbba6a16423f2cce072cc7eb339b601d8f69 Reviewed-on: https://chromium-review.googlesource.com/c/1300102Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#602921}
-
Dale Curtis authored
This reverts commit cb9c3091. Reason for revert: Broke https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8508 Original change's description: > Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants > > Also renamed some methods to make interface more consistent. > In preparation for more changes in AXVirtualView. > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Change-Id: Ib417493794cc16536e20c3ce72dc8b00ba8568a9 > Reviewed-on: https://chromium-review.googlesource.com/c/1296621 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602876} TBR=ellyjones@chromium.org,dmazzoni@chromium.org,sky@chromium.org,afakhry@chromium.org,nektar@chromium.org,aleventhal@chromium.org Change-Id: I25559076276191b79884dcfa1b611e926ab250a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1299908Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602920}
-
Daniel Cheng authored
the unsafe scheme set only contains string constants, base::StringPiece is more efficient. base: :flat_set is more space-efficient than std::set. In addition, since Change-Id: I230cdc02e43dd00a1f2f8c750c1acb061e754867 Reviewed-on: https://chromium-review.googlesource.com/c/1298082 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602919}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c6c9df99db6..8c27ccac7597 git log 6c6c9df99db6..8c27ccac7597 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 benwright@webrtc.org Promotoing webrtc::CryptoOptions to RTCConfiguration. 2018-10-25 benwright@webrtc.org Fixes use after free error when setting a new FrameEncryptor on ChannelSend. 2018-10-25 scottmg@chromium.org fuchsia: Stub out timing and memory functions 2018-10-25 jamiewalch@google.com Disable probe delay warning in release builds. Created with: gclient setdep -r src/third_party/webrtc@8c27ccac7597 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:808287,chromium:888038 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6bda4329d38b26019758d06a637ffa44712f12c2 Reviewed-on: https://chromium-review.googlesource.com/c/1299590Reviewed-by:
-
Klaus Weidner authored
Moving the pointers to arcore_install_utils_ and arcore_factory_ zeroed them, so entering WebXR sessions only worked once, and crashed the browser on a second attempt. Pass a plain pointer to the device-owned objects instead to enable reuse. BUG=895973 Change-Id: Iefdf40055349e4513eee4edb2c802e4de095be8a Reviewed-on: https://chromium-review.googlesource.com/c/1297596 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Avi Drissman authored
BUG=895514, 845389 Change-Id: I7e44184c8a88b3e905fe26fd131a4900969c8f48 Reviewed-on: https://chromium-review.googlesource.com/c/1287326 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#602916}
-
Josh Nohle authored
Currently, when a device is retrieved by CryptAuth, a boolean histogram "CryptAuth.DeviceSyncSoftwareFeaturesResult" logs "Success" for each feature that is supported and enabled, and logs "Failure" for each feature that is enabled but not supported. Here, we provide a more granular look into the latter case by adding another histogram, "CryptAuth.DeviceSyncSoftwareFeaturesResultFailures", that buckets each failure by feature type, i.e., by the enum cryptauth::SoftwareFeatures. This was tested manually; however, we could only get EASY_UNLOCK_HOST to be in a state where it was enabled but not supported. Bug: 896082 Change-Id: Ib4fae768f203d637caa87d0a9e0baa5bf596f515 Tested: Manual; added unit test Reviewed-on: https://chromium-review.googlesource.com/c/1297285Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#602915}
-
Katie D authored
This is still hidden behind the accessibility features flag. For more, see go/chromeos-dwell-design. Bug: 894907 Change-Id: I8566f2e46e3703c56ede43e6efa8f8b4cbd97abb Reviewed-on: https://chromium-review.googlesource.com/c/1297575Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Liquan(Max) Gu authored
We need to report Last Image Paint to UKM and UMA. This CL uses mojo to send the metric from web performance (Blink) to the page load metrics (Browser). The browser then reports the metric to UKM and UMA. Bug: 869924 Change-Id: I680576ec2940558ed38910e2b4e2ff695a41ea30 Reviewed-on: https://chromium-review.googlesource.com/c/1298109Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602913}
-
Mason Freed authored
When running in single threaded mode, calls from OnBeginImplFrameDeadline() can make their way from the main thread to the impl thread, and then (erroneously) directly back to the main thread, causing a crash. See the stack trace below. With this CL, the call from viz::HostFrameSinkManager::OnFrameTokenChanged() is proxied back to the main thread for the call to content::DelegatedFrameHost::OnFrameTokenChanged(). A number of tests also call FrameSinkManagerImpl::SetLocalClient and/or surface_utils::ConnectWithLocalFrameSinkManager, and I did not want to change their existing behavior. So the additional task_runner parameter is defaulted to nullptr, and in that case the old behavior still applies - the call is not PostTasked. Example crash: [243567:243567:1023/120428.757147:FATAL:single_thread_proxy.cc(239)] Check failed: task_runner_provider_->IsMainThread(). #0 0x7f4d3b3bbccd base::debug::StackTrace::StackTrace() #1 0x7f4d3b0b8a2a base::debug::StackTrace::StackTrace() #2 0x7f4d3b12a59b logging::LogMessage::~LogMessage() #3 0x7f4d315b4e9b cc::SingleThreadProxy::SetNeedsCommit() #4 0x7f4d3149b8ef cc::LayerTreeHost::SetNeedsCommit() #5 0x7f4d312b28f1 cc::Layer::SetNeedsCommit() #6 0x7f4d312b8205 cc::Layer::SetBackgroundColor() #7 0x7f4d2cb5fd54 ui::Layer::SetColorFromAnimation() #8 0x7f4d2cb79024 ui::LayerAnimator::SetColor() #9 0x7f4d2cb56a5c ui::Layer::SetColor() #10 0x7f4d37f1b8a1 content::RenderWidgetHostViewAura::UpdateBackgroundColor() #11 0x7f4d37f2851e content::RenderWidgetHostViewBase::SetContentBackgroundColor() #12 0x7f4d37f222cb content::RenderWidgetHostViewAura::OnRenderFrameMetadataChangedAfterActivation() #13 0x7f4d37e81d5c content::RenderFrameMetadataProviderImpl::OnRenderFrameMetadataChangedAfterActivation() #14 0x7f4d37e8391f _ZN4base8internal13FunctorTraitsIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEvE6InvokeIS7_NS_7WeakPtrIS3_EEJS5_EEEvT_OT0_DpOT1_ #15 0x7f4d37e83805 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEENS_7WeakPtrIS5_EEJS7_EEEvOT_OT0_DpOT1_ #16 0x7f4d37e8377d _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #17 0x7f4d37e836f9 _ZN4base8internal7InvokerINS0_9BindStateIMN7content31RenderFrameMetadataProviderImplEFvN2cc19RenderFrameMetadataEEJNS_7WeakPtrIS4_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #18 0x7f4d35ecd92e _ZNO4base12OnceCallbackIFvvEE3RunEv #19 0x7f4d37d2d8a3 content::FrameTokenMessageQueue::DidProcessFrame() #20 0x7f4d37ef17cd content::RenderWidgetHostImpl::DidProcessFrame() #21 0x7f4d37f2aeaa content::RenderWidgetHostViewBase::OnFrameTokenChangedForView() #22 0x7f4d3845b99f content::DelegatedFrameHostClientAura::OnFrameTokenChanged() #23 0x7f4d38483f90 content::DelegatedFrameHost::OnFrameTokenChanged() #24 0x7f4d1aaa7e8c viz::HostFrameSinkManager::OnFrameTokenChanged() #25 0x7f4d1b5b41dc viz::FrameSinkManagerImpl::OnFrameTokenChanged() #26 0x7f4d1b59594e viz::CompositorFrameSinkSupport::OnFrameTokenChanged() #27 0x7f4d1b61ab83 viz::Surface::ActivateFrame() #28 0x7f4d1b61920f viz::Surface::ActivatePendingFrame() #29 0x7f4d1b618f2a viz::Surface::OnSurfaceDependencyAdded() #30 0x7f4d1b62e241 viz::SurfaceDependencyTracker::OnSurfaceDependencyAdded() #31 0x7f4d1b6432ac viz::SurfaceManager::SurfaceDependencyAdded() #32 0x7f4d1b619b7f viz::Surface::UpdateActivationDependencies() #33 0x7f4d1b6194f3 viz::Surface::QueueFrame() #34 0x7f4d1b59a155 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrameInternal() #35 0x7f4d1b598206 viz::CompositorFrameSinkSupport::MaybeSubmitCompositorFrame() #36 0x7f4d1b59801a viz::CompositorFrameSinkSupport::SubmitCompositorFrame() #37 0x7f4d1b5a4b08 viz::DirectLayerTreeFrameSink::SubmitCompositorFrame() #38 0x7f4d314d8e24 cc::LayerTreeHostImpl::DrawLayers() #39 0x7f4d315b8ee8 cc::SingleThreadProxy::DoComposite() #40 0x7f4d315bb087 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() #41 0x7f4d3139c9b8 cc::Scheduler::DrawIfPossible() #42 0x7f4d31396581 cc::Scheduler::ProcessScheduledActions() #43 0x7f4d3139c7da cc::Scheduler::OnBeginImplFrameDeadline() #44 0x7f4d313a024d _ZN4base8internal13FunctorTraitsIMN2cc9SchedulerEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #45 0x7f4d313a0194 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2cc9SchedulerEFvvEJPS5_EEEvOT_DpOT0_ #46 0x7f4d313a0145 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #47 0x7f4d313a0089 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc9SchedulerEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #48 0x7f4d313a059e _ZNO4base12OnceCallbackIFvvEE3RunEv #49 0x7f4d313a0544 _ZN4base8internal22CancelableCallbackImplINS_12OnceCallbackIFvvEEEE11ForwardOnceIJEEEvDpT_ #50 0x7f4d3129de9f _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIS5_RKNS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_ #51 0x7f4d3129de1a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc28ScrollbarAnimationControllerEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #52 0x7f4d3129ddb0 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ScrollbarAnimationControllerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #53 0x7f4d3137d0d9 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc12ResourcePoolEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #54 0x7f4d3b0683ee _ZNO4base12OnceCallbackIFvvEE3RunEv #55 0x7f4d3b0ba072 base::debug::TaskAnnotator::RunTask() #56 0x7f4d3b14f466 base::MessageLoop::RunTask() #57 0x7f4d3b14f7ee base::MessageLoop::DeferOrRunPendingTask() #58 0x7f4d3b14fc79 base::MessageLoop::DoWork() #59 0x7f4d3b1572b6 base::MessagePumpGlib::Run() #60 0x7f4d3b14eb5b base::MessageLoop::Run() #61 0x7f4d3b1fac6d base::RunLoop::Run() #62 0x7f4d372f8dfc content::BrowserMainLoop::MainMessageLoopRun() #63 0x7f4d372f8a52 content::BrowserMainLoop::RunMainMessageLoopParts() #64 0x7f4d37301050 content::BrowserMainRunnerImpl::Run() #65 0x0000018caad1 (anonymous namespace)::RunOneTest() #66 0x0000018ca696 (anonymous namespace)::RunTests() #67 0x0000018ca11d LayoutTestBrowserMain() #68 0x0000018c82c0 content::ShellMainDelegate::RunProcess() #69 0x7f4d39305d5a content::RunBrowserProcessMain() #70 0x7f4d39308bc7 content::ContentMainRunnerImpl::Run() #71 0x7f4d392feabc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #72 0x7f4d13359c2a service_manager::Main() #73 0x7f4d393034b3 content::ContentMain() #74 0x00000075e165 main #75 0x7f4d13dcd2b1 __libc_start_main #76 0x00000075e02a _start Bug: 667551 Change-Id: Iab72ad842b4672f7c3e37060bd2085b2d8ce0803 Reviewed-on: https://chromium-review.googlesource.com/c/1297477Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#602912}
-
Chase Phillips authored
Also in this CL: - Add a :mojom_modules target to allow mojom files in this group to link against symbols that only exist in the modules layer. - Rename indexed*db_struct_traits* to _mojom_traits*. Bug: 717812 Change-Id: I85fa493b345bb6ab955316fe1725e4794ed4c99b Reviewed-on: https://chromium-review.googlesource.com/c/1265900 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602911}
-
Michael Giuffrida authored
Motivated by strings in chromium_strings.grd that use "Chrome": https://crrev.com/c/1294589 Bug: 897868 Change-Id: Ie90f92e67e8801f9e78bbdf478fa727b5fee3e22 Reviewed-on: https://chromium-review.googlesource.com/c/1294419Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602910}
-
Darren Shen authored
We're changing the keyboard tray action to toggle the virtual keyboard instead of always showing the virtual keyboard. Previously, we made it so that the VK hides when you interact with the shelf. So we also have to exclude the keyboard tray icon from this behaviour. Bug: 897672 Change-Id: I019f8acf2263a18a3f9248f232e51156c0b8a349 Reviewed-on: https://chromium-review.googlesource.com/c/1298513Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#602909}
-
Sergei Istomin authored
Added TestMediaMetadata for saving metadata observer and UpdateExternalMediaMetadata function for using in unittest (external_pipeline_control_unittests). Test: Unittests. Bug: internal b/117221273 Change-Id: I96266e1b5029ad8fbb5f3b0cf1252e3720f9c6f7 Reviewed-on: https://chromium-review.googlesource.com/c/1291772Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergei Istomin <sistomin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602908}
-
erikchen authored
This allows Chromium developers to more easily distinguish between improvements that reduce start-up jank, and improvements that reduce non-startup jank. This CL removes the expiry from the Jank metrics as they are providing high utility for slow reports, and are being added as a heartbeat metric. Bug: 859155 Change-Id: Ida8bf44219717ba19c2eb13fefdec09d42f2569f Reviewed-on: https://chromium-review.googlesource.com/c/1299295 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#602907}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/02d100af0b2e..a9fb482b9859 git log 02d100af0b2e..a9fb482b9859 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 bhthompson@google.com Make nocturne-paladin important Created with: gclient setdep -r src/third_party/chromite@a9fb482b9859 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idd3c0d0182ffbccbe27490d96862eb54dfbc4614 Reviewed-on: https://chromium-review.googlesource.com/c/1299978Reviewed-by:
-
Etienne Pierre-doray authored
Adds a meta-comment to thread_restrictions.h which coalesces all of the comments below. Change-Id: If02d9cd3403f18f46cb08f6f54298471c2765493 Reviewed-on: https://chromium-review.googlesource.com/c/1296684 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#602905}
-
Evan Stade authored
The test doesn't actually pass in Mash because of crbug.com/897260 but the test should pass once ImmersiveModeControllerAsh::OnWindowPropertyChanged is fixed. Bug: 897260 Change-Id: Ic5914a4c1b17ba49a899f3775be5b21b2f6e1cff Reviewed-on: https://chromium-review.googlesource.com/c/1297731Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
1) Error-icon size set to 20 pixels. 2) Erorr-icon is displayed for errors only. 3) Error message centered vertically. Bug: 898721 Change-Id: Ifa1dcabbc0b8c8c0e5b6132268ed5c9c187ef21f Reviewed-on: https://chromium-review.googlesource.com/c/1298796Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#602903}
-
Esmael El-Moslimany authored
This functionality already exists in CrRadioButtonBehavior. https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_radio_button/cr_radio_button_behavior.js?l=19 Bug: 888922 Change-Id: Ie143f7605d858ea368be9ff7c3f876e05180739d Reviewed-on: https://chromium-review.googlesource.com/c/1298294Reviewed-by:
-
iOS Autoroller authored
TBR=smut Change-Id: I155114bba60788e0c8269181d305aae4492e383f Reviewed-on: https://chromium-review.googlesource.com/c/1299665Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602901}
-
Wenzhao Zang authored
Bug: 896518 Change-Id: Ib6772296f96914fb8d2f6587c537d67afaffd72e Reviewed-on: https://chromium-review.googlesource.com/c/1294418Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602900}
-
Robert Ogden authored
If the previews server responds with a bypass (307) and `chrome-proxy: host-blacklisted` then the original host should be blacklisted from previews for 30 days. This information is stored in prefs. Also adds a histogram to track whether or not a bypass is blacklisted. Bug: 864649 Change-Id: I42012e7ed3d2eb01d0233636ad8bac0202351946 Reviewed-on: https://chromium-review.googlesource.com/c/1297086Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#602899}
-
Yi Gu authored
This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I8060546f654b08642e7554c66dbd017574e3c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/1297182Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602898}
-
Yue Cen authored
Bug: 898786 Change-Id: I83f38fb6c9a9471793f0faadaee619a9771eb7ce Reviewed-on: https://chromium-review.googlesource.com/c/1299521Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602897}
-
Scott Chen authored
This CL makes the welcome_app check if the browser can be set as default, and hold off on initializing modules until we find out. Bug: 874122, 874255 Change-Id: I42e8427a200c717c2eacea04ad9932d15e65caba Reviewed-on: https://chromium-review.googlesource.com/c/1297283 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Nico Weber authored
On the Windows bot, this step takes 20 minutes, half of it in the second half of the script where compare_deps() runs. The win whitelist contains 3 files with the same deps (which are virtually "all built files"), so we spend 10 minutes computing the same information 3 times. Cache it. On Mac, the step takes 25 minutes, and there we list almost all executables in the whitelist file, many also depending on virtually all files (performance_browser_tests, interactive_ui_tests, extensions_browsertests, ...). This should help the step on that bot as well. Bug: 314403 Change-Id: I3c0d5a62a3e430a031c6637516c070d9326ec7c5 Reviewed-on: https://chromium-review.googlesource.com/c/1300014Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602895}
-
