Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Sep, 2016 28 commits
  3. 22 Sep, 2016 12 commits
    • sashab's avatar
      Add a generated ComputedStyleBase class that ComputedStyle extends · 8439075a
      sashab authored 
      Add a generated ComputedStyleBase class that ComputedStyle extends from,
as well as a generated ComputedStyleBaseConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in ComputedStyleBase and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
ComputedStyleBase and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tWxg/edit

BUG=628043

Review-Url: https://codereview.chromium.org/2187493004
Cr-Commit-Position: refs/heads/master@{#420508}
      8439075a
    • jrummell's avatar
      media: Change MediaKeyMessageEventInit to require both attributes · 54111faa
      jrummell authored 
      The latest EME spec has changed the attibutes of MediaKeyMessageEventInit
to required, so update the IDL to match. Also adds a test to verify
that both attributes are required, and that the valid values of
|messageType|.

BUG=647693
TEST=added test passes

Review-Url: https://codereview.chromium.org/2354083003
Cr-Commit-Position: refs/heads/master@{#420507}
      54111faa
    • rsleevi's avatar
      Remove UniCredit from the Symantec CT exception · 893a89bf
      rsleevi authored 
      This sub-CA does not meet the independence criteria to be exempt from
CT.

BUG=620178

Review-Url: https://codereview.chromium.org/2362593002
Cr-Commit-Position: refs/heads/master@{#420506}
      893a89bf
    • fdoray's avatar
      Use ScopedAllowWait to shutdown the TaskScheduler. · 42c5d9b7
      fdoray authored 
      browser_tests fail without this when redirection to TaskScheduler is
enabled.

Wait on the UI thread is disallowed by a call to
base::ThreadRestrictions::DisallowWaiting() in
BrowserMainLoop::PreMainMessageLoopRun().

BUG=553459

Review-Url: https://codereview.chromium.org/2361543002
Cr-Commit-Position: refs/heads/master@{#420505}
      42c5d9b7
    • estade's avatar
      Avert crash in ExtensionInstalledBubbleView::GetWindowTitle triggered · 6538bba7
      estade authored 
      by screen readers.

BUG=648280

Review-Url: https://codereview.chromium.org/2355963002
Cr-Commit-Position: refs/heads/master@{#420504}
      6538bba7
    • mcasas's avatar
      File Video Capture: allow IO operations from Device thread · 831eae63
      mcasas authored 
      FileVideoCapture is a test-only feature, enabled via two
command line flags. It overwrites any system webcam and
introduces a file playback instead. This CL allows the
video capture thread to access IO operations.

BUG=648989

TEST= Run e.g.
./out/gn/Chromium.app/Contents/MacOS/Chromium --use-fake-device-for-media-stream --use-file-for-fake-video-capture=~/Downloads/old_town_cross_420_720p50.y4m https://rawgit.com/Miguelao/demos/master/gum_simple.html

with the said file d'led from https://media.xiph.org/video/derf/y4m/

Review-Url: https://codereview.chromium.org/2358093002
Cr-Commit-Position: refs/heads/master@{#420503}
      831eae63
    • aelias's avatar
      Disable flaky Android IME and selection tests. · 611dec31
      aelias authored 
      These tests (*all* Selection tests, and a few of the IME tests) are
extremely flaky to the point that they often cause waterfall redness
despite @RetryOnFailure.  These areas are actively owned (amaralp@ owns
Android selection, and changwan@/yabinh@ own Android IME) and we plan to
circle back to reenable without @RetryOnFailure when they have been
fully deflaked.

The @FlakyTest annotation is deprecated so also replace existing uses of
it with @DisabledTest, and secondly don't comment out the other
annotations which seems to be unnecessary nowadays.

BUG=649411,628964,592428

Review-Url: https://codereview.chromium.org/2362013002
Cr-Commit-Position: refs/heads/master@{#420502}
      611dec31
    • dcastagna's avatar
      Revert of Add ClientNativePixmap multi-planar support. (patchset #8 id:160001... · f6d9dbe1
      dcastagna authored 
      Revert of Add ClientNativePixmap multi-planar support. (patchset #8 id:160001 of https://codereview.chromium.org/2272153002/ )

Reason for revert:
This makes samus stuck at the Chrome logo.

Original issue's description:
> Add ClientNativePixmap multi-planar support.
>
> ClientNativePixmap, that lets clients map pixmaps in user space,
> always assumed a pixmap contained only one plane.
>
> This CL adds support for multiple-planes.
>
> BUG=618516
> TBR=posciak
> TEST=gl_unittests on samus.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/cdb357b81306f5e8170027d13d931b8e26140405
> Cr-Commit-Position: refs/heads/master@{#420251}

TBR=ccameron@chromium.org,dnicoara@chromium.org,posciak@chromium.org,reveman@chromium.org,spang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618516

Review-Url: https://codereview.chromium.org/2361023003
Cr-Commit-Position: refs/heads/master@{#420501}
      f6d9dbe1
    • xhwang's avatar
      media: Add External Clear Key content browser test on Android · bcd68581
      xhwang authored 
      This CL adds External Clear Key support on Android for testing.
This is implemented by running AesDecryptor in the MojoCdmService,
which runs in the MojoMediaApplication in the GPU process. This is
only enabled when kExternalClearKeyForTesting feature is enabled.

A new content browser test is added to use External Clear Key on
Android. Since AesDecryptor doesn't support decoding, the media
pipeline is configured to do decrypt-only using the mojo CDM
(MojoDecryptor on MojoCdm), and then use the normal Android
pipeline (AVDA/MojoAudioDecoder) to decode encrypted audio/video.

Note that this is different from the default mode how Android
media pipeline works for encrypted content (decryption/decoding
both happens in the GPU process). When browser_tests are enabled
on Android, we should be able to have test coverage on that.

Here's what the new test covers:
- MojoCdm / MojoCdmService
- MojoDecryptor / MojoDecryptorService
- MojoMediaApplication
- Connection to services hosted in MojoMediaApplication through
  MojoShellContext.

This CL also fixes a bug in MojoCdm where the decryptor_ptr is bound to
one thread but is used on another thread.

BUG=581893
TEST=This CL adds a new test. No other functionality change.

Review-Url: https://codereview.chromium.org/2268283003
Cr-Commit-Position: refs/heads/master@{#420500}
      bcd68581
    • gcasto's avatar
      Revert of HTMLImageElement: do not use fallback content for ImageDocument... · 70e44d10
      gcasto authored 
      Revert of HTMLImageElement: do not use fallback content for ImageDocument (patchset #2 id:20001 of https://codereview.chromium.org/2343613002/ )

Reason for revert:
Speculatively reverting to fix broken layout tests on Windows (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10, https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7)

Tests are

fast/backgrounds/border-radius-split-background-image.html
fast/backgrounds/border-radius-split-background.html
fast/borders/border-styles-split.html
paint/invalidation/background-resize-height.html

Original issue's description:
> HTMLImageElement: do not use fallback content for ImageDocument
>
> After https://codereview.chromium.org/1879793003,
> ImageLoader::hasPendingActivity() became false for ImageDocument and thus
> HTMLImageElement::selectSourceURL() didn't consider the image as still loading
> during load (|imageStillLoading| became false).
> This caused ImageDocument not to be displayed progressively.
>
> This CL makes HTMLImageElement to use primary content for ImageDocument.
> This causes ImageDocument not to be replaced with fallback content, but I
> expect that is more acceptable than images not displayed progressively.
>
> BUG=632495
>
> Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
> Cr-Commit-Position: refs/heads/master@{#420432}

TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,hiroshige@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632495

Review-Url: https://codereview.chromium.org/2365523003
Cr-Commit-Position: refs/heads/master@{#420499}
      70e44d10
    • dcheng's avatar
      Revert of Clear LifecycleObserver::m_context when... · 04b18263
      dcheng authored 
      Revert of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of https://codereview.chromium.org/2317483005/ )

Reason for revert:
Speculatively reverting for https://crbug.com/649272

Original issue's description:
> Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called
>
> This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
> This means that LifecycleObserver::context() starts returning false after the context gets destroyed.
>
> The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
> LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
> This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
> (because the coverage of the layout tests is not sufficient).
> However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
> returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
> I think the risk is low.
>
> BUG=610176
>
> Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> Cr-Commit-Position: refs/heads/master@{#419951}

TBR=haraken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176,649272
NOTRY=true

Review-Url: https://codereview.chromium.org/2365463004
Cr-Commit-Position: refs/heads/master@{#420498}
      04b18263
    • kbr's avatar
      Suppress tex-mipmap-levels.html again on Mac Pro. · f6130090
      kbr authored 
      BUG=483282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2359363002
Cr-Commit-Position: refs/heads/master@{#420497}
      f6130090