GitLab

Check for null BottomNonEmptySection even if TopNonEmptySection is not
null because of crbug.com/764525.

Bug: 764284
Change-Id: I4d45cbd3432722a8958ba647767d97b782c10512
Reviewed-on: https://chromium-review.googlesource.com/664303Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501471}

This CL converts misc instrumentation tests to JUnit4. For more on
JUnit4 migration, please check src/testing/android/docs/junit4.md

Bug: 640116
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Change-Id: I8ea44992b48709550855459b9ff4f20bb3eec15a
Reviewed-on: https://chromium-review.googlesource.com/627672
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501470}

Ref CL: cl/168305759

Bug: 63094198
Test: manual
Change-Id: I5fe57a038d8c3b93eee122ef72ed01285c7e3900
Reviewed-on: https://chromium-review.googlesource.com/663884Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Anthony Zhang <antz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501469}

Implementing CreateArchiveTask, which is a task for starting the archive
creation but will not wait for the completion of the process, in order
to support multiple archivers working in parallel. The creator of the
task has to provide a CreateArchiveTaskCallback, which will be
processing the arguments and decide whether the creation is successful,
so that it can create AddPageTask for next steps.
Also duplicating most of the tests related with archive creation from
the OfflinePageModelImpl unit tests.

Bug: 753595
Change-Id: I915daab56a260ccaa9c028c0ea95c2ff0646d461
Reviewed-on: https://chromium-review.googlesource.com/634084
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501468}

Addresses some nits, but primarily fixes the SearchSuggestionParser
match classification logic.

Previously the match_start was incorrectly calculated using the
cleaned-up formatted URL instead of the original URL, which we need
to correctly flag which components the matches are in.

Bug: 761505
Change-Id: Ifae972c79e16387c8a9b8c49811a035c1fb017f1
Reviewed-on: https://chromium-review.googlesource.com/663848
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501467}

Bug: 754774
Change-Id: I7faf88c6d8ce2f734fdb6c39793a72628b73fa06
Reviewed-on: https://chromium-review.googlesource.com/658484Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#501466}

The outputted size is not the size of each allocation, but the sum of
every allocation for a given stackframe.

R=erikchen@chromium.org

Bug: 753514
Change-Id: I1840f89d06a63e5f30af66da080ef7ea91d1715a
Reviewed-on: https://chromium-review.googlesource.com/664250Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501465}

Change-Id: I537ef4d26f75e57bc5868912746141cb9cc14ff7
Reviewed-on: https://chromium-review.googlesource.com/663674Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501464}

According to Qualcomm the unexpected blocking issue likely affects
"all A4x (or newer) chips", though the specific effect only seems
to be noticeable for WebVR on Daydream-ready devices which are 
currently limited to Adreno 530 and 540.

BUG=750306,764526
R=kbr

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifb95ed9a59f58fb7b4a3c91e3745f5def6b51d21
Reviewed-on: https://chromium-review.googlesource.com/662903Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501463}

This reverts exposing the browser target unconditionally; the proper
solution is to retrieve the secure browser target URL from
/json/version server endpoint.

Bug: internal b/65209777
Change-Id: I0b77c7bb39a06cc19fc6fac68f341aded8cdd154
Reviewed-on: https://chromium-review.googlesource.com/663892Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501462}

These tests pass after https://crrev.com/501346

Bug: 731302
Change-Id: I4c6639e59f4270933aaf66a9a25ffac8beb3761f
Reviewed-on: https://chromium-review.googlesource.com/662922
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501461}

The test has been flaky and we could not reproduce the time-out locally.
To suppress the warning/error, we should disable the test until
we figure out the solution.

Bug: 763550
Change-Id: Ia89f569e372d0ee94860f2a1c0ace7d44cd5eb6f
Reviewed-on: https://chromium-review.googlesource.com/664302Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501460}

Adding myself, brettw@ and ajwong@.

Bug: 
Change-Id: I6192ff1b4eefdf400b640e6ea7c61f8c297726a2
Reviewed-on: https://chromium-review.googlesource.com/661380Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501459}

Using an explicit error enum is preferrable to checking
runtime.LastError.

Bug: 762147
Change-Id: I764269b18da6578c07bb3c7eb6e0be79b2f6c798
Test: Deployed local Chrome and verified ServiceError enums occur at the correct times.
Reviewed-on: https://chromium-review.googlesource.com/651209
Commit-Queue: Luke Sorenson <lasoren@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501458}

Add move() function.

Split the command to two steps.
 - move_blink_source.py update
  It updates file contents.
 - move_blink_source.py move
  It moves files in third_party/WebKit/.

This separation would prevent git from misdetecting file moves

Bug: 578345
Change-Id: Ie53668a3f1d75db92737097795e7a89690a10cad
Reviewed-on: https://chromium-review.googlesource.com/662078
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501457}

Now including a hack to handle certificate dates outside the range that
base::Time::FromUTCExploded can handle on 32-bit linux. (Previously those
dates would be imploded with NSPR, which always uses 64bit time values.)

Bug: 671420
Change-Id: I3c633b6f2f434bbb356b83bbc99cf8c8b8a08ff8
Reviewed-on: https://chromium-review.googlesource.com/658326
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501456}

This class used to hold the location as a string, since base::Location
wasn't assignable. It is now.

Bug: 764195
Change-Id: I81a04d2ecc981c39f0e0bcb54cb76e6ee87248f8
Reviewed-on: https://chromium-review.googlesource.com/664220Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501455}

Missing teams and components were identified using an ad-hoc script:
https://chromium-review.googlesource.com/c/chromium/src/+/657580

For some cases of jsbell@ in OWNERS, instead switch to more accurate owners.

Change-Id: Ie3729f9e49d1605301dd9ba33cc4eb8ccc63e755
Reviewed-on: https://chromium-review.googlesource.com/657821
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501454}

Bug: 667560
Change-Id: I417e24d6f2657107aaec74022353f4f329232804
Reviewed-on: https://chromium-review.googlesource.com/660781
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501453}

recordStateInHistory does not work correctly for native controllers
because it reads and stores the state for upcoming page, not for
outgoing page.

This change is a workaround, rather than a fix, which is fine because
native controllers support will be removed from CRWWebController.

Bug: 751161
Change-Id: I020b5b98e890a9d6f1e3bcde64076fd9c1758d5f
Reviewed-on: https://chromium-review.googlesource.com/663771Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501452}

This patch:
1. Enables VsyncAlignedInput on all platforms, and
2. Enables RequestUnbufferedDispatch on Android to avoid native event
   batching.

Note that the feature was disabled in WebView due to compatibility
issues.

This feature won't affect / has minimum effect to Web Platform, thus
doesn't require an Intent-to-Ship.

Bug: 625689
Change-Id: I3c698904c049fea4d8fb7b53e2250d96adf76f66
Reviewed-on: https://chromium-review.googlesource.com/606990Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501451}

This is part of a larger refactor to make downloads a foreground
service on all versions of Android. There was a bug that made it so
that paused downloads were not swipeable (and therefore not
cancellable). This CL fixes that bug.

Bug: 747563
Change-Id: If67d34523e0352aaf3b8f5c78967fd1ec3a697a7
Reviewed-on: https://chromium-review.googlesource.com/661940Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501450}

(on windows)

Bug: 760132
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1c4040a2bff958d79f6e8a1fae90309d3492b29f
Reviewed-on: https://chromium-review.googlesource.com/663939
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501449}

This should ensure that if a Chrome activity is running at the top of an
existing task, an activity in that task would get re-targeted, if
possible.

BUG=747551

Change-Id: Idcdb52ae2b677897e8819ae3e1da70768ed676cc
Reviewed-on: https://chromium-review.googlesource.com/663878Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501448}

These are needed to support the new ARC VPN type.

BUG=696865
TEST=use chrome.networkingPrivate to create/query a network with the
     new properties

Change-Id: I3157ca6d8ccf51c0071b1c3b6b0f6a47f5dd5360
Reviewed-on: https://chromium-review.googlesource.com/592540Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kevin Cernekee <cernekee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501447}

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

Bug: 640116
Change-Id: I508ee1b6512a4a96175d1747a0f8ebe1764f11e6
Reviewed-on: https://chromium-review.googlesource.com/662241
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501446}

This updates the telemetry related to downloads content types to help
answer the question 'What kinds of files are people downloading?' This
extends the existing content file types to include all of the categories
listed by go/chrome-downloads-content-types, specifically including more
categories as well as specific text, audio, and video types.

Bug: 
Change-Id: I5c9a1a1ce42c3edeb88739654ee0836482e1fe4e
Reviewed-on: https://chromium-review.googlesource.com/660801Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501445}

The call sites that call NGFragmentBuilder::AddChild() also need to explicitly
propagate breaks to their container, if that's what they want. The column
layout algoirithm *doesn't* want this.

Bug: 757767
Change-Id: I203c045fc85a65303dfe4c0cdad20eb60e64fba2
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/663859
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501444}

There are some ShouldDisables that cannot switch over, such as
BattOr detecting and reference build detecting.

Bug: 713222
Change-Id: Ie6ce17c6f41d7df3c480b47d7560246f4b129ed7
Reviewed-on: https://chromium-review.googlesource.com/661943
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501443}

Add new QuicQueue and QuicDeque classes to wrap std::queue and std::deque internally, and base::queue/base::deque in chromium.

Merge internal change: 168283215

Bug: 764064
Change-Id: Ic1b74c515866ab8ba57eeff55c3f1137dd6ee031
Reviewed-on: https://chromium-review.googlesource.com/661790Reviewed-by: Jana Iyengar <jri@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501442}

Equivalent functionality can be achieved by adding a bool without any
additional locking in the IncomingTaskQueue::PostPendingTask path.

One fewer lock is required if there is no need to schedule work.

BUG=749312,758721

Change-Id: I812db615ef2d1772c077266240d3a1927c97565c
Reviewed-on: https://chromium-review.googlesource.com/639158
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Francois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501441}

Imported because of https://github.com/w3c/web-platform-tests/pull/7312,
so the old names are removed from W3CImportExpectations.

Change-Id: I15db60386e3cc4db04c6816a0dc9e5f670744e17
Reviewed-on: https://chromium-review.googlesource.com/663833
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501440}

1. Adds browser tests for heap profiling with pseudo and no stack mode.
2. TraceLog does not dcheck if filters are added multiple times.
Reason: The EnableHeapProfiling() mojo message from browser to renderer
is sent before OnBeginTracing IPC message. The tracing is being
converted to service and maybe we will have better fix in future.
3. Whitelist heap profiling overhead dumps for background mode.

BUG=700245

Change-Id: I73289e4f7ec5de1421ac44e87e7c30d363869b5b
Reviewed-on: https://chromium-review.googlesource.com/653782
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501439}

GpuProcessTransportFactory should not be created when running with mus.

BUG=none

Change-Id: I888455b68b9fad81d9e7bbb9b16b683df2abd5a5
Reviewed-on: https://chromium-review.googlesource.com/661337Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501438}

scroll-boundary-behavior is a shorthand containing
scroll-boundary-behavior-x and scroll-boundary-behavior-y.

If only one value is specified, the second value defaults
to the same value.

Spec:
https://wicg.github.io/scroll-boundary-behavior/#scroll-boundary-behavior-properties

BUG=672921

Change-Id: Ib924802ac441f0ddbe9d1f360c7d9d91ff5b80c6
Reviewed-on: https://chromium-review.googlesource.com/662480Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501437}

Bug: 760288
Change-Id: I79e0c682394236aa4a7d2dcd421680e09abef082
Reviewed-on: https://chromium-review.googlesource.com/663793Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501436}

This CL fixes several issues in our app metadata that may get us into
trouble passing the Apple review process.

Bug: 756208
Change-Id: I426fce8453bc22059235d77f631ceaf0b7e8642e
Reviewed-on: https://chromium-review.googlesource.com/664058Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501435}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a3ef78d9..ec37390b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ia404312eefdd8ae50ec4be4d6f20883322c6ce9e
Reviewed-on: https://chromium-review.googlesource.com/663412Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501434}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7370e9da6e0c..49fbcfa16b5d

$ git log 7370e9da6..49fbcfa16 --date=short --no-merges --format='%ad %ae %s'
2017-09-12 eakuefner Add add_reserved_diagnostics script

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1759f9998edb55257f75e8d5296473ec24a2a197
Reviewed-on: https://chromium-review.googlesource.com/663843
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501433}

https://pdfium.googlesource.com/pdfium.git/+log/8ac74971a335..5b2092a1ec59

$ git log 8ac74971a..5b2092a1e --date=short --no-merges --format='%ad %ae %s'
2017-09-12 rharrison Don't attempt to decrypt AES streams that are too short

Created with:
  roll-dep src/third_party/pdfium
BUG=763585


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Idbe0456179d244337dba103a3b55254b920a1b33
Reviewed-on: https://chromium-review.googlesource.com/663943
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501432}