- 19 Jan, 2018 40 commits
-
-
Daniel Vogelheim authored
Add additional checks to script streaming, to help diagnose crbug.com/784326. Bug: 784326 Change-Id: I19aacefc260dce0f5836fa14a217701d388f566c Reviewed-on: https://chromium-review.googlesource.com/874191Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#530467}
-
Ramin Halavati authored
Adds network traffic annotation tag to the socket writes of the following files: - components/cast_channel/cast_socket.cc - components/cast_channel/keep_alive_delegate.cc Bug: 656607 Change-Id: Ie504981e612e6eaa913095fa55da77dd23a9d285 Reviewed-on: https://chromium-review.googlesource.com/873411 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#530466}
-
Gabriel Charette authored
Fix an unintentional dynamic allocation in base/android. Explicitly allow dynamic allocation in two other places where compile-time isn't possible and I *think* are benign. Bug: 801563, 800760 Change-Id: I183e18d21af31625a8729aff44b89be85dcd1220 Reviewed-on: https://chromium-review.googlesource.com/866738 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#530465}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //chrome/installer. This change removes `#include "base/memory/ptr_util.h"` if it's no more used in files. (Might not remove if base::WrapUnique is used) This change also adds `#include <memory>` header except the following two cases: - Not add the header if the file contains the <memory> header - Not add the header if the related header contains <memory> header (The style guide[2] says that foo.cc can rely on foo.h's includes) Confirmed no additional lint errors(by `git cl lint`) after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 [2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: 755727 Change-Id: Ia0b8dc7b79bdb16ee8f59d47cec72f3953bb98c8 Reviewed-on: https://chromium-review.googlesource.com/874974Reviewed-by:Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#530464}
-
Fergal Daly authored
BUG: Document::WillChangeFrameOwnerProperties checks whether body() is null once but calls 2 methods on it. Mutation event listeners can cause body() to become null during the first call, leading to a crash in the secondcall. FIX: Check body() for nullness before each call. This is not a critical fix but clusterfuzz has filed at least 2 bugs that trigger the same problem and the fix is simple. Bug: 778956 Change-Id: I1fdef6bea392999f19a326ed12d66e4b40c98a90 Reviewed-on: https://chromium-review.googlesource.com/872474 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#530463}
-
Pavol Marko authored
Implicitly treat keys stored on the system token as corporate because they can only be enrolled through enterprise.platformKeys ( go/chromeos-system-slot-extension-certificate-permissions ). KeyPermissions calls are now passed a list of KeyLocations in addition to the public_key_spki_der. KeyPermissions still stores the "sign once" flag for corporate keys on the system token to allow an extension which does not have policy-granted permission to sign using corporate keys to enroll keys onto the system token. The PlatformKeysService's SelectTask and SignTask now determine the key location(s) before continuing using GetKeyLocations. SelectTask now also checks if the key is on a token the user has access to (by checking if GetKeyLocations found a valid location). Apart from the standard test changes, a few fixes have been made in tests: - platform_keys_apitest affiliation handling was non-functional since the switch to affiliation ids. Moved the now-common setup common for platformKeys/enterprise.platfromKeys apitests into platfrom_keys_test_base.h/.cc. - enterprise.platfromKeys system-token related tests did not run due to a concat handling oversight. They now run too. Bug: 763746 Test: browser_tests --gtest_filter=*PlatformKeys* Change-Id: I75bf9c729ef0a0d87dd342ed38796600f2ff3582 Reviewed-on: https://chromium-review.googlesource.com/849217 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#530462}
-
Colin Blundell authored
This CL converts ContextualSuggestionsFetcherImpl from using //components/signin to using the Identity Service client library. The conversion is straightforward: - Get info of primary account via IdentityManager rather than SigninManager. - Create PrimaryAccountAccessTokenFetcher via IdentityManager rather than directly. I tested the relevant behavior manually by going to the NTP for a signed-in and syncing test user on Android and confirming that their content suggestions showed up after this change identically to before this change. A followup change will convert the test to use IdentityTestEnvironment. Bug: 798413 Change-Id: I8da6bc3a812960078c0e22a1239bb00142f1d25e Reviewed-on: https://chromium-review.googlesource.com/870831 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#530461}
-
Yoichi Osato authored
TBR: bartfab@chromium.org Bug: 803755 Change-Id: I005ee35f23837eb2c6f0209be502701540d1ec0c Reviewed-on: https://chromium-review.googlesource.com/875685Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#530460}
-
Vaclav Brozek authored
This CL introduces a UMA metric to measure the proportion of selected SSL errors on pages with password forms. Bug: 431618 Change-Id: I8344dab5744c5e5cd01820673aee17013ffa135c Reviewed-on: https://chromium-review.googlesource.com/870322 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#530459}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-webvtt-non-snap-to-lines.html 2. track-webvtt-two-cue-layout-after-first-end.html Bug: 782555 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie3a0e7c7662821d605b9beddd0dd0e6ed3e10870 Reviewed-on: https://chromium-review.googlesource.com/875571Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#530458}
-
Yoichi Osato authored
This patch makes the function local and change the signature from assigning to reference argument |CompositedSelection&| to returning the value. This patch also improve if-else code flow of the caller LocalFrameView::UpdateCompositedSelectionIfNeeded. Bug: 789870 Change-Id: I004142521c5848d5f905e777c519ea653b6e934c Reviewed-on: https://chromium-review.googlesource.com/875515Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#530457}
-
Peter Collingbourne authored
Found by compiling with libc++ on Windows. Bug: 801780 Change-Id: I3fe12643ed23c8757f1620b3c33253257999dd17 Reviewed-on: https://chromium-review.googlesource.com/874522Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530456}
-
Marc Treib authored
Bug: none Change-Id: I04b69bd24759246e5fa2c3a253bc535dc46a3036 Reviewed-on: https://chromium-review.googlesource.com/873634Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#530455}
-
Colin Blundell authored
Bug: 803452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3875413cd8ffc50ac52bef1771bb108fdcd5e330 Reviewed-on: https://chromium-review.googlesource.com/873830Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#530454}
-
Hiroshi Ichikawa authored
Solution here is to let GetThirdPartyDepsFromGNDepsOutput() return relative paths instead of absolute paths. Then |path| of ParseDir() will always be a relative path, so it can match with SPECIAL_CASES. Bug: 773906 Change-Id: I1f54efd014dc5ef07fd5164255d9e1d5cfc57380 Reviewed-on: https://chromium-review.googlesource.com/861366Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#530453}
-
rhalavati@chromium.org authored
Comments on definition and help doc of mutable annotations are updated to provide a more precise set of use cases for them. Bug: 656607 Change-Id: I72d04fd960be558222a87e2f6e4cabd1313a73f0 Reviewed-on: https://chromium-review.googlesource.com/872930Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#530452}
-
Bhagirathi Satpathy authored
This patch contains 1. HTMLLinkElement relList attribute should be [SameObject]. https://html.spec.whatwg.org/multipage/semantics.html#the-link-element 2. Unified a, area and link element relList attribute test. Bug: Change-Id: Iec5b2b2d2bc35502e173128194060fd30a9f3fac Reviewed-on: https://chromium-review.googlesource.com/867800Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Cr-Commit-Position: refs/heads/master@{#530451}
-
Alexander Shalamov authored
This CL adds Sensors entry to the site specific settings as well as to the global settings. Access device's sensors is enabled by default and allows users to disable access to device's sensors if needed. In a follow-up CLs, PageInfo, disclosure UI and omnibox indicators would be added. Visibility of the new settings entry is controlled by kGenericSensorExtraClasses feature flag. Bug: 796904 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c3a991b211d3f9eef59ff351d32a2475094bc53 Reviewed-on: https://chromium-review.googlesource.com/833924 Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530450}
-
Tarun Bansal authored
This is guarded behind a field trial, and is the last killswitch option. Bug: 781189 Change-Id: I22a25ff6a2629ca8b59aef727c54e2f491cb4771 Reviewed-on: https://chromium-review.googlesource.com/872074 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#530449}
-
Ramin Halavati authored
Network traffic annotation is added to SocketOutputStream constructor to be passed to underlying socket classes. Bug: 656607 Change-Id: I0f1ba4a944cf785c6aefad376475fdffbf2ce168 Reviewed-on: https://chromium-review.googlesource.com/870032 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#530448}
-
nikhil authored
Fixing names of password_manager EnableManualSaving feature as per the naming convention. Bug: 785953 Change-Id: I1c056e5a6c3893274761a8ffc2cb974d54d5d4d9 Reviewed-on: https://chromium-review.googlesource.com/851519 Commit-Queue: NIKHIL SAHNI <nikhil.sahni@samsung.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#530447}
-
Rune Lillesveen authored
We missed passing the ParentTraversalDetails argument from the old to the Ng flat tree traversal class. TEST=fast/dom/shadow/user-modify-inheritance.html Bug: 776656, 660265 Change-Id: Idfcdc97f5043483cc61720c88d970111f96064fc Reviewed-on: https://chromium-review.googlesource.com/873770Reviewed-by:
-
Blake O'Hare authored
This changes the persistence from a single coordinate into a struct that takes into consideration which side of the screen the keyboard is closest to. If the keyboard, for example, is effectively docked to the bottom right corner of the screen, and the user flips the orientation, the new position will also be in the bottom right corner of the screen. Change-Id: Ieed97751adb72272683f4fd943866e5aa4263d05 Reviewed-on: https://chromium-review.googlesource.com/872554Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#530445}
-
Jaebaek Seo authored
LocalDOMWindow::scrollX() must return a CSS pixel scaled value, but it returns a wrong value when enabling --use-zoom-for-dsf. Since LocalDOMWindow::scrollX() returns viewport_x / PageZoomFactor() and PageZoomFactor() is DSF when --use-zoom-for-dsf is enabled, viewport_x must be in physical pixel scale. root_offset given to SynchronousCompositor::DidChangeRootLayerScrollOffset() as an argument will be the value of viewport_x. It must be in physical pixel scale if --use-zoom-for-dsf is enabled (otherwise, it must be in DIP scale). This CL lets BrowserViewRenderer pass physical pixel scaled value to SynchronousCompositor::DidChangeRootLayerScrollOffset() when --use-zoom-for-dsf is enabled. Bug: 737777 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I36c3593633a90cb55c6e9eb7a48d4c406694c751 Reviewed-on: https://chromium-review.googlesource.com/844266 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#530444}
-
Derek Cheng authored
This done by removing the white-space: nowrap; attribute. Bug: 798777 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2f4af3cc8f6d2c790dab6124a4d9aad0639b8128 Reviewed-on: https://chromium-review.googlesource.com/875416Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#530443}
-
Yutaka Hirano authored
URLLoaderFactoryImpl has two CreateLoaderAndStart functions: One is a static method used by ResourceMessageFilter and another is an instance method used by ServiceWorker navigation preload. This CL removes the static function and has ResourceMessageFilter use a URLLoaderFactoryImpl instance for consistency. Bug: 736308 Change-Id: I5e687d8faf9bf8cc78abc0a66a19b407cf0c660c Reviewed-on: https://chromium-review.googlesource.com/872553 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#530442}
-
Xida Chen authored
In quite a few functions in the CSSPaintImageGeneratorImpl class, we check whether the document paint definition of a particular name exists or not, but we never do null check on that definition. This could lead to crash if the document paint definition is a null ptr. This CL fixes the problem by doing null check. It also changes one layout test to execise this code path. The change to the layout test also fixes the problem that this layout test passes in the browser that doesn't support paint worklet. Bug: 802970, 768683 Change-Id: Ia952ad977b63af643410b0973cc8034fac504f9f Reviewed-on: https://chromium-review.googlesource.com/869891 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530441}
-
Tatsuhisa Yamaguchi authored
We decided to postpone release of this feature to M66. The flag was originally added by Issue 844497. Bug: 783200 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I67189658f2b4c680a902eaba9550aad986d6f06a Reviewed-on: https://chromium-review.googlesource.com/874979Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#530440}
-
Patti authored
Chosen object views (currently, only USB devices) shown in the Page Info bubble only show the name of the USB device granted to them and don't give any context of what they might be. Add a label in secondary text underneath the chosen object name to make it clear to the user that this is a USB device. Bug: 773156, 773146 Change-Id: I95af87ed0fe86ff14fd539f44204f9158cc0ff9a Reviewed-on: https://chromium-review.googlesource.com/771060 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#530439}
-
rhalavati@chromium.org authored
Network traffic annotations should be passed from the request sources to the final sockets. This CL does the annotation tunneling from SocketDispatcherHost to the actual sockets in P2PSocketHostTcpBase. In a next CL, we will pass the annotation from the call sources (like WebRTC) to SocketDispatcherHost. Bug: 656607 Change-Id: I83cd604197dec71e77df429dfd0aed5bb3edc96a Reviewed-on: https://chromium-review.googlesource.com/859499Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#530438}
-
Wei-Yin Chen (陳威尹) authored
Sole integration needs to know whether it's enabled or not before native is loaded, so it's cached in shared preference, and requires restarting twice after the flag is modified. Bug: 778805 Change-Id: I5885b2fb44990d6bb0cdcbba4cc382772c5732be Reviewed-on: https://chromium-review.googlesource.com/875322 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530437}
-
Lei Zhang authored
- Make them all consistent. - Remove IsAskPrintSettingsEnabled() method since all impls as the same. Change-Id: Ief39548a5ab9fd7ea92638f41612282c82373df1 Reviewed-on: https://chromium-review.googlesource.com/875264Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
-
Shanmuga Pandi M authored
Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Qc-bOSyU0FQ Bug: 534245 Change-Id: Ib97235c26b4b3ccd681e708e232a782d5612745c Reviewed-on: https://chromium-review.googlesource.com/861601Reviewed-by:
-
Eddy Mead authored
Bug: 803453, 803520 Change-Id: I3870ea56cd8349704621f3a72b64b69a24624680 Reviewed-on: https://chromium-review.googlesource.com/874981Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#530434}
-
John Abd-El-Malek authored
Remove usage of content/common from content/network in preparation of moving that code to services/network. Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifcde5a90551d5abec39ff96fccf665aae3183391 Reviewed-on: https://chromium-review.googlesource.com/875298 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530433}
-
Yoichi Osato authored
# COMPONENT: UI>Browser TBR: tapted@chromium.org Bug: 803743 Change-Id: Iabe7e265797ba0c37666016479687d51ef967a17 Reviewed-on: https://chromium-review.googlesource.com/875512Reviewed-by:
-
Sidney San Martín authored
Work around a High Sierra bug that makes a window in an inactive space activate if it shows its status bubble. Starting in 10.13, adding a child window to a window in an inactive space brings it to the front if the user is interacting with its application in the active space. I can't find a nice workaround, and hidden windows showing a status bubble have triggered similar issues in the past, so this workaround waits to add the status bubble to a window until it's visible. Bug: 798792, 783521 Change-Id: I35cd7df87d74b6e1237cd91fc91acf455c443f82 Reviewed-on: https://chromium-review.googlesource.com/849559 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#530431}
-
Peter Collingbourne authored
Found by compiling with libc++ on Windows. Bug: 801780 Change-Id: I948e6d5baaf7008892a576bcc27943d96b911e62 Reviewed-on: https://chromium-review.googlesource.com/875372Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530430}
-
JunHo Seo authored
This CL contains a major refactoring. 1. Ignore non-navigable iframes. Previously, spatnav only dug into the first iframe it found. Now, in case that is an iframe without focusables, we ignore it and go look for the next candidate. Note that additional time and space can be increased in the worst case (the next closest element is always an iframe that cannot consume input). Example: <a href='#'>focused element</a> <iframe></iframe> .. many iframes <iframe></iframe> <a href='#'>target element</a> 2. Remove recursion. Now we use a HeapVector and regard it as stack for managing search order instead the call stack. Also we cleaned up some dead code related with is_offscreen_after_ scrolling condition statements. The condition never hit because is_offscreen_after_scrolling==false is one of condition for being candidate. 3. Don't revisit subtrees we've already searched. When the search scope is expanded from "current container" C to C's parent container, AdvanceFocusDirectionallyInContainer() searched C's tree again. Now we skip already searched subtrees. Bug: 770147, 784320 Change-Id: Idcce4e9125ec05d35481ecdc17b1336a85bc968a Reviewed-on: https://chromium-review.googlesource.com/781326 Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#530429}
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::GenerateLineBoxRects()| to LayoutNG by utilizing |NGInlineFragmentTraversal::SelfFragmentsOf()| which encapsulates handling of culled inline boxes. After this patch, following member functions of LayoutInline is adapted to LayoutNG: - AbsoluteRects - AbsoluteQuadsForSelf - AddOutlineRects - ComputeSelfHitTestRects Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 591099 Change-Id: I05dd8772928932a1b102506ebac9c1df965c545a Reviewed-on: https://chromium-review.googlesource.com/866602 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#530428}
-
