- 19 Nov, 2020 20 commits
-
-
Ethan Jimenez authored
Previously,`NGGridItemContributionType` and `AutoPlacementType` were moved outside of `NGGridLayoutAlgorithm` to improve readibility of several helper functions, as referencing such enums from functions outside of the class resulted in much longer lines. This change returns these enums inside `NGGridLayoutAlgorithm` following the same pattern as `AxisEdge` to use them in external helper functions. Bug: 1045599 Change-Id: Iab68d75778858ba2f6d0a61329f56d49db6c6455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543205Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#829001}
-
Avi Drissman authored
JSDialogs.OnBeforeUnloadStayVsLeave expired in M77. Probably worth removing now that it's M89. Fixed: 975888 Change-Id: Icbc30a141e6e3b1cac2c91bebfbfce8880a52229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546461 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829000}
-
Xinghui Lu authored
Real time URL check was launched to all Android devices in M83. Remove the code that checks system memory to reduce complexity. Bug: 1148966 Change-Id: I150451cd337fae135fc9b764faea462229bee9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545897Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828999}
-
Nancy Wang authored
This CL is another option to resolve the crash of below call stack: AppWindowLauncherItemController::GetAppWindow(aura::Window*, bool) AppWindowLauncherItemController::SetActiveWindow(aura::Window*) AppWindowLauncherController::OnWindowActivated() One possible guessing is the AppWindowBase object is not removed from AppWindowLauncherItemController's windows_, so modify the destructor of AppWindowBase to remove itself from AppWindowLauncherItemController's windows_. BUG=1128491 Change-Id: I79c34db74449c28336ce8cac3d38e86304665933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547220 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828998}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=mfoltz@chromium.org Bug: 1145565 Change-Id: Iaa4fc1526f737ad71819f92887baf319aa117bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547773 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828997}
-
Pilar Molina Lopez authored
Add new flag to chrome://flags ui. Before initializing minigbm set environment variable MINIGBM_DEBUG to "nocompression" if this flag is set. Bug: 1136497 Change-Id: I81770a2e59023b993df3f8f5aab939926686000e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518257 Commit-Queue: Pilar Molina Lopez <pmolinalopez@google.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828996}
-
behdad authored
This change sets the max percent dropped frames of a 1 second sliding window of frames as worst_smoothness. Bug: 1115141 Change-Id: Iaab465289a72f1cc80a1d75a7836016a5c0ab53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532672 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828995}
-
Aleks Totic authored
Legacy used Table as a sticky container for TD. Bring TablesNG in sync with legacy, and make table rows also use table as a sticky container. Standard not settled yet, discussion at: https://github.com/w3c/csswg-drafts/issues/5020 Makes 2 layout tests pass: external/wpt/css/css-position/sticky/position-sticky-table-th-bottom.html external/wpt/css/css-position/sticky/position-sticky-table-th-top.html Makes 3 unit tests pass LayoutBoxModelObjectTest.StickyPositionComplexTableNesting (layout_box_model_object_test.cc:886) LayoutBoxModelObjectTest.StickyPositionNestedStickyTable (layout_box_model_object_test.cc:818) LayoutBoxModelObjectTest.StickyPositionTableContainers (layout_box_model_object_test.cc:349) Bug: 958381 Change-Id: If099efe32a6a23154b53bf96981f7176030cd52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542737Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828994}
-
Karandeep Bhatia authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2519173, we raise a hard error on failing to parse optional properties. As a result, we should never be concatenating unrelated errors. Modify the code to reflect the same. BUG=1113513 Change-Id: If7a4220435378207d84e32e9dd093d63059e7a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547422Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828993}
-
Chris Palmer authored
And base/allocator/partition_allocator. Bug: None Change-Id: I9c98833294ef489bce2fbb204f7b00e3fa9907e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506429Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828992}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d361e6028c27..2d31db0b3751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I38f2c0b142eaed8ee00ecd307e81c7935b2da0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547964Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828991}
-
Sigurdur Asgeirsson authored
Bug: 1145565 Change-Id: Id4cc4569c4eca64cc250e11325f921a873f3819d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547048Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828990}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/484196b73916..444733610032 2020-11-18 linxinan@chromium.org Improve the setup logic for tryserver 2020-11-18 ehmaldonado@google.com [owners] Add tests for Depot Tools owners client. 2020-11-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146487 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I002a111db4b38183ede211a5c475ecdfc854ff29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548344Reviewed-by:
-
Aaron Leventhal authored
No longer necessary: setsize/posinset are now computed browser-side. TBR=kinuko@chromium.org NOTRY: true Bug: None Change-Id: If5238ccb1ca0d0631c5b5da50631b792608fc12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538117Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828988}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dda9c164cb3b..d361e6028c27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I53e05e78d644ffd319cb421a4f2b87196b6770ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547768Reviewed-by:
-
Filip Gorski authored
Bug: 1149818 Change-Id: Ic64c464b3c7413920f881cc0429ee94ed474347e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547465Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#828986}
-
Yuheng Huang authored
The CL also makes finding tab search target more robust by comparing url scheme Bug: 1099917 Change-Id: Idb0497176c1b3f5cb700362905932d029b6d6ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547425Reviewed-by:
-
Noel Gordon authored
Change to just say "load" since the "lazy-" part is imprecise. The SWA needs to "load" scripts. How that is done might not be "lazy". Comment only change. No-try: true Tbr: Bo Bug: 1113981 Change-Id: I27c8c7f823d27d4f5a82050f0f18e8d0e04303d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547747Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828984}
-
Maggie Cai authored
This CL adds 3 browser tests for intent picker: 1. If the website call pushstate on page loaded, with same URL, the intent picker should work as normal. 2. If call pushstate to a different URL, the intent picker should check with the new URL and update the visibility status accordingly. 3. If we reload a page after install an app that can be handle by that page, we should be able to see intent picker icon after reload. BUG=853604 Change-Id: I8fe9f13b6d21e691f382fedcd4170729bc35c0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546679Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#828983}
-
Anqing Zhao authored
Add a user policy to select the user experience of disabled features listed in another policy 'SystemFeaturesDisableList'. Bug: 1142785 Change-Id: I276eced7c9968e66988fbd2413ed09de35ee0bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512886 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828982}
-
- 18 Nov, 2020 20 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I90d6a33c4304b56563edee9268a320247eb56baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544964Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#828981}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/88091d3d17e1..627732c40839 2020-11-18 bclayton@google.com src/reader tests: Have parse() return a unique_ptr 2020-11-18 rharrison@chromium.org [transformer] Remove deprecated Manager constructor 2020-11-18 dsinclair@chromium.org ast: Support decoration kind hierarchies 2020-11-18 sarahmashay@google.com [validation] unittest v-0015: runtime array may only appear last in a structs 2020-11-18 dsinclair@chromium.org [spirv-writer] Support optional trailing return. 2020-11-18 bclayton@google.com Fix linter warnings, stdout test spew 2020-11-18 dneto@google.com Fix doxygen comment 2020-11-18 dneto@google.com spirv-reader: Register usage for handle vars and func parameters 2020-11-18 dneto@google.com spirv-reader: GetMemoryObjectDeclarationForHandl can return null If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I0a765a26ed4917fd69f2e374d664e046e4ef4bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547113Reviewed-by:
-
Xi Han authored
When clicking +1 button from the Tab Switcher, it launched the Start surface via ChromeTabCreator#launchNTP(). During this transition from the Tab Switcher mode to the Start surface mode, the onActivityChange() event isn't triggered since tab is null in both scenarios. As a result, the token to suppress the bottom sheet in Tab Switcher isn't released when transiting to the Start surface. In this CL, we make BottomSheetManager listen to the Start surface state change, and move the logic of suppression of the bottom sheet for Start surface + Tab switcher into the listener. Bug: 1129746 Change-Id: I74fd545bfd6799626a57944fb97db6c9164225be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541811Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828979}
-
Aaron Leventhal authored
The <menu> tag is no longer supported as an interactive feature, but is still supported as a semantic tag. The HTML spec still includes it as a container for <li> children, but has removed <menuitem>. Another option would be to try and be "clever" and look for role=menuitem children, changing the mapping to menu. However, given the state of the standard and varying browser support, it seems better to not add extra complexity and also to not encourage usage. Decisions: - Support simple mapping to the list role, because if it's just used semantically, it will be confusing for users who reach te menu and it does not act like one. - Remove behavior where child buttons/radios/checkboxes are mapped to menuitemfoo roles when inside a menu. There is nothing spec'd in HTML-AAM or CORE-AAM for either of these conditions, and it looks like more strange menu code that was inherited from WebKit. This CL will make it easier to support an upcoming CL that cleans up radio button code. Bug: None Change-Id: I49e95b5e526e742102b0bb6ad92b17f7a4ba0175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543685Reviewed-by:
-
ckitagawa authored
Decoding an image can result in it becoming a bitmap. To ensure this doesn't negatively impact memory when decoding also apply the bitmap size enforcement to already encoded images. Bug: 1144768 Change-Id: I7fc36601e07fcafda65bc408f2563f0ec319dbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547213Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#828977}
-
Antonio Gomes authored
Implementation is stubbed out today, but still needed so that BrowserNonClientFrameViewChromeOS can be adopted on lacros builds. SnapControllerLacros inherits the pure virtual chromeos::SnapController, and "maximizing" lacros chrome windows require an instance to exist (held by ChromeBrowserMainExtraPartsViewsLacros). Similarly to ash::SnapControllerImpl, SnapControllerLacros is created from the newly added ChromeBrowserMainExtraPartsViewsLacros::PreProfileInit(). BUG=1113900 R=jamescook@chromium.org Change-Id: I86a034ddcba7c12c3a7d7b2736058476c2db3ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547045 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828976}
-
Francois Doray authored
Preliminary results from the Canary+Dev experiment are encouraging. Adding to testing config to allow Beta experiments. Bug: 1144166 Change-Id: Ie40d0c5f46ab2779c2a6ec3c55b21cdfec79abb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541004Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#828975}
-
Peter Kasting authored
This prevents compile failures when e.g. doing EXPECT_EQ() with StrongAliased types that don't have <<. Bug: none Change-Id: I8efe29521bc6b05ac39aa2602a4fa1189318af57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538497 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#828974}
-
Haiyang Pan authored
It runs 100% experimentally since crrev.com/c/2541222. The build duration (http://shortn/_4qFyYutBjf) and test devices (http://shortn/_gE18OBAzt8) are still in good shape. Bug: 1111436 Change-Id: Iee624ad216243cd6a6b07afc9e64456acb5cdd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544749Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#828973}
-
Moe Ahmadi authored
Update color of the expand arrow button as well as the deletion button from Grey 900 --> Grey 700. before: screenshot/4mphygPwGNXtcDv after: screenshot/6CSf8WmB8DXD9kW Fixed: 1146256 Change-Id: Iaddb97e4f7b70b85ca61815a6f341896832ea32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547924 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#828972}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=ellyjones@chromium.org Bug: 1145565 Change-Id: Ie6262d31836393d9c8bdbf0cc684564a073792b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547962 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#828971}
-
Xiaoqian Dai authored
Fullscreen, window, region capture mode now all require change mouse cursor. This CL put mouse cursor setting logic in a central place and auto decide which cursor to use based on the current event location. It unified the cursor behavior on the capture bar and button, and also fixed a few bugs in the original implementation, like the mouse cursor can be disappear after clamshell->tablet->clamshell transition. Bug: 1142937 Change-Id: I139cfcb5b0c97970d65562579c2244080693f850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537939 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#828564} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547429 Cr-Commit-Position: refs/heads/master@{#828970}
-
Patrick Noland authored
This change adds LocationBarMediator and puts it in front of most signals that LocationBarLayout receives: * AutocompleteDelegate * FakeboxDelegate (moved from LocationBarCoordinator) * VoiceRecognitionHandler.Delegate * AssistantVoiceSearchService.Observer * UrlBarDelegate (moved from LocationBarCoordinator) (OnClickListener is excluded for now) This also entails moving init/ownership of VoiceRecognitionHandler and AssistantVoiceSearchService out of LocationBarLayout. Otherwise, the change should be mechanical; LocationBarMediator merely forwards its calls to LocationBarLayout. A small set of unit tests for LocationBarMediator is included, with the intent to add more as logic is ported into it. Bug: 1147581 Change-Id: I6c2c97bac24b0040052079d4bc06cf502d07b7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530747 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#828969}
-
chinsenj authored
This CL adds metrics for the configuration a user has when they capture. I.e. taking a fullscreen screenshot, window screenshot, etc. Test: manual + added Bug: 1140182 Change-Id: Ibe4f6289d754d76e1e6ecba1d9442cdfc96d0d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538062 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828968}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=shaktisahu@chromium.org Bug: 1145565 Change-Id: I6d607bcafec4a912694f42c48881bcbec04914de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547770 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828967}
-
Daniel Cheng authored
- Add MapTraits to allow serialization of a vector of pairs directly into a Mojo map for ui::AXNodeData. - Update AX browsertest to use Gmock matchers for container comparison. This test currently depends on an ordering that is not guaranteed by abnything and may unexpectedly break in the future. Using Gmock makes it easier to update at such a point in the future. - Deserialize attribute maps into a base::flat_map and extract the underlying result directly into ui::AXNodeData. Bug: none Change-Id: I1db2649312ad1e68a40962e27bd5c97da29cc3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541745Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828966}
-
Nina Satragno authored
Disable SSLUITest.BadCertFollowedByGoodCert. Flaky. Tbr: estark@chromium.org Bug: 1150592 Change-Id: I2b3a4b9b82fd6e19cf9d2d8e66e4370a14efb20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548180Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828965}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/01e445072921..ce207be41fd6 2020-11-18 rharrison@chromium.org Use the transform manager instead of invoking the transform directly 2020-11-18 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 90f32536458a to 46d9c7745efa (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Iea2a116ac2263e365320bce6e161ae188ccf5048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546977Reviewed-by:
-
Eric Lawrence [MSFT] authored
Onion-souping landed long ago, so remove the TODO item in the doc. Change-Id: I58a20028eeae43fd56ac37f86d3be20e5b01b315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547944 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828963}
-
Yashar Dabiran authored
Change-Id: Iabc86cc45f754e1f8b10191a6bb6118b21d80558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545824 Commit-Queue: Yashar Dabiran <yashard@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#828962}
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
