- 05 Oct, 2019 11 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f7ad03aa869b..1ba72546da4c git log f7ad03aa869b..1ba72546da4c --date=short --no-merges --format='%ad %ae %s' 2019-10-04 jmadill@chromium.org GN: Allow building without /build/ folder. Created with: gclient setdep -r src/third_party/angle@1ba72546da4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I941e7966ee4857e14ba9dcf3ac3dbe8ce5f80555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703112}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ce64248fdc9..57a5b927de7d git log 6ce64248fdc9..57a5b927de7d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 vapier@chromium.org failures_lib: rework handling of Exception.message 2019-10-04 vapier@chromium.org infra_libs: drop unused imports Created with: gclient setdep -r src/third_party/chromite@57a5b927de7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic42ffc7359bf31e907990a52750df3a7ed22772b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703111}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifc08e837d17feb3402cb779a3a18d20e87ff166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703110}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8151b15c. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4157aa3be40682e2e4a7cadf610cd9d6d8c05e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842074Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703109}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9b9ccf7ac88a..61297bd64bfd $ git log 9b9ccf7ac..61297bd64 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 yusukes system_api: Add cpus field to StartArcVm proto 2019-07-02 cylai system_api: compile attestation_ca.proto to golang Created with: roll-dep src/third_party/cros_system_api BUG=b:142144019,b:139752657 TEST=try Change-Id: Ib5721ae0d5c0403dfac5880ec04bef4030444389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841897 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703108}
-
Matt Menke authored
Also turn the ReportingEndpointManager tests into unit tests, so that this is testable without wiring up NetworkIsolationKey through all the reporting code. Bug: 993805 Change-Id: I0d511dd7eb5f1418bf0a29e853198c39b4b4ea97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842131 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#703107}
-
Bettina authored
Bug: 1010764 Change-Id: I0a37a1f275f74860cc4df79747f9df97f7d22be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842503Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#703106}
-
Brandon Wylie authored
Change-Id: I0c52401587eda127ae9e48515fbd20db8b63d41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841582Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#703105}
-
chrome://managementdpapad authored
Bug: 965770 Change-Id: Ie978f3b8331275693f883ae6b11058f0a2ad3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836604 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#703104}
-
Carlos IL authored
Removes the active mixed content shield from the omnibox and adds an 'Insecure Content'content setting to toggle allowing it on a per site basis. Currently behind a default off flag. Bug: 987294 Change-Id: Ic4c5238261eabc9606101a5227c6479a40f6633f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757740 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703103}
-
kylechar authored
Remove some usage of deprecated callback types in services/viz/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Bug: 714018 Change-Id: I241bbfff47b705f448790e13b2089fe10425e280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841235Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#703102}
-
- 04 Oct, 2019 29 commits
-
-
Benjamin Beaudry authored
When navigating by word or by character with ATs on Windows (i.e. Narrator), links were not announced by the screen reader or were announced one word earlier. This was caused by two different bugs: 1. GetEnclosingElement() used to return the child text node of the link instead of returning the link node. I believe this might cause multiple other bugs related to other controls, such as buttons, and will look into a more general fix soon. This bug as been addressed in CL:1828124. 2. For Narrator to announce links and other control types properly, the |start_| and |end_| endpoints of a range must be in the same anchor for by word and by character navigation. Otherwise, "link" will be announced multiple times where not expected. This CL introduces a fix for the second bug. We reposition the |end_| endpoint to the end of the |start_| anchor if they are not in the same anchor. Bug: 928948 Change-Id: Ie455cdee26d233b6b97347345d0e3cdaa99b9f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825490Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703101}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40ba239931e2..6822e098c873 Created with: gclient setdep -r src-internal@6822e098c873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ibe1b98fb2227f356e93c5573a4754f7682bda6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842398Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703100}
-
Maggie Chen authored
This DCHECK in the default initialization path prevents Chrome from running in Windows. Remove this DCHECK and use a error log instead when Vulkan is enabled. Bug: 1010584 Change-Id: I52dfab8ee07c2a555c155722e632f974cfbbdf59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842039Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703099}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/571177f01598..7f271e7f2645 git log 571177f01598..7f271e7f2645 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7f271e7f2645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I50f9896803b167b4667c34c0fa56ef71b47216ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842498Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703098}
-
Sergey Ulanov authored
Previously WidevineKeySystemProperties was initialized with hw_secure_codecs containing only video codecs, which was preventing playback on sites that require HW_SECURE_ALL robustness. Bug: b/141148085, b/141251412 Change-Id: Ia2909e47fa844a50655047132bfa04cfe317c222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841744 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703097}
-
Joe DeBlasio authored
This CL updates the Safety Tip UI to add a 'learn more' link, an explicit ignore button, a revised edit distance button string. It also prepares the code to facilitate a new graphical header. This CL omits the placeholder image for the header while we are figuring out the final UI. Using the a tentative image, it looks roughly like this: https://storage.cloud.google.com/chromium-translation-screenshots/df14c960857c08e55816d0cd50445988f337be8a Bug: 996731 Change-Id: I8db71f843a23e89c370b7cc3fbb9c79346bafd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816805 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#703096}
-
Johann authored
Change-Id: I2e52c0c27b049b8af8af205b7d6d497139bc071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838529 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#703095}
-
Collin Baker authored
This CL: * Exposes function for getting Browser* from a window ID in ExtensionTabUtil * Moves TabRendererData creation logic into c/b/ui/tabs * Makes the tab strip JS notify TabStripUI of its window ID * Observes the window's TabStripModel in TabStripUI Bug: 1006946 Change-Id: Ie9650cf9070c140d7ae23415f57d96bfcb8d76d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836455 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#703094}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/f518a2641c6d..ef79a5fa1b2c $ git log f518a2641..ef79a5fa1 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 dschinazi Improve logging by adding more ToString methods and refactor 2019-10-04 bnc Fix crasher in QpackProgressiveDecoder destructor if QpackHeaderTable is already destroyed. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I74618e93beb91846c3f65783c796bd9b0b610f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841584 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703093}
-
Tina Lu authored
Bug: 1009844 Change-Id: Ibf6b878061f30c93541f29dad41520cf399dc2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830090Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tina Lu <ltina@google.com> Cr-Commit-Position: refs/heads/master@{#703092}
-
Danan S authored
The WallpaperControlClient is referenced by the SessionControllerClient via the following code path: WallpaperControllerClient::RemoveUserWallpaper() policy::WallpaperImageExternalDataHandler::RemoveForAccountId() chromeos::ChromeUserManagerImpl::RemoveNonCryptohomeData() user_manager::UserManagerBase::RemoveUserFromList() user_manager::UserManagerBase::RemoveNonOwnerUserInternal() chromeos::ChromeUserManagerImpl::RemoveUserInternal() user_manager::UserManagerBase::RemoveUser() chromeos::ChromeUserManagerImpl::PerformPostUserListLoadingActions() user_manager::UserManagerBase::EnsureUsersLoaded() user_manager::UserManagerBase::GetUsers() chromeos::ChromeUserManagerImpl::GetUsersAllowedForMultiProfile() SessionControllerClientImpl::GetAddUserSessionPolicy() SessionControllerClientImpl::SendSessionInfoIfChanged() SessionControllerClientImpl::Init() Because the WallpaperControllerClient singleton hasn't been created yet, this results in a crash when running tests that activate the code path. This was discovered while working on http://crrev.com/c/1836457. This fix is necessary to fix a crash in that CL. Bug: 1010707 Change-Id: I239a743536afd97c99ba5e8e1fb1d6031c4a9805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842318Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703091}
-
Alison Maher authored
WebThemeEngineImplDefaultBrowserTest.GetSystemColor was disabled due to failure on Win7: https://chromium-review.googlesource.com/c/chromium/src/+/1837225 The test now takes Win7-specific system colors into account. Bug: 1010924 Change-Id: If14e79d90ed9cda1cbbfdc2a2144751cdd493754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839013 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703090}
-
Renjie Tang authored
Bug: 1011036 Change-Id: Ic0cd9cb59240c65efe1702da605b3898fb2aa69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838952Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703089}
-
Vladimir Levin authored
This patch updates the perftests to use rendersubtree attribute instead of the imperative displayLock. Also adds an activatable perftest. For this change to be equivalent to the previous one, the perf tests also need to run with CSSContentSize enabled, which this adds as well. R=chrishtr@chromium.org, crouleau@chromium.org Change-Id: I6447b467aa9cd58da9f572bca0eca7eda04f3216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841233Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703088}
-
Alex Cooper authored
This test page can help validate scenarios where a page is behaving or performing poorly. Bug: 1009813 Change-Id: I0e31bc919194e0db19b0b346f9568a45828834ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842278 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703087}
-
Toni Barzic authored
Disables events within apps container subtree when the apps container is shown (faded) behind search results. Change-Id: I80e83a584ec206f059e2ab34300d338479e6c6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842008 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703086}
-
Nate Fischer authored
No change to logic. This refactors WebView's metrics files into a separate folder (//aw/browser/metrics/, //aw/java/.../metrics) and refactors the native files into a separate build target. I've also added OWNERS files for the subfolders, proposing myself as owner. Bug: 934152 Test: gn check out/Default/ Test: ninja -C out/Default/ webview_instrumentation_test_apk system_webview_apk android_webview_unittests Change-Id: I049e1336ba6d452527069f49d16495bd985224bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842533Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703085}
-
Matt Mueller authored
CertVerifierWithTrustAnchorsTest: test both CertVerifyProcChromeOS and CertVerifyProcBuiltin(with SystemTrustStoreProviderChromeOS) Bug: 410574 Change-Id: I8f1eaa03c0c5497ab51b72dda4d96f75a53c5a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836383 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#703084}
-
Philip Rogers authored
Removed CompositeAfterPaint-specific mask-composite-missing-image expectation that caused the test to fail. Triaged composited filter failures (crbug.com/1008501). Bug: 1008501 Change-Id: I67472958ed19a7f32afa7971559ef6ec437d8adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841734Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703083}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6474a450e961..23463e8bb77f git log 6474a450e961..23463e8bb77f --date=short --no-merges --format='%ad %ae %s' 2019-10-04 amaiorano@google.com Remove unused SamplingRoutineCache::Key::operator< Created with: gclient setdep -r src/third_party/swiftshader@23463e8bb77f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141863676 Change-Id: I7eb624b192ee7964c8452ad2a7e28ac822941919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703082}
-
Fredrik Söderquist authored
Move the priority comparison between two timed elements into the new SVGSMILElement::IsHigherPriorityThan() method. This ought to make fixing the existing FIXME easier. Bug: 998526 Change-Id: I05492faa770cb9eaf8589e88cbf86845f870c9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841131 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#703081}
-
Daniel Cheng authored
Bug: none Change-Id: I4c065e8257c54ff9d731fca17c3786764e9a774a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841504Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#703080}
-
Gayane Petrosyan authored
Bug: 1011464 Change-Id: Id1028ef2b63b877d7e0e91525e28a1ffd56837b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841655 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#703079}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c0efff9d41d9..6ce64248fdc9 git log c0efff9d41d9..6ce64248fdc9 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 lamontjones@chromium.org config: update Cr50 firmware builders Created with: gclient setdep -r src/third_party/chromite@6ce64248fdc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id62a1d27163dcbb2fee2306bc86f6f9dabdfef74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842497Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703078}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/395b9e4a..76548ed5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff6d9a8cac3d59cbd67e05d0536c9c8bcaaf64c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842413Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703077}
-
Min Qin authored
In DownloadFileImpl::RegisterAndActivateStream(), it registerers a callback when data become available in the stream handle. Then it starts reading the stream handle in a while loop. And the following scenario could happen afterwards: 1. The SimpleWatcher object in StreamHandleInputStream thinks data is available, and posted a callback to run DownloadFileImpl::StreamActive(). 2. Before the callback gets to run, the while loop consumes all the data in the data pipe. This hits the stream_handle_->stream.reset() statement in StreamHandleInputStream::Read(). 3. The callback is executed, and stream_handle_->stream->ReadData() is called. And this causes chrome to crash. This CL fixes the issue by registering the callback only when data from the stream handle is not ready. By doing this, the callback won't be scheduled when DownloadFileImpl is inside the StreamActive() loop. BUG=1009839 Change-Id: I9d90686ffea56fb61a9c29aa2a569618fcf6fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832735Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703076}
-
Kevin Marshall authored
Changes the OUTDIR/bin/install_foo scripts to run "pm install" on existing Fuchsia Amber repositories. This better suits the common workflow of deploying to existing paved devices. Adds a GN arg "default_fuchsia_build_dir_for_installation" to enable super EZ zero-arg invocations of the install script. Bug: 973159 Change-Id: I5d4456fd74f7000a576749d2c427051f24d216b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815838Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#703075}
-
Klaus Weidner authored
This opt-in mode keeps DOM content visible as a transparent overlay while in an immersive-ar WebXR session. It is activated by requesting an optional or required feature on session start: navigator.xr.requestSession( 'immersive-ar', {optionalFeatures: ['dom-overlay-for-handheld-ar']}); This functionality is only available if the corresponding feature flag chrome://flags#webxr-ar-dom-overlay is enabled. On session start, this fullscreens the <body> element. The application can use the Fullscreen API to change the visible element. Exiting the session ends fullscreen mode, and calling document.exitFullscreen() exits the immersive-ar session if there are no remaining fullscreened elements. (As of this CL, changing the fullscreen element doesn't fully update layer visibility, so non-fullscreen content can remain visible unexpectedly. That's being addressed in a followup.) Change-Id: I77b767b111436b45e2b584e46a390a68473ab118 Bug: 991747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741008Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#703074}
-
Fredrik Söderquist authored
The ordering required in SMILTimeContainer::ApplyAnimationValues isn't really the full-blown ordering used for sandwiches - using only the "document order index" should be sufficient (although arguably still not correct). Bug: 998526 Change-Id: I293b9e55824c2b683b5991e7da3266958eb94e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840991Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#703073}
-