GitLab

The credential IDs of the Touch ID authenticator are basically an
AEAD of the associated PublicKeyCredentialUserEntity (= (id, name,
display name), with the RP ID as the AD. While the user ID is bounded to
64 bytes, the user name and display name are not. Instead, CTAP
authenticators are supposed to truncate them at any length larger than
64 bytes as they see fit.

The spec doesn't define an upper limit for credential IDs, but I suspect
some RPs will limit what they accept based on what they observe in
security keys from large manufacturers. Also storing potentially
unbounded IDs in attribute fields of the macOS keychain items might not
be the best idea. Hence, let's impose some (arbitrary) limit.

Bug: 1631393
Change-Id: I43cbbf3daa6e926baba7007ff99223b5666773e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631655
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665653}

Following up on a drive-by from mek@ at
https://crrev.com/c/1252912, this change updates our IndexedDB
code to comply with Chromium's C++ dos/don'ts where it says
to avoid std::pair and prefer a struct when defining an alias
to the std::pair return result.

Bug: 717812
Change-Id: I74755d832b1bc34c17fbdf769a54adf5cac406bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601821Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665652}

Bug: 935529

Change-Id: I6844597a562c761d6000d16a34cffc85ad79985a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639041
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665651}

BUG: 969857

Change-Id: I9ba74d64e9bc3a6400f9a504ccedb105c4b90452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606763
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665650}

There are lots of files that pull in Aura headers on the Mac.
Many have header includes that are easy to fix. The other is
hosted_app_button_container.cc, which includes
native_widget_aura.h in order to access GetWindowTitleFontList().
Move GetWindowTitleFontList() to custom_frame_view.h and file
a bug to move it elsewhere.

BUG=968860

Change-Id: I944a9c4016b65c5b10e5faead4e06aaafe71155c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636230Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665649}

This is a reland of ad780388

Fix includes moving the '!' into its proper place.

And crrev.com/c/1638777 was uploaded to prevent this type of regression from slipping
in again.

Original change's description:
> Skip 'dep:chrome_internal' Tast tests if we're not building w/ is_chrome_branded.
>
> So that no dep:chrome_internal tests are ran if they don't have the
> needed internal bits.
>
> Bug: 947531
> Change-Id: I060734d2fe05c878d16f2c6a63815bd0abbb554c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637644
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665158}

Bug: 947531
Change-Id: I8acc782fb8a926a628e7531b7df73cc6029be6d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637672Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665648}

We've moved away from having separate IsXYZFlagEnabled() functions in
favor of just having the flag-checking code at the calling points
themselves. I believe these are the last three stragglers.

Change-Id: I8060cacd962851dc22691ef95437b7aa72b6fbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639051Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#665647}

Use of GSSAPI libraries is gated on a complicated condition that's
repeated in multiple locations. In reality it simplifies greatly since
there are only two exceptions to the "Use an external POSIXish GSSAPI
library if supporting Kerberos" rule.

Bug: 927182
Change-Id: I6e3b514cdddb857409e90ee9fd0460d8d7836404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640782
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665646}

Bug: 969257
Change-Id: Ic24c32bc581a7a5aa2b84b3755ef313afb55c410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639821
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#665645}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 968302
Change-Id: Ic5a0341b41596cef91ffcce72f467bf26c01c244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636452
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665644}

Bug: 969093, 968951
Change-Id: Ibc88bcc667d8035c49f58c3c0cd0f98651595acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637669Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#665643}

With completion of NewWindow API and Execute[Async]Script APIs,
WebDriverExpectations have been updated to expect affected tests to
pass. This should include all webdriver/tests/new_window tests,
all webdriver/tests/execute_async_script tests, and all
webdriver/tests/execute_script tests (except
json_windowproxy_serialize.py).

Change-Id: I95ea32d727996f40d18816e7198b40c34cd4acbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641802
Auto-Submit: Rohan Pavone <rohpavone@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665642}

After PM/UX discussion, we don't want to duplicate the search engine
drop-down between browser and OS settings. Instead, OS settings uses
an info label with a link to browser settings.

Screenshots on bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=960937#c7

Bug: 960937
Change-Id: I622558c4c7238dc8f3d36d3a63305e7abc0f473a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640601Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665641}

https://webrtc.googlesource.com/src.git/+log/102b7289a9f2..e86af2c75fe6


git log 102b7289a9f2..e86af2c75fe6 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 eladalon@webrtc.org Allowing buffering a LNTF (loss notification) feedback message in RTCPSender
2019-06-03 barrerap@webrtc.org Check input file extension is not wav


Created with:
  gclient setdep -r src/third_party/webrtc@e86af2c75fe6

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icd16aa13c3aa587e8e5495c91c7d6b39d512c194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641505Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665640}

Causing a lot of flakes on android-marshmallow-arm64-rel. Also removes
the suite-specific shard timeout.

Tbr: perezju@chromium.org
No-Try: true
Bug: 964804
Change-Id: I79878f447cb3206416eedc51a69c0cbf381ae953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639347
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665639}

We saw a crash report in MuxingSignalStrategy (see the bug) that
OnWaitForAllStrategiesConnectedTimeout seems to try reading address 0x0.

The callstack seems a bit confusing and incomplete but one failure
pattern I can see is that when MuxingSignalStrategy is destroyed, it
will first call Core::Invalidate() then schedule to delete Core
asynchronously. Invalidate() doesn't stop the timer so the timer may
kick in any time before the Core is actually destroyed. Then
OnWaitForAllStrategiesConnectedTimeout may access the signal strategies
after they have been deleted in Invalidate().

This CL stops the timer in Core::Invalidate, which should fix this
particular failure pattern.

Bug: 969825
Change-Id: I448eee26173e4cb6d976803b7f4e9e08f3dda4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641372
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665638}

Turns on a new tab-loading animation by default. This animation displays
the favicon earlier in the loading process to communicate where a user
is navigating to even while the page is still loading.

Bug: chromium:941039
Change-Id: I8a117243d963b87e75a875832529bcb35e9af035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639565Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665637}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/062420146dfd..4867952e90e7


git log 062420146dfd..4867952e90e7 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 dgagnon@google.com Update gen_luci_scheduler with R76 branch


Created with:
  gclient setdep -r src/third_party/chromite@4867952e90e7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I739ff396f20c8a62d20fa5bc59fd5538ef11051b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641504Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665636}

TBR=foolip@chromium.org
BUG=968164

Change-Id: Id5bf236dfd3a3e716ebfb88a1b6f8e6302c3060d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641327Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665635}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d167c5b89a42..6e0b92527131


Created with:
  gclient setdep -r src-internal@6e0b92527131

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=harringtond@google.com,orphis@google.com,shend@google.com

Change-Id: I9b899a7d3362b1ba6cad4d7efd9221b67758acd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641503Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665634}

This reverts commit 400c3bba.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 665601 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDAwYzNiYmE5YmEwMTRiYmJmODk5YzA3YzVjOTllNjJkZTliYWVjYgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/92132

Sample Failed Step: content_browsertests

Sample Flaky Test: WebContentsViewAuraTest.DragDropOnOopif

Original change's description:
> Use async targeting to find drag and drop targets
> 
> Add callback supports to the RenderWidgetTargeter
> and use the async targetting in drag and drop code
> and register a callback to send drag events using
> the callback. Note that since drag and drop events
> aren't WebInputEvent it is not possible to use
> FindTargetAndDispatch function of RenderWidgetTargeter
> at this time.
> 
> The original CL
> https://chromium-review.googlesource.com/c/chromium/src/+/1596840
> was reverted due the added test being flaky. This CL is the same
> as the original CL expect it has the same test with another
> way of checking the logic.
> 
> TBR=sadrul@chromium.org
> 
> Bug: 804633
> Change-Id: I46f15a2b694c3ad9d3574473c2a46ba13dcbfb79
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641383
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665601}


Change-Id: Ib44e431fa894a33ce908c2f7defb2ae80d399e8d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 804633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641515
Cr-Commit-Position: refs/heads/master@{#665633}

We extend the functionality for mobile, including different favicon
sizes in the favicon server request. We add no mobile UI callers in
this CL.

Change-Id: I115ba3d494fbb6ebbfbced328fe75d9a21f331f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635470
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665632}

Some developers still have older version of the presubmit script locally, which means their not automatically adding strings to the grdp files.

This PR adds some that were missed. This should settle out as devs pull the latest master.

Bug: 941561

Change-Id: I53cb00e3df1b19b2559f9d3745d42aa0f5ff6be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637844
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665631}

Updates all the VR golden images that had the word "Ingcognito" in them,
as a recent change switched the term to "Private".

TBR=alcooper@chromium.org

Change-Id: Id7b30ebd99c6282d5fd95916619aaf96a0c92957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641543Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665630}

BEST_EFFORT tasks will not run until after startup and only if there is no
critical work pending.

This patch should not change the current behaviour. Please double check
whether the task being posted via BrowserThread::PostAfterStartupTask
really cares about being run after startup or just wants to run after
any critical work was completed. If you are fine with it just running
after critical work has completed LGTM and keep on with your life. If
that is not the case let me know and please explain your reasoning in a
comment.

More details:
https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI

This CL was uploaded by git cl split.

R=droger@chromium.org

Bug: 887407
Change-Id: Ibfc8941bf5e8237e89363a930581342eb27f44c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632222
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#665629}

In most cases pixel expectations for layout tests on Fuchsia are the
same as Linux, so it's not necessary to duplicate them for Fuchsia.

Bug: 958017
Change-Id: I00aea4f5ad82a5a6bc5be17668b4342222f19719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641662
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665628}

BUG=chromium:934251

Change-Id: Ia41778d9a4787e022c167b1e5f6b0da4ed3b8e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641285Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665627}

This less-efficient version was only needed in one place; inline the lookup
there.

Bug: none
Change-Id: I26c5e2e1fe77612c3b01a9bd2e1646b5434751cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637854Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665626}

Original description:
> This doesn't re-use TabletModeObserver, instead introducing
> TabletModeToggleObserver (equivalent to old mojom::TabletModeClient),
> because TabletModeObserver has other methods that don't seem like they
> should be exposed as part of the public API.

Fix:
rewrite InitializedWhileTabletModeSwitchOn so the TabletModeController
doesn't need to be recreated.

TBR=tsepez@chromium.org
Bug: 958220

Change-Id: I48490531269e6ed8b4bd856ec7ffab5609282dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639119Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665625}

https://chromium.googlesource.com/angle/angle.git/+log/12a524231f53..4a75741655d3


git log 12a524231f53..4a75741655d3 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 kkinnunen@nvidia.com D3D: Fix heap corruption when copying texture arrays


Created with:
  gclient setdep -r src/third_party/angle@4a75741655d3

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Change-Id: I2e42c795195b1790c5b438b0f76d38661d3549f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665624}

Calls to pin or load user32.dll cannot happen on the main thread loop
because they are blocking calls. The test code always executes on the
main thread loop, so if the test code hits anything that requires
user32 then it will crash (with dchecks on). To avoid this, we simply
call PinUser32() in main before we get to the main thread loop.
This same thing is done in browser_tests_main.cc and shell_main.cc for
other test binaries.

It's worth noting that the crash from this bug only hits on touch
devices where the IsDeviceUsedAsATablet method runs.

Bug: 968500
Change-Id: Ia3de38c7893b7143bde39aef3edc88ff0853caec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637503
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665623}

This better reflects what the code actually does as
there's now a bunch of non backgrounds related stuff
in there.

This will be followed up with renaming of the
customBackgrounds object.

Bug: None
Change-Id: I42a2f5b0eb0d5aec04ce302217f1fbf61fe57110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639180
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665622}

Bug: 875053
Change-Id: I5adf910defdfddbc8a63ecb9d5559fdec4fa3316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639478
Auto-Submit: Nick Harper <nharper@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665621}

* Add support for test suite-specific sandbox policy.
* Add fuchsia.web.Debug API to the ContextProvider service.
* Add tests for that API by using the Fuchsia Hub.

Bug: 955589
Change-Id: Icc5d9a91c30b55e71f6f104f8b7ea984b811a1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578597Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665620}

https://chromium.googlesource.com/catapult.git/+log/58f6c4682e28..1c7a411305c5


git log 58f6c4682e28..1c7a411305c5 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 khokhlov@google.com Py_trace_event: return traceUrls metadata field
2019-06-03 khokhlov@google.com Telemetry: report zero values in diagnostics


Created with:
  gclient setdep -r src/third_party/catapult@1c7a411305c5

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:969681,chromium:968959
TBR=charliea@google.com

Change-Id: I85d60e8b916a254d8347410730a445384db9ccb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640533Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665619}

Also fix AwCookieChangeDispatcherWrapper to handle URL substrictions,
as RestrictedCookieManager uses those.

RestrictedCookieManager is used by the under-development (hidden by origin
trials) Cookie Store API; access to it doesn't go through
ContentBrowserClient::AllowGetCookie & friends, so Android WebView cookie
control knobs don't work. To fix that, route RestrictedCookieManager creation
via ContentBrowserClient and insert a proxy in AwContentBrowserClient that
applies that policy.

Bug:958923

Change-Id: Iea87f0ecebaef303492f5aad0bab7849204e94b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613923Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665618}

The method only had one caller, which required a less specialized version of the
function. No point in unnecessarily exposing the method in base/.

Change-Id: I5286af592168fbf013b515da4cc8010ab3c49584
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637662Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665617}

This CL replaces GaiaCookieManagerServiceObserver with vanilla
callbacks. Now that GCMS is owned by IdentityManager, and cannot have
multiple observers, a callback interface seems more natural than an
Observer class.

This also has the nice side effect of removing transitive includes of
gaia_cookie_manager_service.h via identity_manager.h.

Change-Id: I9cdac56c8237c9a09eb2c2ce87f41f48872a9fb6
Bug: 939372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630162Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665616}

Bug: 945522
Change-Id: I9a039f9eeb3327932ac11c24352e26d6e7ac4e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638946Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665615}

Bug: 934009
Change-Id: Id80a3835f6d6da36e8d2a96a155de4b42db82539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639074
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665614}