GitLab

Bug: 830489
Change-Id: Ief2540485aa699a72ad9adccafa487a729e7fb08
Reviewed-on: https://chromium-review.googlesource.com/1015441Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551515}

We'd like to provide smaller tarballs with which one can build Chrome,
and such tarballs exclude //third_party/WebKit/Tools/Script. We're
moving //third_party/WebKit/Tools/Scripts to //third_party/blink/tools,
and would like to exclude //third_party/blink/tools as well. However,
some build scripts use name_style_converter.py in the directory.

This CL moves name_style_converter.py out from
//third_party/blink/tools, and enables to exclude
//third_party/blink/tools.

test-webkitpy includes //third_party/blink/renderer/build/scripts. So
the following existing tests run on buildbots in addition to
name_style_converter_test.py:
- in_file_unittest.py
- minimize_css_unittest.py
This CL fixes test failures of in_file_unittest.py.

Bug: 832283
Change-Id: I7d3b3524daa59291eaf7f323818a7b0e25163179
Reviewed-on: https://chromium-review.googlesource.com/1013768Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551514}

Temporarily disabling checkering of decode=async tag images to debug
entries in ukm logs for checkerboarded images in the control group for
checkerimaging finch study.

R=vmpstr@chromium.org

Bug: 833666
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib9a79262599efa17fd18e9cb71d7518492e9a7ee
Reviewed-on: https://chromium-review.googlesource.com/1014644Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551513}

This reverts commit f0acd4fc.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 551483 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YwYWNkNGZjZjE5MzlhMTUyYzI3ODdmNjI1NjQ0YThlNTc5NDdkMjgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7001

Sample Failed Step: base_unittests

Original change's description:
> Fix SampleVector tests to expect CHECK rather than DCHECK deaths.
> 
> Bug: 832728
> Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f
> Reviewed-on: https://chromium-review.googlesource.com/1012732
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551483}

Change-Id: Ie2ad7fb9ebd4c214a7dd2cebe0763b2f41793f01
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832728
Reviewed-on: https://chromium-review.googlesource.com/1015194
Cr-Commit-Position: refs/heads/master@{#551512}

... so as to insure it's always destroyed on the correct thread even though it's passed
around through different threads.

Change-Id: Ieae597251f2836de73cc13cb39fa6d39b9645133
Reviewed-on: https://chromium-review.googlesource.com/1013379
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551511}

Bug: 754986
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I234a2cc037b78b11d08660b641f5524ed8171a0b
Reviewed-on: https://chromium-review.googlesource.com/1014601Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551510}

Previously, when the autocomplete engine did not provide any matches,
the OmniboxEditModel would generate a current match from the text
contents of the View.

This would lead to bad behavior when Steady State Elisions was on. For
example, if the user was at the full URL https://router/, and the
elided display text was simply "router", this would trigger a search
when the user pressed Ctrl+L, and then Enter.

This CL fixes that by only using the View text if user input is in
progress, and using the full formatted URL otherwise (if in display
mode).

This bug doesn't have an impact unless the Steady State Elisions flag
is on, so this doesn't require a merge.

This CL also adds a test.

Bug: 797354
Change-Id: Id27913f567313333e8a171a8040bf906a7a1cc52
Reviewed-on: https://chromium-review.googlesource.com/1013694Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551509}

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 781352
Change-Id: Ide6e641f8e9fed673bbf641074f33a05d238735a
Reviewed-on: https://chromium-review.googlesource.com/1014782Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551508}

https://chromium.googlesource.com/catapult.git/+log/055c0339565a..ca7ee7a2c7fe

$ git log 055c03395..ca7ee7a2c --date=short --no-merges --format='%ad %ae %s'
2018-04-17 simonhatch Dashboard - Use bot_configuration in /auto_bisect.
2018-04-16 simonhatch Dashboard - Update delete/migrate to also do histogram data.
2018-04-16 simonhatch Dashboard - Fix up diagnostics

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:779618


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ie5fbb5255dd417719043563f31e69bb61e633657
Reviewed-on: https://chromium-review.googlesource.com/1015762
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551507}

Bug: internal b/74159854
Test: Ran on Android Things speaker, verified bug is fixed.
Change-Id: I14b4f82c175f771cf7387d1bf6b2655221397edc
Reviewed-on: https://chromium-review.googlesource.com/1011297Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551506}

If ALPN protocol negotiation gives us an answer, use that directly;
otherwise, we assume HTTP/1.1 if any response headers were received.

Bug: 748549,833996
Change-Id: I33d6217ede6202358acf1a343296f5019a9b6052
Reviewed-on: https://chromium-review.googlesource.com/998021
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551505}

Currently AudioDestination starts with an empty PushPullFIFO, so
the first callback from the AudioDeviceThread always ends up with
a bogus "glitch report" on the histogram.

This CL fixes the issue by priming (prefill) the PushPullFIFO to cover
the first callback from the ADT.

Bug: 833766
Change-Id: I17e40df31586c9dd3e3678706d47f08693b96d45
Reviewed-on: https://chromium-review.googlesource.com/1015201Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551504}

Team drives only support retrieving change lists using the a start
page token, which currently is not supported at all by the drive
sync client.

This CL makes it possible to retrieve the start page token for either
the users changelog or a team drive changelog.

Today, the drive client uses startChangeId to retrieve change lists,
which has been deprecated in favor of pageToken. A follow up CL
will make this change so that the logic will be consitent when
retrieving either the users change list or a team drive change list.

Other Notes:
- In places fixed a few "git cl lint" errors.
- "git cl upload" complains about using base::Bind so I used
  base::BindRepeating, but I suspect we can change this to base::BindOnce in a
  followup cl.

Bug: 715355
Change-Id: Ie1a93b6919c3c179aeb68d5deb5fa3b367d02497
Reviewed-on: https://chromium-review.googlesource.com/1013819Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551503}

When entering VR we hide the browser controls. However, it can take some
time for this state update to reach the FullscreenManager. As a
consequence, hover move events may have a false offset depending on
whether the initial hover enter event was processed with the updated
browser controls state or not. To fix that, also update the top offset
for hover move events.

Bug: 822384
Change-Id: I196a38098f736d6a9c8066b0a48cafa774ea1864
Reviewed-on: https://chromium-review.googlesource.com/1014708Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551502}

WKBasedNavigationManager does not yet inject session history into new
WKWebViews created by PrerenderService. Disable PrerenderService for
now so we can measure the load performance impact in Finch experiment.

Bug: 814789
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iad1db96832dc2e30ab85aa6b8939b8e5850ad250
Reviewed-on: https://chromium-review.googlesource.com/1012494Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551501}

SingleThread, not SingleTreaded (add one letter, remove two). Spelling
matters to allow searching for the referenced functions.

Change-Id: I46909856cd3540fe246d9d8a9db70aaee2ebe71f
Reviewed-on: https://chromium-review.googlesource.com/1012489
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551500}

This patch simplifies the code to scroll to fragment (i.e. scrolling to
an Element with id="foo" when navigating to http://ex.pl/index.html#foo)
code by moving more of it into LocalFrameView rather than in Document.

Previously, we kept some state whether rendering was blocked when the
URL fragment was processed and if it was we'd try to perform the scroll
later in the document lifecycle. This patch removes the state tracking
and relies entirely on the scroll happening in PerformPostLayoutTasks if
it can't be done immediately.

It also moves focusing on the fragment element into the method that
performs the scrolling, tying these together. This appears to have been
the original intent based on the comment in ProcessUrlFragment but
changes behavior slightly.

Re-land Note: This was originally reverting because script could run
inside the ScriptForbiddenScope in UpdateLayout
(https://crbug.com/796222). This patch removes the ScriptForbiddenScope
in Document::UpdateStyleAndLayout since both UpdateStyleAndLayoutTree
and UpdateLayout are guarded internally by ScriptForbiddenScope. It also
narrows the scope of the ScriptForbidden section in UpdateLayout to not
include the call to Document::LayoutUpdated and moves the scrolling and
focus related methods there.

Bug: 795381, 830881
Change-Id: I571932217a0664f21fae8463d26b2c807a5f565e
Reviewed-on: https://chromium-review.googlesource.com/1010264
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551499}

Change-Id: I32b5e7e37ff1b366a99de9ce5cd627ee5251490b
Reviewed-on: https://chromium-review.googlesource.com/1015900Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551498}

Destroy the MediaEngagementService object later. Should fix the
ToTLinuxUBSanVptr bot on the clang ToT waterfall.

R=beccahughes@chromium.org,mlamouri@chromium.org
BUG=chromium:827609

Change-Id: I9570279416a39d1018f714762d3df871cf2ce07a
Reviewed-on: https://chromium-review.googlesource.com/1015770Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551497}

This patch splits creating box fragments from computing inline
positions, in preparation of supporting text-overflow in
NGInlineLayoutAlgorithm.

No behavior changes in this patch.

Bug: 636993
Change-Id: I0e99a07128031a7085426ad53f91214df9c223a1
Reviewed-on: https://chromium-review.googlesource.com/1013779
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551496}

To support certain use cases the current upgrade strategy
can't be used. This cl changes all upgrades to N-1 strategy.

Bug: 461856
Change-Id: Ic7a7580e6e2e51b65428cddaca1209a3edc0af5b
Reviewed-on: https://chromium-review.googlesource.com/1013222Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: James Meade <mmeade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551495}

CDM_9 support has been shipped in Chomium for multiple releases. All new CDMs
should use CDM_9 and above. Hence removing support for CDM_8.

only cover CDM_9 and CDM_10.

Bug: 737296
Test: Removing support of old interface support. Currently our tests
Change-Id: I22facd6dc6e18933a295d3aece7ba2de1369cb79
Reviewed-on: https://chromium-review.googlesource.com/1015640Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551494}

The new name is kDisplayingNativeErrorForFailedNavigation. This change
is needed to support HTML based error pages which will use
kDisplayingWebErrorForFailedNavigation enum.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id68e8239d9706b8d98bc591a0d264609b13e23c0
Reviewed-on: https://chromium-review.googlesource.com/1015531Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551493}

This reverts commit 6db68698.

Reason for revert: Broke compile on Windows
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130690

FAILED: angle_shader_translator.exe angle_shader_translator.exe.pdb  E:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /OUT:./angle_shader_translator.exe /PDB:./angle_shader_translator.exe.pdb @./angle_shader_translator.exe.rsp translator.lib(OutputVulkanGLSL.obj) : fatal error LNK1236: corrupt or invalid COFF sections

Original change's description:
> Roll src/third_party/angle/ aa8b3982a..aed1b56aa (8 commits)
> 
> https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..aed1b56aac8e
> 
> $ git log aa8b3982a..aed1b56aa --date=short --no-merges --format='%ad %ae %s'
> 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper.
> 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation
> 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly
> 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState
> 2018-04-17 jmadill Vulkan: Fix build after roll.
> 2018-04-17 jmadill Vulkan: Suppress ClearIssue test.
> 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD.
> 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18
> 
> Created with:
>   roll-dep src/third_party/angle
> BUG=chromium:833736
> 
> 
> The AutoRoll server is located here: https://angle-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=jmadill@chromium.org
> 
> Change-Id: I7c7f1fb47c5cde7e4552f40d084fcd9d1af2e9ee
> Reviewed-on: https://chromium-review.googlesource.com/1015624
> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#551461}

TBR=jmadill@chromium.org,angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: Ic8bf0038e7b39a6025ac24b65aa5a38f078f0ede
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:833736
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1015191Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551492}

This change includes the integration of the MacOS KeyboardHook impl in
the RenderWidgetHostViewMac and RenderWidgetHostViewCocoa classes.

RWHVMac handles the lock/unlock calls from RenderWidgetHostImpl and
forwards them to RWHVCocoa which handles the events and input routing.

The RenderWidgetHostViewMac and RenderWidgetHostViewCocoa integration
follows the same pattern I used for RenderWidgetHostViewAura and
RenderWidgetHostViewEventHandler. The main difference between this impl
and the Aura impl is that there is a bridge class between RWHVMac and
RWHVCocoa (RenderWidgetHostViewNsBridgeView).

BUG=680809

Change-Id: I524c98c059ae4883bf597704c326b5a0055f1212
Reviewed-on: https://chromium-review.googlesource.com/989618Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551491}

Nobody will pick them up anyway.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ice7a1f9ee743a1555f0fab00feca0b2eef97125f
Reviewed-on: https://chromium-review.googlesource.com/1012847Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551490}

Add a check that the parent FrameSinkId is registered before creating an
OffscreeCanvasSurfaceImpl, which is really a generic embedded surface
and not just used for offscreen canvas. The IPC channel that controls
the destruction of the parent CompositorFrameSink, and subsequent
invalidation of parent FrameSinkId, is different than the IPC channel
used to create embedded surfaces. We can't rely on ordering of messages
between them. It's possible the parent FrameSinkId is invalidated before
the browser gets the request to create an embedded surface.

If this state is detected then just drop the request for the embedded
surface. This will avoid triggering the DCHECK that the parent
FrameSinkId is registered and avoid doing work for something that is
about to be destroyed.

The experiment to enable UseSurfaceLayerForVideo, which uses
OffscreenCanvasSurfaceImpl, had tests running into this problem and
hitting a DCHECK in HostFrameSinkManager::RegisterFrameSinkHierarchy().

Bug: 830003, 829306
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I4e8cb26548444ecbf941a87a984b21aa4c846580
Reviewed-on: https://chromium-review.googlesource.com/1014330
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551489}

This ports similar (internal) code used on systems not supporting CMA backend.

Bug: internal b/77986368
Test: Running on speakers, observing proper logs.
Change-Id: Ifde45f035e2f52096f82e9682bf5c60b170d2c47
Reviewed-on: https://chromium-review.googlesource.com/1014740Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Chris Kuiper <ckuiper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551488}

This patch enables OOPIF pixel dumps behind a flag. The reason for the
flag is that this isn't working for 100% of cases yet. Specifically,
selection rects and dialogs windows aren't being captured correctly.

As well, there seem to be some pixel differences between existings tests
which will likely need to be rebaselined.

R=lukasza@chromium.org

Bug: 667551
Change-Id: Icfb98958e5b9d007b1bd3a554b32d55d545e04e6
Reviewed-on: https://chromium-review.googlesource.com/994240
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551487}

Fixing nits to improve readibility, also removing unnecessary TODO.

Bug: None
Tets: Build, tests still valid as funcionality remain the same.
Change-Id: Ia0be3efa9ba6e064a520b37ab27552e3af063a03
Reviewed-on: https://chromium-review.googlesource.com/1013287
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551486}

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rvera@chromium.org

Bug: 781352
Change-Id: I5429418614b13b654af86c4764ac1c9066a21f95
Reviewed-on: https://chromium-review.googlesource.com/1014780Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551485}

Bug: 828704
Change-Id: I1263e0bc2520b7b5f110ac2ae0ac92e3db8e2fd9
Reviewed-on: https://chromium-review.googlesource.com/999310Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551484}

Bug: 832728
Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f
Reviewed-on: https://chromium-review.googlesource.com/1012732Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551483}

Bug: 814860
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibe97fb4ccc820b72b67c8311b5ac5749ddb39d8d
Reviewed-on: https://chromium-review.googlesource.com/1014275
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551482}

Currently we create CFString and CFData wrappers for the underlying
std::string in RemotingKeychain. Even though the underlying content
isn't managed or released by the wrapper, we still need to release the
wrapper itself.

Bug: 834021
Change-Id: I47b298dc9a06ce34de68442cddc7ff07e79c0873
Reviewed-on: https://chromium-review.googlesource.com/1015769Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551481}

This cl makes some string changes for Keyboard Shortcuts Viewer based on
TC.

Bug: 833967, b/77166809, b/77861902
Test: manual
Change-Id: Ib28c40c1aea1303151bf2f4a687df7f230760cfa
Reviewed-on: https://chromium-review.googlesource.com/1015601Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551480}

This CL puts the ViewAndroidDelegate in WebContents internal to
makes it accessible using |WebContents.getViewAndroidDelegate|.
It helps replace ContentViewCore with WebContents where CVC is passed
as a way to access WebContents and container view.

The update of container view in VAD is taken care of by embedder
(WebView), so we don't need ContentViewCore API |setContainerView|
any more. It was deleted in this CL.

There are content classes that relied on |setContainerView| to do
some clean-ups (such as hiding popups). Added ViewAndroidDelegate.
ContainerViewObserver for them.

Bug: 598880
Change-Id: Icb824ddefc9707d9ea78cdba55615e47f2d100e7
Reviewed-on: https://chromium-review.googlesource.com/994500
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551479}

The file internal_app_id_constants.h was not added to
ash/public/cpp/build.gn. This cl fixes this.

Bug: 833955
Test: manual
Change-Id: Iff82b5d556ba084580640dbd73f423af67f64899
Reviewed-on: https://chromium-review.googlesource.com/1015527
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551478}

Only parameters encodings.active, encodings.maxBitrate and
encodings.priority are effectively working and connected
to the native layer.

Due to discrepancies between the WebRTC specification and the
native layers, the objects are not passed back from Javascript
and converted to native directly, but instead the relevant fields
are converted and patch the last result from getParameters().
If any read-only field is implemented by the native layer but not
exposed yet to Javascript, they will be left as is and won't cause
any InvalidModificationError.

Bug: 803494
Change-Id: Ia59734e5c3eddb54e5a1448a04fdcefe5a41a279
Reviewed-on: https://chromium-review.googlesource.com/969124Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551477}

Add version of conversion tests with and without premultiplied
alpha.

Bug: 833388
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I9d269e5867fee62ed70b2f3579a4c4bf524a7103
Reviewed-on: https://chromium-review.googlesource.com/1014631Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551476}