- 11 Sep, 2018 40 commits
-
-
Dmitry Gozman authored
This follows the page's logic of only interrupting for some of the debugger commands. To achieve this, we switch from running a tight loop with only inspector tasks to a nested message loop (again, similar to the main frame). This requires making some operations respect PausableObject semantics, noticeably worker's ResourceFetcher, post message and evaluating initial scripts. WorkerInspectorProxy now either posts a regular task or interrupting task similar to how DevToolsSession does it. This is a preparation to unifying workers and page debugging experience and implementation. Bug: 775132 Change-Id: I1c8ccd98c2c9a35fa7ab0b91017b924a81a297b1 Reviewed-on: https://chromium-review.googlesource.com/1205802 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#590505}
-
Donn Denman authored
Aids with the integration of Contextual Search with Unified Consent by recording whether the user was previously undecided when their preference gets changed due to Unified Consent, and whether to throttle for every request and when throttling is in effect. BUG=829597 Change-Id: I28c10e10faee25dd6741243c4560d9ed74fa75ef Reviewed-on: https://chromium-review.googlesource.com/1214402Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#590504}
-
Ted Choc authored
BUG=800033 Change-Id: I9e9b1904004b0f4e82806b53b0fa53e8abfea396 Reviewed-on: https://chromium-review.googlesource.com/1220551 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#590503}
-
Fabio Tirelo authored
This reverts commit 65103ba6. Reason for revert: A proper fix was sent to clank downstream by jbudorick@ (https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/670069), so this is no longer needed. Original change's description: > [Autofill] Bring back isAutofillEnabled and setAutofillEnabled > > The functions are still used by Clank downstream and will be removed > once only the new preferences are used by it. > > TBR=mathp@chromium.org > > Bug: 879384 > Change-Id: Ibee61db92a2bd3cd8b4124b79fc1c0d747d401d1 > Reviewed-on: https://chromium-review.googlesource.com/1198453 > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587912} TBR=ftirelo@chromium.org Change-Id: I415c94a269e97637774af17289f7699215ed9a4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879384 Reviewed-on: https://chromium-review.googlesource.com/1199564Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#590502}
-
Bo Liu authored
Resources are only explicitly returned from OnDraw. This means it's possible for resources to be stuck in RenderThreadManager returned_resources_map_ indefinitely, if OnDraw stops. Post a task with roughly 2 frames of delay to return these resources to ensure that they don't get stuck indefinitely. Bug: 881957 Change-Id: I2a6331b9251b4057125761eb9fb0aaf29c881eeb Reviewed-on: https://chromium-review.googlesource.com/1214700Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590501}
-
Sylvain Defresne authored
Histograms will be logged starting with M-71, so add an expiration date of M-76 (five releases or a bit over six month). Bug: 881250 Change-Id: I73fb44340755f3fb1afbf2d01e34c5068dc49da9 Reviewed-on: https://chromium-review.googlesource.com/1219233Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590500}
-
Wenzhao Zang authored
Demo mode is mainly implemented in //chrome, but there're some initialization needed in //ash. Currently they are placed in |SessionController::SetIsDemoSession|, we should consider creating a demo_mode_controller in //ash if the logic becomes complex later. Bug: 882700 Test: Manual, with/without Mash feature Change-Id: I945d003875b0cf3864f5796810d09c83e30b76ea Reviewed-on: https://chromium-review.googlesource.com/1220179Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#590499}
-
Mason Freed authored
Change-Id: I55bc9e154abd300804d44988b35725c3c452011f Reviewed-on: https://chromium-review.googlesource.com/1220038 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590498}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/memory_details_android.cc. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 874080 Change-Id: I26104d2e0bc7817b955152a60a8ee4c97b033079 Reviewed-on: https://chromium-review.googlesource.com/1191418Reviewed-by:David Trainor <dtrainor@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#590497}
-
Matt Reynolds authored
The FusedLocationProvider API determines which location providers to use based on a priority mode specified in the API call. In PRIORITY_BALANCED_POWER_ACCURACY mode, the request will never cause power-intensive providers like GPS to be used unless another app requests it. Instead, the network provider is preferred. If Android is configured to disable network location providers but to enable sensors (like GPS), then elevate the priority of the request to improve the likelihood that GPS sensors will be used to acquire a location. BUG=620003 Change-Id: Ia11b7d367b0bdf89631a3e0ccfc696daf1d238a3 Reviewed-on: https://chromium-review.googlesource.com/1182289 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#590496}
-
Philip Rogers authored
The root scroller is also known as the outer viewport and is not always the root frame's LayoutView. If the root scroller is a child of the root frame, the clips between the child and the root frame should not apply to the root scroller. Previously, this was implemented by disabling clipping on the ancestor GraphicsLayers of the root scroller. This patch changes the behavior to adjust all ancestor clips in LayerTreeHostImpl::UpdateViewportContainerSizes. This should be safe because of the restrictions on what can be a root scroller. Bug: 879610 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1974ae6b2a2f130cc2ce4a4d90e3dea1c9d64340 Reviewed-on: https://chromium-review.googlesource.com/1217509 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590495}
-
Piotr Pawliczek authored
It is an update of required version number of the component. The current version number of the package is 1.6.23.2 . BUG=chromium:869939 TEST=Tested on nautilus with the autotest platform_PrinterPpds Change-Id: I4c16d960640cb7e8e30e49653451bce0ff51c517 Reviewed-on: https://chromium-review.googlesource.com/1212445Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#590494}
-
Jinsuk Kim authored
TabRedirectHandler can be null when swapped out for VR mode change, for which it should not be put into UserDataHost when restored. This CL adds the missing null check to prevent crash upon exiting VR mode. Bug: 882977 Change-Id: I67f740eceffb2ad2acde12501d142583a10d052b Reviewed-on: https://chromium-review.googlesource.com/1220407Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#590493}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5954a8c7. With Chromium commits locally applied on WPT: d3406a52 "Add more WPT tests for mixed-content check in workers/worklets (2/2)" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24555 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I9f1bcec6bcabe0724d0f15995ac1d69344436c52 Reviewed-on: https://chromium-review.googlesource.com/1219997 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590492}
-
Changwan Ryu authored
There is no logic change - this just move the code around for optimization. This CL specifically fixes verification errors around field access. Also, it avoids extra type conversion which was causing another verification error. See crbug.com/838702 for more information about run-time verification issue. Bug: 868250 Change-Id: I00c593e9526ddc3766d0c5b203ed38816c5c6da0 Reviewed-on: https://chromium-review.googlesource.com/1218522 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590491}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b7f5c6989122..6333b6741efe git log b7f5c6989122..6333b6741efe --date=short --no-merges --format='%ad %ae %s' 2018-09-11 eakuefner@chromium.org Revert "[TBMv2] Support Chromium commit positions in legacy_json_converter" 2018-09-11 eakuefner@chromium.org [TBMv2] Support Chromium commit positions in legacy_json_converter Created with: gclient setdep -r src/third_party/catapult@6333b6741efe The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:843643,chromium:843643 TBR=sullivan@chromium.org Change-Id: I0d1ec9f49266ef65d643842ee5de8c6e3a2261ea Reviewed-on: https://chromium-review.googlesource.com/1220232Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590490}
-
Joel Einbinder authored
Adds an option "emulate page focus" that stops blur listeners from firing on the page. Useful for debugging focus issues. Change-Id: I87086715d87514738a68b5b38f4df31693b97546 Reviewed-on: https://chromium-review.googlesource.com/1119257 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#590489}
-
Matthew Jones authored
This patch reomves some obsolete code that was used to transition theme colors on the tab border in the tab switcher. This feature has since been removed. Bug: 882508 Change-Id: Ie63fabb08631f0377721f7057cbe65a4cd3af9a2 Reviewed-on: https://chromium-review.googlesource.com/1217405Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#590488}
-
Varun Khaneja authored
Bug: 882979 Change-Id: I7c4b717a39da3ee11d62a9bd5d91e7a5b42d6b2e Reviewed-on: https://chromium-review.googlesource.com/1220469Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590487}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7a45d5722c7e..5c86fd4c5110 git log 7a45d5722c7e..5c86fd4c5110 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 rharrison@chromium.org Small optimizations for CBC_HighLevelEncoder::lookAheadTest Created with: gclient setdep -r src/third_party/pdfium@5c86fd4c5110 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:881678 TBR=dsinclair@chromium.org Change-Id: Ic8d21e5a9bf9c488a9e7f33f9da6b83c85c636c1 Reviewed-on: https://chromium-review.googlesource.com/1220234Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590486}
-
Ben Pastene authored
R=jbudorick@chromium.org Change-Id: Ic593c71edc288deb6aa9480b2bf9542722b38f0f Reviewed-on: https://chromium-review.googlesource.com/1217914Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#590485}
-
Artur Khachatryan authored
Disabling failing Java tests on Android platform. Change-Id: I0b07e9e2d961aedc8127470e4dc4e8ec16dee6f9 Reviewed-on: https://chromium-review.googlesource.com/1219933Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590484}
-
John Chen authored
Previously, IP address matching for whitelisted-ips options was done by string comparison, and was unreliable. In particular, it didn't handle IPv4-mapped IPv6 addresses. To make the matching more robust, we now do binary comparison using IPAddress object. Bug: chromedriver:2566 Change-Id: I81430ecef60b44dbc40a976637cdb42ed50acde1 Reviewed-on: https://chromium-review.googlesource.com/1220474 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#590483}
-
Patrick Monette authored
Check where the shell extensions are actually registered instead of only looking at the list of Approved shell extensions. Change-Id: I3257106060f4775fe83f8af322c007e022064630 Reviewed-on: https://chromium-review.googlesource.com/1197352Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#590482}
-
Matt Menke authored
These aren't full integration tests - they don't make sure that the correct configuration is sent to the network service on start, or that the configuration is updated as the prefs change. Instead, they just check the code that maps prefs to NetworkService configuration structs. Bug: 881168 Change-Id: I923d8536686ca3a10083c1b8ba0b76c5703e1f9d Reviewed-on: https://chromium-review.googlesource.com/1210365Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#590481}
-
Francois Doray authored
This will allow use of these methods in constexpr expressions. Change-Id: If93c03a93aaa0dd6d4442f40ea296ebcfa80a862 Reviewed-on: https://chromium-review.googlesource.com/1219770Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#590480}
-
Dan Sanders authored
Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I48b205e7b20cf512e953d5992be6ed507add688b Reviewed-on: https://chromium-review.googlesource.com/1217716Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#590479}
-
Charlie Harrison authored
Bug: 820612 Change-Id: Iaa184a71421b8885363794638a5e14aa5e5e0dee Reviewed-on: https://chromium-review.googlesource.com/1216943 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590478}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/753fd86e86ac..96e1c6b7ce91 $ git log 753fd86e8..96e1c6b7c --date=short --no-merges --format='%ad %ae %s' 2018-09-08 jzern fix vp9_svc_adjust_frame_rate signature 2018-09-07 jingning Fork auto-alt-ref control 2018-09-07 jingning Extend auto-alt-ref parameter range 2018-09-06 jingning Add NORMAL_BOOST macro 2018-09-05 huisu Initialize the best partition before partition RDO 2018-09-05 angiebird Add non-greedy-mv experimental flag 2018-08-29 marpan vp9-svc: Allow for setting framerate per spatial layer. 2018-08-31 jingning Adaptive ARF factor decision 2018-08-29 jingning Recursive rate allocation for multi-layer ARF coding 2018-08-28 jingning Enable adaptive rate allocation for multi-layer ARFs 2018-09-04 huisu Move partition search ML models to a seperate file 2018-09-04 marpan vp9-svc: Fix to first_spatial_to_encode for pattern constraint. 2018-08-28 jingning Increase encoder buffer for multi-layer ARFs 2018-08-28 jingning Structure the multi-layer ARF locations 2018-09-03 paulwilkins Fix short first kf bug. 2018-08-27 jingning Assign target bits for multi-layer ARF system 2018-09-03 marpan vp9-svc: Add bypass flag to constrain inter_layer. 2018-09-03 paulwilkins Revert "Revert "Prevent double application of min rate in two pass."" 2018-09-02 marpan vp9-svc: Fix condition for pattern constraints 2018-08-27 jingning Properly update the raw_src_frame for psnr calculation (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I4abe9809e979c2c929ea41532f5ceb49daa9e5cb Reviewed-on: https://chromium-review.googlesource.com/1219894Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#590477}
-
yiyix authored
Add metrics to measure the amount of time it takes to prepare CompositorFrame on the client side: GraphicsPipeline.(Browser|Renderer).SubmitCompositorFrameAfterBeginFrame. Bug:814909 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic81532c8bec28b43ec1fa20ff3634be0fbf5f84a Reviewed-on: https://chromium-review.googlesource.com/1154630 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#590476}
-
rbpotter authored
This CL addresses 3 bugs that were causing CrSettingsAllSitesTest to fail with Polymer 2: (1) async() call in basic_page.js did not pause for all of layout on the first call in Polymer 2 (likely due to layout not being finished by the end of attached()). This was also causing a runtime error on content, languages, and other subpages. (2) The test itself also called async(), which did not wait long enough for rendering to complete before checking various elements. (3) The computed subpageScrollTarget was set earlier in Polymer 2, as its computation function was called with some parameters undefined. This resulted in overriding the non-null, defined default scroll target for iron-list with an undefined scroll target, which caused toggleScrollListener(), called from the resize handler in iron-list, to fail. Bug: 875452 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2a09020a798fdf806a98c7c9d9d32547b3fa310f Reviewed-on: https://chromium-review.googlesource.com/1208448 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#590475}
-
John Chen authored
Remove obsolete code that was intended to handle OOPIF on m65 and below. Change-Id: I1e3a7fbe23a0c9b472fb6da3310cd80a63458ca9 Reviewed-on: https://chromium-review.googlesource.com/1211110Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590474}
-
Marcin Wiacek authored
When system permissions are disabled for Camera / Microphone, Chrome displays "Ask first" in Settings/Site Settings. Patch is changing it to "Blocked" + doing one micro-optimization as small bonus. BUG=882698 Change-Id: Ie061803b0de805c7fbc3c11c698afcceeda082fe Reviewed-on: https://chromium-review.googlesource.com/1218142 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#590473}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2c47b2a941163b30b3a37bd9ef2c08c9b9ccd2ed Reviewed-on: https://chromium-review.googlesource.com/1212382Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#590472}
-
Will Harris authored
../../ui/base/test/ui_controls_internal_win.cc(204,9): warning: implicit conversion loses integer precision: 'WPARAM' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] w_param, reinterpret_cast<MOUSEHOOKSTRUCT*>(l_param)); ^~~~~~~ ../../ui/base/test/ui_controls_internal_win.cc(405,25): warning: implicit conversion loses integer precision: 'std::vector<tagINPUT, std::allocator<tagINPUT> >::size_type' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] if (::SendInput(input.size(), input.data(), sizeof(INPUT)) != input.size()) ~~ ~~~~~~^~~~~~ ../../ui/base/test/ui_controls_internal_win.cc(520,25): warning: implicit conversion loses integer precision: 'std::vector<tagINPUT, std::allocator<tagINPUT> >::size_type' (aka 'unsigned long long') to 'UINT' (aka 'unsigned int') [-Wshorten-64-to-32] if (::SendInput(input.size(), input.data(), sizeof(INPUT)) != input.size()) ~~ ~~~~~~^~~~~~ BUG=879657 Change-Id: Iea866217701ef4b9f67b63a58a6ab6a35a88b1a8 Reviewed-on: https://chromium-review.googlesource.com/1217848 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#590471}
-
Doug Arnett authored
Creates HostFilter which wraps a host suffix BloomFilter and adds logic for checking a set of host suffixes for a url against the BloomFilter. Also, adds IsBlacklisted() api support to PreviewsHints and PreviewsOptimizationGuide. Coming next will be populating this blacklist from Cacao Configuration proto and tests at the guide level. Bug: 864640 Change-Id: Idd8facf0d4718f1e9bd41f4d24ef03691cfb9590 Reviewed-on: https://chromium-review.googlesource.com/1216716 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#590470}
-
Ted Choc authored
BUG=800033 Change-Id: Id64a04b6f46ec54ce4ec0a6a6a29de74e398b37a Reviewed-on: https://chromium-review.googlesource.com/1220190Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#590469}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb18639804e7..e6146bd7be6f git log fb18639804e7..e6146bd7be6f --date=short --no-merges --format='%ad %ae %s' 2018-09-11 jvanverth@google.com Fix float overflow in shadow tessellator 2018-09-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0d0fb43f34ee..2da04538b4ff (2 commits) 2018-09-11 fmalita@chromium.org Reland: add SkPath::shrinkToFit 2018-09-11 bsalomon@google.com Make GrAAConvexTessellator bail on paths that map to inf/nan in device space. Created with: gclient setdep -r src/third_party/skia@e6146bd7be6f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:882609 TBR=caryclark@chromium.org Change-Id: I0db5cee64e208a6b6bc158ce8f82ebc97b0166c5 Reviewed-on: https://chromium-review.googlesource.com/1220233Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590468}
-
David Black authored
By adding a parent container to |footer_|, we will reserve the same amount of layout space whether or not that view is visible. This is because the parent container uses a FillLayout which does not factor visibility in when measuring. Bug: b:113871610 Change-Id: I4810368f5de3af4c3b8152e080acf7c2249304fc Reviewed-on: https://chromium-review.googlesource.com/1219899Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#590467}
-
Fady Samuel authored
Delete some dead code in / around RenderWidgetHostImpl::SubmitCompositorFrame. Bug: none Change-Id: If4666e6213946340bd0bdadefe733160a945ae0c Reviewed-on: https://chromium-review.googlesource.com/1220481Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590466}
-