- 28 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d47875c4c50..85e0cba51e88 git log 6d47875c4c50..85e0cba51e88 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 crouleau@chromium.org [Telemetry] Raise exception when trace buffer is overrun. Created with: gclient setdep -r src/third_party/catapult@85e0cba51e88 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948412 TBR=crouleau@google.com Change-Id: I51da4e1da745425a3a5fd328132c6ba139716dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673416}
-
Tarun Bansal authored
Enable PredictivePrefetchingAllowedOnAllConnectionTypes by default since we decided to enable the experiment for 100% population now. Change-Id: I053429312301d5665ef599523b8b919ac0e6a0ed Bug: 914503 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679655Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#673415}
-
dpapad authored
<link rel="import" src="foo.html"> needs to be converted to import './foo.m.js'; Where the "./" prefix is added, otherwise the following error is thrown at runtime. Uncaught TypeError: Failed to resolve module specifier "foo.m.js". Relative references must start with either "/", "./", or "../". This was discovered while porting md_select_css.html to Polymer3, which happens to trigger this case. Bug: 965770 Change-Id: Id22bcb70a2d1bb4035b33b54dbde87bf0321982c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681343 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#673414}
-
Gabriel Charette authored
This is a prerequisite for MOCK_TIME on ThreadPool because base::internal::WorkerThread doesn't support TimeTicks::Now() being zero. And it's also a definite source of pain given the number of codesites found which had to work around this. Bug: 946657 Change-Id: I115b4af77e5095454b2d505915884215e82d7f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677107Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#673413}
-
Evan Stade authored
This re-lands commit a5646d5a. Difference to original: Override TearDownOnMainThread() instead of TearDown(). Original change's description: > Remove NOTIFICATION_FULLSCREEN_CHANGED > > Replace with an observer interface on FullscreenController. > > Bug: 268984 > Change-Id: I1af2056e870af56b2f436a3aa8c6a54ed0ff44fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666148 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671901} Bug: 268984 Change-Id: I735754efa634d8ef21b4bb57f366dbad22b3c682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676731 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673412}
-
Salvador Guerrero authored
leveldb_database.cc used to log all initialization errors, including a case we considered normal. When a database file is missing, and the client set create_if_missing = false then this means the client expected the file to be missing. Our DB code attempts to open the shared database. As no client has migrated to it then it's fine if it doesn't exist. However, as this code get executed when BrowserContext starts then it spams the logs on BrowserTests. This CL removes logging for this specific case, as it is an expected state which doesn't have to be logged. Change-Id: I51a986b43b13c441384a7cf67df6565a64881941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670361 Commit-Queue: Salvador Guerrero <salg@google.com> Auto-Submit: Salvador Guerrero <salg@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#673411}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a47ba4119f27..8f01c4e1b654 git log a47ba4119f27..8f01c4e1b654 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 eladalon@webrtc.org Define FecControllerOverride and plumb it down to VideoEncoder 2019-06-28 danilchap@webrtc.org Add trait to Build/Parse DependencyDescriptor rtp header extension 2019-06-28 kwiberg@webrtc.org Initialize signal processing function pointers statically Created with: gclient setdep -r src/third_party/webrtc@8f01c4e1b654 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3273b3dfceb7f9e01950a9245ce9788c2e5fd840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673410}
-
Jun Cai authored
This CL implements the permission prompt for Bluetooth Scanning API on Android: 1. Implements a permission prompt on Android. The message at the top of the prompt calls out that the user is being asked the permission for a site to receive nearby Bluetooth advertisement packets. The prompt lists device name for found nearby Bluetooth devices. 2. Implements the ShowBluetoothScanningPrompt method in TabWebContentsDelegateAndroid which launches a permission prompt displaying the nearby Bluetooth devices. I uploaded some screenshots of the permission prompt in the issue link. Bug: 960960 Change-Id: I15a3b4115644fe0d8674c7c00921b5560287e51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665909Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#673409}
-
Jun Mukai authored
This has been enabled on all devices for a while, now we can say it's always true. Removing the flag and the legacy code now makes sense. Bug: 979365 Test: compilation succeeds / trybot Change-Id: Icf8bbf06fbd385ad9ff50380d242e0b4b43960e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680986 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#673408}
-
Ilia Samsonov authored
ProcessGTestOutput might return TestResults in |results|, even if the method returns false. Instead of re-using the vector set by ProcessGTestOutput, return new vector from ProcessMissingTestResults. Bug: 978566 Change-Id: I036b79e0a578c87d4dc692b042302e4c2db4ede8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677689Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#673407}
-
Katie D authored
This component extension will use the automation API to provide accessibility tree information to the Automatic Clicks controller in Ash, initially enabling drawing of focus rings to highlight the scrollable region where scroll events will take place. The extension is only loaded if the autoclick features flag is enabled. See go/chromeos-dwell-scroll-design for more. Bug: 978163 Change-Id: Id3700f113a913738d4a15cd87dee18c194ef55d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673570Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#673406}
-
Miguel Casas authored
This CL adds UMA histograms of VideoFrameSubmitter decode-to-raster and decode-to-compositor delays (the latter strictly included in the former). This is needed for field data collection and CrOs tests (Tast uses Go and there are no Go bindings for about:tracing AFAIK). Bug: 953253 Change-Id: I384f5b8cd9d4bd28d9857d07957be5a52af3e85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680764Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#673405}
-
Johann authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7d9288f5f86e..30e7f9d856eb $ git log 7d9288f5f..30e7f9d85 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 angiebird Remove mv_dist/mv_cost from new mv search funcs 2019-06-25 angiebird Speed up diamond_search_sad_new 2019-06-25 angiebird Let full_pixel_exhaustive_new return int64_t 2019-06-20 zxdan script to compact frames to y4m video 2019-06-19 zxdan add output of frame info 2019-06-19 zxdan Add Ray Tracing 2019-06-14 zxdan Add Scene module to manage other objects 2019-06-20 angiebird Integerize exhaustive_mesh_search_new() 2019-06-20 angiebird Make vp9_nb_mvs_inconsistency return int64_t 2019-06-19 angiebird Make type of lambda int in TplDepFrame 2019-06-19 angiebird Integerize log2_approximation() Created with: roll-dep src/third_party/libvpx/source/libvpx BUG=webm:1624 Change-Id: Iaf1a692312f7dba13865c14299b4e0969a386b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680301Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#673404}
-
Victor Hugo Vianna Silva authored
Bug: 979546 Change-Id: Ia6ff275769c75029f434ba2f4712d2613af5d827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682034 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#673403}
-
danakj authored
This adds it as a 100% experimental target so that it does not block CLs and only adds it to the android-kitkat-arm-rel as a first step. Other bots will be removed from exclusions as it proves okay. R=sky@chromium.org Bug: 961849 Change-Id: I652b7ae3a76ec511ca6fc8881f7708c7d0802105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680513 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673402}
-
Fabrice de Gans-Riberi authored
This will soon be required for every user of the DNS service. Bug: 979080 Change-Id: Ifc10b74d2917f825bbd299b4f9e8d4ebc7dc8cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680896 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#673401}
-
Bettina authored
Previously, Chrome Safe Browsing code converted PasswordType from the password manager code to ReusedPasswordType which we define in the protos. However, the only difference is that SYNC_PASSWORD=>SIGN_IN_PASSWORD. SIGN_IN_PASSWORD is confusing. Thus, this CL is changing to use the original PasswordType from the PasswordManager as it will be a clearer source of truth. In addition, the SYNC_PASSWORD originally meant a password for an account that is considered "blessed" for sync. This is equivalent to the primary account, which is the a currently Chrome signed in profile that the user has that is closest to being set to syncing if the user chooses to set it up. This is only part 1 of the refactoring. The next part is to update SyncAccountType with the new field from the new proto. Bug: 914410 Change-Id: I35948bc745e568cb93e5f852cf4ff9a2b4bc1393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639717Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#673400}
-
Junbo Ke authored
global volume multiplier for extra audio streams. Bug: b/134381697 Test: On device Change-Id: Idbabbfef0381f00d330263d721c6da0fc4c752ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681384 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#673399}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/625f5b2fbd89..d4d43ac07382 git log 625f5b2fbd89..d4d43ac07382 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 syoussefi@chromium.org Add suppression for test failing on old MESA 2019-06-28 syoussefi@chromium.org Vulkan: Enable numerous deqp texture tests 2019-06-28 jmadill@chromium.org Revert "Cleanup angle_libs_suffix in BUILD.gn." 2019-06-28 geofflang@chromium.org GL: Clamp uniform array access on Android and AMD devices. 2019-06-28 fei.yang@arm.com Vulkan: pipeline cache not populated as blob cache is not set Created with: gclient setdep -r src/third_party/angle@d4d43ac07382 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:979349 TBR=syoussefi@google.com Change-Id: Iee3e81a53e2763e495679f3a55dc6793cee911c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673398}
-
Mohammad Refaat authored
Change InsertTab method on TabModel to be InsertWebState. (This is intermediate step as i'll be moving the logic to WebStateList and will call it directly). Bug: 914967 Change-Id: Ie131559abfd9c8a073992ee8ad67c046e6a4cc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680134 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#673397}
-
Tiansong Cui authored
When disconnect starts, device can be disconnected any time so we shouldn't treat it as still connected. Bug: internal b/136211218 Test: cast_bluetooth_unittests Change-Id: I84d2bf996d8cef956ae612f0fbfe1fc1d2fe56d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681306Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Auto-Submit: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#673396}
-
Francois Doray authored
The failure reported in https://crbug.com/857418 has nothing to do with what the test is verifying. It is very possible that the problem was caused and later fixed by unrelated changes. Bug: 857418 Change-Id: Ia0f213c5bb86743c1e97aa8d4d66fabe42dbee0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679060 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#673395}
-
Natalie Chouinard authored
Migrate the Password settings page from the deprecated Framework Preferences to the Preferences Support Library. This also fixes the issue with missing preference widget animations on the Password settings screen. Bug: 968592, 967858 Change-Id: Id9aa3a1fda30729f52e2456e730345acaa01c1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678848Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673394}
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: sky@chromium.org, miu@chromium.org, boliu@chromium.org, seantopping@chromium.org Change-Id: Ic005b1cc50020f130fe216efcc1c01187bcaa9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680425 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673393}
-
Siye Liu authored
There are differences in the behaviors in Textfield::InsertText and RenderWidgetHostViewAura::InsertText when the provided text is empty. TSF uses TextInputClient::InsertText to commit current composition and expects all implementation classes to have same behavior. The text will be committed only if the provided text is not empty in TextField::InsertText. However, in RenderWidgetHostViewAura::InsertText, composition will be committed with current composition text if provided text is empty. As a short term fix for Windows platform, only call |InsertText| if text is not empty. Use crbug.com/978678 to keep track of long term solution. Bug: 977820 Change-Id: I3eb1bbc9ed6f98f8356fda01cd9cc2ee91a79a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675465 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#673392}
-
chrome://flagsMaksim Moskvitin authored
Bug: 922900 Change-Id: I5c6f07b29e21f278d2051e5fc06cf0e36d611ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678373 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#673391}
-
Yun Liu authored
Add the same flag as instrumentation and junit test options to process coverage data later and avoid unknown flag on remote. Bug: 972171 Change-Id: Ib982062adf64b5f7d7d221c166c5b0d23fab519f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681273 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#673390}
-
John Emau authored
By disabling the following rules we can expect tests to run ~4 seconds faster. Tested with https://crrev.com/c/1635874. Disabled slow rules: - color-contrast - image-redundant-alt Disabled rules with bugs: - aria-required-children, see: https://github.com/dequelabs/axe-core/issues/1444 Disabled low value rules: - meta-refresh - blink - audio-caption - object-alt - video-caption - video-description - radiogroup - marquee - html-has-lang - html-lang-valid - meta-viewport-large - meta-viewport - valid-lang Any test may override this list to re-enable rules on specific UI. Bug: 963183 Change-Id: I9094360c73c45168df4ac99aea0d659103950eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638125 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#673389}
-
Sky Malice authored
Bug: 976829 Change-Id: If287af7835e5d17fc0e9f16bbc4f99a104e5f36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681401 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#673388}
-
Cliff Smolinsky authored
This change fixes multiple accessibilty issues with the certificate viewer dialog, primarily with regards to screenreader support: - The "Field Value" is never read in any way. This change makes it a tab stop so that it can be read that way. It also adds aria-live so that when the selected certificate field changes the updated field value is read as well. - The individual <tab>s in a <tabs> section are not individual tab stops which makes it more difficult to understand what happens with a screen reader. This also means that nothing is read when the selection changes. This change makes the individual tabs tab stops, ensures the tab is focused when it becomes selected, and sets the aria-selected property to ensure selection state is read properly. - The three different fields of information on the details tab (two trees and the field value) were not labeled appropriately so while the content was read it wasn't clear what the information represented. This change adds proper labeling. - When an item in a tree was read, its level in the tree was always off- by-one. This change fixes that by properly labeling the root of the tree as a tree instead of a group. - The gray color used for information text on the general tab didn't meet contrast requirements so this change make the text a little darker. - Additional changes to add appropriate role and aria-* properties to various elements for proper identification. Bug: 971843 Change-Id: I677a01fa785900c66939d3b5263c6e5914fc8482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651513Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#673387}
-
Dominik Röttsches authored
Since font scanning is now an asynchronous, BEST_EFFORT priority task, we should trigger it at startup so it may already be ready when a renderer requests it. Previously, it was a synchronous task, triggered by when a renderer requested the lookup table for the first time. Triggering it at startup matches the approach we take on Windows 7 and 8. Bug: 973394 Change-Id: I2e890058c538ed157217e98d1f4a0bdba639a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681760Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#673386}
-
Eugene But authored
On iOS 13 "Always Translate French" item is not visible due to a real bug in the options menu. This CL relaxes matching requirement for iOS 13 to make the test pass. The real fix will be landed separately and this workaround will be removed. Bug: 979079 Change-Id: Icfbd6a39f1ca7ff93fdc7dbad59414004232503b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679637Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#673385}
-
Sylvain Defresne authored
Since AccessTokenCallback is only run once, document this by changing the type to base::OnceCallback (since the type base::Callback is deprecated). Bug: 714018 Change-Id: Ic276e1fbd14400320eb1bbc670f5b39130c9987e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681584 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#673384}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I8b3065a4ad2d482f59dbea83c7828df19c31a264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660396 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#673383}
-
Andrey Kosyakov authored
Use Fetch domain instead. Change-Id: I4f85f0f909def198cffe9cc47f8dca9f3d173db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678387Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#673382}
-
Dave Tapuska authored
The lifecycle state is currently communicated back to the DocumentResource coordinator. The instantiation of that class is tied to the browser's resource coordinator instance. So the browser has no notion of frame being frozen at the content level. This change adds such communication. The source of freezing comes from two sources, the renderer and the browser. The browser may also request a page to be frozen however it may not take effect until a later time like the load event firing. BUG=957597 Change-Id: I64bd263643edd8afadecb5ab063008a238c2042c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676233Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#673381}
-
Bailey Berro authored
This change switches [add|edit|reconfigure]CupsPrinter to resolving a promise when successful and rejecting a promise on failure. Additionally, errors are shown inline rather than on the parent page. Bug: Change-Id: Ia9dc5cf609425d73a4d2f8c7bacfb9f7e635fd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674405Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#673380}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit b7a9a779 ("Notification scheduler: Add two new service APIs"): ../../chrome/browser/notifications/scheduler/internal/scheduler_utils.cc:75:18: error: no matching function for call to 'lower_bound' auto right = lower_bound(impressions.rbegin(), impressions.rend(), ^~~~~~~~~~~ ../../../../../../usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_algobase.h:984:5: note: candidate function template not viable: requires 3 arguments, but 4 were provided lower_bound(_ForwardIterator __first, _ForwardIterator __last, ^ ../../chrome/browser/notifications/scheduler/internal/scheduler_utils.cc:80:17: error: use of undeclared identifier 'upper_bound' auto left = upper_bound(impressions.rbegin(), impressions.rend(), ^ Bug: 957519 Change-Id: Id73ae91a738237ed9d3940f424e4f9d60332a862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681765 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673379}
-
Natalie Chouinard authored
The Preference activity's onOptionsItemSelected override currently forwards these method calls to the corresponding preference fragment first for Framework PreferenceFragments. This CL replicates this behavior for preference screens that have been migrated to the Support Library PreferenceFragmentCompat. Bug: 978431 Change-Id: Ib0afd9e6987f586a8caf58cfb18a46cef49717c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679379Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673378}
-
Natalie Chouinard authored
The Tracing category preferences were incorrectly styled with excess padding on some Android versions. This CL fixes that issue by picking up the PreferenceManager's styling for programatically created preferences. Bug: 979127 Change-Id: Iab3bc8f9958946aed85861d12e27d0c20dac0630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680976Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673377}
-