GitLab

This is the first of a series of three or four CLs to rename
the ControlService related names in the updater project.

This CL consists in a global mechanical replacement of
ControlService->UpdateServiceInternal,
control_service->update_service_internal, and fixing related whitespace.

The next CL is going to rename related names in the
Windows COM interfaces and implementations.

The third CL renames the source files and build files.

The last CL cleans up some potential macOS issues and wraps it up.

Bug: 1151106

Change-Id: Ib5b66d1fb50c100042310726ccac6121d685720c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551260Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829667}

Local sizediffs shared as oneoffs can include private symbols. Detect if
so and upload privately instead.

Change-Id: I62d17183716afe18b02c4a005c56c1190bc97115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552204
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829666}

For MICE we are moving all identity information into the top-level
Settings page. The Google Services Settings will now only contain
the relevant Services information.

Before: https://drive.google.com/file/d/1IaeI3UWGWIeFEWWR8s_FZIFQ_99ZDqha
After: https://drive.google.com/file/d/1jP4iYi5Fewd1o2hn5scJEwaYW-jgmdsK

Bug: 1151296
Change-Id: I6ce11e114873ae9ec411bfb6aeec342c4165083d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550555Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829665}

This fix allows the user to submit by clicking the enter key after
typing the old password.

Bug: 1110051
Change-Id: I1068dce770926163705c401495a8c145452c55ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550186Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Ossama Mahmoud <osamafathy@google.com>
Cr-Commit-Position: refs/heads/master@{#829664}

PartitionAlloc: PCScan: Perform scan only when quarantine is larger than the minimum scanning threshold.

This CL also another Reclaim mode to PartitionAllocMemoryReclaimer to force a scan when memory is critical.

Bug: 11297512
Change-Id: I054d8d032ed0b7e3abc9da57b33e6e471c830ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550062
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829663}

-[SceneController openURLInNewTabWithCommand:] is not used,
-[SceneController openURLInNewTab:] should be used instead.

Change-Id: I5a650a7e2fe44fd46e8733b2c6dc1dcf8b9511dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552389Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829662}

This CL refactors DedicatedWorkerServiceImpl to keep a pointer to the
DedicatedWorkerHost instead of the DedicatedWorkerInfo.

Bug: chromium:1145158
Change-Id: I081c77c04fa4741dd244ca1939cac6916a7f15c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517579
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829661}

This was an explicit ordering of all ModelTypes, used to determine the
order in which to kick off LoadModels() on all the controllers.
However, the next layer (DataTypeManagerImpl) anyway waits until all
types have finished loading before continuing with the next stage, so
the order really makes no difference.

Bug: 1102837
Change-Id: If1c60d9861655c3540218cb06a1f2285872720c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550671
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829660}

Previously, this test would filter console messages to only the success
string, leading to a 30 second delay for the timeout to be reached in
the event of a failure. Change the test to filter for any relevant
console messages to enable the test to fail more quickly.

Bug: 1111261
Change-Id: Ia2c7e4945de9344e440a0430c53dfb45624fbb74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550582
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829659}

Whether the renderer is backgrounded is not used anymore, no need to
track it.

Change-Id: I4547feceb362d5fba90fbabf0b3842862a2d6af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552404Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829658}

- Move kMaxHeapObjectSize to HeapAllocator as Oilpan has no internal
  restrictions on object sizing other than ultimately running OOM.
- Size quantization for Oilpan can just return whatever is required to
  match capacity needs. Internally, sizes may be padded and aligned
  accordingly.

Bug: 1056170
Change-Id: I5c833a2b6cb5354bd24b117406e68fe18e622f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551121Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829657}

compromised passwords and mutes.

Bug: 1137775
Change-Id: If9f2d4e7b130318a1f1ff6c12f4ef04fb0e005af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550045
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829656}

Currently the docs are not clear on whether priority is optional or
mandatory. Make it optional and clarify the same.

Skipping presubmit since this seems to be hitting crbug.com/956368.

BUG=1150821

No-Presubmit: True
Change-Id: I68ade1dc31b3d56bd49f195fe41d7db69a164fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550364
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829655}

It appears that on some devices the SignalStrength.getLevel method
requires the READ_PHONE_STATE permission that Chrome doesn't have.
This CL catches the exception to avoid crash in this case.

Bug: 1150536
Change-Id: I1fcbdbbe36d62cc48357e01f66654ca1c1fe5291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549967Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#829654}

Change-Id: Idf8027acd402ce8faf8095370688ea8f33f46fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551513Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829653}

This changes the signature of |WebController::SelectOption|
to take a regular expression (string) and a value source
instead of the previous strategy.

The regular expression is matched in JS (similar to how
|TextFilter| works in |ElementFinder|), which makes it a
"contains" by default. The matching is done case insensitive
as was done so far.

The |RequiredFieldsFallbackHandler| still operates on the
strategy and builds the regexp on the client. This is done
to reduce complexity in that action. Currently the script
does not know whether or not a field is a dropdown, this is
evaluated on the client. Setting a regular expression as a
value would be possible but potentially confusing.

Bug: b/171281545
Change-Id: I00ab0bcf518d16063ceeae60da4b854707cfeff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542983
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829652}

VulkanContextProvider is created before GrShaderCache and so cache
wasn't pass to Skia via GrContextOptions.

This CL defers init of GrContext in VulkanInProcessContextProvider to
SharedContextState::InitializeGrContext to mitigate this.

Use of cache itself is under feature flag for metrics comparison and
a kill switch purpose.

Bug: 1151031
Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829651}

Bug: 1104336
Change-Id: I7669ebd551e003c0199a3274af38ab0287fcc0fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547441Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#829650}

Prior this change, at the bottom of the dialog there was always a label
with text "* Field is required". Now this text is only shown when there
is at least one required field.

For now it only affects the AddressEditor usage opened from Autofill
Settings.

Bug: 1149568
Change-Id: I581c7ca6e89f1aaacb3e698dd3fb21981f2aa087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536438
Commit-Queue: Elizabeth Popova <lizapopova@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#829649}

Roll Chrome Linux PGO profile from chrome-linux-master-1605851942-6f480177b4524c7e895c150a8dd7d9195900edb6.profdata to chrome-linux-master-1605873573-9397db153d32d8ff4c4f46949924e1cd67fa6977.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I9fc090440237088088fcb09c2a5ea40eee028f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552467Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829648}

Bug: chromium:1011811
Change-Id: Ia1473a40ff26070f87ef8ff5bcbcba0286fb9976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550828
Auto-Submit: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829647}

Re-structure write barrier to allow delegating to the Oilpan library.

Bug: 1056170
Change-Id: I872fdb902a51d16d985f4e88ffd7e9368bf46623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551115
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829646}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aaaa5b96c66b..68553be73643

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC mmoskvitin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: mmoskvitin@google.com
Change-Id: If8b50089b7fbfe935c6664647e67417b899ccf2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552464Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829645}

Adds View::GetMirroredContentsBounds() which takes view insets into
account.

Bug: 1150725
Change-Id: I2d07b90f6388790fdb442f172b72452a5401ea03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551082Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829644}

This CL adds a mechanism to report file errors, as reported by
base::File::Error, though DOMExceptions. Due to security and privacy
considerations, not all errors are exposed to the user. For those
operations performed by the browser process (open, rename), the exact
error type is not exposed to the renderer.

Errors that are not reported by base::File::Error are left unchanged and
will be addressed in a followup CL.

The design document for this change is
https://docs.google.com/document/d/1rvs615AU2s8kVsmUlukbmtQNvUWFny0yzAS_gsnYZEs/

Bug: 1095537
Change-Id: If047ddccb6464dd6efb2b06a5da262d049f1e9a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436344
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829643}

This CL replaces all uses of net::EffectiveConnectionType with
blink::mojom::EffectiveConnectionType to reduce type conversion
between them in blink.

Bug: 919392, 1097943
Change-Id: I42db0329e9a0e436391e30779d69cf8d7f8040cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550321Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#829642}

Move the self keep alive member into the base class.
Remove Close overrides.
Remove Compositor() dead code.
Remove web_view_ member and use View().

This leaves one method left in the subclasses.

BUG=1097816

Change-Id: I7fd2c6fd87c8990070f329a6ade53cbe4f94cf1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548500
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829641}

Document the minimum Chrome version for the new enum values in the
chrome.certificateProvider API that were introduced in r828892 (the
new PSS-related entries in the Algorithm enum).

Without this change, the documentation at developer.chrome.com doesn't
contain information that these enums were added later than the other
ones. Apparently, the documentation only autogenerates these notices for
types and methods, but not for enum items.

Bug: 792204
Change-Id: Ia81a11691d9db5e1ba75cacd0d6dda53e679d0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550545
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829640}

This CL changes the current variable name accountId to accountEmail so
that we can have a consistent name for account email.

Bug: 1131344
Change-Id: I652755e7485673d6611622f5bd60aceda5d849ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550827Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829639}

Start.

Bug: 1150937
Change-Id: Ief46f56a25ec90a35a84aa15c0c2a04f4d67d203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551795Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829638}

CORS support code for non network service code path existed
in the network::cors::legacy namespace, and mistakenly is left
even after the network service full launch.

This patch removes the network::cors::legacy,
//services/network/public/cpp/cors/cors_legacy.{cc|h}.

Bug: 1053866
Change-Id: Id03f49751d63dbe8fc1cac48161aa9c579d3ebe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552322
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829637}

Reland "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.""

This reverts commit f01c0ad1.

Reason for revert:
1. Fixed `CaptureScreenshotBeyondViewport_OutOfView` by proper rounding.
2. Fixed `CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown` on some platform by relaxing color tolerance.

Original change's description:
> Revert "Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.""
>
> This reverts commit b8a64dcd.
>
> Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_OutOfView is failing consistently on "Android FYI SkiaRenderer Vulkan (Pixel 2)"
>
> https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20SkiaRenderer%20Vulkan%20%28Pixel%202%29/b8863213321775995088
>
> Original change's description:
> > Reland "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."
> >
> > This reverts commit 85d844e3.
> >
> > Reason for revert: reland initial commit with disabled flaky test.
> >
> > Original change's description:
> > > Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."
> > >
> > > This reverts commit 114bc6ab.
> > >
> > > Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel:
> > >
> > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849
> > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850
> > >
> > > Original change's description:
> > > > Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
> > > >
> > > > 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
> > > > 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered.
> > > > 3. Set `hide_scrollbars` to avoid artificial scrollbars.
> > > > 4. Set `record_whole_document` to force the whole page to be rendered.
> > > > 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight".
> > > >
> > > > Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37
> > > >
> > > > Screenshots:
> > > >
> > > > - Before: https://i.imgur.com/yt6WZRx.png
> > > > - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars.
> > > > - Patchset #3:
> > > >   * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view.
> > > >   * https://imgur.com/MXpgHOl
> > > >   * https://imgur.com/haxemcr - not aligned with the node.
> > > >   * https://imgur.com/RbdlYVT
> > > > - Patchset #18:
> > > >   * https://imgur.com/EWUmn0O
> > > >   * https://imgur.com/DUrQ1yF
> > > >   * https://imgur.com/cT5oBSi - perfectly aligned.
> > > >   * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended).
> > > >
> > > > Bug: 1003629
> > > > Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876
> > > > Commit-Queue: Maksim Sadym <sadym@chromium.org>
> > > > Auto-Submit: Maksim Sadym <sadym@chromium.org>
> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#827440}
> > >
> > > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org
> > >
> > > Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1003629
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543
> > > Reviewed-by: Scott Little <sclittle@chromium.org>
> > > Commit-Queue: Scott Little <sclittle@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#827505}
> >
> > TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sclittle@chromium.org,sigurds@chromium.org,sadym@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1003629
> > Change-Id: I2d394d77d0235762c61449ff8e90573de4c0c5d5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545524
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Commit-Queue: Maksim Sadym <sadym@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#829147}
>
> TBR=wangxianzhu@chromium.org,caseq@chromium.org,sadym@chromium.org
>
> Change-Id: I2422b2560d10910cd90290c5647eb068743ac682
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1003629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550242
> Reviewed-by: Mingjing Zhang <mjzhang@chromium.org>
> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#829230}

TBR=wangxianzhu@chromium.org,caseq@chromium.org,mjzhang@chromium.org,sadym@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1003629
Change-Id: Ib6e44df890e6707d811fccf2c6a8817983123c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551114
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829636}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2477097c7892..cc8c82e4bcb7

2020-11-20 tvanderlippe@chromium.org Typecheck javascript_metadata/JavaScriptMetadata.js with TypeScript
2020-11-20 jacktfranklin@chromium.org TypeScriptify ui/SoftContextMenu.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6f85861aa29f7d36acb199b351e9a46b3a5b9373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552441Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829635}

1. Remove diacritic symbol above cyrillic letters (е́ -> е, а́ -> а). It
is only used to show which syllable should be stressed when the word is
pronounced and never used in writing.
2. Allow using "е" instead of "ё", both spellings are used.
3. Add nominative grammatical case for email address keyword. Before in
Russian "адрес электронной почты" (email address) was matched, but
"электронная почта" (email) not.

Change-Id: Ibbb88d263eb8fde52bc0cd11e47e66fed780c227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550784Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Elizabeth Popova <lizapopova@google.com>
Cr-Commit-Position: refs/heads/master@{#829634}

MainFrame scroll focused editable element takes place in two phases.
1) To call scroll into view on the layout object.
2) Scheduling a page animation for zoom.

1) is common for local child roots just the calculation is a bit different.

BUG=1097816

Change-Id: I28dc389b21098e90376ea7bb3fade37313d244b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548420
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829633}

If the caspian files are missing, the upload script will now download
them from the current latest deployment before uploading the new
version. This allows a chrome dev to upload a new version without
worrying about caspian if their changes are unrelated.

Change-Id: Ib0f79f760845b239215e2c8f8be3c964060fbeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551775Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829632}

Test is failing due to a change unrelated to autofill.

We could edit the test expectation file, but try to batch cipd
changes, so disabled for now as we determine if we have some more
tests to fix at the same time.

Bug: 1151204
Change-Id: Ie9dd2053dbe89e063a828c78df0591d09e5be53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552261
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/master@{#829631}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f300a38617e..aaaa5b96c66b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC mmoskvitin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: mmoskvitin@google.com
Change-Id: If371b8ca8ac8bd4dd2e6b692831127e39f3f29f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551659Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#829630}

This is preferred by the style guide:
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#initialize-members-in-the-declaration-where-possible

Bug: None
Change-Id: I51d527f6db042e2b3e4efa3bbe8e06af336b5773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549861Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829629}

The self-destruction timer is not necessary because the RegionDataLoader
is guaranteed to be destructed once the query to libaddressinput
terminates.

Change-Id: Iac364183aa9d456b91ddc4d5f6f29b4c0ffe816d
Bug: 1148749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544945Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#829628}