GitLab

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC. (patchset #4 id:60001 of https://codereview.chromium.org/2737603007/ )

Reason for revert:
EG bookmarks tests started failing after this CL. Here is the first failure:
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25193

Original issue's description:
> [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.
>
> Automatically generated ARCMigrate commit
> Notable issues:None
> BUG=624363
> TEST=None
>
> Review-Url: https://codereview.chromium.org/2737603007
> Cr-Commit-Position: refs/heads/master@{#456064}
> Committed: https://chromium.googlesource.com/chromium/src/+/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a

TBR=lpromero@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624363

Review-Url: https://codereview.chromium.org/2738053008
Cr-Commit-Position: refs/heads/master@{#456084}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bd893d0c2c9d..1ebe368476a6

$ git log bd893d0c2..1ebe36847 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 simonhatch Eventually this will be a lot cooler, with graphs and buttons to interact with the job. But this at least displays the dict for now and will help w/ debugging jobs.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2739203005
Cr-Commit-Position: refs/heads/master@{#456083}

Just a simple cleanup I saw while working on
https://codereview.chromium.org/2727853002

Review-Url: https://codereview.chromium.org/2741143002
Cr-Commit-Position: refs/heads/master@{#456082}

While this exposes SW-related methods on DataSource, it also allows us to:

- remove SW-related methods from WebFrameClient
- remove cryptic entanglement between ServiceWorker and DataSource
  (DocumentLoader) that was done by ExtraData and UserData magic

BUG=538751

Review-Url: https://codereview.chromium.org/2733283004
Cr-Commit-Position: refs/heads/master@{#456081}

BUG=687657

Review-Url: https://codereview.chromium.org/2737213002
Cr-Commit-Position: refs/heads/master@{#456080}

Replace it with a function static, as it has no destructor to run.

R=dcheng@chromium.org
BUG=698982

Review-Url: https://codereview.chromium.org/2736393004
Cr-Commit-Position: refs/heads/master@{#456079}

ViewsDelegate should have the layout related functions coalesced into a handful of functions which take an enum element for each metric.

BUG=652024,687349

Review-Url: https://codereview.chromium.org/2696263002
Cr-Commit-Position: refs/heads/master@{#456078}

This debug url is used to crash the browser, but it is hard to find,
especially so since it is not listed among the urls that can be used
for debugging.

R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2738233003
Cr-Commit-Position: refs/heads/master@{#456077}

BUG=700134
TBR=thomasanderson@chromium.org

Review-Url: https://codereview.chromium.org/2740333002
Cr-Commit-Position: refs/heads/master@{#456076}

This class will be used by the command architecture in the clean skeleton app.
View controllers will receive a pointer to a CommandDispatcher and can use it to
send command methods to the appropriate coordinators.

BUG=698748
TEST=None

Review-Url: https://codereview.chromium.org/2734863002
Cr-Commit-Position: refs/heads/master@{#456075}

BUG=698235

Review-Url: https://codereview.chromium.org/2739473006
Cr-Commit-Position: refs/heads/master@{#456074}

BUG=699979

Review-Url: https://codereview.chromium.org/2740783004
Cr-Commit-Position: refs/heads/master@{#456073}

BUG=none
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2734333003
Cr-Commit-Position: refs/heads/master@{#456072}

https://skia.googlesource.com/skia.git/+log/5af600e42c56..b726d58efc91

$ git log 5af600e42..b726d58ef --date=short --no-merges --format='%ad %ae %s'
2017-03-09 robertphillips Partially defer SkImage_Gpu
2017-03-10 halcanary FuzzCanvas: fuzz_enum_range template
2017-03-09 reed increase Builder's prealloc size after colorspace change
2017-03-10 reed clipstacks can be on the stack or embedded, therefore should not be ref-counted
2017-03-09 reed Clients can provide preallocated storage to clipstack

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I800eba20476a4ae487985b76b23b42e0138ab3a0
Reviewed-on: https://chromium-review.googlesource.com/452669Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456071}

An extra invisible quad added on top of the content quad, which is only enabled
while in menu mode and when clicked exits to normal mode

BUG=692319
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2740013003
Cr-Commit-Position: refs/heads/master@{#456070}

BUG=700382
TBR=benjhayden@chromium.org

Review-Url: https://codereview.chromium.org/2746433003
Cr-Commit-Position: refs/heads/master@{#456069}

Mark external/wpt/fullscreen/api/document-exit-fullscreen-nested-in-iframe-manual.html as timeout flaky on Win7

BUG=700387
TBR=foolip@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2744783003
Cr-Commit-Position: refs/heads/master@{#456068}

In CL https://codereview.chromium.org/2724913002/, we will move
chromeos::EventRewriter to //ui/chromeos/events. So it can not use
ash. This CL make StickyKeysController implement ui::EventRewriter,
and let chromeos::EventRewriter use the ui::EventRewriter interface
instead StickyKeysController.

BUG=693180

Review-Url: https://codereview.chromium.org/2731283004
Cr-Commit-Position: refs/heads/master@{#456067}

BUG=699573
TBR=xhwang@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2739313003
Cr-Commit-Position: refs/heads/master@{#456066}

This patch also adds a getter to the content delegate on the browser
process. This is in preparation for a chrome client to pull the
verified ruleset dealer handle off the delegate.

BUG=637415

Review-Url: https://codereview.chromium.org/2731283009
Cr-Commit-Position: refs/heads/master@{#456065}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737603007
Cr-Commit-Position: refs/heads/master@{#456064}

BUG=700374
TBR=dgozman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2746583002
Cr-Commit-Position: refs/heads/master@{#456063}

These methods are all being declared and defined in the same place, so the
inline keyword is redundant.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2743523004
Cr-Commit-Position: refs/heads/master@{#456062}

BUG=697092

Review-Url: https://codereview.chromium.org/2741633003
Cr-Commit-Position: refs/heads/master@{#456061}

https://skia.googlesource.com/skia.git/+log/0e5a9906e350..5af600e42c56

$ git log 0e5a9906e..5af600e42 --date=short --no-merges --format='%ad %ae %s'
2017-03-09 halcanary FuzzCanvas: SkVertices

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I5086dfb7062e8ded823a11e29cb74374070c0756
Reviewed-on: https://chromium-review.googlesource.com/452549Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456060}

BUG=699139

Review-Url: https://codereview.chromium.org/2739643003
Cr-Commit-Position: refs/heads/master@{#456059}

If a non-client frame is set to a system modal, its embedded sub-window
should be able to receive events.

For example, creating a JS alert() creates a non-client frame and sets it
to MODAL_TYPE_SYSTEM. Previously users couldn't click on the OK inside
the client window since all events were routed to the non-client frame.

BUG=699213

Review-Url: https://codereview.chromium.org/2737003002
Cr-Commit-Position: refs/heads/master@{#456058}

Passing null to AccountManagerHelper.updateCredentials would cause
NullPointerException, which led to creation of unnecessary callbacks,
for example in SyncCustomizationFragment. This CL fixes it.

BUG=NONE

Review-Url: https://codereview.chromium.org/2740873004
Cr-Commit-Position: refs/heads/master@{#456057}

BUG=

Review-Url: https://codereview.chromium.org/2742973002
Cr-Commit-Position: refs/heads/master@{#456056}

This CL adds 6 custom accessibility actions to Reading List:
- Delete entry
- Mark Read/Unread
- Open in New Tab
- Open in New Incognito Tab
- Open Offline in New Tab
- Copy Link

BUG=676290
TEST=Enable custom action with VoiceOver.
Test that the Reading List entries have the custom actions described in the CL
description.
Test that the current edit behavior (using the toolbar) is undisturbed.

Review-Url: https://codereview.chromium.org/2737663005
Cr-Commit-Position: refs/heads/master@{#456055}

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item,  CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737793003
Cr-Commit-Position: refs/heads/master@{#456054}

This CL adds 6 custom accessibility actions to Reading List:
- Delete entry
- Mark Read/Unread
- Open in New Tab
- Open in New Incognito Tab
- Open Offline in New Tab
- Copy Link

For now the actions are no-op.

BUG=676290

Review-Url: https://codereview.chromium.org/2743713002
Cr-Commit-Position: refs/heads/master@{#456053}

This allows Custom Tabs and Web Apps to use video persistence.

BUG=

Review-Url: https://codereview.chromium.org/2742983002
Cr-Commit-Position: refs/heads/master@{#456052}

https://skia.googlesource.com/skia.git/+log/6e1e27b7fccd..0e5a9906e350

$ git log 6e1e27b7f..0e5a9906e --date=short --no-merges --format='%ad %ae %s'
2017-03-09 iannucci [recipes.cfg] manually roll recipes to get skia recipe roller unstuck.

Created with:
  roll-dep src/third_party/skia
BUG=699379


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I520d94e4ec7d08adacf7934ca7cb25af20c15c85
Reviewed-on: https://chromium-review.googlesource.com/452668Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456051}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2ae07fc28bb3..bd893d0c2c9d

$ git log 2ae07fc28..bd893d0c2 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 nednguyen Remove legacy v8_execution metric

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2739233004
Cr-Commit-Position: refs/heads/master@{#456050}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fbffc377..5362e552

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2739383002
Cr-Commit-Position: refs/heads/master@{#456049}

Records (https://heycam.github.io/webidl/#idl-record) are ordered
associative arrays mapping instances of K to instances of V, where K must be
a ByteString, a DOMString or an USVString.

In C++, we represent records as Vector<std::pair<k,v>> (or HeapVector),
which are converted from V8 objects via

    NativeValueTraits<IDLRecord<K, V>>::nativeValue()

To convert the C++ Vectors back to V8 objects, we piggyback on already
existing ToV8() overloads for Vector<std::pair<>> and HeapVector.

The majority of the required work to support this new IDL type has already
landed and concerned making it possible to convert JS values to arbitrary
C++ types without knowing much about them (there is a single JS->C++
conversion function that needs to work for pretty much any JS data type).

This CL mainly makes the Python bindings code aware of this new type and
allows it to generate the appropriate JS->C++ and C++->V8 calls, and adds
the IDLRecord NativeValueTraits template specialization mentioned above. All
the rest is new tests and updates to existing expectations.

It is also important to note that the JS->C++ conversion code relies on a
NativeValueTraits specialization existing for the record value types, and
they are always used regardless of whether they are the fastest way to
convert data or not -- for example, it always creates and uses an
ExceptionState even if the actual conversion functions do not use it (as is
the case for toDOMWindow() or ScriptValue()).

Finally, while here rename IDLSequence::MaybeWrappedCppType to IDLSequence::MaybeMemberCppType to avoid confusion (and do the same for IDLRecord), as "wrapper" in a bindings context tends to refer to the V8 wrapper for DOM objects, which is not the case here.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2732093003
Cr-Commit-Position: refs/heads/master@{#456048}

We keep track of last seen text node for more efficient whitespace
re-attachment. When style recalc and layout tree building was split,
the text node is still tracked during recalc, stored in a hash map, and
retreived when needed during layout tree building.

However, the text nodes are also traversed during layout tree building
so that we can track the nodes during that phase instead.
StyleReattachData is removed and this CL reverts back to using the
m_nonAttachedStyle map for ComputedStyle.

The comment about reversed traversal of children for avoiding n^2
performance is moved to rebuildChildrenLayoutTrees() since that's where
the issue is. We should be able to do the child recalc first-to-last
now if we want to.

R=nainar@chromium.org,esprehn@chromium.org
BUG=595137

Review-Url: https://codereview.chromium.org/2740823005
Cr-Commit-Position: refs/heads/master@{#456047}

Its one remaining member, GetOmniboxView, can be replaced easily by
telling the SearchTabHelper when its tab gets attached to a new window
(i.e. Browser::TabInsertedAt), at which point it can grab the
OmniboxView* itself. This also correctly handles the case where a tab
is dragged between windows.

BUG=627747

Review-Url: https://codereview.chromium.org/2739943005
Cr-Commit-Position: refs/heads/master@{#456046}

std::vector has no such limitations, so let's drop them either.
Vector unit test is updated accordingly.

BUG=698998

Review-Url: https://codereview.chromium.org/2739813003
Cr-Commit-Position: refs/heads/master@{#456045}