- 19 Jun, 2018 40 commits
- 
- 
Kinuko Yasuda authoredResourceLoadScheduler (as a code infra) is already in use for the renderer-side resource scheduler, and is also a basis for stopping loading feature that is gated by other feature flags. This change isolates the ResourceLoadScheduler flag (as a flag) to make it affect only for background throttling, so that separate features built on top of ResourceLoadScheduler can be enabled independently. R=ksakamoto@chromium.org, toyoshim@chromium.org Bug: 837771 Change-Id: I346faf192ff93f2441fe5ed6a82212e76bd34b78 Reviewed-on: https://chromium-review.googlesource.com/1105202Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568390} 
- 
Olga Sharonova authoredAudio process experiment is observing performance regressions caused by on-the-flight audio process launch. Introducing a feature flag to pre-launch it on the browser startup. This will be rolled out as another AudioService experiment group, to evaluate memory and performance impact. TEST=manual Bug: 851611,853781 Change-Id: I30c1798dae07c5ce8a71243ab482ceb89d008e43 Reviewed-on: https://chromium-review.googlesource.com/1104681 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568389} 
- 
Tsuyoshi Horo authoredThis CL copies the throttling_profile_id of the original signed exchange request to the certificate request, so that we can throttles the certificate requests using DevTools. The throttling_profile_id is copied in this flow. Navigation case: NavigationURLLoaderImpl::URLLoaderRequestController => SignedExchangeRequestHandler => SignedExchangeLoader => SignedExchangeCertFetcherFactory::Create() => SignedExchangeCertFetcherFactoryImpl => SignedExchangeCertFetcher::CreateAndStart() => SignedExchangeCertFetcher => network::ResourceRequest Prefetch case: PrefetchURLLoader::PrefetchURLLoader() => SignedExchangePrefetchHandler => SignedExchangeLoader => ... same as navigation case... Bug: 849966 Change-Id: I443af86ca6a465a68e9f4c804d4cd9a9bac12227 Reviewed-on: https://chromium-review.googlesource.com/1088343Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568388} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd5dd45d..72566aa8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0e6d34f28a4c3cb7b025fabb5a72769659b20557 Reviewed-on: https://chromium-review.googlesource.com/1105629Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568387} 
- 
Christian Dullweber authoredTest that the CookieTreeModel behaves the same as the site data counter. Bug: 843995 Change-Id: Ib226c829dec5a242fca22222961b99c398703d1d Reviewed-on: https://chromium-review.googlesource.com/1100827 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568386} 
- 
Gauthier Ambard authoredThis CL avoid presenting a popup menu is there is already one shown. This can be done by pressing simultaneously on two buttons. Bug: 850057 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e501235c3527217e9f354277e09bc353430b95b Reviewed-on: https://chromium-review.googlesource.com/1104694Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568385} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/00c71836144b..024eeff4215d git log 00c71836144b..024eeff4215d --date=short --no-merges --format='%ad %ae %s' 2018-06-19 buildbot@webrtc.org Roll chromium_revision 9df92afb..9d565db4 (566630:568343) 2018-06-18 braveyao@webrtc.org [desktopCapture Mac]reorder execution order in start/release processing 2018-06-18 deadbeef@webrtc.org Removing unused cricket::Port constructor. 2018-06-18 titovartem@webrtc.org Extract rtc_base/base64.h and rtc_base/base64.cc into separate target. 2018-06-18 nisse@webrtc.org Delete FakeWebRtcVcmFactory::OnDestroyed method. 2018-06-18 saza@webrtc.org Stop using the beamformer inside APM 2018-06-18 danilchap@webrtc.org Replace rtc::Optional with absl::optional in test and rtc_tools 2018-06-18 danilchap@webrtc.org Pass buffer with size when writing rtp header extension 2018-06-18 danilchap@webrtc.org Replace rtc::Optional with absl::optional 2018-06-18 jonasolsson@webrtc.org Disable new RTC_CHECK unittest Created with: gclient setdep -r src/third_party/webrtc@024eeff4215d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:851883,chromium:None,chromium:826911 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I40c83252469c6851a87290ae594082cb5a53c2cf Reviewed-on: https://chromium-review.googlesource.com/1105221 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568384} 
- 
Chris Nardi authoredPer the CSS Fonts 4 spec [1], only keyword values for font-stretch are valid in the font shorthand. Our current serialization code ignores this, and outputs percentage values as well in the shorthand, meaning that the generated rule cannot be reparsed. We now check if the percentage can be converted to a keyword, and if so, output it as that keyword. Otherwise, we do not output a serialization for the font shorthand, as per the CSSOM spec [2]. [1]: https://drafts.csswg.org/css-fonts-4/#font-prop [2]: https://drafts.csswg.org/cssom/#serializing-css-values Bug: 850092 Change-Id: I7e3eec64723966b15abfa819213b95cba6cbc3d5 Reviewed-on: https://chromium-review.googlesource.com/1103856 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#568383} 
- 
Jérôme Lebel authoredMoving code to implement collapsable model from TableViewModel to ListModel. The benefit is to have collapsable collection view too. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iff0d0bd9c15358ba21b82fdda9e373e8b1079656 Reviewed-on: https://chromium-review.googlesource.com/1101518 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#568382} 
- 
Gauthier Ambard authoredThis CL uses frames and autoresizing masks for positioning the popup menu shadow instead of auto layout as auto layout is introducing a bug on iPhone X where the shadow is 1px off. Bug: 850519 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia01d6abe924b5229b69676fe37ef251e11b60d31 Reviewed-on: https://chromium-review.googlesource.com/1104686Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568381} 
- 
Daniel Vogelheim authoredUpdate the experiment to our current launch candidate. Bug: 761977 Change-Id: I3fda7188b9fa963e95dfeaa5512dcdf4f594a2f5 Reviewed-on: https://chromium-review.googlesource.com/1104350Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#568380} 
- 
Marc Treib authoredGetUploadToGoogleState supposedly tells you whether a given ModelType is actively being uploaded to Google. However, before this CL, it only checked that the ModelType is "preferred" (i.e. not disabled by the user) and that the SyncService itself is in an active state. That missed some cases, e.g. when a ModelType is disabled via browser policy. This CL fixes this by also checking that the ModelType in question is in an active state. Bug: 852385 Change-Id: Ifb3f4e912844ece21c691199091b3cf65ad02ad1 Reviewed-on: https://chromium-review.googlesource.com/1099239 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568379} 
- 
Noel Gordon authoredThe QuickView tests are slower than most, and the bug addresses making them faster. setupAndWaitUntilReady loads, and pre-populates Downloads and Drive volumes with many file entries. Can we do better? A modest test speed improvement is to make setupAndWaitUntilReady only populate the volumes needed in the tests (Downloads, Drive, etc), with only those files needed to perform each test. Bug: 851888 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0cb4d08fa38d9df76999595f41dfb8a0df378a9f Reviewed-on: https://chromium-review.googlesource.com/1104619Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568378} 
- 
Marc Treib authoredTBR=cduvall@chromium.org Bug: 854032 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0af88589cf1bce8715660d4b7e71c95a697085f8 Reviewed-on: https://chromium-review.googlesource.com/1105766 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568377} 
- 
Arthur Sonzogni authoredUpdate the blink layout test: http/tests/inspector-protocol/frameScheduledNavigation.js This CL is similar to: * https://chromium-review.googlesource.com/c/chromium/src/+/1071630 * https://chromium-review.googlesource.com/c/chromium/src/+/1071791 Depending on timing and the size of the main resource, new navigations initiated in <script> may starts before the document is fully loaded. In this case, frameStartedLoading is not fired because the load didn't stop in between. Bug: 831155 Change-Id: I872b7ff9b332893c0b57f921f992e348276e9d42 Reviewed-on: https://chromium-review.googlesource.com/1102681Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#568376} 
- 
Mikel Astiz authoredWe currently only stop sync (without disabling) in tests only, but we expect this to be more common in the future (DICe, payments, Butter). Instead of letting bridges do ugly workarounds, let propagate the transition to the processor, and allow bridges to (if interested) do something about it. Bug: 681921 Change-Id: I9689346e71d7eeb0c7b13eb601d88722e51f5ae4 Reviewed-on: https://chromium-review.googlesource.com/1098915 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568375} 
- 
Boris Sazonov authoredThis CL adds StateListDrawableBuilder, a helper class that simplifies StateListDrawable and AnimatedListDrawable creation. Bug: 814728 Change-Id: If2f07e1dab0cd7f5a6d46c81e37f4153b6259caa Reviewed-on: https://chromium-review.googlesource.com/1101325 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568374} 
- 
Ned Nguyen authoredChange-Id: Ia2524a47c97a55f17686e8a8153d3548b1eee161 Reviewed-on: https://chromium-review.googlesource.com/1105280 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568373} 
- 
Gauthier Ambard authoredThe spotlighted view wasn't created for the tools menu button. This bug was introduced in the CL moving the creation of the spotlight view from a lazy accessor to a protected method. Bug: 850513 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bdf63ab0ed7095203a0dad2ce34642912814710 Reviewed-on: https://chromium-review.googlesource.com/1104690Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568372} 
- 
tzik authoredMockOneShotTimer and MockRepeatingTimer are subclasses of OneShotTimer and RepeatingTimer respectively, that are intended to replace most of MockTimer. As MockTimer is not a OneShotTimer nor RepeatingTimer, when we want to use MockTimer for other timers, we had to use the generic Timer to hold a timer instance, that loses the timer traits from its type. Change-Id: Iea4a469708be2b89d4feb228460d78ab2a2f96d1 Reviewed-on: https://chromium-review.googlesource.com/1095195 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#568371} 
- 
Hajime Hoshi authoredThis reverts commit 60d31377. Reason for revert: We realized that MediaElementEventQueue : target is not 1:1. Instead of MediaElementEventQueue with a target, each event should have its target. Original change's description: > Remove some Event::SetTarget for MediaElementEventQueue > > Before merging MediaElementEventQueue into EventQueueImpl, we need to > eliminate code to set the target for an event. This is part of this work. > > Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# > > Bug: 846618 > Change-Id: Ic3b19ff2af19d931356ff72800797b36506f5ff0 > Reviewed-on: https://chromium-review.googlesource.com/1102233 > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567587} TBR=hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846618 Change-Id: I28cf7c58e123b66e2472f64b233684cbf1006dd4 Reviewed-on: https://chromium-review.googlesource.com/1105540Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568370} 
- 
chrome://flagsDarren Shen authoredThis is the expected behaviour (there was a typo in flags page template) Change-Id: I94a318b03df8bd133d49e2d8d4b345770cd6e864 Reviewed-on: https://chromium-review.googlesource.com/1105654Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#568369} 
- 
Anders Hartvoll Ruud authoredWhen a node is inserted into a container, it is notified via ::InsertedInto. However, a node may request a second notification via DidNotifySubtreeInsertionsToDocument, which occurs after all the children have been notified as well. *StyleElement is currently using this second notification. This causes a problem, because *ScriptElement is using the same mechanism, which in turn means that scripts can execute before the state of *StyleElements are properly updated. This patch avoids ::DidNotifySubtreeInsertionsToDocument, and instead processes the stylesheet in ::InsertedInto. The original reason for using ::DidNotifySubtreeInsertionsToDocument in the first place appears to be invalid now, as the test case is still passing. R=futhark@chromium.org, hayato@chromium.org Bug: 853709, 847570 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic0b5fa611044c78c5745cf26870a747f88920a14 Reviewed-on: https://chromium-review.googlesource.com/1104347 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568368} 
- 
Kush Sinha authoredFix memory leak in tests by removing the dangling pointers to |GaiaTokenRevocationHelper| and instead make |AccountManager| own those pending requests (via a |std::vector<std::unique_ptr<GaiaTokenRevocationRequest>>|). In tests, when |AccountManager| is deleted, these pending requests will be deleted too. Original change's description: > Add server token revocation in AccountManager > > Bug: 820046 > Test: chromeos_unittests --gtest_filter="*AccountManager*" > Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" > Reviewed-on: https://chromium-review.googlesource.com/1087455 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566961} Bug: 820046 Test: chromeos_unittests --gtest_filter="*AccountManager*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I8e186de574ab78a2e4c03d43a9147d1371473dd3 Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_asan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1101202 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#568367} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 141dc0d3. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19923 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams mcasas@chromium.org: external/wpt/mediacapture-record TBR=robertma No-Export: true Change-Id: I94e66f68998aad1953e5573137a08ca71ee727ab Reviewed-on: https://chromium-review.googlesource.com/1105615 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568366} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/5045e501d2ae..fb3beb0591ae git log 5045e501d2ae..fb3beb0591ae --date=short --no-merges --format='%ad %ae %s' 2018-06-19 fmalita@chromium.org [skjson] More short string micro-optimizations 2018-06-19 reed@google.com add new source list in prep for separating imagefilters from other effects 2018-06-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 f6fd48fd329f..2dabb4a367c3 (7 commits) 2018-06-19 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 700a1a67d569..1fa206780108 (1 commits) 2018-06-19 bungeman@google.com Stop using SkTSwap. 2018-06-19 herb@google.com Remove unused drawText code Created with: gclient setdep -r src/third_party/skia@fb3beb0591ae The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Iba28ddf37521e453230aa5a4ef0c72cc29e0aaed Reviewed-on: https://chromium-review.googlesource.com/1105220Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568365} 
- 
Mitsuru Oshima authored* use TYPE_POPUP for xdg_popup. The differences from TYPE_WINDOW are: - no frame - ash will not control its bounds * make popups transient children: this fixes following scenarios - z order is correctly updated when parent's z order changes - they're grouped in overview. * implement grab - capture even when the grab is requested on the surface - transfer capture to child if the child popup requested grab. - close the surface when capture(grab) is lost. - but transfer the grab to the parent if the parent had grab. BUG=788782 TEST=covered by unit tests. manually tested with gtk3-demo. Change-Id: I73f5bc7e555f2c28f78dc25a55f77f0a70fd9b78 Reviewed-on: https://chromium-review.googlesource.com/1102354 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568364} 
- 
Giovanni Ortuño Urquidi authoredTBR=jkarlin@chromium.org NOTRY=true Bug: 853283 Change-Id: I9fc6fd81c7461db738ee2e7eeece6eae69fc7109 Reviewed-on: https://chromium-review.googlesource.com/1105679Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#568363} 
- 
Giovanni Ortuño Urquidi authoredTBR=ortuno@chromium.org NOTRY=true Bug: 854071 Change-Id: Ie3c0ef10d18858eb5d12bb332998a4a81fbf5727 Reviewed-on: https://chromium-review.googlesource.com/1105656Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#568362} 
- 
Sergey Ulanov authoredThis is a reland of 502b5a8a TBR=sky@chromium.org Original change's description: > [Fuchsia, ozone] Implement ScenicWindow > > ScenicWindow now creates View and listens to input events (mouse and keyboard). > > Bug: 829980 > Change-Id: If5d05bf1107fec553aecf2537fd197d177d2fbb1 > Reviewed-on: https://chromium-review.googlesource.com/1081609 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568293} Bug: 829980 Change-Id: I8e3d6f83d4f38d40da065922f85866a1419712d8 Reviewed-on: https://chromium-review.googlesource.com/1105098Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568361} 
- 
Mitsuru Oshima authoredHeaderView is a sibling not child of the CustomFrameViewAsh, so we need to set the visibility on overlay view as well. BUG=b/110240289 TEST=manual, using following pip test app. https://x20web.corp.google.com/users/ed/edcourtney/piptest.apk Change-Id: Ide5fde4b9ead4fe89b349668d6cbce9ce7f49387 Reviewed-on: https://chromium-review.googlesource.com/1105624 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#568360} 
- 
Hwanseung Lee authoredreplace std::find() with base::containsValue() at components/sync* Bug: 561800 Change-Id: I450fe0c1d0e59244647bcdb23e2b6e2b29571dbc Reviewed-on: https://chromium-review.googlesource.com/1102439Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#568359} 
- 
Yuta Kitamura authoredThe removed code does not do anything useful -- it just churns the reference counts and that's it. Change-Id: I80ec8a5d559ae966038cf56d2e8606a0bb0f0201 Reviewed-on: https://chromium-review.googlesource.com/1104081Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#568358} 
- 
Makoto Shimazu authoredPreviously GlobalRequestID could be created at both of NavigationURLLoader and ResourceDispatcherHost when ServiceWorkerServicification is on, and these IDs could be overlapped. This CL is to generate the id always by ResourceDispatcherHost. Bug: 846197 Change-Id: Id6b70b60e920995b98c62e7e8e01d0d99fa7e5b0 Reviewed-on: https://chromium-review.googlesource.com/1104057Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568357} 
- 
tzik authoredThis simplifies base::MockTimer implementation using overridden task runner. Also, this moves base::MockTimer to //base/test:test_support. Tbr: khorimoto@chromium.org, chirantan@chromium.org, sky@chromium.org Bug: 850247 Change-Id: Id233bfdff24fc258d45c5fb3e6ebe292fc973775 Reviewed-on: https://chromium-review.googlesource.com/1094852 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#568356} 
- 
François Beaufort authoredThis make sure starting a new Picture-in-Picture session from the same video doesn't crash in Chrome OS. Bug: 852289 Change-Id: I7f4f5f3bed9999c08ee6576e9fe96e559e92009f Reviewed-on: https://chromium-review.googlesource.com/1102469 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#568355} 
- 
Joel Hockey authoredBug: 813477 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ief0de1355199f9cc69e296f117d93adf4e771206 Reviewed-on: https://chromium-review.googlesource.com/1104620Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#568354} 
- 
rajendrant authoredBackground: Currently page load metrics tracks data usage when requests complete. This misses canceled requests when the tab closes. The current codepath will also deprecated due to the upcoming network servicification work. This CL reports the continuous data use to page load metrics in renderer. Response starts and completions are reported as well so that the observer can keep track of data per resource. Subsequent CLs will send this to browser process via the existing PageLoadMetrics mojo. Bug: 836029 Change-Id: I023ea08b2b8f1974ea40586afeee3a27b9900782 Reviewed-on: https://chromium-review.googlesource.com/1042795 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568353} 
- 
Kyle Horimoto authoredThis class creates one ConnectionAttempt per ConnectionAttemptDetails requested; if more than one request shares the same ConnectionAttemptDetails, a single ConnectionAttempt attempts a connection for all associated requests. If a ConnectionAttempt successfully creates a channel, this class extracts client data from all requests to the same remote device and alerts its delegate, deleting all associated ConnectionAttempts when it is finished. Bug: 824568, 752273 Change-Id: If9790549157919209e3e96f4a0b11d04fda2870c Reviewed-on: https://chromium-review.googlesource.com/1103669 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568352} 
- 
Tsuyoshi Horo authoredTo set the throttring network condition using DevTools, currently the special HTTP header key "x-devtools-emulate-network-conditions-client-id" is used. But having the special HTTP header is not good for design. The header value is sometimes accidentally sent to the server (bug: 395966, 698905, 814568, 595229). To avoid this issue and for code health, we should have a flag for it. This CL introduces |throttling_profile_id| flag in: - network::ResourceRequest And |devtools_token| flag in: - blink::ResourceRequest - content::NavigationRequestInfo And creates a ScopedThrottlingToken when net::URLRequest is created in network::URLLoader and ResourceDispatcherHostImpl to register the profile ID with the NetLog source ID of the request to ThrottlingController. And changes ThrottlingController to use the NetLog source ID to lookup the ThrottlingNetworkInterceptor for the request. The flag |devtools_token| and |throttling_profile_id| are passed through the following flow: For subresource requests: - InspectorNetworkAgent::WillSendRequest() InspectorNetworkAgent.devtools_token_ -> blink::ResourceRequest - WebURLLoaderImpl::Context::Start() blink::ResourceRequest -> (WebURLRequest) -> network::ResourceRequest * If NetworkService disabled - ResourceDispatcherHostImpl::ContinuePendingBeginRequest() network::ResourceRequest => ScopedThrottlingToken => ThrottlingController * If NetworkService enabled - network::URLLoader::URLLoader() network::ResourceRequest => ScopedThrottlingToken => ThrottlingController For main resources (navigation): - NavigationRequest::OnStartChecksComplete() frame_tree_node_->devtools_frame_token() -> content::NavigationRequestInfo - NavigationURLLoaderImpl::NavigationURLLoaderImpl() content::NavigationRequestInfo -> network::ResourceRequest * If NetworkService disabled - ResourceDispatcherHostImpl::BeginNavigationRequest() network::ResourceRequest => ScopedThrottlingToken => ThrottlingController * If NetworkService enabled - network::URLLoader::URLLoader() network::ResourceRequest => ScopedThrottlingToken => ThrottlingController ScopedThrottlingToken calls UnregisterNetLogSource() in the destructor. Bug: 395966, 849966 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic8b428cbea0a5b4fdca3f065f3884ca0e99344e1 Reviewed-on: https://chromium-review.googlesource.com/1086949 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#568351} 
 
-