- 05 Apr, 2013 40 commits
-
-
anandc@chromium.org authored
BUG=224948,227043 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13735002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192621 0039d316-1c4b-4281-b951-d872f2087c98
-
posciak@chromium.org authored
This check was removed due to misinterpretation of the spec, but it seems it's needed for some streams. BUG=225787 TEST=manual playback Review URL: https://chromiumcodereview.appspot.com/13726007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192620 0039d316-1c4b-4281-b951-d872f2087c98
-
dubroy@chromium.org authored
Sergiu's fix for crbug.com/224081 inadvertently broke the layout on Android. This fixes the problem. BUG=None TEST=Open chrome://history and ensure that the 'x' buttons on the right hand side of each entry are all aligned. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13724008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192619 0039d316-1c4b-4281-b951-d872f2087c98
-
adamk@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/13668002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192618 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
With gyp_managed_install no shared libraries should be packaged in the APK (except gdbserver). When toggling gyp_managed_install, there may be left over libraries in <(intermediate_dir)/libs. APK packaging should use a different directory when doing a managed install, so that it does not include the library from a non-gyp_managed_install build. BUG=158821 Review URL: https://chromiumcodereview.appspot.com/13651003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192617 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
cancelling. This matches behavior of the win32 control. BUG=163711 TEST=covered by unit tests R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/13646008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192616 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
Suppose you have an intranet hostname "c" that you've previously visited. After this change, the behavior will be as follows: input -> inline suggestion (what happens what you hit return) c -> navigate to URL c/ -> navigate to URL c#foo -> search (this behavior differs from before this change) c# foo -> search (this behavior differs from before this change) c# foo -> search (this behavior differs from before this change) c# -> search (this behavior differs from before this change) c# -> search (this behavior differs from before this change) (notice the extra spaces the URL parser drops them) c/#foo -> navigate to URL BUG=169449 Review URL: https://chromiumcodereview.appspot.com/13190020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192615 0039d316-1c4b-4281-b951-d872f2087c98
-
caitkp@chromium.org authored
TBR=ben@chromium.org BUG=181277 Review URL: https://chromiumcodereview.appspot.com/13650007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192608 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
NOTE: This does not run on perf test bots yet. BUG=138280 TEST=components_perftests R=boliu@chromium.org,kaiwang@chromium.org,joi@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/13392002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192607 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192604 0039d316-1c4b-4281-b951-d872f2087c98
-
frankf@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/13703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192603 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Timing out on regular and ASAN bots. Note: Google Test filter = InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from InstantExtendedTest, where TypeParam = [ RUN ] InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus Right after fork Right before base::type_profiler::Controller::Stop() Right after base::type_profiler::Controller::Stop() Right after signal/exception handler restoration. Right after fd_shuffle push_backs. Right after ShuffleFileDescriptors Right after CloseSuperfluousFds Right before execvp /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources HTTPS server started on 127.0.0.1:50602... sending server_data: {"host": "127.0.0.1", "port": 50602} (36 bytes) [0405/102718:ERROR:test_launcher.cc(365)] Test timeout (60000 ms) exceeded for InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus BrowserTestBase signal handler received SIGTERM. Backtrace: 0 interactive_ui_tests 0x03a4fe9a base::debug::StackTrace::StackTrace() + 26 1 interactive_ui_tests 0x03640083 (anonymous namespace)::DumpStackTraceSignalHandler(int) + 131 2 libSystem.B.dylib 0x951de05b _sigtramp + 43 3 ??? 0xffffffff 0x0 + 4294967295 4 CoreFoundation 0x97a702df __CFRunLoopRun + 2079 5 CoreFoundation 0x97a6f3c4 CFRunLoopRunSpecific + 452 6 CoreFoundation 0x97a6f1f1 CFRunLoopRunInMode + 97 7 HIToolbox 0x91cd1e04 RunCurrentEventLoopInMode + 392 8 HIToolbox 0x91cd1bb9 ReceiveNextEventCommon + 354 9 HIToolbox 0x91cd1a3e BlockUntilNextEventMatchingListInMode + 81 10 AppKit 0x980f2595 _DPSNextEvent + 847 11 AppKit 0x980f1dd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156 12 AppKit 0x980b41f3 -[NSApplication run] + 821 13 interactive_ui_tests 0x03a14a51 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 737 14 interactive_ui_tests 0x03a136b0 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 448 15 interactive_ui_tests 0x03ac44fa base::MessageLoop::RunInternal() + 650 16 interactive_ui_tests 0x03b1efd5 base::RunLoop::Run() + 69 17 interactive_ui_tests 0x0365be40 content::RunThisRunLoop(base::RunLoop*) + 144 18 interactive_ui_tests 0x0365d343 content::WindowedNotificationObserver::Wait() + 611 19 interactive_ui_tests 0x008f7749 InstantExtendedTest_CommitWhenShownInFullHeightWithoutFocus_Test::RunTestOnMainThread() + 12777 20 interactive_ui_tests 0x0a6af765 InProcessBrowserTest::RunTestOnMainThreadLoop() + 581 21 interactive_ui_tests 0x036405b9 base::internal::Invoker<1, base::internal::BindState<base::internal::RunnableAdapter<void (content::BrowserTestBase::*)()>, void ()(content::BrowserTestBase*), void ()(content::BrowserTestBase*)>, void ()(content::BrowserTestBase*)>::Run(base::internal::BindStateBase*) + 137 22 interactive_ui_tests 0x05fd844c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 23292 23 interactive_ui_tests 0x05fd27cc ChromeBrowserMainParts::PreMainMessageLoopRun() + 28 24 interactive_ui_tests 0x05677805 content::BrowserMainLoop::CreateThreads() + 1813 25 interactive_ui_tests 0x0567b058 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 1080 26 interactive_ui_tests 0x0567441e content::BrowserMain(content::MainFunctionParams const&) + 142 27 interactive_ui_tests 0x0363fd44 content::BrowserTestBase::SetUp() + 1076 28 interactive_ui_tests 0x0a6abdc7 InProcessBrowserTest::SetUp() + 1943 29 interactive_ui_tests 0x0260b299 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 473 30 interactive_ui_tests 0x025f0910 testing::Test::Run() + 752 31 interactive_ui_tests 0x025f22d1 testing::TestInfo::Run() + 1601 32 interactive_ui_tests 0x025f31ea testing::TestCase::Run() + 1418 33 interactive_ui_tests 0x02604d83 testing::internal::UnitTestImpl::RunAllTests() + 3043 34 interactive_ui_tests 0x0260cbd9 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 473 35 interactive_ui_tests 0x02604133 testing::UnitTest::Run() + 307 36 interactive_ui_tests 0x04e0bb51 base::TestSuite::Run() + 673 37 interactive_ui_tests 0x00985d94 ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 132 38 interactive_ui_tests 0x0365277c content::LaunchTests(content::TestLauncherDelegate*, int, char**) + 3884 39 interactive_ui_tests 0x00985b8c main + 172 40 interactive_ui_tests 0x000030a5 start + 53 R=xhwang@chromium.org BUG=227076 Review URL: https://codereview.chromium.org/13685015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192602 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192598 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
Also reorder the file alphabetically NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13704013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192597 0039d316-1c4b-4281-b951-d872f2087c98
-
japhet@chromium.org authored
BUG=none TEST=none TBR=tkent Review URL: https://codereview.chromium.org/13533018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192596 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=176857 Test=None R=erg TBR=sky (For ui/linux_ui/linux_ui.h) Review URL: https://chromiumcodereview.appspot.com/13497002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192595 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
Once more with feeling. This time for sure. I correctly figured out how to do a GOOGLE_CHROME_BUILD since apparantly this does not get defined in any of the CQ chromeos bots. BUG=192420 TBR=ben@chromium.org, et. al. Review URL: https://codereview.chromium.org/13730003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192594 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
This logic was already added in scoped_ptr::reset() in https://src.chromium.org/viewvc/chrome?view=rev&revision=185551. this is a straightforward port of the logic to scoped_array to prevent any accidental regressions during the transition. BUG=162971,176091 Review URL: https://codereview.chromium.org/13433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192590 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
BUG=225967 TEST=manual, lock screen, go to second terminal, kill render process for lock screen, login screen should be shown Review URL: https://chromiumcodereview.appspot.com/13520006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192589 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Make autofill's Address store country using the country code so that app locale isn't needed for the raw methods. This is in preparation for removing content::GetContentClient calls outside of content. BUG=227047 Review URL: https://codereview.chromium.org/13697002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192588 0039d316-1c4b-4281-b951-d872f2087c98
-
varkha@chromium.org authored
BUG=100083 TEST=Open bookmark manager on a touch device (such as Pixel). Confirm that the vertical splitter can be comfortably moved and tree pane resized for reasonably long folder names to fit. Repeat with a RTL language, e.g. by running "chrome --lang=IW" confirming that the left and right padding is reversed. Review URL: https://chromiumcodereview.appspot.com/13606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192585 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
By reducing the time waited between sending a Autocomplete request and SearchProvider sending the request to mocked suggest server. The speeds up the wall time of running SearchProvider test from 30 seconds to 20 seconds. BUG= Review URL: https://chromiumcodereview.appspot.com/13461012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192584 0039d316-1c4b-4281-b951-d872f2087c98
-
haruki@chromium.org authored
BUG=174233 TEST=unittests. Open Files App and verify Google Drive is available. Review URL: https://chromiumcodereview.appspot.com/13456002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192583 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG=226789 TEST=no logic change, simply code refactor, so everything stays the same Review URL: https://codereview.chromium.org/13400003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192580 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
This test failed on Vista Tests bot: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/33887/steps/browser_tests/logs/DownloadExtensionTest_OnDeterminingFilename_InterruptedResume DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_InterruptedResume: [0405/091818:ERROR:gl_surface_egl.cc(98)] eglInitialize failed with error UNKNOWN [0405/091818:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed. HTTP server started on 127.0.0.1:51868... sending server_data: {"host": "127.0.0.1", "port": 51868} (36 bytes) browser\extensions\api\downloads\downloads_api_unittest.cc(3222): error: Value of: item->GetState() Actual: 0 Expected: DownloadItem::INTERRUPTED Which is: 3 browser\extensions\api\downloads\downloads_api_unittest.cc(3223): error: Value of: item->IsInterrupted() Actual: false Expected: true > Fix DownloadExtensionTest_OnDeterminingFilename_InterruptedResume > > Review URL: https://codereview.chromium.org/12422012 TBR=benjhayden@chromium.org Review URL: https://codereview.chromium.org/13598016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192579 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiu@chromium.org authored
The lock/unlock button for the managed controls in the history page has been misplaced by one of the patches. This moves it to somewhere else so it looks fine again. R=dubroy@chromium.org BUG= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13568003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192577 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
Fix sizing when auto-scaling a missing resource at a non-integer scale factor. Matches the rounding rules used by UX when scaling resources at non-integer scale factors. BUG=223928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190970 Review URL: https://chromiumcodereview.appspot.com/12939015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192576 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
A little code cleanup I did while debugging some panel focus issues. BUG=none Review URL: https://codereview.chromium.org/12442009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192575 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
R=vsevik,pfeldman BUG=227030 Review URL: https://codereview.chromium.org/13674009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192574 0039d316-1c4b-4281-b951-d872f2087c98
-
dubroy@chromium.org authored
The problems were not caused by a bug, but rather a change in the flexbox spec. BUG=None TEST=None, no functional change. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13459009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192573 0039d316-1c4b-4281-b951-d872f2087c98
-
haruki@chromium.org authored
We are introducing a new namespace "root". The "My Drive" root will be represented as "/special/drive/root". BUG=174233,218221 TEST=Open options UI Review URL: https://chromiumcodereview.appspot.com/12790013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192572 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
New icons from sgabriel@. BUG=180107 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/13685011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192571 0039d316-1c4b-4281-b951-d872f2087c98
-
haruki@chromium.org authored
This enables the update logic for /drive/root namespace. BUG=174233 TESTS=unittests Review URL: https://chromiumcodereview.appspot.com/13586012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192570 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=226014 Review URL: https://chromiumcodereview.appspot.com/13517002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192569 0039d316-1c4b-4281-b951-d872f2087c98
-
perkj@chromium.org authored
BUG=175683,177443 Review URL: https://chromiumcodereview.appspot.com/13679005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192567 0039d316-1c4b-4281-b951-d872f2087c98
-
alph@chromium.org authored
DevTools creates RenderView before browser populates systems settings into WebContents preferences thus the renderer gets default subpixel antialising setting. The fix makes it sending ViewMsg_SetRendererPrefs to the renderer when the preferences are finally obtained by the browser. R=pfeldman@chromium.org Review URL: https://chromiumcodereview.appspot.com/13580007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192566 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192565 0039d316-1c4b-4281-b951-d872f2087c98
-
csharp@chromium.org authored
TBR=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/13520009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192564 0039d316-1c4b-4281-b951-d872f2087c98
-
benjhayden@chromium.org authored
Review URL: https://codereview.chromium.org/12422012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192563 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
BUG=222217 TEST=manual R=nkostylev Review URL: https://chromiumcodereview.appspot.com/13194004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192562 0039d316-1c4b-4281-b951-d872f2087c98
-