Commits · 33995564a0c9c1d27f0bec4bb65050727ad11a7e · eriksson monteiro / tangled

28 Jul, 2012 40 commits

Updating trunk VERSION from 1220.0 to 1221.0 · 33995564
chrome-release@google.com authored Jul 28, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148895 0039d316-1c4b-4281-b951-d872f2087c98
```
33995564

Change ShareableFileReference to take TaskRunner instead of MessageLoopProxy · 9becf77c

kinuko@chromium.org authored Jul 28, 2012

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148893 0039d316-1c4b-4281-b951-d872f2087c98

9becf77c

Update .DEPS.git · 2916724d

chrome-admin@google.com authored Jul 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148892 0039d316-1c4b-4281-b951-d872f2087c98

2916724d

Update WebKit to r123957. · 13460adb

pkasting@chromium.org authored Jul 28, 2012

BUG=none
TEST=none
TBR=tomhudson
Review URL: https://chromiumcodereview.appspot.com/10823070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148891 0039d316-1c4b-4281-b951-d872f2087c98

13460adb

Add 2x asset to about:downloads · cb021472

thakis@chromium.org authored Jul 28, 2012

BUG=123162
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10829071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148890 0039d316-1c4b-4281-b951-d872f2087c98

cb021472

Support copying a partial rectangle region from the compositing surface on Win. · 4f646165

mazda@chromium.org authored Jul 28, 2012

BUG=118571
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10829054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148889 0039d316-1c4b-4281-b951-d872f2087c98

4f646165

[Chromoting] Add unit tests for up- and down-scaling. · 1d65f485

simonmorris@chromium.org authored Jul 28, 2012


Review URL: https://chromiumcodereview.appspot.com/10828058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148888 0039d316-1c4b-4281-b951-d872f2087c98

1d65f485

Valgrind: Exclude more browser tests that fail consistently. · aacecdcf

thestig@chromium.org authored Jul 28, 2012

BUG=none
TEST=none
TBR=timurrrr
Review URL: https://chromiumcodereview.appspot.com/10820067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148887 0039d316-1c4b-4281-b951-d872f2087c98

aacecdcf

Valgrind: Add and widen suppressions. · 9565df26

thestig@chromium.org authored Jul 28, 2012

BUG=122670,139470
TEST=none
TBR=timurrrr
Review URL: https://chromiumcodereview.appspot.com/10831066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148886 0039d316-1c4b-4281-b951-d872f2087c98

9565df26

Add blank line at end of file so that deleting it works on the try server · 086c24e9
jam@chromium.org authored Jul 28, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148885 0039d316-1c4b-4281-b951-d872f2087c98
```
086c24e9
Commit test data to be moved since try bots won't apply otherwise · 1cdfb501
jam@chromium.org authored Jul 28, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148884 0039d316-1c4b-4281-b951-d872f2087c98
```
1cdfb501

Remove chromeos::CryptohomeLibrary::IsMounted · 2c3ac4cb

hashimoto@chromium.org authored Jul 28, 2012

CryptohomeClient::IsMounted is converted to asynchronous and used instead.
Mock's default action for IsMounted is set in the ctor of MockCryptohomeClient.

BUG=126674
TEST=git try -b linux_chromeos


Review URL: https://chromiumcodereview.appspot.com/10817007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148883 0039d316-1c4b-4281-b951-d872f2087c98

2c3ac4cb

Convert the sub-rectangle for GL functions from the views coordinate to the OpenGL coordinate. · 3d257761

mazda@chromium.org authored Jul 28, 2012

BUG=118571


Review URL: https://chromiumcodereview.appspot.com/10826054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148882 0039d316-1c4b-4281-b951-d872f2087c98

3d257761

HiDPI: Enable OTR NTP 2x assets. · 90b769df

thakis@chromium.org authored Jul 28, 2012

BUG=123162
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10820066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148881 0039d316-1c4b-4281-b951-d872f2087c98

90b769df

Add global tracking of GPU memory allocations. Have each ContextGroup push... · 00b19257

ccameron@chromium.org authored Jul 28, 2012

Add global tracking of GPU memory allocations. Have each ContextGroup push memory tracking information to the GpuMemoryManager. With this we can determine if we transiently oversubscribe.

BUG=135525
TEST=

Review URL: https://chromiumcodereview.appspot.com/10796096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148880 0039d316-1c4b-4281-b951-d872f2087c98

00b19257

add oauth2 zippies to views extension install dialog · a7a6b495

estade@chromium.org authored Jul 28, 2012

BUG=130206
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10824054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148879 0039d316-1c4b-4281-b951-d872f2087c98

a7a6b495

Added ToJson to JSON schema compiler. · 08c876aa

mitchellwrosen@chromium.org authored Jul 28, 2012

Also re-factored the recently landed Debugger api (I believe it's the only API to have compiled events, so far)

BUG=138767

Review URL: https://chromiumcodereview.appspot.com/10796114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148878 0039d316-1c4b-4281-b951-d872f2087c98

08c876aa

Valgrind: Suppress error in AccessibilityTable::roleValue(). · 0d0c9cc5

thestig@chromium.org authored Jul 28, 2012

BUG=139467
TEST=none
TBR=dmazzoni
Review URL: https://chromiumcodereview.appspot.com/10823068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148877 0039d316-1c4b-4281-b951-d872f2087c98

0d0c9cc5

Update .DEPS.git · 0bb5a58f

chrome-admin@google.com authored Jul 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148876 0039d316-1c4b-4281-b951-d872f2087c98

0bb5a58f

Revert 148768 - roll skia to 4804 · e9c7de64

inferno@chromium.org authored Jul 28, 2012

Review URL: https://chromiumcodereview.appspot.com/10826009

TBR=reed@google.com
Review URL: https://chromiumcodereview.appspot.com/10835026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148875 0039d316-1c4b-4281-b951-d872f2087c98

e9c7de64

Ignore unrecognized protection schemes in ISO BMFF files. · 66fcdd5d

strobe@google.com authored Jul 28, 2012

BUG=
TEST=Manual, in browser


Review URL: https://chromiumcodereview.appspot.com/10827079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148874 0039d316-1c4b-4281-b951-d872f2087c98

66fcdd5d

SPDY - update the comment to have "status" for SPDY_SESSION_GOAWAY · 9313bd4f

rtenneti@chromium.org authored Jul 28, 2012

net log event.

https://src.chromium.org/viewvc/chrome?view=rev&revision=148115 is 
the original CL that had the logging.


BUG=133995
R=willchan
TEST=network unit tests

Review URL: https://chromiumcodereview.appspot.com/10833059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148873 0039d316-1c4b-4281-b951-d872f2087c98

9313bd4f

Revert revert of 146149 - Don't pass the connector check policy along. · ed8ce0bc

scottbyer@chromium.org authored Jul 28, 2012

Continuation of http://codereview.chromium.org/10692178/

If a browser is running, and the service process is running the connector, the
connector will occasionally start up a chromium process to check the connector
enablement policy. The flag to do so would get passed to a running browser, if
present, and there is a path through the policy check code that could cause the
browser to quit.

This patch prevents the policy check flag from being passed on; the started
process will be very short lived and does a silent launch.

Original Review URL: https://chromiumcodereview.appspot.com/10666010
Second Review URL: http://codereview.chromium.org/10692178/

BUG=134252
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10823059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148872 0039d316-1c4b-4281-b951-d872f2087c98

ed8ce0bc

[Chromoting] Add a host domain policy to the PolicyWatcher. · b9612a58

simonmorris@chromium.org authored Jul 28, 2012

Follow-up CLs will make the host respect this policy, and will let Windows
and Mac builds read this string-valued policy.

BUG=132684


Review URL: https://chromiumcodereview.appspot.com/10816036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148871 0039d316-1c4b-4281-b951-d872f2087c98

b9612a58

Add unit_tests_disabled file for android. · e5bb0cd6

nileshagrawal@chromium.org authored Jul 28, 2012

2732 tests pass with these suppressions.

BUG=138115

TEST=


Review URL: https://chromiumcodereview.appspot.com/10824070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148870 0039d316-1c4b-4281-b951-d872f2087c98

e5bb0cd6

Disable a flaky test. · 0e47f384

pkasting@chromium.org authored Jul 28, 2012

BUG=123851
TEST=none
TBR=bauerb
Review URL: https://chromiumcodereview.appspot.com/10831065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148869 0039d316-1c4b-4281-b951-d872f2087c98

0e47f384

chromeos: Use protocol buffers for Contact class. · 5676bf28

derat@chromium.org authored Jul 28, 2012

This was formerly a hand-rolled C++ class, but Satoru
pointed out that using protocol buffers would make
serialization to disk much simpler.

BUG=128805
TEST=compiles
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148868 0039d316-1c4b-4281-b951-d872f2087c98

5676bf28

Move NPAPI unit tests from test_shell_tests to content_unittests. · 11faec11

tony@chromium.org authored Jul 28, 2012

BUG=126514


Review URL: https://chromiumcodereview.appspot.com/10826052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148867 0039d316-1c4b-4281-b951-d872f2087c98

11faec11

sadrul@chromium.org authored Jul 28, 2012

If there is an error bubble on the login screen, and the user clicks
on the status-tray, then the bubble should close. Instead of sending
complicated messages from the UI to the login webui code, it is much
simpler to just close the bubbles when the login window loses focus.

BUG=127092
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10827015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148866 0039d316-1c4b-4281-b951-d872f2087c98

9201dc00

Fix a SPDY crash bug where a CHECK() is hit because a cancelled stream is... · 82e41413

rch@chromium.org authored Jul 28, 2012

Fix a SPDY crash bug where a CHECK() is hit because a cancelled stream is considered active by the spdy session.

BUG=139375
TEST=SpdySessionSpdy2Test.CancelStream

Review URL: https://chromiumcodereview.appspot.com/10829066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148865 0039d316-1c4b-4281-b951-d872f2087c98

82e41413

Update .DEPS.git · 272de577

chrome-admin@google.com authored Jul 28, 2012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148864 0039d316-1c4b-4281-b951-d872f2087c98

272de577

[Sync] Avoid unnecessary DB rewrite for TokenService credentials that were just read from DB · a84cf0f9

rsimha@chromium.org authored Jul 28, 2012

When the token service is initialized, tokens are read from disk via LoadTokensFromDB. The callback for this function after the DB read completes is LoadTokensIntoMemory.

When LoadTokensIntoMemory is run, it calls UpdateCredentials, which implicitly rewrites the just-read credentials back to the DB. This DB write is unnecessary. An unintended side effect is that the credential caching service does an unnecessary file-write to "Sync Credentials" every single time Chrome is restarted, even though the sync credentials haven't changed in any way.

This patch modifies LoadTokensIntoMemory to merely update |credentials_|, the in-memory credentials object, without updating the DB too.

BUG=139263
TEST=unit_tests; Sign in to sync, restart chrome, and make sure TokenService credentials are not re-written to DB during initialization.

Review URL: https://chromiumcodereview.appspot.com/10829051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148863 0039d316-1c4b-4281-b951-d872f2087c98

a84cf0f9

Roll WebKit 123763->123866 · 9445d561

tomhudson@google.com authored Jul 28, 2012

Review URL: https://chromiumcodereview.appspot.com/10829057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148862 0039d316-1c4b-4281-b951-d872f2087c98

9445d561

Enable gesture events handling on Android. · 5b261952

yusufo@chromium.org authored Jul 28, 2012

This add gesture related functionality to the java side to ContentViewCore and also
adds some missing calls on the routing path of the gesture events to webkit. The WebKit side
for related parts of the WebCompositorInputHandler has already been upstreamed.

BUG=136680
TEST=

Review URL: https://chromiumcodereview.appspot.com/10790066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148861 0039d316-1c4b-4281-b951-d872f2087c98

5b261952

HiDPI icons for ssl error webui page · d1bbf2ea

thakis@chromium.org authored Jul 28, 2012

BUG=134372,123162
TEST=none
TBR=flackr

Review URL: https://chromiumcodereview.appspot.com/10673017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148860 0039d316-1c4b-4281-b951-d872f2087c98

d1bbf2ea

Revert 148856 (broke mac, asan, linux cros bots) · 13b94c9b

thakis@chromium.org authored Jul 28, 2012

cc1plus: warnings being treated as errors
./chrome/browser/extensions/api/api_resource_manager.h: In member function 'void extensions::TestExtensionSystem::CreateSocketManager()':
./chrome/browser/extensions/api/api_resource_manager.h:28:error: 'id' is used uninitialized in this function
chrome/browser/extensions/test_extension_system.cc:55: note: 'id' was declared here



/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:56:3:error: variable 'id' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized]
  DCHECK(BrowserThread::GetCurrentThreadIdentifier(&id));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../base/logging.h:706:35: note: expanded from macro 'DCHECK'
  LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition))   \
                                  ^
../base/logging.h:670:3: note: expanded from macro 'DCHECK_IS_ON'
  ((::logging::g_dcheck_state ==                                        \
  ^
../base/logging.h:362:5: note: expanded from macro 'LAZY_STREAM'
  !(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
    ^~~~~~~~~
/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:57:56: note: uninitialized use occurs here
  socket_manager_.reset(new ApiResourceManager<Socket>(id));
                                                       ^~
/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:56:3: note: remove the '&&' if its condition is always true
  DCHECK(BrowserThread::GetCurrentThreadIdentifier(&id));
  ^
../base/logging.h:706:35: note: expanded from macro 'DCHECK'
  LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON() && !(condition))   \
                                  ^
../base/logging.h:670:3: note: expanded from macro 'DCHECK_IS_ON'
  ((::logging::g_dcheck_state ==                                        \
  ^
../base/logging.h:362:5: note: expanded from macro 'LAZY_STREAM'
  !(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
    ^
/b/build/slave/cr-mac-rel/build/src/chrome/browser/extensions/test_extension_system.cc:55:3: note: variable 'id' is declared here
  BrowserThread::ID id;
  ^
1 error generated.


- Improve unit testing of socket API.

Add socket_api_unittest.cc, which calls Socket API functions directly.
This skips the whole browser_tests setup that is relatively slow and
expensive. The current test merely validates the socket-type argument
handling, but the next phase will simulate blocking socket operations.

BUG=112902
TEST=see above


Review URL: https://chromiumcodereview.appspot.com/10795052

TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148859 0039d316-1c4b-4281-b951-d872f2087c98

13b94c9b

Moved tulip2.webm from chrome/test/data/media. · 8d425e44
dalecurtis@google.com authored Jul 28, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148858 0039d316-1c4b-4281-b951-d872f2087c98
```
8d425e44
Move tulip2.webm to content/test/data/media. · 8484d791
dalecurtis@google.com authored Jul 28, 2012
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148857 0039d316-1c4b-4281-b951-d872f2087c98
```
8484d791

Improve unit testing of socket API. · d8a156d3

miket@chromium.org authored Jul 28, 2012

Add socket_api_unittest.cc, which calls Socket API functions directly.
This skips the whole browser_tests setup that is relatively slow and
expensive. The current test merely validates the socket-type argument
handling, but the next phase will simulate blocking socket operations.

BUG=112902
TEST=see above


Review URL: https://chromiumcodereview.appspot.com/10795052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148856 0039d316-1c4b-4281-b951-d872f2087c98

d8a156d3

Change string to run protected content. · ca2e2feb

ihf@chromium.org authored Jul 28, 2012

BUG=139088
TEST=Linux CrOS build.

Review URL: https://chromiumcodereview.appspot.com/10827031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148855 0039d316-1c4b-4281-b951-d872f2087c98

ca2e2feb