- 12 Jul, 2017 40 commits
-
-
Suchit Agrawal authored
Create new BUILD.gn file for media/cdm and moved respective media component changes from media/BUILD.gn file to new BUILD.gn file. BUG=613033,739673 Signed-off-by:
Suchit Agrawal <a.suchit@samsung.com> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I944b712791833edf6417db308225295c6cb3bdbf Reviewed-on: https://chromium-review.googlesource.com/561265Reviewed-by:
Alexander Potapenko <glider@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org> Cr-Commit-Position: refs/heads/master@{#485843}
-
Hiroshige Hayashizaki authored
Previously, XMLDOcumentParser uses ScriptResource directly. This CL replaces the ScriptResource with PendingScript, in order to: - Replace a call of ScriptLoader::ExecuteScript() with ExecuteScriptBlock() to unify load/error event handling within ExecuteScriptBlock(), as follow-up of https://chromium-review.googlesource.com/c/554098 (Issue 686281), - Prepare for module script support in XHTMLs (Issue 717643), and - Enable SRI check in XHTMLs (Issue 684306). Bug: 686281, 717643, 684306 Change-Id: Ibedded79223d30952dee4c8370fc9eed2201a462 Reviewed-on: https://chromium-review.googlesource.com/557304 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485842}
-
Christopher Cameron authored
This was already present, now use it to populate the information read by the compositor and renderers. Bug: 735613 Change-Id: Id5c85b2bc3a0891e35760dd27b65d85c898d9176 Reviewed-on: https://chromium-review.googlesource.com/564392Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#485841}
-
Bettina Dea authored
Added Steven because of file ownership. Added Catherine and Robert for file overview. Bug: 734248 Change-Id: I64eeabf9785d1b98ac0d5c615c0e082db327b1e5 Reviewed-on: https://chromium-review.googlesource.com/564184Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#485840}
-
Tsuyoshi Horo authored
In the current implementation, when SiteInstance was used to get the process, the Service Worker UMAs are recorded as NEW_PROCESS. But This is not accurate. SiteInstance can reuse the existing process. This CL also splits the EXISTING_PROCESS UMAs to EXISTING_READY_PROCESS and EXISTING_UNREADY_PROCESS. When PlzNavigate is enabled, the service worker is likely to be started in an existing unready process which was newly created for the navigation. We should record this case apart from starting in an existing ready process. Bug: 740102 Change-Id: I523cea926fb78eb25e2669cfa0a3d56ca003e08c Reviewed-on: https://chromium-review.googlesource.com/564912Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#485839}
-
Philip Rogers authored
This patch ensures all trees (pending and recycle) are synchronized if scroll offset is modified on the active tree. This lets us remove LayerImpl's UpdatePropertyTreeScrollOffset which duplicated the transform tree update logic found in LayerTreeImpl::DidUpdateScrollOffset. This removes more LayerImpl scroll logic. This patch reverts [1] which updated the recycle tree in LayerTreeHostImpl::InvalidateContentOnImplSide and instead updates the recycle tree in LayerTreeImpl::DidUpdateScrollOffset. [1] https://chromium.googlesource.com/chromium/src/+/0e55c1eae61583ba6634a8a58cb30a2b38c922a9 Bug: Change-Id: I326176b7089b1bc9f6d8064af94844b3999a0b11 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/562556Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Weiliang Chen <weiliangc@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485838}
-
kylechar authored
The ctrl+d developer accelerator was broken with the switch to simplified display management. Add the plumbing in ScreenManagerForwarding for TestDisplayController. Make the window close button remove the display again too. The ctrl+d accelerator will only work properly in mash, since mus does something different with accelerators, but it would be fairly simple to fix in mus too. The window close button should work in both mus and mash mode. This CL also removes ToggleDisplayResolution from the TestDisplayController since it's not used anymore. Bug: 548429 Change-Id: I0f664af246a98d13eda6f312e44d226d599cecd1 Reviewed-on: https://chromium-review.googlesource.com/567333Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#485837}
-
Yoshifumi Inoue authored
This patch changes SelectionModifier::ModifyExtendingForward() to utilize early-return style for improving readability. Change-Id: I005c7064bacafca1ffaf2f805b31d5860f326389 Reviewed-on: https://chromium-review.googlesource.com/566203 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#485836}
-
Patricia Lor authored
Cookies have their own permissions, so a cookie created by one origin can potentially also be read by other origins. Since the "Site Details" page only shows origin-scoped permissions, having cookies in Site Details complicates the UI by suggesting they can be cleared for only one origin. Instead, clearing cookies for just one origin can cause other origins to enter an invalid state, and render sites effectively broken. Avoid this problem by removing it from Site Details entirely. Note that cookie settings will still be available via chrome:settings -> Advanced -> Content Settings -> Cookies. the Page Info bubble and click "Site settings" to open the Site Details page. Verify "Cookies" is not listed as one of the content settings there. Bug: 656758 Change-Id: I44ecd7aaea594659d286244380a8cd8d9510de4d Test: With #enable-site-details on, navigate to https://permission.site. Open Reviewed-on: https://chromium-review.googlesource.com/563137Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Patricia Lor <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#485835}
-
ananta authored
This patch builds on the earlier patch where we passed the URLLoaderFactory for AppCache to the renderer process. The renderer invokes CreateLoaderAndStart which comes to the AppCache factory. We then instantiate the AppCacheRequestHandler instance here and call into it to handle the request. The handler creates the AppCacheURLLoaderJob and passes itself to the job. The job controls the lifetime of the handler. The AppCacheSubresourceURLFactory class is passed the precreated AppCache host during init. We save maintain this as a weak reference in the class to protect against the case where the host dies while we are processing the call from the renderer. Added support to get a weak pointer in the AppCacheHost class. The AppCacheRequestHandler saves away the host as a weak reference during InitializeForNavigationNetworkService() and passes to the factory in MaybeCreateSubresourceFactory() The other changes are to pass the information from CreateLoaderAndStart() to the AppCacheRequestHandler class and from there to the job. A bug was fixed in the AppCacheURLLoaderJob where we weren't terminating the write correctly causing the renderer to not consider the load as complete. With this change normal subresource loads will work. Fallback support is not added yet and will happen in a followup. BUG=715632 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2956373002 Cr-Commit-Position: refs/heads/master@{#485834}
-
Jingkui Wang authored
This CL fixes the bug that the generated coalesced events always report the same position of touchdown. BUG=741004 TEST=Build/deploy chrome to chromeos, run google keep and inspect logs. Change-Id: Iba1f12623397a07d5aeba89a67bdce9db5337dd3 Reviewed-on: https://chromium-review.googlesource.com/567318Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jingkui Wang <jkwang@google.com> Cr-Commit-Position: refs/heads/master@{#485833}
-
Jay Civelli authored
Moving the ChildProcessLauncher class to base. This will allow the Multiprocess tests (used by mojo/ and ipc/) to reuse the launching code instead of duplicating it. TBR=dcheng Bug: 702316 Change-Id: I8f05ce382bd87fe4f681fa510e1a61eab2d15428 Reviewed-on: https://chromium-review.googlesource.com/559833 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485832}
-
piotrs authored
This is done with avoiding explicit chrome package name (using component name instead) and using EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent. With this patch the redirect works, however it takes a long time for CCT to consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect in ChromeTabbedActivity is almost instantaneous. Result is that for _blank links CCT shows up briefly before redirecting to an external app. In a follow up it should be investigated why it is the case and if it cannot be improved, we might need to bypass CCT in such case, which would diverge from existing navigation paths for _blank links in Clank. BUG=740402 Review-Url: https://codereview.chromium.org/2969143002 Cr-Commit-Position: refs/heads/master@{#485831}
-
Ben Wells authored
More tests are going to be added soon that need to run differently. This change extracts some repeated code into re-usable functions so these future tests can use them. A few is_particular_state functions are also removed (e.g. is_inactive) and instead the state is just exposed and tested directly. Bug: 729919 Change-Id: Ia453f0017c0c127e40277d51931c5452381a663d Reviewed-on: https://chromium-review.googlesource.com/566763Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#485830}
-
Ryan Hansberry authored
Bug: 672263 Change-Id: I34f0836f35b9e25416abefa2088db96104ee5160 Reviewed-on: https://chromium-review.googlesource.com/562573 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#485829}
-
eae authored
Variable 'x' is assigned a value that isn't used after the assignment. R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2982513002 Cr-Commit-Position: refs/heads/master@{#485828}
-
Miguel Casas-Sanchez authored
This CL removes the unused member variable |make_context_current_| and associated file static function MakeDecoderContextCurrent(), because they are unused. Bug: 736517 Change-Id: I5e294cdc00b5703fafed3afb96fbd5e54aa31991 Reviewed-on: https://chromium-review.googlesource.com/567603Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#485827}
-
Lambros Lambrou authored
Android O introduces a new authentication model for accessing the list of accounts on the device. Each account has to be specifically authorized for the app before it will appear in the list returned by the system's AccountsManager. This CL rewrites the open-source account-switcher so it will work on Android O devices, now that the app's AndroidManifest has been updated to target Android O. Bug: 704216 Change-Id: I35497209114d10a818424d04ca3215cca68c386d Reviewed-on: https://chromium-review.googlesource.com/566989Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#485826}
-
Christopher Lam authored
This reverts commit 45df4f39. Reason for revert: compile fail due to unused variable https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/43945 Original change's description: > Fix threading in FileDescriptorWatcher and MessagePumpLibevent tests. > > Changes to MessagePumpLibevent & tests: > 1. Add an explicit wait for thread start-up to TestWatchingFromBadThread, > which was not updated when the base::ThreadStart() call was changed to > not wait for the thread startup to complete. > 2. Reinstate TestWatchingFromBadThread on all libevent platforms. > 3. Add sanity-check tests for readable/writable notifications. > 4. Clean up some .get()s and add some DPLOGs. > > Changes to FileDescriptorWatcher & tests: > 1. Add a DLOG_IF() to StartWatching, to make it easier to spot > WatchFileDescriptor failures. This can't be a DCHECK or CHECK, since the > StartWatching operation is racey with file-descriptor close() on the > calling thread. > 2. Fix the test fixture to Stop() |other_thread_| to ensure it is done > working before we tear down the test file descriptors. > 3. Fix the WatchWritable test to request write notifications for the > correct end of the pipe (since pipe()s are uni-directional). > > Bug: 138845,740692 > > TBR=dcheng,fdoray > > Change-Id: I86bdd100561fbc56c1e6291216cafc3168b185dc > Reviewed-on: https://chromium-review.googlesource.com/565227 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485822} TBR=dcheng@chromium.org,wez@chromium.org,thakis@chromium.org,fdoray@chromium.org,sergeyu@chromium.org Change-Id: Idbb8c3cc0f6889c546195e62df552241d67312b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 138845, 740692 Reviewed-on: https://chromium-review.googlesource.com/566839Reviewed-by:
Christopher Lam <calamity@chromium.org> Commit-Queue: Christopher Lam <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#485825}
-
chrome-release-bot authored
TBR=dimu@chromium.org Change-Id: I93113c343cbfaf61e62a5b56d6c82c9041698182 Reviewed-on: https://chromium-review.googlesource.com/567628Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#485824}
-
Bence Béky authored
Refactor string classes and utility functions: * std::string to Http2String, * base::StringPiece to Http2StringPiece, * StringPiece::AppendToString and StringPiece::append to Http2StrAppend * base::StringPrintf to Http2StringPrintf, * implement Http2StrCat in net/http2/platform, just like it has been done in net/spdy/platform. This lands server side CL 161074972 by bnc. BUG=488484 Change-Id: I893bf6c0b97eeea92aa06d3503edea85a9ce302c Reviewed-on: https://chromium-review.googlesource.com/561756Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485823}
-
Wez authored
Changes to MessagePumpLibevent & tests: 1. Add an explicit wait for thread start-up to TestWatchingFromBadThread, which was not updated when the base::ThreadStart() call was changed to not wait for the thread startup to complete. 2. Reinstate TestWatchingFromBadThread on all libevent platforms. 3. Add sanity-check tests for readable/writable notifications. 4. Clean up some .get()s and add some DPLOGs. Changes to FileDescriptorWatcher & tests: 1. Add a DLOG_IF() to StartWatching, to make it easier to spot WatchFileDescriptor failures. This can't be a DCHECK or CHECK, since the StartWatching operation is racey with file-descriptor close() on the calling thread. 2. Fix the test fixture to Stop() |other_thread_| to ensure it is done working before we tear down the test file descriptors. 3. Fix the WatchWritable test to request write notifications for the correct end of the pipe (since pipe()s are uni-directional). Bug: 138845,740692 TBR=dcheng,fdoray Change-Id: I86bdd100561fbc56c1e6291216cafc3168b185dc Reviewed-on: https://chromium-review.googlesource.com/565227 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#485822}
-
hkamila authored
-Added the experimental features section as part of the chrome://safe-browsing. For the experiments not running at 100%. -Exported the list of SafeBrowsing features (base::Feature) to have them in the future in a central location. -Fixed the message dialogue for the WebUI. -Added some extra css. Note: Tags for the experiments are not added in this issue. Review-Url: https://codereview.chromium.org/2964693003 Cr-Commit-Position: refs/heads/master@{#485380} Committed: https://chromium.googlesource.com/chromium/src/+/fdacb19a2600b6ca47c7d58752a97bc075fd89f5 BUG=740955,734667 Review-Url: https://codereview.chromium.org/2964693003 Cr-Commit-Position: refs/heads/master@{#485821}
-
Wez authored
The internal Timeout wrapper for DBusTimeout was previously ref-counted to ensure that it was still valid when HandleTimeout fires. This CL adds a WeakPtrFactory to Timeout, allowing it to be safely deleted when the corresponding DBusTimeout is removed, with HandleTimeout becoming a no-op. TEST=dbus_unittests Change-Id: I3caffc8062dc6a30e10005395f8ed8cd447b878a Reviewed-on: https://chromium-review.googlesource.com/566338 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#485820}
-
Yves Arrouye authored
Define a new GN build flag that can be used to enable specific behaviors for that variant. Bug: 740673 Change-Id: Id1fd1a28f84cfa0d593509644b5af4a15018e728 Reviewed-on: https://chromium-review.googlesource.com/565818Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#485819}
-
Toni Barzic authored
The crash happens when device with lock screen apps enabled is shut down from the lock screen. SigninScreenHandler observes lock_screen_apps::StateController, and removes itself from the observer list on shutdown - this means that it assumes lock_screen_apps::StateController is still around at the SigninScreenHanlder destruction time. SigninScreenHandler is owned by LockScreenWebUI, which can remain around until the ash shutdowns, more specifically ash::LockWindow (provided the screen was locked at shutdown). This is after lock_screen_apps::StateController is currently destructed. To fix this, introduce lock_screen_apps::StateController::Shutdown which will reset the lock screen apps state and clean up its dependency on profiles - everything that should be done before profiles are destroyed. Actual lock_screen_apps::StateController instance destruction is deffered until ChromeBrowserMainChromeOS goes out of scope. BUG=739596 Change-Id: I50c76c9c0efac6ee1b8d29b5e7ba2eb6aa3b2372 Reviewed-on: https://chromium-review.googlesource.com/560648 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#485818}
-
Emircan Uysaler authored
This CL uses strides based on the allocated buffer rather than copying over. Bug: 741222 Test: Proposed test in the bug report passes with this CL. Change-Id: Icfd006fd1d615c780a28a5f08fb9aafb56d566e6 Reviewed-on: https://chromium-review.googlesource.com/567720Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#485817}
-
Fady Samuel authored
This CL moves: 1. FrameSinkId, LocalSurfaceId, SurfaceId => components/viz/common 2. FrameSinkIdAllocator and LocalSurfaceIdAllocator => components/viz/common All other changes are related to updating includes and namespaces. TBR=junov@chromium.org, reveman@chromium.org, sky@chromium.org Bug: 722935 Change-Id: Ie4fc5e5d94a50cd1eddd1e5b91af3131090ffe52 Reviewed-on: https://chromium-review.googlesource.com/567493 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#485816}
-
sczs authored
Showcase is intended to be a standalone UI app and as such should not reference //ios/web or //ios/chrome. This CL eliminates the Showcase app creating an IOSChromeMain instance and thus implicitly being an //ios/web embedder, instead directly inlining the minimal parts of that startup that are needed (initializing base::CommandLine and loading resources). As part of that change, this CL eliminates Showcase bundling //ios/web resources. Bug: 738880 Change-Id: I0a3d3494838cc588034feb48443d24ddf1bec03a Reviewed-on: https://chromium-review.googlesource.com/565453 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#485815}
-
btolsch authored
This removes small_map.h and moves flat_set.h to where it is used. Bug: None Change-Id: I057e386bad0eadfc9b02b5690f893da31cf9045e Reviewed-on: https://chromium-review.googlesource.com/567600Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#485814}
-
Xing Liu authored
Previously the throttling config is only checked at the beginning of ActivateMoreDownload, but we should check on every time we transit something to ACTIVE. Also fixed an issue that Reschedule should only consider active and available entries. Bug: Change-Id: I62f1bb6c8c5aa7e81dc44a09fbae0273493d53f2 Reviewed-on: https://chromium-review.googlesource.com/546677 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485813}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=aelias@chromium.org Review-Url: https://codereview.chromium.org/2981563002 Cr-Commit-Position: refs/heads/master@{#485812}
-
Wez authored
This is a reland of b377a02f Original change's description: > Pass-through batch-limit, jobs & single-process options and tag OS. > > Adds pass-through of some command-line options useful for debugging: > --test-launcher-batch-limit to control tests-per-process. > --test-launcher-jobs to control # of parallel test processes. > --single-process-tests to run all tests in a single process. > > Also adds the OS_FUCHSIA tag to the test results output. > > Change-Id: I4ce99f2a33536ddd9fae4fcb6bf93eab6f38a612 > Reviewed-on: https://chromium-review.googlesource.com/564738 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485516} Change-Id: Ib81b640818e6b6751135e4780f31135e15e6bc23 Reviewed-on: https://chromium-review.googlesource.com/566899Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#485811}
-
Matthew Halpern authored
This is a reland of 75bf6831 Original change's description: > [GRC] Remove ambiguity from CoordinationUnitImpl property operations > > The following changes address ambiguity regarding the methods related > to the CoordinationUnitImpl property store: > > 1. Eliminate the mojom::Property struct > Previously, a mojom::Property struct was used to set properties > using the Mojo interface to a particular CoordinationUnit, while > a key-value approach was used locally. The latter is the preferred > approach, making the mojom::Property unnecessary. > > 2. Remove CoordinationUnitImpl::ClearProperty (for now) > A CoordinationUnitImpl::ClearProperty was added but never actually > used for anything. It has been removed for now as its use is > unclear. If a valid use case is found it can be added back. > > Bug: 691886 > Change-Id: I2d8fa1478c1bf784b29d9783fca2acddab25062b > Reviewed-on: https://chromium-review.googlesource.com/562917 > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Matthew Halpern <matthalp@google.com> > Cr-Commit-Position: refs/heads/master@{#484994} Bug: 691886 Change-Id: I928ad1aab4000c29345ad3476b09d2584d117af0 Reviewed-on: https://chromium-review.googlesource.com/564090 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485810}
-
Ken Rockot authored
Changes Service Manager to actually enforce the client_process capability when handling StartServiceWithProcess requests from service instances. This enforcement regressed in r444496. BUG=740710 R=jcivelli@chromium.org Change-Id: I6f0e6880f5c48a13d1b769ae6903ef96746f9030 Reviewed-on: https://chromium-review.googlesource.com/566479Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#485809}
-
Theresa Wellington authored
BUG=713928 TBR=mdjones@chromium.org Change-Id: I69e4fb6bdac3c06a114a807f98411b67143ae965 Reviewed-on: https://chromium-review.googlesource.com/567525Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485808}
-
rdevlin.cronin authored
There are a number of times we need to handle exceptions from untrusted code running in the bindings system; two of the main ones include when running a callback to an asynchronous extension function and when dispatching events to listeners. In both of these cases, we want to log the exception (so the developer knows something went wrong), but we don't want to allow the exception to interrupt the flow of running JS. Introduce an ExceptionHandler class to handle these cases and log the caught exceptions to either the console (default) or a custom-set handler (used in testing). Wire it up to the APIRequestHandler (with more uses coming in later patch sets). Add unit tests for both the ExceptionHandler and the APIRequestHandler's use of it. BUG=653596 Review-Url: https://codereview.chromium.org/2961103002 Cr-Commit-Position: refs/heads/master@{#485807}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/012893b4aad8..51b2f1b64c4d $ git log 012893b4a..51b2f1b64 --date=short --no-merges --format='%ad %ae %s' 2017-07-11 scroggo Stop adding Android-specific defines to SkUserConfig 2017-07-11 reed check for null surface in test 2017-07-11 scroggo Remove Android-FrameworkDefs from CQ 2017-07-11 bsalomon Handle invalid lattice case in LatticeOp test factory 2017-07-10 wutao Serialize the new TileMode in SkBlurImageFilterImpl. 2017-07-11 scroggo Reland "Remove support for decoding to kIndex_8" 2017-07-11 reed check for default typeface for new test 2017-07-11 jvanverth Update SkiaSDLExample to latest Ganesh interfaces. 2017-07-11 brianosman Correctly set encoder options according to color space 2017-07-11 reed Revert "Change image encode api to return sk_sp" 2017-07-11 reed Change image encode api to return sk_sp 2017-07-11 brianosman Ensure FB sRGB conversion is on during copy-as-draw 2017-07-11 bsalomon Revert "Revert "Make TessellatingPathOp be a non-legacy GrMeshDrawOp"" 2017-07-11 halcanary GMs: Call SkBitmap::notifyPixelsChanged() 2017-07-11 reed Add serialize + catalog api to SkTextBlob 2017-07-07 fmalita Devolve SkTwoPointConicalGradient to SkRadialGradient when possible Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I0c5b359cbcc7494f9136665616a726b3d1549ebd Reviewed-on: https://chromium-review.googlesource.com/566597Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485806}
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I45a7ab7af11e6bd40892946821f3a3cebf15217f Reviewed-on: https://chromium-review.googlesource.com/564286Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485805}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2974293003 Cr-Commit-Position: refs/heads/master@{#485804}
-