GitLab

http://codereview.chromium.org/7038012/.

BUG=83062
TEST=PrerenderStatusManagerTests, PrerenderBrowserTests

Review URL: http://codereview.chromium.org/7060012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86342 0039d316-1c4b-4281-b951-d872f2087c98

It is accessed from the io thread after the fetcher is destroyed on the ui thread.

BUG=none
TEST=Reliability bots.

Review URL: http://codereview.chromium.org/7065008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86340 0039d316-1c4b-4281-b951-d872f2087c98

PrerenderContents::Destroy() is called in response to
TabContents destruction.

Re-enables PrerenderBrowserTest.PrerenderHttpAuthentication,
which ran into the issue on ChromeOS.

BUG=82835,82913
TEST=PrerenderBrowserTest.PrerenderHttpAuthentication on ChromeOS

Review URL: http://codereview.chromium.org/7017014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86339 0039d316-1c4b-4281-b951-d872f2087c98

Reverting due to regression of Autofill preferences pane.  See bug 83629.

BUG=82868, 83629

Review URL: http://codereview.chromium.org/7038024

TBR=vsevik@chromium.org
Review URL: http://codereview.chromium.org/7063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83638
TEST=none
Review URL: http://codereview.chromium.org/7063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86337 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Connections still work.

Review URL: http://codereview.chromium.org/7067002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/7045020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83438
TEST=none

Review URL: http://codereview.chromium.org/7038045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86334 0039d316-1c4b-4281-b951-d872f2087c98

I had been concerned that this wouldn't work with our -fPIC
bits we build internally, but the difference is actually a
performance once, not a correctness one.

(Retry of r85286, with ARM and ia32 disabled.)

BUG=57908

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85437

Review URL: http://codereview.chromium.org/6973032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86333 0039d316-1c4b-4281-b951-d872f2087c98

This is part of an ongoing effort to treat GL contexts and GL surfaces as independent entities.

TEST=run WebGL on mac, windows and linux, trybots
BUG=none
Review URL: http://codereview.chromium.org/7021014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83622
TEST=Run chrome with --enabled-sync-typed-urls, bring up customize sync dialog, verify typed-urls checkbox is enabled and checked state persists across browser restart.

Review URL: http://codereview.chromium.org/7065001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83638
TEST=Heapchecker goes green.
TBR=ahendrickson
Review URL: http://codereview.chromium.org/7063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86330 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
BUG=None
TBR=ukai
Review URL: http://codereview.chromium.org/6990042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86329 0039d316-1c4b-4281-b951-d872f2087c98

This makes some substantial changes to

1) The ownership model needed to change slightly; Global{Bookmark,History}Menu needed to own its GtkMenu due to timing issues. (The other possible way to do this (use gtk_widget_destroyed to NULL out the reference) was discussed and rejected in a similar recent code review).

2) The first connection to the TabRestoreService needs to happen lazily. While this doesn't appear to have any affect during normal startup, it breaks the majority of browser, ui and unit tests that depend on the TabRestoreService because they all depend on controlling the loading state. We can't use the OnShow/PostTask method (see previous CL) so connect to the GtkMenuItem's activate signal.

BUG=30213
TEST=ui_tests and browser_tests pass

Review URL: http://codereview.chromium.org/7017028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86328 0039d316-1c4b-4281-b951-d872f2087c98

Note: I can do this 2 ways. I can either make it call it truly
direclty as in

  gles2_implementation_->BindBuffer(args)

or I can do as I have using CALL_GL_API in which case it's

  CALL_GL_API(BindBuffer)(args)

The only advantage to the second format is a macro changes
it back to the way it was. On the other hand the class is
called WebGraphics3DCommandBufferImpl so maybe I should
change it to the first style.

TEST=try-bots and ran chrome myself
BUG=none

Review URL: http://codereview.chromium.org/7056020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86325 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of url_request_tracking.*.  The only other place that used it other than ResourceDispatcherHost was the plugin installer.  It doesn't really matter which process the request for downloading a plugin (which is very infrequent) shows up for, and arguably, it's better to show up under the browser process.

BUG=76697
Review URL: http://codereview.chromium.org/7054023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86324 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for user certificates, sending their PKCS#11 certificate ID down to flimflam.  Note this does not send the certificate slot - flimflam will have to look in the TPM slot.  This is similar to what we do for 802.1X Wi-Fi connection certificates.

BUG=chromium-os:14111
TEST=Start with no certificates installed.  Go to network menu > Private networks > Add private network.  Select "L2TPIPSec + User cert".  Verify connect button does not enable (because you have no certs available).  Cancel, then install a user cert with certificate manager.  Verify the cert appears in the Add private network dialog.  Verify connect button is enabled.  Verify you can connect to a VPN that requires certs.

Review URL: http://codereview.chromium.org/7038038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86323 0039d316-1c4b-4281-b951-d872f2087c98

And use the API in the keyboard.

BUG=chromium:76413
TEST=manually on chromebook

Review URL: http://codereview.chromium.org/7033033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86322 0039d316-1c4b-4281-b951-d872f2087c98

Adding a button instead of a link to allow the user to reopen the initiator page.

BUG=83244
TEST=See bug description


Review URL: http://codereview.chromium.org/7051026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86321 0039d316-1c4b-4281-b951-d872f2087c98

Reduced the lifetime of DownloadCreateInfo. 

DownloadCreateInfo now only lives until DownloadFileManager::CreateDownloadFile(). It's contents are put into DownloadItem, and then only the download ID is passed around to get at the information. 

In addition, most of DownloadItem's members are grouped into sub-structures by functionality: 
- history_ 
Passed to the history data base, and includes the data relevant to that. 

- request_ 
Contains the information about the request, which is not present in the other structures. 

- state_ 
Contains data that is used to manage the download process. It is part of DownloadItem because it is specific to that item, but it could instead be passed around as an extra parameter. 

Some notes on the refactoring: 

- DownloadItem is only accessed in the UI thread. This means that the state_ structure needs to be passed by value to DownloadManager::CheckIfSuggestedPathExists(), modified there, and then passed by value again to DownloadManager::OnPathExistenceAvailable(), where it is copied bach into DownloadItem. 

BUG=78084,77188
TEST=Passes all download unit tests.


Review URL: http://codereview.chromium.org/6969009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86319 0039d316-1c4b-4281-b951-d872f2087c98

Fix paint flashing when switching tabs on ChromeOS. It seems like this hidden tab host window isn't necessary... it was previously. Anyway, this fixes the flashing.

BUG=chromium-os:15507
TEST=see bug
Review URL: http://codereview.chromium.org/7059017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86317 0039d316-1c4b-4281-b951-d872f2087c98

Revert 86306 (failed compile on win builder) - Move OpenGL ES 2.0 conformance test support into main tree

This support breaks often because it is not built but the buildbots.
This CL adds it to the main tree so it will be built by the buildbots.

Not sure where to add it in all.gyp but I need to make sure it's built

TEST=opengl es 2.0 conformance tests still build
BUG=83382

R=apatrick@chromium.org

Review URL: http://codereview.chromium.org/7057033

TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/7066003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86316 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83626
TEST=Valgrind webkit goes green.
TBR=jhawkins
Review URL: http://codereview.chromium.org/7066001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83609
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7063001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7057036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70126
TEST=no

R=asargent@chromium.org

Review URL: http://codereview.chromium.org/7049032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86309 0039d316-1c4b-4281-b951-d872f2087c98

header value pair.

BUG=82137
TEST=no

Review URL: http://codereview.chromium.org/7048010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86308 0039d316-1c4b-4281-b951-d872f2087c98

Added code to track the following stats:

- How often users cancel print preview.
- How often users use the advanced settings link.
- How often users print to PDF.
- How often print preview fails.
- How many times users adjust (re-render) the preview before printing.
- Number of printers.

BUG=80917
TEST=none

Review URL: http://codereview.chromium.org/7016039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86307 0039d316-1c4b-4281-b951-d872f2087c98

This support breaks often because it is not built but the buildbots.
This CL adds it to the main tree so it will be built by the buildbots.

Not sure where to add it in all.gyp but I need to make sure it's built

TEST=opengl es 2.0 conformance tests still build
BUG=83382

R=apatrick@chromium.org

Review URL: http://codereview.chromium.org/7057033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=71443
TEST=unit-tested
Review URL: http://codereview.chromium.org/6877130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6621018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86304 0039d316-1c4b-4281-b951-d872f2087c98

I've moved watching changes to the default zoom level to the Profile class.  The other value being watched was for the per-hostname level, which is only needed if it's being synced.  However this pref stopped being synced in r51849, so the removal is roughly a revert of 44056.
Review URL: http://codereview.chromium.org/7058003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86303 0039d316-1c4b-4281-b951-d872f2087c98

Plumb through from renderer to GPU process' OMX decoder.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/7034040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86302 0039d316-1c4b-4281-b951-d872f2087c98

the registrar.  Only seems to have shown up on two download
tests, curiously.

BUG=81985
TEST=PrerenderBrowserTests.*

Review URL: http://codereview.chromium.org/7057031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86301 0039d316-1c4b-4281-b951-d872f2087c98

HostContentSettingsMap cleanup: Remove obsolete kBlockNonsandboxedPlugins preference; don't send CONTENT_SETTINGS_CHANGED notifications when preferences change.

BUG=none


Review URL: http://codereview.chromium.org/7026004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86300 0039d316-1c4b-4281-b951-d872f2087c98

current tab where they are swapped in.
R=dominich@chromium.org
Review URL: http://codereview.chromium.org/7059019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6961032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7059018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86297 0039d316-1c4b-4281-b951-d872f2087c98

Increases code reuse a bit. To make this work, give MenuButton a
-menuRect function, since ProfileMenuButton is larger than the
area it draws in.

Also potentially addresses the problem described inhttp://waffle.wootest.net/2007/08/07/popping-up-a-menu-in-cocoa/
which might be 10.5-only.

xib changes: Remove the old popup button-based PopupMenuButton, re-add
it by duplicating the new tab button, changing the resize anchor to the
upper-right corner, and changing the cell to ClickHoldButtonCell.

BUG=83169
TEST=none

Review URL: http://codereview.chromium.org/7061001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86295 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed a "connecting" attribute not properly set problem.

BUG=chromium-os:15596
TEST=Verify fix for chromium-ls:15596. i.e. Blue strip shows up on hovering "not configured" networks. Also "connecting" network now will show up in a lighter blue (compared with "connected" networks) box with no hovering and no buttons.

Review URL: http://codereview.chromium.org/7004050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86293 0039d316-1c4b-4281-b951-d872f2087c98