- 15 Jan, 2020 40 commits
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=dpranke@chromium.org Bug: 1041419 Change-Id: I490a7c39e7121c8f7129edfedc10680061732645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998138 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#732013}
-
Yuki Shiino authored
base::void_t is the same feature as std::void_t, which is supported in C++17. Chromium currently follows C++14 and base::void_t is an exceptional support of a C++17 feature. void_t is a simple mapping from arbitrary type(s) to type void and nothing is harmful. https://en.cppreference.com/w/cpp/types/void_t This patch adds base::void_t to the allowed list of Blink. FYI, Blink somehow already uses base::void_t at two places: //third_party/blink/renderer/platform/heap/finalizer_traits.h //third_party/blink/renderer/platform/wtf/type_traits.h Change-Id: I1e1f0447027df58c85b6a8f20db10df4aac2796b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002552Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#732012}
-
Nazerke authored
This CL modernizes the SnackbarCoordinator - to use the superclass -initWithBaseViewController:browser: initializer, - to remove the public property for dispatcher, - to update the naming and usage of ‘dispatcher’ parameters to match the usage guidelines. - the unit test has not been converted and has been removed. Bug: 1029346 Change-Id: I4607703e5fe5f504d53642e4c0834589fa3cb924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999199 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732011}
-
Etienne Pierre-doray authored
This is a reland of de5ec163 Reason for revert: rendering.desktop/frame_times regressions Fix: SetWorkBatchSize(2) in gpu_main to keep previous behavior. Original change's description: > [base] Migrate the Mac/iOS MessagePump to DoSomeWork > > Recycling https://chromium-review.googlesource.com/c/chromium/src/+/1470938/13 > This CL also fixes DetachToBrowserTabDragControllerTest.PressEscapeWhileDetached > to make CQ happy. > > Bug: 885371 > Change-Id: I0b54ade1fd3481a9248c89ec2993738b20fce002 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906337 > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722094} Bug: 885371, 1032188 Change-Id: Id1d6916a83e1c72cacc554c100d60fd0c78c6b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992161 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#732010}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1041419 Change-Id: Ib28835e0fe99bfe6c4d6226ba60c4ab26f5707a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998748 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732009}
-
Marina Ciocea authored
Bug: 1042199 Change-Id: I9880a7358f6ff6356ee238bc7fcde1269f17f5c0 TBR: pmeuleman@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002810Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#732008}
-
Sam Sebree authored
[Controls Refresh] Bugfix - Issue 1021225: Upon autofill pre-filling, the border styles unexpectedly change This bug fix addresses the issue of darker than normal borders on text inputs when autofill is being used. Bug: 1021225 Change-Id: I0f62bd5d3cb4bbd07c88e9cab090da09481416e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918439Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#732007}
-
Jamie Madill authored
This reverts commit d432e7b7. Reason for revert: Suspected for breaking ANGLE CQ. See bug for details. Bug: 1042252 Original change's description: > Add EXT_texture_norm16 extension for WebGL > > Expose to WebGL 2 only as first stage. > > Implementation includes hooking up ANGLE implementation and that in cmd decoder. > > Bug: 1000354 > Change-Id: I0f856d5ce693cb8da8275eda5179a582068880ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907195 > Auto-Submit: Shrek Shao <shrekshao@google.com> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#731823} TBR=dcheng@chromium.org,zmo@chromium.org,jdarpinian@gmail.com,shrekshao@google.com Change-Id: Ic7411e4fecb5b86e55129d448eb2f9a5035c5025 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003028Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#732006}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1041419 Change-Id: I9a1edf49df78480bf90f2eec8578f150a9bd21bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997658 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Allowing multiple parts was resolved in the spec after we shipped. Both Safari and Firefox implemented support for this. Bug: 955897 Change-Id: Id4222ac16d1a0bb899d336764df35068051d0775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002389Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#732004}
-
Kurt Horimoto authored
The previous API required mock expectations to explicitly set the response object. This was not sufficient for testing overlay mediators whose public interface triggers dispatch commands generated within the mediator implementation since the tests calling the public interface don't have access to the generated response to use in the EXPECT_CALL() macro. This CL updates the test callback receiver to take a single response support argument so that tests that don't care about the response value don't need access to it. Additionally, this CL removes the response object from the mock callback receiver's CompletionCallback() function, as this was also unused. Since the list of dispatch response info types is constant for all existing FakeOverlayRequestCallbackInstaller instances, the setter was moved to the constructor. In addition to updating existing tests using FakeOverlayRequestCallbackInstallers, this CL also updates tests for OverlayRequestMediators to use the fake installer. Bug: none Change-Id: Ie9fd2b680a59520b31a09a8725e165141061043f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994150 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732003}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb16c3879516..5dd59b4e1cf6 Created with: gclient setdep -r src-internal@5dd59b4e1cf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifb78a534139390b16617438b62a97732d0b84b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002851Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732002}
-
Josh Karlin authored
What: Enable the prioritized disk cache by default via the waterfall. Why: Prioritizing the backend cache by itself didn't get us much of a performance win across all pages. Perhaps it does on some individual sites (as I had noted anecdotally before starting the experiment). To get bigger wins we'd need to support prioritization across the entire network stack. But there are clients (such as CacheStorage) that already prioritize their requests and would benefit from this feature. Since the code is there, it's pretty simple, and clients need it, let's enable it by default. Bug: 655585 Change-Id: Ia84ac138e69a3ad1b06312adc4fa17ea36322e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000966Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732001}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7655168e6865..bd1466cd4e88 git log 7655168e6865..bd1466cd4e88 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 adlai@google.com Add a new gm for large kernel matrix convolution Created with: gclient setdep -r src/third_party/skia@bd1466cd4e88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Id9e46db97edefa950ebc9113fd89f7b98d454ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732000}
-
Alex Turner authored
PrefetchBrowserTest.CrossOriginWithPreload is currently failing when split cache and UseRegistrableDomainInNetworkIsolationKey are enabled. The cause is the cross_origin_server_'s URLs only differing from the embedded_test_server's in the port used, resulting in an identical scheme and eTLD+1. We thus explicitly specify third-party domains that differ in eTLD+1, also changing other tests for consistency. We also disable HTTPS to avoid SSL certificate errors from mismatched host names. Bug: 1035499 Change-Id: Ibb6b566814743343a93e6538cecd1f5771486810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001140 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#731999}
-
Ben Kelly authored
This CL improves CacheStorage prioritization in two ways: 1. It gates the CacheStorage.match() priority behind the feature just like Cache.match(). This was an oversight from previous CLs. 2. It extends the priority value into the simple disk_cache layer. 3. Previous priority values are normalized to net::MEDIUM so that CacheStorageSchedulerPriority::kHigh can be mapped to net::HIGHEST. Note, the simple disk_cache priority will not take effect until crrev.com/c/2000966 lands. Bug: 1018920 Change-Id: I2f3d272558b4457556fa307ddca566d95e61dadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000520 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#731998}
-
Nazerke authored
This CL modernizes the PasswordBreachCoordinator - to use the superclass -initWithBaseViewController:browser: initializer, - to remove the public property for dispatcher, - to update the naming and usage of ‘dispatcher’ parameters to match the usage guidelines. Bug: 1029346 Change-Id: I26064ad9d0cf024185a28c33483db5631c4c7cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000626 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Cloned from crrev.com/c/2002850, with a manual fix due to an API change. --- Roll src/third_party/perfetto 947555efc3ea..f7650d0b86f4 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/947555efc3ea..f7650d0b86f4 git log 947555efc3ea..f7650d0b86f4 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 eseckler@google.com Merge "processor: Refactor string pool IDs" 2020-01-15 eseckler@google.com Merge "protos: Consistent enum type naming between ChromeProcess/ThreadDesc" Created with: gclient setdep -r src/third_party/perfetto@f7650d0b86f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Change-Id: Ifd438eeed68079fba1c060cdfd4be8bd36f7292e Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002612Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#731996}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8842c8f43b4e..cd55f0518d68 git log 8842c8f43b4e..cd55f0518d68 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 bclayton@google.com SpirvShader: Stub OpenCL.DebugInfo.100 2020-01-15 bclayton@google.com System/Types.hpp: Make vec(T replicate) constexpr 2020-01-15 bclayton@google.com SpirvShaderDebugger: Add flag for printing opcodes Created with: gclient setdep -r src/third_party/swiftshader@cd55f0518d68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1d1e8f40066fde7c9a8ab39ccf52a392b1df9146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002849Reviewed-by:
-
Tanmoy Mollik authored
TBR=hluca@google.com,arbesser@chromium.org Bug: 1041870 Change-Id: I6641879877eb48e444537debbbc4291176c6bc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002572Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#731994}
-
Olivier Robin authored
When closing tabs, some tabs (NTP) are not synced to recent tabs. When undoing the close all, those tabs should not be removed from TabRestoreService. Bug: 1040899 Change-Id: Ieeb5f03c3a944ff943ad965c5ea4b1b2d97eecbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994885Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731993}
-
edchin authored
Previously, the "Close All" and "Done" buttons were not being updated when using VoiceOver and switching panels in the tab grid. Additionally, the incognito tabs were not being hidden in the app switcher (when using VoiceOver). The problem was that the buttons are being configured in the scrollview animation completion code. VoiceOver turns off animation, so the buttons are not being properly configured when using VoiceOver. Same goes for the incognito hiding code. This CL fixes this issue by calling the button configuration and incognito content visibility update methods from the VoiceOver codepath. Bug: 1038010 Change-Id: If76127096638f73283b54a0b1be952b0479d3b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001838Reviewed-by:
-
edchin authored
There are broken autolayout constraints when starting the app. The constraints break in iOS 13, though it is not visible to the user. The issue is that UIToolbar needs to be initialized with a non-zero rect in iOS 13. Bug: 1029344 Change-Id: I7871bbe5c1b9d75c3970f336ccc90ad2337b04ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001021Reviewed-by:
-
Mark Cogan authored
A keyed service which can track browsers created or destroyed for a browser state. This implementation is intended to be a tool that can be used by objects that own Browsers (currently in Chrome, that's BrowserViewWrangler). Browsers themselves are not automatically tracked by the BrowserList; the code that creates and destroys them must add and remove them. Change-Id: Ia67c730b7ff0fa6668cd23f7955b78071d21444a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995326 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#731990}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=gogerald@chromium.org Bug: 1041419 Change-Id: I1db9ad258f3025c25d8c491a665baa616e4eae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997744 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#731989}
-
Vladimir Levin authored
This patch ensures that if we enable CSSRenderSubtree, then DisplayLocking is enabled automatically. R=chrishtr@chromium.org Change-Id: Ie5f48e2c6a4178ba4a442371a47b73058edc6d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001116Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#731988}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kinuko@chromium.org Bug: 1041419 Change-Id: Iedaf875c56ccf34c6538c46a6a23d238d8dcc944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998273 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731987}
-
Sebastien Marchand authored
Change-Id: I544a23719e477cf1fa5dd87a6bfedcb448cd9e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963272Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#731986}
-
sczs authored
This is needed since SaveCardManager needs to know if this flag is enabled. Bug: 1029067 Change-Id: Ia33f4bc3c109458271042893523d015b833dda76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998098 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#731985}
-
Andreas Haas authored
This CL replaces calls to DeprecatedByteLengthAsUnsigned by calls to ByteLengthAsSizeT. Unfortunately the current implementation cannot deal with huge ArrayBuffers yet. Therefore I reject the incoming ArrayBuffers with a RangeError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. Bug: chromium:1008840 Change-Id: I87f083e72858ae2ca119cb8adc2e021d540e4e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000922Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#731984}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=kinuko@chromium.org Bug: 1041419 Change-Id: Id6afd8a28ae205f6ec265dbcb1d2ba251028c55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997900 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/1869332 The above CL was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1891144 And it was because the OOP-R wasn't handled. OOP-R has been handled, and we have also added pixel tests: https://chromium-review.googlesource.com/c/chromium/src/+/1992311 The pixel test is running all multiple platforms, and multiple devices with different GPUs to ensure correctness. It is time to ship off-thread paint worklet. Bug: 829967 Change-Id: I8eef62e13da216b6677a750a1214fd1ae918e9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001117 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#731982}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 61 histograms that show frequent access in the past 90 days. These are the 84% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-07-13. Change-Id: Iff859ddbd202dd757ec8738c21d92647ea2d6ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002788 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#731981}
-
Tim van der Lippe authored
Necessary for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1994967 Bug: 1006759 Change-Id: Ie0043d85e7bab12f4531317c8e62c53a82461e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002868 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#731980}
-
Daniel Clark authored
This CL updates the <input type="time"> and <input type="datetime-local"> popup UI's in three related aspects per design feedback: 1) The in-page controls now update immediately as values are changed in the popup, instead of waiting for the popup to be dismissed. The page can watch for these 'live' changes via the input event. 2) The UI is simplified by removal of the submit and cancel buttons. The popups are now dismissed only by clicking outside of them or with the Enter or Escape keys. 3) A 'double-escape' model is introduced in which if a user has opened the popup and changed the value, hitting Escape once will reset the value back to what it was when the popup was opened. Hitting Escape once more, when the popup value matches the value when opened, will dismiss the popup. The new live-update behavior required a change to how the platform fires change events for temporal input popups. Instead of firing it for every value setValue call--which would now cause it to fire every time the user clicked a different value--it is now fired when the popup is closed, via MultipleFieldsTemporalInputTypeView::DidEndChooser. This is similar to how the event is dispatched for the color input type popup. Bug: 1001571 Change-Id: I464ba22768e4a722c1b6548a0128c849fbad6a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988949 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#731979}
-
Nazerke authored
This CL modernizes the PassKitCoordinator to use the superclass -initWithBaseViewController:browser: initializer. Also this CL updates unit tests for Pass Kit Coordinator. Bug: 1029346 Change-Id: I2b35adc3ef854e603abcc2f8b27d16fa40ef9173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985964Reviewed-by:
-
Tanmoy Mollik authored
This reverts commit a98a5c5c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable AutofillAssistant...#testKeyboardIsHiddenOnLostFocus on P > > BUG=1041870 > TBR=aluo@chromium.org,arbesser@chromium.org > > Change-Id: I5c0670220cd35f0915cf2be7d55d2248739626dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999248 > Commit-Queue: Theresa <twellington@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731558} TBR=twellington@chromium.org,aluo@chromium.org,arbesser@chromium.org Change-Id: I18d739e6edb90835c47eeb504540554b44c66e3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002870Reviewed-by:
-
Kouhei Ueno authored
This CL removes the below functions currently unused: - ThreadControllerImpl::CreateSequenceFunneled - SequenceManagerImpl::CreateSequenceFunneled This CL is a follow-up CL to: https://chromium.googlesource.com/chromium/src/+/2a7d7125598fefd1b2af83387af78ffe4eab0c15 Bug: None Change-Id: Ib17dca5deb1e70f9362c28dc4ffc4a74aef00e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002550Reviewed-by:
-
Francois Marier authored
Bug: 1042136 Change-Id: I20241a0cb7db2e38cd56c0c7c26672c388c166ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002001 Auto-Submit: Francois Marier <francois@brave.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#731975}
-
Hitoshi Yoshida authored
The auto-generated bindings of IDL dictionaries have been split into two; one as {core,modules}/xxx/yyy.{h,cc} and the other as bindings/{core,modules}/v8/v8_yyy.{h,cc}. This is because Blink had a policy that only bindings/ can access V8 APIs and neither of core/ nor modules/ must not access V8 APIs. Blink changed the policy and there is no need to split IDL dictionary's bindings into two. Plus, the old style doesn't work in case that multiple partial dictionary definitions exist in modules/. An example case is below. core/xxx/main_dictionary.idl => core/xxx/main_dictionary.{h,cc} modules/yyy/partial_dict1.idl => where??? modules/zzz/partial_dict2.idl We need to merge partial_dict1 and partial_dict2 above, but it's not trivial where the header should be generated. The new style generates IDL dictionary's bindings into either of bindings/core/v8/v8_xxx.{h,cc} or bindings/modules/v8/v8_xxx.{h,cc}, and this new style is the same as other IDL definitions such as IDL interface, IDL callback function, etc. This CL has no behavioral change, because the replacing header includes the replaced header. Bug: 839389, 1034398 Change-Id: I30ac56e41f4077ffb8b509b9e0cf6011417fcb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000446Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#731974}
-
