- 01 Aug, 2019 40 commits
-
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //components/translate. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I177733c24c2b6ff37144a9127a1c2509a0a01101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730518Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683144}
-
Nico Weber authored
Bug: 989932 Change-Id: I6b85d7401a00fd58a89bbe8153eace2b3c2192e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731289 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#683143}
-
Henrique Grandinetti authored
Bug: 988490 Change-Id: Ib26f0315a6fcebec7e25b6f2b3139b34f5221c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724697Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#683142}
-
vitaliii authored
Disable SingleClientSessionsSyncTest.NavigationChainForwardBack on Mac, because fails flakily. TBR=treib@chromium.org Bug: 972871 Change-Id: Ibfe85c4fa768a1a06ff31eb06fb8b70fdcb106cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730420Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683141}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenFetchedOnRequestCanceled and OnAccessTokenFetchedOnRequestCompleted in O2ATMtest to test that OnAccessTokenFetched is invoked when a request is canceled or completed. Bug: 967598 Change-Id: Iebb3a2c6e601e385f8a3288130f39b249b616b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727769 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683140}
-
Arthur Hemery authored
This CL removes all of the references to PlzNavigate in the comments of extensions/. Change-Id: I89b3510b32e61d2bb4f737ff5705b5f1a47f9746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729085Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683139}
-
François Beaufort authored
This CL adds `dispatchIndirect` to GPUComputePassEncoder and `drawIndirect` and `drawIndexedIndirect` to GPURenderPassEncoder. Bug: 877147 Change-Id: Idd5344c112fc2df6564e5091ca0ef86dc8f8bcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731113Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#683138}
-
Edvard Thörnros authored
This is the first commit in the series of updating all the old svg animation tests. The usage of testharness has replaced the older SVGAnimationTest.js for all where it's suitable. No functionality should have changed and the tests should cover almost the same. In all of the animations where there is a sampling at T=0, where it was assumed that no animations had started. Which didn't work flawlessly when moved to the new system. Bug 985335 Change-Id: Icd94f4345cda61f9328abfb18caeed2b747dde93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729088 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683137}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/11243c3b6292..1532d22050cb git log 11243c3b6292..1532d22050cb --date=short --no-merges --format='%ad %ae %s' 2019-08-01 senorblanco@chromium.org Dawn: fix supportedWritePixelsColorType(). Created with: gclient setdep -r src/third_party/skia@1532d22050cb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I8e51ee44801f5e5e01975949489f89b48542915b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683136}
-
Rune Lillesveen authored
We were able to SetNeedsReattachLayoutTree() on a Text node where none of the ancestor elements had a LayoutObject and the Document had a <br> as a documentElement. The reason is that LayoutView does not allow a LayoutBr child which meant we recomputed styles for the whole subtree, but no LayoutObjects were created. Setting the text data on the text node would mark it for re-attachment (in case it didn't have a LayoutText because it used to be a non-rendered white-space). If it was in a display:none subtree we wouldn't have reached the text node during recalc, but because of LayoutView rejecting the LayoutBr, we already had ComputedStyle all the way. Bug: 989827 Change-Id: I72ae371466e607baf4caffad9ed634beb2a66bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731112Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683135}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLBodyElement> and DynamicTo<HTMLBodyElement> as new downcast helper. 2. Use IsA<HTMLBodyElement>(element) in place of IsHTMLBodyElement(element) Bug: 891908 Change-Id: I375e68ef0d03ed6119a22bf71b6e7cceeeca29f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729389 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If61c81302aa9f87cbba919dfbb71487abf807899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731084Reviewed-by:
-
Juan Antonio Navarro Perez authored
The new options_for_unittests.GetRunOptions function now factors out all of the details required to build an options object. This removes all remaining references in tools/perf to the Add-/ProcessCommandLineArgs functions from the telemetry.benchmark module. Depends on catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1713636 Bug: 985712 Change-Id: I49403b437a5e5e992328199372e4d9db57740906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720834 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#683132}
-
Findit authored
This reverts commit bef7a422. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 683057 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlZjdhNDIyZTk4N2U1NTcxYWYxZjZhNWM0MGEzMjQxMzFlNjk3ZDAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/34678 Sample Failed Step: unit_tests Original change's description: > [Dolphin] Add a sequence checker > > The RecurrenceRanker isn't threadsafe, so we should formalize this. > This CL adds a sequence DCHECK to all public methods (and a couple > of private callbacks, for clarity). > > Bug: 921444 > Change-Id: Ib52f8e33be82de147efd23e67c424083ff980184 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729991 > Reviewed-by: Charles . <charleszhao@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683057} Change-Id: Idfac688d72ba6a356259a575209b755ec340b7ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730620 Cr-Commit-Position: refs/heads/master@{#683131}
-
vitaliii authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1730154 TBR=yhirano@chromium.org Bug: 989717 Change-Id: I060adb383fed7b911cfc602ced6831da2a424d61 No-try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730898Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e02102755a5b..470527ec6414 git log e02102755a5b..470527ec6414 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 treehugger-gerrit@google.com Merge "processor: Export thread instruction counts to JSON" Created with: gclient setdep -r src/third_party/perfetto@470527ec6414 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib27cce382de999ab0037471a3869ac3594408cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730614Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fbf6c023. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5dcd194bc6e011d9c6355109c13a5d94fc5c8ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729890Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683128}
-
vitaliii authored
This reverts commit 3ed48d07. Reason for revert: Broke src-internal rolls. See crbug.com/989897. Original change's description: > desktop-pwas: OpenApplication called using Launch Service > > The Launch Service is used to open a new application > window. > > TBR=avi@chromium.org > > Bug: 966288 > Change-Id: Ibc7c1f49fa109335e81744ddda292a08f36b80a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723794 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683074} TBR=ericwilligers@chromium.org,reillyg@chromium.org,loyso@chromium.org,dominickn@chromium.org Change-Id: Icfc62bcaea99c6d38797138e49632800aceb1de4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966288, 989897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730418Reviewed-by:
-
Yasmin authored
Bug: 988461 Change-Id: I2cc57ddd1ee3b93036a10a7243045a3f7320d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725635 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683126}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4a17b2e..db2e0c7d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id87bf61148d4c00b5abf0ec7333b387b678c0840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729891Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683125}
-
Anders Hartvoll Ruud authored
Because of an unintended behavior change in [1], it's no longer possible to have a nullptr animating element, since StyleResolverState:: GetAnimatingElement will fall back to GetElement() if pseudo_element is nullptr. Previously (pre-[1]), if the PseudoElement* retrieved by StyleResolver::PseudoStyleForElement was nullptr, the animating element would just be nullptr, and not fall back to anything. This CL restores that behavior by passing PseudoId to a dedicated StyleResolverState constructor. That way we know whether we're doing a style resolution for a pseudo element or a regular element, and we can return the correct thing from GetAnimatingElement. Also removed the StyleResolverState constructor which accepted a ElementResolveContext, since it only had one call site which anyway did the same thing as the other constructor. [1] https://crrev.com/c/1724680 Bug: 989151,989402,989437 Change-Id: I0aecf0a7a3a857dbd0664d969abeea7ec5852260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729250Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#683124}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/31590104ec86..5ada98d0bb33 git log 31590104ec86..5ada98d0bb33 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 zoddicus@users.noreply.github.com Update WebGPU validation rules of OpAtomic*s (#2777) 2019-07-31 alanbaker@google.com Treat access chain indexes as signed in SROA (#2776) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5ada98d0bb33 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I93ad082715bc2577563623306b5992366d3882ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730610Reviewed-by:
-
François Beaufort authored
This CL adds a boolean multisampled to the bind group layout binding. When set to true, it currently raises a validation error as Dawn doesn't support it yet. Bug: 877147 Change-Id: Iad27630add2ce508ed015ddef7ff8930b32547e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731109 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Vasilii Sukhanov authored
The leak check is supposed to happen on successful sign-in. Bug: 986298 Change-Id: Id4745f70f7723aabeab5eb91ece92bad6f4b48bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727049 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#683121}
-
Christopher Gunadi authored
Hide the above context menu option when CrostiniRootAccessAllowed policy is set to false and kCrostiniAdvancedAccessControls feature flag is enabled. Currently does not support dynamic policy updates, so changes apply after restarting the UI. This will be implemented in a follow up CL. Bug: 983997, 983998 Test: compile Change-Id: Icd1fc61975cd7616efe5e580ce222551a27e75b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712667 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#683120}
-
vitaliii authored
TBR=yhirano@chromium.org No-try: true No-Presubmit: true Bug: 989863, 989848, 989825, 989824, 989823, 989811, 989808, 989807, 989806, 989805, 989757, 989879, 989878, 989756, 988074, 948167 Change-Id: Ia5a35e1e81ba5a36758e7ba3397954f40674835a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730154Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683119}
-
Roman Aleksandrov authored
Bug: 989590 Change-Id: Ie9ad7872a8be684155a44077519580f004b76be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729266Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#683118}
-
Dominic Farolino authored
To get cross-origin prefetches to work with SplitCache enabled, we'll want to create a URLLoaderFactory via CreateNetworkServiceDefaultFactory with a non-default NetworkIsolationKey. To do this, we'll need to communicate a NetworkIsolationKey to CreateNetworkServiceDefaultFactoryInternal. This CL changes both of these methods to accept NetworkIsolationKey parameters. This CL introduces no observable difference, but will make it easier to create the URLLoaderFactories we'd like for cross-origin main-resource prefetch requests. See https://docs.google.com/document/d/1bKGDIePAuF6YXmmrwM33LeLvtuCsla3vTspsxsNp-f8/edit#heading=h.9a0qg5l6gbnj. R=kinuko@chromium.org, yhirano@chromium.org Bug: 939317 Change-Id: Ib2100dc2ad7efd9f33ac22e0bd6edb14cf816c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730572Reviewed-by:
-
Juan Antonio Navarro Perez authored
This CL implements the basic API layer of the new results_processor, exposing functions to create an argument parser, process options, and finally process results. Currently the results processor only supports the "none" output format, still delegating all output formatting to Telemetry. Depends on catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1718424 Bug: 928275 Change-Id: Ib65cf62eeb59a4ab515f963bfcc7cc3bbd1f13f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692986 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
Change-Id: I37a084f25288cf473ebb3a37408534cb9a2d3977 Bug: 934009, 985682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728869 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683115}
-
Hirokazu Honda authored
V4L2VideoEncodeAccelerator requests its client to allocate video frame buffer with a frame size. If the client allocates video frame buffer using GBM API, the frame size of the created video frame can be different from the requested one. In that case, we need to reconfigure v4l2 drivers with the new frame size by S_FMT. The reconfiguration must happen only once during encoding and when the first frame is fed. Bug: 979115 Test: CtsMediaTestCases on kevin Change-Id: Ie245001fad631f5d3ff66c0d7280037bea21a8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722835 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#683114}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1dbbc7b3e232..e995d7fb23c5 git log 1dbbc7b3e232..e995d7fb23c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 xinghua.cao@intel.com Use memoryBarrier to sync image load and store Created with: gclient setdep -r src/third_party/angle@e995d7fb23c5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I6f7ab7b8d6e8bc7f743200d576fce70774558bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730613Reviewed-by:
-
Colin Blundell authored
Groups these related methods together and eliminates one method that has no production callers. Bug: 970295 Change-Id: I07c9f79862efcf94b28ad7c2571b0a33a77be316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729264Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683112}
-
Lowell Manners authored
Since this is the first RenderFrameHostProxy/RenderFrameProxy method to be mojofied, this CL also adds the boilerplate for establishing a mojo connection between RenderFrameHostProxy/RenderFrameProxy. Change-Id: I9153eb01b7a5bef374823a067eaf793a48b6a3fe Bug: 786836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643473 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683111}
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=droger@chromium.org Change-Id: Ieb7595218c6176d258dfbd7d83272a4b9d3704e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717291 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#683110}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adb42687. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I279fbf7fc8c98c38efeef6e9b798ef4023666cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730971Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 1b08fa8e. Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673 deterministic failures: ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 ArcAppLauncherForDefaultAppTest.AppIconUpdated/1 ... E.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0 [ RUN ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 Received signal 11 <unknown> 000000000000 #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread() #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver() #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver() #12 0x5611ff697745 apps::ArcApps::~ArcApps() #13 0x5611ff69786c apps::ArcApps::~ArcApps() ... #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate() #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed() #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed() #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed() #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder() #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown() #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile() #29 0x5611fe3b43cc TestingProfile::~TestingProfile() ... Original change's description: > Flip the AppServiceAsh feature default to enabled > > BUG=826982 > BUG=989789 > > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683064} TBR=dominickn@chromium.org,nigeltao@chromium.org Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826982, 989789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#683108}
-
Kent Tamura authored
elements/toast/.eslintrc.js and kv-storage/.eslintrc.js were identical, and elements/virtual-scroller/.eslintrc.js had some differences. The following describes differences between them and decision for them. * virtual-scroller had '2' for no-magic-numbers exceptions. We keep the '2' exception. * virtual-scroller enabled max-len. We enable max-len. max-len is helpful because clang-format doesn't support *.mjs extension for now. * virtual-scroller had no no-lonely-if and no no-else-return. We drop them. Following these rules is sometimes harmful for code consistency. Change-Id: Icf3118e4d504248a55a284a763f7392c59793769 Bug: 976576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727447 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683107}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It moves RegisterTokenResponse to private since it's only used by OAuth2AccessTokenManager::Fetcher which is a nested class in OAuth2AccessTokenManager. Bug: 967598 Change-Id: Ic51db4d938f955e920a33d00a6f74e07f88a8763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731029Reviewed-by:
-
Kenichi Ishibashi authored
The motivation is to avoid creating GarbageCollected objects in WebEmbeddedWorkerImpl so that we can start service worker on the IO thread, not on the main thread. The IO thread runs without Oilpan and thus we can't create GarbageCollected objects on the IO thread. ServiceWorkerGlobalScopeProxy was a GarbageCollected object because it contained ParentExecutionContextTaskRunners which is also a GarbageCollected object. The only usage of the task runners was to get the default task runner so we can replace it with Thread::Current()->GetTaskRunner(), which returns a non GarbageCollected task runner. After this CL, ServiceWorkerThread owns ServiceWorkerGlobalScopeProxy as a unique_ptr, not a Persistent. The ownership of these classes are as follows and there seems no cycle ownership, so that's fine IIUC. WebEmbeddedWorkerImpl --(unique_ptr)--> ServiceWorkerThread ServiceWorkerThread --(was Persistent, now unique_ptr)--> ServiceWorkerGlobalScopeProxy ServiceWorkerThread --(CrossThreadPersistent)--> ServiceWorkerGlobalScope ServiceWorkerGlobalScopeProxy --(CrossThreadPersistent)--> ServiceWorkerGlobalScope ServiceWorkerGlobalScope --(raw reference)--> ServiceWorkerGlobalScopeProxy ServiceWorkerGlobalScope --(raw ptr)--> ServiceWorkerThread Bug: 988335 Change-Id: I5c9104e73300ac14b56f7ad9b337d71c53321d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725530Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683105}
-
