- 18 Sep, 2020 40 commits
-
-
Joel Hockey authored
Once any app management detail page loads, the page starts to watch for any changes to any apps (install, remove, become active). It currently navigates to the app main page no matter what page it is currently on. This CL changes to only navigate to the main page if the detail page is currently being shown. Bug: 1098441 Change-Id: If1821abb579c4b9aaccf4d0db914360ebb4bd066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416151Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#808213}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad48610a0129..31634288fdf3 2020-09-17 csmartdalton@google.com Add gms that test limited hw tessellation segments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I2f8ad64f002482760eee77fcfcfedf9b049e80de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417603 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808212}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1e4781e5ec2..882abc4519b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1077274,chromium:1099982,chromium:1105693,chromium:1128770,chromium:1129342,chromium:1129402,chromium:1129540 Tbr: yutak@google.com Change-Id: Iedb2614fa2100e62b39a54dd82ed657f633955c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808211}
-
Ayu Ishii authored
This updates cookies attribute to be SameObject. Further context & discussion on this can be found here: https://github.com/WICG/cookie-store/pull/181#discussion_r489817744 Bug: 1129218 Change-Id: I7d17263b15bf06adaf7cc15e05c093a23c6aa035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416965 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808210}
-
Hiroshige Hayashizaki authored
This CL removes all (but one in ClassicScript) RunScriptAndReturnValue() calls ignoring return values. This CL doesn't change the behavior. There still remain RunScriptInIsolatedWorldAndReturnValue() calls ignoring return values, and they will be cleaned up by https://chromium-review.googlesource.com/c/chromium/src/+/2413430. Bug: 1111134 Change-Id: I27766d57b5a01b9cbfdef4166c75bfa9831338b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410105Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#808209}
-
Shik Chen authored
This reverts commit 67a8dbc3. Reason for revert: https://crbug.com/1129639 Original change's description: > idle-detection: Implement requestPermission() method > > This change implements a static requestPermission() method on the > IdleDetector interface and switches the API from requiring the > "notifications" permission to the new "idle-detector" permission. > > Bug: 878979 > Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539 > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Ayu Ishii <ayui@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808019} TBR=reillyg@chromium.org,arthursonzogni@chromium.org,ayui@chromium.org Change-Id: I41401a81e0e75613340ebe8aa5665c3d1a45414c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417473Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#808208}
-
Eric Willigers authored
We no longer attempt to expand :is and :where during style sheet loading. Correct support for these selectors remains to be implemented. In particular, we need: - invalidation - RuleFeatureSet - support for empty selector lists - error recovery - CSSSelectorParser Bug: 1127347 Change-Id: I28912cf5cb9b373c423d488b47c20251917329fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405034 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#808207}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I39d53fcdbd2cb647356cb4fa253f797f2647b51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417643Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808206}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600365511-0307b18a9fe145dd28de0ead73e8fb46212de02b.profdata to chrome-mac-master-1600387025-1a927353a66c94deef84219e25e017cd673d3d66.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I8c67d7fb3c8ce527c1410b105dfa7b7749d9d43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416835Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1123750 Test: Manually Change-Id: Ia7ea22289b2463a83f0a241983560d4d0e9c955a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416478Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I542d94bf28178b35ec51241dd99f905d2d9d3d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417596Reviewed-by:
-
Clark DuVall authored
This changes the approach for including shared libs from DFMs a bit. Instead of adding the native deps to the main lib, this change instead keeps the native code in partitioned libs which are added to the base module. This allows the DFMs folded into the chrome DFM to function as much as possible like they would normally, and also saves us from loading native code from the DFMs if it's not needed. This change also adds loadable modules from DFMs into the base module if the chrome module is enabled. Bug: 1126301 Change-Id: Iff5466b62a1adbbf0bce730df66e7116759d5df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416725Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808202}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600279142-24a6b7614c1fc4b5002795ef657956153ec745b6.profdata to chrome-linux-master-1600387025-8e83821116dd5b4024f7e67a897d35744d6cd04c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibded499eb6bac69c94feacc9d57ac6e4d18e94f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417606Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc79097fa2f9..d949c910de8c 2020-09-18 mfarazma@redhat.com gclient: Don't try opening pseudo-terminal pipes on AIX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I6cfc62307fc7263c06084fa6d79785db85d0199d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417594Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Iceac9e2787109c3303dbca615247f47f8cdf9fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417593Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4099f6552592..ac3765e663cd 2020-09-17 bryan.bernhart@intel.com D3D12: Align UBO sizes to 256B. 2020-09-17 rharrison@chromium.org Enable running robust buffer access pass on shaders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iefcdeef10c5e88a4e3ef942db17ab2afc847fb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417599Reviewed-by:
-
Brian Sheedy authored
Works around two separate issues in the Gold Python code caused by `goldctl diff` misbehaving: 1. Creates a copy of the working directory to pass to `goldctl diff`, as it currently clobbers the auth files in the given working directory. 2. Uses the public version of the Gold instance for `goldctl diff`, as authentication does not currently work for the non-public instance. Bug: skia:10610, skia:10611, skia:10587 Change-Id: Idff3202c048f4e7baa986cfc8ad21fb918382603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416861 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808197}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ifa23a4f2a7926066669fb24c598e5bc83ada2fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417597Reviewed-by:
-
Kenneth Russell authored
Still being used for prototyping; replacement not yet available. Tbr: jdarpinian@chromium.org Bug: 859249 Change-Id: I7f435ed1827634c89cf5238615dcc90d56961a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417462Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808195}
-
Tom Sepez authored
We never build chrome with this configuration, but there's no reason to prevent some third-party from building chromium in this manner. In the absence of a few new #ifdefs, we would get errors like: error: use of undeclared identifier 'FPDF_GetRecommendedV8Flags' Change-Id: I1500dd1aa587707ea81e175254b79a21f1bd6010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416939 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#808194}
-
Min Qin authored
This CL adds a metadata to existing TileGroup proto. And store it in the Tile DB. To avoid being removed during tile download, this TileGroup is using a special key and saved separately. A utility class is introduced to sort the tiles. Bug: 1096224 Change-Id: I81f4471e5e89794d3538a4b7522c6b22c36e15b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417088 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#808193}
-
Hidehiko Abe authored
It is just the delegate of Keyboard, so instead of using the observer, this CL just defers the lifetime management of WaylandKeyboardDelegate to Keyboard. This allows us to remove the inheritance of KeyboardObserver from WaylandKeyboardDelegate. BUG=1123705 TEST=Ran exo_unittests. Change-Id: I45b35a016edc3c7bd441223f1b25a28ad1debaa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416476 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#808192}
-
Karandeep Bhatia authored
Types declared in manifestTypes are only meant to be used for manifest parsing. Remove dependency of fileManagerPrivate on manifestTypes by duplicating the FileSystemProviderSource enum. BUG=1113513 Change-Id: I911ed3864cf282aa3e45b59674cf6b0cc5e6013b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414892 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808191}
-
Dominic Mazzoni authored
Replace the hand-written code to parse each enum from ax_enums with a templatized function that builds a map from string to attribute value on-demand. This saves a little bit of manual effort each time someone updates an enum. Note that these parsing functions are only used by the automation API. Bug: None Change-Id: I4be5e192041cf0686175a20e68782184295a1f9c AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404164 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#808190}
-
Evan Stade authored
It's only called for client versions <83, which are no longer supported. Thus the calling code on the impl side can be removed, and the method can be removed from the interface and client side. Bug: 1110811 Change-Id: Ia8396dab7703e74ee0cf52cbdee3b6b7e5efa0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414515 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#808189}
-
Aaron Colwell authored
This change adds fields to SiteInfo & ProcessLock to allow the process model to isolate origins according to COEP/COOP policies. This change also sets the CrossOriginIsolated bit on the renderer correctly now so that the cross origin isolation state is visible from JavaScript. The COEP/COOP info is attached to "allow any site" and "locked to site" ProcessLocks so it can easily be considered along with existing lock checks. This change was inspired by ahemery@'s patch (https://crrev.com/2339964) but uses the SiteInfo and ProcessLock to carry COEP/COOP info instead of adding these values to RenderProcessHostImpl. Bug: 1055779 Change-Id: I6d550115a9fa549ff3b93a2dc1e10e707d44d96f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393244 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#808188}
-
Danan S authored
This app is being built to replace the existing largely local WebUI-based edu_login app with a largely server-based version. This CL provides the framework for the app, with several details left to be filled in. Bug:1129661 Change-Id: I040a06a89c9097f14989ef622d528cca97e3ae7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391760 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808187}
-
Joel Hockey authored
If a USB device is already assigned to a VM and another requests to attach it, we show a confirmation dialog. https://storage.cloud.google.com/chromium-translation-screenshots/e35f1ed0b95833f5b1417ab90fe568efed19a1c2 Bug: 1129266 Change-Id: I08692dcc29db82cb0e15f8e3acc391a86f3684ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415913 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808186}
-
Minoru Chikamune authored
[related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: I28ca5b34a0285d679e98786c84ed9c1b08a230a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413929 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808185}
-
Daniel Classon authored
Completes the OsSettingsDeepLinking project by enabling the flag. Yay :) Bug: 1084154 Change-Id: If9b8d9548ca052e7165c2e3f338df2fc7c316c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417459Reviewed-by:
-
Chris Lu authored
Change-Id: Iea9ed517360cc0441b6ba9b51283957e1e64cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417569 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808183}
-
Scott Violet authored
//gpu/command_buffer/service:gles2_sources had a dependency on //media/base/android, which has a dependency on //media/base. Both of the later are source sets. This means that any features defined in //media/base/media_switches ended up with multiple definitions, which triggers DCHECKs in component builds. //gpu/command_buffer/service:gles2_sources can not directly depend upon //media as doing so results in a cycle. The fix is to move the function //gpu/command_buffer/service:gles2_sources needed from media into base. BUG=1129587 TEST=none Change-Id: Iebefc6366d34a2baff1c9dfc2061abcd9de5fcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417568Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 1117097 Change-Id: I27c01dfec1c47a927a75f6129c698c1ca5207ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413724Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#808181}
-
Nate Fischer authored
This adds support for escape characters in multiline strings definitions (where the variable name and the string literal are on different lines, not for string literals which span multiple lines). This also simplifies STRING_RE because it no longer needs to contain a regex for the string literal. This also adds tests for empty string. This hardens the regex to avoid mistaking multiple string literals (which is often used to split a string literal across multiple lines) with a complete string expression. This also removes _ToUpper and _GetClassName because these are unused by this class. Fixed: 1129591 Test: vpython build/android/gyp/java_cpp_strings_tests.py Change-Id: Ib4b6dcc2bbe70081ebaaa3552b4cb6d36dc0ffe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417488Reviewed-by:
-
Xing Liu authored
This CL adds strings for read later UI. Bug: 1128074 Change-Id: I149eba152a870bc723fe9b5c1fb7428f7940a8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417104 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808179}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: Ia5efcfaf1a165487e4b449eebfa5f42448539d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416455Reviewed-by:
-
Arthur Eubanks authored
Change-Id: I9d4971c6756e915db4beccbff330295438dc70b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410729Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#808177}
-
Joel Hockey authored
Change-Id: I03b1f15a186efb6b7edc2f586287db4ebe075ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416064 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Joel Hockey authored
Replace getCrostiniSharedUsbDevices with event sent when page is ready. This matches the Plugin VM USB page. Bug: 1129266 Change-Id: I97ee3e60129a59c3f616552d6ffa27f7be443767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415708Reviewed-by:
-
Joe DeBlasio authored
This CL ensures that target embedding matches against no-separator top domains (e.g. "googlecom.example.com") don't trigger if they are too short. It also ensures that these embedded domains are properly checked for common words and checked against the target allowlist. In doing this, it also stops a DCHECK from triggering when a user visited a domain like "googlecom.example.com" (instead of "www.googlecom.example.com"). Bug: 1126146, 1127450 Change-Id: I19e0f5735240fad85ea7079c8905e95d2744ac2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416266 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#808174}
-
