- 14 Dec, 2020 28 commits
-
-
Hiroki Nakagawa authored
<link rel=next> is expected to trigger prerendering like <link rel=prerender>. Note that when the feature flag `kPrerender2` is disabled, <link rel=next> triggers NoStatePrefetch. Bug: 1155925 Change-Id: If430701e125dcc55e9bded8350dcc43eed8a1a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578499Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#836533}
-
Alan Cutter authored
This CL replaces a check that was accidentally removed by: https://chromium-review.googlesource.com/c/chromium/src/+/2422022 Specifically the lines: const base::FilePath dir = DetermineScanDir(profile_); if (dir.empty()) { std::move(callback).Run(std::vector<ExternalInstallOptions>()); return; } Without this check Chrome would attempt to read json files in its own installation directory on non-Chrome OS platforms. Bug: 1157424 Change-Id: I351ad24d13c1ce394660f74013d094adef2a02f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585257 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#836532}
-
Joel Hockey authored
Bug: 1144138 Change-Id: I970293c61c9686ab32f574957c028bd3db754ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589049 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#836531}
-
Fergal Daly authored
Looks like render_frame_created_ is getting reset to true inside RenderFrameDeleted! - extend the dump_on_render_frame_created_for_bug_1146573_ region to catch this. - add dump points inside RenderFrameDeleted. These seem redundant if the the prior debugging works but I want to avoid yet another round. Bug: 1146573 Change-Id: I93dfd0a89fd9b95fc3e86e68189195c3b9c6dc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586456Reviewed-by:
-
Leo Lai authored
We are deprecating GetTpmStatus APIs by cryptohome. Also, GetLoginStatus is a better fit to reporting "lock to single user" status. BUG=b:172748724 TEST=unit_tests. Cq-Depend: chromium:2586412 Change-Id: I096e09c8ecbc670b03f375f059f70d466f8839e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586414 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836529}
-
Bo Majewski authored
Adding chrome://file-manager/* as one of the URLs allowed to use metics private. This allows us to remove faked out metrics private from file_manager_fakes.js Bug: 1113981 Change-Id: Ica90a7fe5560474bde91bbd911782d5cdca57211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586417 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#836528}
-
Melissa Zhang authored
We are adding a nullcheck before the callback because callers may call ShowBubble with NullCallback. Bug: 1142706 Change-Id: I2d3c1376b036057a2e5890e20a10f6478d5c7075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589139 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#836527}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97514559. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ibd2f63c22377281fb8c19fefae1383fa15a097da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588754Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836526}
-
Jérémie Boulic authored
Update the modules generation script with the changes below. Fix reformatting of single-line dependency lists: empty dependency lists (e.g. `deps = []`) were rewritten on multiple lines (deps = [\n]) incorrectly. In the `find_dependencies` function, simplify calls to `add_dependency` by the need for redundant `if is_unittest... else...`. "//chrome/test/data/webui:chai_assert" can be imported in non-unittest files, and "//ui/webui/resources/js" can be imported in unittest files. Remove unittest distinction when importing variabble from these locations. Fix function exports: The detection of functions used a variable (the name of the function the export) that was not defined. Fix test function exports: when converting the same unittest multiple times, the "export" keyword was added multiple times in front of each test function to be exported. Facilitate testing by adding a `add_js_file_exports` function that takes `file_lines` as arguments (`convert_js_file` is harder to test directly, taking a file path as argument). Fix edge case where, when the only reported closure error is about extending `EventTarget`, the script doesn't do what's needed to fix it: Run `find_dependencies` whether or not there is any variable to import. Add unittests and presubmit script. Bug: 1133186 Test: ui/file_manager/base/tools/modules_test.py Change-Id: Ia0ed675576d021b3b952215384e7a491ff7f4430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580970 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Jiewei Qian authored
This is a preparation for implementing a new LaunchSystemWebApp API, where we use AppService to launch apps and don't return the Browser object hosting the app (because AppService doesn't return it to us). This change is safe for terminal, because LaunchSystemWebApp won't fail if it is called with appropriate parameters after OnAppsSynchronized. The metrics for CrostiniResult::UNKNOWN_ERROR contains other error origins, and don't reflect whether LaunchSystemWebApp fails. Bug: 1154540 Change-Id: I517202293140a7907f8af061ecbffec3dac623e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576861Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#836524}
-
Nancy Wang authored
The RestoreData class is the full restore data in memory to be written to the FullRestoreData file. There will be some separate CLs to convert RestoreData to JSON format, and write the full restore data to a file. BUG=1146900 Change-Id: I7b51b0ba6e1cbe4f7a4b763a52e81f273a74c8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581702Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I3db1da41cad058389067728e80c4f94f7e54e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589115Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836522}
-
Wei Lee authored
This CL implements the CameraPrivacySwitchObserver on Chrome side and provide an interface in CameraHalDispatcherImpl to let other components in Chrome to add observers for camera privacy switch status changed. Bug: b/167994459 Test: Build successfully Change-Id: I4efe132cd2d0a5988a4ffeb99ab0ca2802ad2a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551882 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#836521}
-
Wei Lee authored
It is a requirement on Android R to pass the CtsVerifier Camera Intents test. Bug: b/173559007 Test: Pass CtsVerifier Camera Intents test. Change-Id: If2e9bc084af62ce634242c1f45eb7e339a15d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560436 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#836520}
-
Melissa Zhang authored
Bug: 1157709 Change-Id: I67e0fa6488a7bd8c0fa980372dba3a8444dd2c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586170 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
Moves the timeout mechanism for bfcache-deferred network requests to be per-request, allowing the timer to be stopped when we see that the request finished loading/failed/etc, so we won't evict the page if all the loads have finished. Bug: 1137682 Change-Id: I781f2739133b47a78295c66c5de94d97c6a8bdfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583601Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#836518}
-
Hiroki Sato authored
We introduced full focus mode to simulate TalkBack's focusability and announcement computation. AXTreeSourceArc.FindFirstFocusableNode() uses AccessibilityNodeInfoWrapper.IsAccessibilityFocusableContainer(), which expects to be in the full focus mode. This fixes usages of FindFirstFocusableNode() so that the magnifier's focus following feature works well in ARC++ apps. AX-Relnotes: None. Fix of regression. Bug: b:175362381 Test: manual. In PlayStore, magnifier correctly follows the focus. Change-Id: I0d000e2009137a68f8bd1cf6cbaac45cf087b834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586499Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#836517}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607877457-effe83abb8e7ff22ee3583111d897aa8e6b290fe.profdata to chrome-win64-master-1607891758-dfc01cb84a8cbce40136b5ebc3d0c450466784dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icabc7456e53f3f50d2e5a9e058c6aa29bacc18c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836516}
-
Hirokazu Honda authored
Bug: b:174318867 Test: video_encode_accelerator_tests on trogdor Change-Id: Ic961a7bc411599e6b43feee128ed09ee42b4cfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564927 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#836515}
-
Timothy Loh authored
Currently this causes the dialog to never come up again -- this CL fixes it to correctly reset state so future operations can respawn the dialog. Bug: 1146325 Change-Id: I74c9d7b60937076ad1852f4779fb9cbeacc49799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580973Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836514}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95df31bf94c7..35ebfe2c3bf8 2020-12-14 michaelludwig@google.com Use SkNoPixelsDevice when layer creation fails If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Id966b282ec6de575bba153e5cb7828d9b4651ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589028Reviewed-by:
-
Leo Lai authored
This is the missing test coverage in unittests. Technically speaking, certain browser tests, e.g., WebviewClientCertsTokenLoadingLoginTest also exercise the logic, but the code distance is very far and thus hard to debug. It makes sense for the its own unittests to test it first. BUG=b:172748724 TEST=unit_tests. Change-Id: Ib293bdeb1c572172e611ce9a55da15a8a0349a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581707 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607877457-0b1a8c1c399f28b72c88ab7954f4d2a02d90c96f.profdata to chrome-linux-master-1607903843-a675fcd2050380ffbc0661240474ef4aba9bd536.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ied0c3ecc1d78f91ed6a282994acc2e8ac9a1b93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588997Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607877457-9925f99e566e74a56d513f1785c4d16d1ed26d7c.profdata to chrome-mac-master-1607903843-cfbf56cfb9918bf3ea560508846f459222f50389.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibf71d6e635c7620352b8aac8f3ae8aa3b842d83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588996Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id3e79cb02c20598a237e9f0dee9ae1fc64b3339f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588988Reviewed-by:
-
Eric Willigers authored
We now support Web Share Targets with method POST and enctype "application/x-www-form-urlencoded" Note that enctype "multipart/form-data" is already supported. Spec: https://w3c.github.io/web-share-target/level-2/#dom-sharetarget-enctype Not yet implemented: - Receiving title/text/url using GET. - Updating PopulateIntentFilters in web_apps_base.cc Design doc: https://docs.google.com/document/d/1E4CYASFDVNqmyCbaxa8u8sOn0-Sc1miLeZfA3t3ou5o/edit?usp=sharing Bug: 1125880 Change-Id: I8fc5fe5dc008fddc6852f44572cf46325faa615f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584625Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#836508}
-
Noel Gordon authored
Bug: 1113981 Change-Id: Ia32fa995fd05fbbf8baa7e710d0d435073f7effc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585252 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f4ca81b9ed8..96b0fdfcfb65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I35d95e7ea1461304453e6729978bfbd37bd7f16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588613Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836506}
-
- 13 Dec, 2020 12 commits
-
-
David Munro authored
NEVER_FINISHED is one of the larger (and growing :'( ) error buckets. Add timeouts to every step to ensure that hangs are caught, turned into errors for the right state, and the user has a chance to retry. To get there we: 1. Add some timeouts, initially set to quite generous values which we'll tighten in future CLs. We have crosbolt data, but would like some real-world timings before getting stricter. 2. Add a metric tracking the time spent in each step, to give us a real-world breakdown to supplement what we have in crosbolt 3. Add a metric tracking how often we see invalid transitions. In theory a slow operation could send its response during the next restart attempt, and since there's no validation on the state transitions we'd end up in a weird state with unknown effects. There are options with varying thoroughness (and corresponding cost) to address this, but first let's see if it's actually a problem. This could already happen (though we haven't had reports) and there are some mitigations in place already so it may be a non-issue. Bug: 1142319 Test: Unit tests, mannually run installation + app launch. Change-Id: Iafd15cf8f659b9a29764ce399359a29711e35043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563042 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#836505}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607868419-d5f6c8caaa398287431f70f2a064250f6f51fb88.profdata to chrome-win64-master-1607877457-effe83abb8e7ff22ee3583111d897aa8e6b290fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifd11fc8be7f1a873944a61f0517ed08c4b6ac590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588948Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4bd9fcc6c22a..95df31bf94c7 2020-12-13 reed@google.com remove test code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Id2d3afab3aeef99df704f23bc7bd72e34ee4d9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588435Reviewed-by:
-
Victor Costan authored
Bug: Change-Id: Ia047dc1c99f07ba703be62190145f53dbb55f021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588100Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836502}
-
Jason Lin authored
This is a reland of 31b56eca. The original CL failed the chromeos-kevin-rel bot because it triggered some race condition in the camera service. Now that camera service has been fixed, and the chromeos-kevin-rel trybot is passing, this CL is ready for a reland. This CL is updated a bit from the original CL: * We only connect to the camera service if media::ShouldUseCrosCameraService() returns true * We check against both CameraClientType::UNKNOWN and ...::PLUGINVM * Changes in user_session_initializer are removed because we have another CL (2586286) for it. Original change's description: > Connect VmCameraMicManager with camera service for PluginVM > > The camera notification/indicator is shown when PluginVM accesses camera > now. Note that flags pluginvm-show-camera-permissions and > vm-camera-mic-indicators-and-notifications need to be turned on. > > Bug: b/167491603 > Change-Id: Ib2e3f7bc85531313811d2525ecac394aadee6e17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557122 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832576} Bug: b/167491603 Change-Id: Ibc01c2144bd8c7b5ba704abff9a8ccd1adec3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573936 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34e873c9aca6..7f4ca81b9ed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I301bb29c9629028e8d81be660a976c54fa03249e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588802Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I4c0e356cde1c2e1511813b22c284c04279340339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588891Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836499}
-
Victor Costan authored
Change-Id: I36ed7cf8876168e6da5e0e68ae364c2dc33560d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587832 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#836498}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1f6ac6d95bc5..4bd9fcc6c22a 2020-12-13 bsalomon@google.com Address Michael's after the bell comments on blur change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1156804 Tbr: tdenniston@google.com Change-Id: Iff40af81a439705393cbd46d20e055ad5279e5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588797Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607849457-bcb4b1274e1b8e89999b27c85d54dd11124cd561.profdata to chrome-win64-master-1607868419-d5f6c8caaa398287431f70f2a064250f6f51fb88.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1645ffba91655d4e2d2485af16e1239f6434dc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588590Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fce647bb. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ic4fe295388ca7c5535d840838c468a00bed2f98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588752Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a2ac8d66da3..34e873c9aca6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I7af91b9d0a4e59a52ea26fc93f10ffb798ebcd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588868Reviewed-by:
-
