- 06 Mar, 2020 40 commits
-
-
adamta authored
When running on a non-windows platform, MachineIdProvider will provide the hardware model name. Bug: 981408 Change-Id: I1edae511b1e79cb2360630c1253c4e7209aeec3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088531 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#747763}
-
Jan Wilken Dörrie authored
This change adds an extract() and replace() API to base::flat_tree which are inspired by the equivalently named API mentioned in the standardization proposal of std::flat_map and std::flat_set. References: - https://wg21.link/p0429 - https://wg21.link/p1222 Bug: 682254 Change-Id: If517376aa7a682064d55882a0eecf4ff1ce89eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091352Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747762}
-
Ahmed authored
- Focusing the desk name should select all text, unless the user clicks and drags to make their own selection. - Tab / Shift+Tab should commit any pending name changes. - Commit changes on: - Clicking on empty places in the desks bar. - Creating / removing desks. - Dragging a window in overview. - Reduce the vertical spacing before and after the DesksNameView. BUG=1040980 TEST=Manually, added some tests. Change-Id: I834c24890ff92a9e72b485328a90a6dd63b117e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083870Reviewed-by:James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#747761}
-
Henrique Nakashima authored
This allows caching double-typed field trial parameters for use before native is loaded. Also implement methods to read and write double-typed values with SharedPreferencesManager. Bug: 1041865, 1012975 Change-Id: Ieba6e8b41ed566bbd087ddba84c53260a16d481c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087429Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#747760}
-
Nate Chapin authored
This actually changes the structure, so that LocalDOMWindow inherits ExecutionContext, rather than Document. I left as much logic as I could on Document, and had LocalDOMWindow call in to it. A few things needed to move for consistency, and I moved anything where the Document override of a ExecutionContext function was only called through the ExecutionContext interface. Added null-checks and updated code to final format where it was necessary to keep tests passing, otherwise left transitional code/helpers intact. Updated many unit tests that needed an ExecutionContext to use DummyPageHolder instead of just a standalone Document. Bug: 1029822 Change-Id: I9e4276aaeba476289e260e7a28e500db9982a424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051021 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#747759}
-
Nohemi Fernandez authored
This patch concerns the change in the skip button text to 'No Thanks' and the presentation of the user sign-in as fullscreen. Note that the first run logging will be extracted in a separate patch. Bug: 971989 Change-Id: I372937780288b190948819605a913d50dae81cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087617 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747758}
-
Koji Ishii authored
This patch fixes: 1. |LayoutNGBlockFlowMixin<Base>::AddOutlineRects| to call |NGPhysicalContainerFragment::AddSelfOutlineRects| if it has |NGFragmentItems|. This is needed to include inline continuation when FragmentItem is enabled. 2. |NGPhysicalContainerFragment::AddOutlineRectsForNormalChildren| to include child boxes of line boxes. Fixes two failures. Bug: 982194 Change-Id: I9d4f73caa2f7f7e063a8db667aeb88f1dce7ac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967096Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747757}
-
Kevin McNee authored
Tbr: afakhry@chromium.org Bug: 1049178 Change-Id: I54c8d2e9a480917ab1bd8466f9232effb0f6aee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090200Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#747756}
-
Mohsen Izadi authored
Each thread (impl and main) will be processing at most one event at a time. This means that EventsMetricsManager does not need to have a list of active events. A single active event would suffice. Bug: 1054007 Change-Id: Iebaa9deb0f88dc73bcf7d0612e989fac7b7d03f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067356Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747755}
-
Mark Schillaci authored
This CL addresses missing actions that were added in various Android SDK's after version M. Here we add all those actions, and for a subset of them we have fully implemented their behavior: - ACTION_PAGE_UP - ACTION_PAGE_DOWN - ACTION_PAGE_LEFT - ACTION_PAGE_RIGHT - ACTION_SET_PROGRESS For other actions we have included them and stubbed methods but have not fully implemented them. Namely ACTION_IME_ENTER will be addressed in an upcoming CL. Bug: 1057254 Change-Id: I9e29a3bc0c895a9110a297d1cef607a1d5dba6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082088Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#747754}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..8c13b2f02094 git log a095711c5d77..8c13b2f02094 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 capn@google.com Explicitly compile with warnings-as-errors 2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader Created with: gclient setdep -r src/third_party/swiftshader@8c13b2f02094 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059196 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ica8b2d431aef339a35dc45dcf467dbffbb0dfa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747753}
-
Maks Orlovich authored
1) If we're navigating a top-level, feature policy isn't generally available; this broke its application for client hints in fresh tabs. Instead, just use 1P check since we don't have feature-policy yet. 2) The 1P/3P check is also needed if we don't have feature policy use enabled. 3) The bug in #2 was unnoticed because the virtual testsuite for feature policy integration off only disabled it on renderer and not browser. Bug: 1050726 Change-Id: I9a26e8f818656e96ba130da38d08ccd017867f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087977 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747752}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e9fd4857e2e..74dadc1e8e33 git log 8e9fd4857e2e..74dadc1e8e33 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 minyue@chromium.org Ready to support of absolute capture timestamp header extension. 2020-03-06 hbos@webrtc.org Correct email address in OWNERS file. 2020-03-06 hbos@webrtc.org [Overuse] Initial version of VideoStreamAdapter (Restrictor moved). 2020-03-06 danilchap@webrtc.org Migrate RtcpTransceiver to use webrtc::TaskQueueBase instead of rtc::TaskQueue Created with: gclient setdep -r src/third_party/webrtc@74dadc1e8e33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I224dd4e7fb84c7eddb14c10d98dc5c6410eb462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089783Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e85398565d3..6535f4251dfc Created with: gclient setdep -r src-internal@6535f4251dfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I293bf7ce8a5c0ab2d63f2d4c6791aac42e321600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091419Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747750}
-
Mathias Bynens authored
This reverts commit e4048c2e, and applies the fix from https://chromium-review.googlesource.com/c/chromium/src/+/2087672. Original change's description: > [DevTools] Support vision deficiency emulation in CDP > > This patch makes it possible to emulate various vision deficiencies, > including color vision deficiencies and blurry vision, in the Blink > Renderer. The various deficiencies can be triggered by the new > Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools > Protocol. > > Design doc: https://goo.gle/devtools-cvd > > Bug: chromium:1003700 > Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746715} TBR=caseq@chromium.org,vogelheim@chromium.org,mathias@chromium.org,futhark@chromium.org Bug: chromium:1003700 Change-Id: I3f3e91dd72e7fb479eb7d73ba8452fc876e20b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087347Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#747749}
-
Mark Cogan authored
As part of preparing for multi-window, the URLLoadingService needs to be migrated to be a BrowserAgent instead of a KeyedService. That change is itself fairly large, but as an additional complication URLLoadingService is used in downstream code. This CL is the first in a series of changes needed to complete this refactor: 1. Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, including updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Remove the implementation of the shimmed API. 8. Upstream, remove the loading shim protocol and the old shimmed CreateLogoVendor() API. Call only the new shimless API. Specifically, this CL creates a shim URLLoadingBridge protocol so that the implementation of the actual URL load can be changed upstream in a single CL upstream (step 5 in the process above). At the same time, a Browser object is also passed into the provider so that after the loading service is changed, it can be fetched (via Browser) in the downstream code. This CL doesn't introduce any implementation of the shim protocol; that will be in step 3. Bug: 1046374 Change-Id: Ic2388c0f9680dabc8cb10349255cc9ab281cccbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089687Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#747748}
-
sandromaggi authored
Previous to this CL, when detaching / attaching the UI the form would be recreated in its initial state. This CL reads the already existing data from the last result and uses it to initialize the form. Bug: b/150929960 Change-Id: If416659092dae45f282be120af0128ff6fcbd2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091486Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#747747}
-
Jan Wilken Dörrie authored
This change implements sending a PasswordCheckStatusChanged event to JavaScript whenever the status of the password check changes. Bug: 1047726 Change-Id: I68361cef3ab1eb232b1ff4883bf56158adfa4be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087676 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747746}
-
Peter Kotwicz authored
This CL: - Makes StatusBarColorController use TopToolbarThemeColorProvider instead of StatusBarColorController.StatusBarColorProvider - Deletes CustomTabStatusBarColorProvider.java - Renames TabThemeColorProvider to TopToolbarThemeColorProvider and makes it return the correct value when there is no active tab. - Moves StatusBarColorController owners to RootUiCoordinator BUG=1015627 Change-Id: I0aff744a8901c00c6198adfa1a086b7de6193a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063966 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#747745}
-
Ehsan Kia authored
By default, traffic_annotation_auditor will use the proto file compiled into the binary, which can be problematic if the proto was modified since the last deployment of the binary. Removed fields can go undetected while added fields will throw an exception and require a redeployment. This change uses a DynamicMessageFactory to load the latest .proto file from source and uses it to parse the serialized annotation, catching any exception that may turn up. It also uses the dynamic proto to serialize back the proto before it is turned into a hash. All other functions are performed on the original static proto, since we really care about changes to chrome_settings.proto and the chrome_policy field is never directly accessed within this binary. Bug: 1048178 Change-Id: I2acbbe962b3233424982e9d5216e0c385dfaf577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079202 Commit-Queue: Ehsan Kia <ehsankia@google.com> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#747744}
-
Matt Menke authored
Downloads are currently treated as main frame navigations, with respect to same-site-cookies, but as subresources, with respect to NetworkIsolationKey. This means we don't gain any cross-site tracking protections as a result of the NIK, and there are often mismatches between NIKs and their site-for-cookies values. This CL makes downloads act like navigations with respect to NetworkIsolationKey, to mirror the site-for-cookies behavior. This does mean that downloads leak data across sites, and we may want to address this in the future, but for now, we should at least be consistent, since NIK and site-for-cookies are similar concepts, and should have complementary behavior. This is one of several CLs aimed at letting us DCHECK that NIK and site-for-cookies are consistent. Change-Id: I6e35d189c87dc6b04b35ca4ef16170e65a07f990 Fixed: 1046453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050987Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#747743}
-
Alexander Timin authored
Remove it as it is not being used now. BUG=954271 R=arthursonzogni@chromium.org Change-Id: I7f7e0d0e4d5b1937c9c2a87aaf39f45da6f40bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091488 Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747742}
-
Ulan Degenbaev authored
ArrayBufferView and friends currently cache the buffer start and length. The cache is cleared on ArrayBuffer::Detach, which requires ArrayBuffer to keep track of all its ArrayBufferViews in a linked list. This function adds ArrayBuffer::IsDetached before accessing each cached value. This will allow us to remove the linked list and simplify the ownership model and eventually get rid of WTF versions of ArrayBuffer, ArrayBufferView, and friends. Bug: chromium:1008840 Change-Id: Ib29d2d4f493ea4abfad0b85314b7934137fa1857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091489Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I048e2563334e886d0828323c2422cc64aee6efd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090422 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#747740}
-
Viktor Semeniuk authored
Comments after merge from: https://chromium-review.googlesource.com/c/chromium/src/+/2078257 are applied here. Bug: 1047726 Change-Id: I130f410e1fdfbf8b44c630279efff0e9618b1fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089851 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747739}
-
Timothy Gu authored
V8PersistentValueVector is a flavor of v8::PersistentValueVector that uses WTF::Vector as the underlying container. It is now dated with the introduction of Oilpan and unified GC. Use HeapVector with TraceWrapperV8Reference instead. Also, make one of the tests for WebLocalFrame's RequestExecuteV8Function() use receiver and arguments in order to test those functionalities. Bug: 1058706 Change-Id: I46c76ae087af478f9368c90ff27a0f6a69c71b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089984Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747738}
-
Stephen Nusko authored
This is failing consistently. BUG=1059273 NOTRY=true CC=sadrul@chromium.org,vmiura@chromium.org TBR=crouleau@chromium.org Change-Id: I36aa5ca865e7751ef51cf01b561744711d161c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090427Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747737}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93a2a6b8badb..491df6ba72d3 git log 93a2a6b8badb..491df6ba72d3 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 mtklein@google.com remove SkTLS Created with: gclient setdep -r src/third_party/skia@491df6ba72d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: If1c3a56eed374ed895cc2aa6af0c25ecd00e7e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091415Reviewed-by:
-
Ewann authored
Renames google_drive_app_util. files to external_app_util. and GetFilesAppDownloadsDirectoryUrl() to GetFilesAppUrl(). Moves GetFilesAppUrl() inside external_app_util. Bug: 1052851 Change-Id: I15195179615bba4c891e66443d1518f02eacd4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090416Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#747735}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c7e1c6b5bd96..f291e9f01a9c git log c7e1c6b5bd96..f291e9f01a9c --date=short --first-parent --format='%ad %ae %s' 2020-03-06 sanikak@chromium.org auto_updater: update CheckPayloads method to ssh into devserver 2020-03-06 saklein@chromium.org flash-ap: Create deploy config. 2020-03-06 saklein@chromium.org flash_ap: Fix dut control command. 2020-03-05 saklein@chromium.org cros build-ap: Add FW_NAME support. 2020-03-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-05 saklein@chromium.org lib/firmware: Fix octopus build config. Created with: gclient setdep -r src/third_party/chromite@f291e9f01a9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Id89694bb4ef30da3baae8492b995a65ec983330f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091418Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1bf49a28878573d79b2bf6ac31fe6f7ebffb0288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091420Reviewed-by:
-
behdad authored
The guides for investigating the representative perf tests are added: - Common failures listed - accessing the traces and benchmark logs are documented Bug: none Change-Id: Ic087fb97ee362e04d839414f1396165f111b9934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087220 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL adds the missing wiring call that lets the check button trigger the native check call. (Only bridge code, no tests possible.) Bug: 1047726 Change-Id: Ib430e3c10730d664c5364684c2c70ccdaff22ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089707 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747731}
-
Hans Wennborg authored
Bug: 1059231 Change-Id: Iea8de23e989a450caa02e67bfb9b5a5e780af8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089686Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#747730}
-
Dave Tapuska authored
In order to move BeginFrame into blink change WebWidgetTestProxy to use an alternate method that occurs before BeginFrame. No behavioural changes intended. Change-Id: I5b8e1c2346005321f7f7c294edd598b451aeaa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090306Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#747729}
-
Omer Katz authored
This is a reland of 2f69de56 Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} Bug: 986235 Change-Id: I3bdc6c53fcf7f2d0cc17c5eabbb1a86f470a263c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090421Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements the passwordsPrivate.getPasswordCheckStatus extension API. In order to obtain this information, the PasswordCheckDelegate instantiates a BulkLeakCheckAdapter, and forwards its GetBulkLeakCheckState(). An event listener that notifies about changes to this event will be added in a follow-up CL. Bug: 1047726 Change-Id: Id9b6aeff1d604df4924be81a2213d77c16cd0ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085273 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Andrew Luo authored
Bug: 1058637 Change-Id: I519f740d02078cb38d67e38d7d4a3307f5cce88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090839Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#747726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b1579a826af..88d9224c538a git log 0b1579a826af..88d9224c538a --date=short --first-parent --format='%ad %ae %s' 2020-03-06 lalitm@google.com Merge "tp: refactor systrace serialization code in raw table" Created with: gclient setdep -r src/third_party/perfetto@88d9224c538a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1bdd286458a2239445f8c92c41fa76069cc549c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091417Reviewed-by:
-
Omer Katz authored
Moved the CHECK to when we pop from the worklist on the main thread instead of before we push concurrently. Bug: 1059185 Change-Id: I3b010d263c943395c7e483b3775a03e766ee1b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091525Reviewed-by:
-
