GitLab

BUG=540493

Review URL: https://codereview.chromium.org/1571633002

Cr-Commit-Position: refs/heads/master@{#369371}

properties.

Without this patch, when an ancestor modifies custom property values
then children that make use of just the non-inherited part of the
matched properties cache won't apply any custom property value
overrides, as they aren't flagged as inherited.

BUG=570164

Review URL: https://codereview.chromium.org/1581223003

Cr-Commit-Position: refs/heads/master@{#369370}

BUG=568486
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1586663004

Cr-Commit-Position: refs/heads/master@{#369369}

- Re-styled buttons on dialogs to MD's ones.
- Adjusted shadow, background, and layout of dialog container.
- Removed white shield which was shown behind the dialog.

BUG=575150
TEST=manually confirm the style of dialogs which are shown as follows.
- Delete a file (delete confirm dialog)
- Rename a file to ".foo" (alert dialog)
- Try to open unsupported file in Downloads. (alert dialog with a title)
- Open change-default dialog by selecting a file which has multiple support app and clicking "Change default..." from OPEN dropdown menu. (default task dialog)

Review URL: https://codereview.chromium.org/1584113002

Cr-Commit-Position: refs/heads/master@{#369368}

Cr-Commit-Position: refs/heads/master@{#369367}

This is a tad earlier than what we used to do; we used to do it for all sets in
one go at the end of layout of the multicol container. We now do it
individually for each column set (children of the multicol container) as we lay
them out.

This way we have an up-to-date column height when positioning column sets
during multicol container child layout (children being either spanner
placeholders or column sets).

For the bug in question, this is particularly important in the first layout
pass, where column heights are completely bogus. When we're in a nested
fragmentation context, inner column heights are typically set to the remaining
height of an outer column, which may be more space than the contents actually
need. This could in turn trick the machinery into believing that we need to
insert another fragmentainer group for a spanner following a column set, even
if column heights were completely unconstrained.

BUG=552615
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/1558963003

Cr-Commit-Position: refs/heads/master@{#369366}

The patch starts treating css comments as CSS properties if the parsed
property name resembles a valid property name.

BUG=568017
R=pfeldman

Review URL: https://codereview.chromium.org/1534323003

Cr-Commit-Position: refs/heads/master@{#369365}

The current site engagement tests are a) based on
BrowserWithTestWindowTest (which doesn't run on Android); or b) not
compiled as part of unit_tests on Android. This CL refactors the tests
so that they compile, run, and pass on Android.

BUG=575509

Review URL: https://codereview.chromium.org/1578133002

Cr-Commit-Position: refs/heads/master@{#369364}

Before this patch, |VisibleSelection::setWithoutValidation()| assumes it is
always called |m_affinity| == |TextAffinity::Downstream|, however as attached
test case, "/set-without-validation-with-upstream-caret.html", this assumption
is false. |setWithoutValidation()| can be called with
|m_affinity| == |TextAffinity::Upstream|.

This patch makes |VisibleSelection::setWithoutValidation()| to handle in case
of |VisibleSelection::m_affinity| == |TextAffinity::Upstream| case by keeping
invariant only caret selection having |TextAffinity::Upstream|.

BUG=575568
TEST=editing/caret/set-without-validation-with-upstream-caret.html

Review URL: https://codereview.chromium.org/1581333002

Cr-Commit-Position: refs/heads/master@{#369363}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ebce338fa58c..701b2443d668

$ git log ebce338fa..701b2443d --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1589743002

Cr-Commit-Position: refs/heads/master@{#369362}

BUG=558054

Review URL: https://codereview.chromium.org/1588853002

Cr-Commit-Position: refs/heads/master@{#369361}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/302c89a0..cb9210d4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1585673004

Cr-Commit-Position: refs/heads/master@{#369360}

BUG=568486

Review URL: https://codereview.chromium.org/1582893002

Cr-Commit-Position: refs/heads/master@{#369359}

BUG=chrome-os-partner:48623
TEST=Set the "keyboard_layout" value as "ime:ko:hangul" in VPD; Goes to
OOBE screen, set the locale as Korean; Goes to Guest mode, verify the
Korean input method is the default (and the only one) input method.

Review URL: https://codereview.chromium.org/1578133003

Cr-Commit-Position: refs/heads/master@{#369358}

BUG=570588
TEST=manually

Review URL: https://codereview.chromium.org/1581933004

Cr-Commit-Position: refs/heads/master@{#369357}

Adds connection migration capability to QUIC. This CL causes QUIC connections to migrate to a new network when an old network is disconnected or about to be disconnected. These notifications are available for Android >= L, so QUIC connection migration will only work for Android >= L.

BUG=576998

Review URL: https://codereview.chromium.org/1327923002

Cr-Commit-Position: refs/heads/master@{#369356}

Previously BufferedSocketWriter was ignoring Write() calls before
Init(). Fixed it to buffer all data in that scenario. Also renamed
Init() to Start().

Review URL: https://codereview.chromium.org/1582583003

Cr-Commit-Position: refs/heads/master@{#369355}

- UseCounter::MenuItemElement
  Counts menuitem element usage.
  if chrome://flags/#enable-experimental-web-platform-features is enabled,
  HTMLMenuItemElement is used.  Otherwise, HTMLUnknownElement is used.

- UseCounter::MenuItemCloseTag
  Counts </menuitem>.  <menuitem> is a void element according to the current
  specification.  This counts wrong usages like crbug.com/412945.

BUG=412945

Review URL: https://codereview.chromium.org/1587673005

Cr-Commit-Position: refs/heads/master@{#369354}

This change adds SVGLengthListInterpolationType to enable additive
and neutral Web Animation keyframes for SVG attributes: x, y, dx, dy

This is a continuation of: https://codereview.chromium.org/1535523002

LayoutTests have been updated to test lengths, length lists and numbers
separately on these attributes.

BUG=530436

Review URL: https://codereview.chromium.org/1587533002

Cr-Commit-Position: refs/heads/master@{#369353}

BUG=576750

Review URL: https://codereview.chromium.org/1582843003

Cr-Commit-Position: refs/heads/master@{#369352}

Re-landing after first attempt was reverted:

https://codereview.chromium.org/1548523002/

TBR-ing, the only change is adding the missing visitor->trace().

BUG=570538
TBR=ojan@chromium.org,kinuko@chromium.org

Review URL: https://codereview.chromium.org/1582993002

Cr-Commit-Position: refs/heads/master@{#369351}

BUG=561867

Review URL: https://codereview.chromium.org/1563763002

Cr-Commit-Position: refs/heads/master@{#369350}

Previously, the mojom bindings generator would use the jinja template
files directly, requiring relatively expensive conversion to Python
bytecode once for each mojom file. This adds template precompilation
and changes the generator to use the precompiled bytecode.

On a z620 running Linux, generating all mojo bindings using GN
Before:
real	0m11.729s
user	4m22.588s
sys	0m6.003s

After:
real	0m2.948s
user	0m33.126s
sys	0m4.564s

GYP (many mojom files are only used in GN builds)
Before:
real	0m9.822s
user	0m49.949s
sys	0m1.046s

After:
real	0m5.354s
user	0m4.776s
sys	0m0.998s

Review URL: https://codereview.chromium.org/1572213002

Cr-Commit-Position: refs/heads/master@{#369349}

There isn't much that uses bit_cast. bit_cast requires memcpy which
requires <string.h>

On Mac, <string.h> includes AvailabilityInternal.h which is half a
megabyte and defines dozens of macros. Providing <string.h> in
base/macros.h also tempts IWYU violations. Try to avoid it.

Add base/bit_cast.h and include it from the 17 files that need it. Then
remove the <string.h> #include from base/macros.h and IWYU.

BUG=395001

Review URL: https://codereview.chromium.org/399313006

Cr-Commit-Position: refs/heads/master@{#369348}

Since panels have a promoted -[NSWindow level], OSX prefers them to
browser windows when it needs to activate a window. One case this
happens is whenever an autofill popup is dismissed (e.g. when tabbing
between text fields on a web page).

Sometimes, a panel window may be activated in this case since it thinks
it was the "previous" key window, when actually it was a browser window.

The "previous" key window case doesn't really seem to add much. So
remove it. It means that a panel can lose focus (and not immediately
regain it) when another panel window is closed, but that seems
preferable to tabbing into a Hangouts chat window instead of a password
field when a username autofill popup is dismissed. (Note it doesn't
happen if a *browser* window is closed, since the native close button
doesn't activate a window, but the non-native hangouts close button
does).

The "allow previous" logic was included in r127517 (to fix
http://crbug.com/112038). Closing hangouts windows seems to be the only
use case it supports, and I don't think that use case will be missed.

BUG=546509, 112038

Review URL: https://codereview.chromium.org/1575743003

Cr-Commit-Position: refs/heads/master@{#369347}

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None

Review URL: https://codereview.chromium.org/1558413002

Cr-Commit-Position: refs/heads/master@{#369346}

The new audio player has 4px top padding, which is shown white under the window header.
The window size calculation didn't consider it, which causes issues.
- Playlist height grows (issue 576622)
- Scroll bar can be shown when it shouldn't be.
This CL fixes the calculation.

BUG=576622
TEST=manually

Review URL: https://codereview.chromium.org/1576093006

Cr-Commit-Position: refs/heads/master@{#369345}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dd08748a..302c89a0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1582943004

Cr-Commit-Position: refs/heads/master@{#369344}

BUG=295792

Review URL: https://codereview.chromium.org/1579253003

Cr-Commit-Position: refs/heads/master@{#369343}

BUG=none

Review URL: https://codereview.chromium.org/1586853003

Cr-Commit-Position: refs/heads/master@{#369342}

BUG=538612

Review URL: https://codereview.chromium.org/1581083004

Cr-Commit-Position: refs/heads/master@{#369341}

BUG=577010

Review URL: https://codereview.chromium.org/1580653006

Cr-Commit-Position: refs/heads/master@{#369340}

BUG=577246

Review URL: https://codereview.chromium.org/1586863002

Cr-Commit-Position: refs/heads/master@{#369339}

Done by running third_party/polymer/v1_0/reproduce.sh.

Fixes compile error found in https://codereview.chromium.org/1521433002/

BUG=none

Review URL: https://codereview.chromium.org/1561893002

Cr-Commit-Position: refs/heads/master@{#369338}

Part 3 of several.

Adds Chrome specific strings, which are gated to Chrome branded builds.

BUG=560457

Review URL: https://codereview.chromium.org/1573333002

Cr-Commit-Position: refs/heads/master@{#369337}

Handle the case when the display route for a device the user is currently viewing controls for is updated to a different route.

BUG=577335

Review URL: https://codereview.chromium.org/1587803002

Cr-Commit-Position: refs/heads/master@{#369336}

This patch fixes not to break surrogate pairs when word-wrap:
break-word with fit-content.

This combination needs a larger fix in crbug.com/380667, but this fix
is small enough to take at this point, and it is reasonable to handle
trailing pairs when we handle leading pairs.

BUG=574577

Review URL: https://codereview.chromium.org/1575333002

Cr-Commit-Position: refs/heads/master@{#369335}

This function is that calculate distance squared between
Rectangle and Point.

BUG=445329

Review URL: https://codereview.chromium.org/1580363002

Cr-Commit-Position: refs/heads/master@{#369334}

MediaRecorder is supposed to fire an Error event if the amount
of tracks of the associated MediaStream varies. This CL adds
monitoring of said amount and Error firing.

There's no need to stop the MediaRecorder: adding a Track
would not start automatically recording it, and removing it
guarantees it would not be recorded not recording. Moreover,
the spec does not say if MRecorder should stop if the
#Tracks varies, and also instructs to throw an Exception,
which is not possible since the error is asynchronous.

Also this CL removes superfluous test variables.

BUG=545156

Review URL: https://codereview.chromium.org/1578973002

Cr-Commit-Position: refs/heads/master@{#369333}

This is to keep LSAN bots happy.

BUG=561803,574325
TBR=ben

Review URL: https://codereview.chromium.org/1589693002

Cr-Commit-Position: refs/heads/master@{#369332}