- 26 Jun, 2019 40 commits
-
-
Robert Ogden authored
Timeouts count as a failed attempt. I'm not using the SimpleURLLoader timeout because I can't set it's TickClock for testing without calling SetTickClockForTesting in the production code. Bug: 977603 Change-Id: I6c4c6d0ebbc10f95942ca0e83011270735216c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679222 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#672707}
-
Evan Liu authored
Allow Chrome users on platform that do not have system caption styling to provide a default styling for WebVTT captions displayed by Blink. This should affect Chrome OS and Linux as Windows, macOS and Android have system settings. Design doc: https://docs.google.com/document/d/1wgKMbvP8nJkUKXkwnh5iEajSa4GHxDURL8kHIyHEO4s/edit?hl=en# Bug: 976966 Change-Id: I41282753305b81f76e6b3f565516160cd63d69f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656714Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#672706}
-
Fabrice de Gans-Riberi authored
Add the |enable_remote_debugging_on_port| build flag for Fuchsia builds. When set to a non-zero value, the WebRunner and CastRunner packages publish a DevTools service listening on this port. Bug: 973268 Change-Id: If9d78bdde06c25f59063afb62b204e76d3ad8853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677593Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#672705}
-
li authored
Bug: b/129715312 Test: Manual Test Change-Id: I15bee4721a8133913fffa73f28ac53566005368e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679057Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672704}
-
Alexei Svitkine authored
Bug: None Change-Id: I56a7735ce113d7988d2e20f07d83efc3a602ad9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670876 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#672703}
-
Mostyn Bramley-Moore authored
depot_tools seems to have gsutil.py but no gsutil. BUG=978360 Change-Id: Ib17e3b86e4cf0592a34dcb89224e6ab4d6ecdf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678322Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#672702}
-
Kyle Horimoto authored
A previous CL [1] used a newly-added string as part of the <network-proxy-exclusions> element. This element is shared between both the settings page and the Internet detail dialog. However, the newly-added string was only added to the WebUIDataSource belonging to settings and was not added to the dialog's. This CL fixes this crash by adding the string to the shared chromeos::network_element::AddDetailsLocalizedStrings() function instead. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1669183 Bug: 978762 Change-Id: Ibc5f06d6f3db71b06e55c8c96e717fb08c4d42ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679099 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672701}
-
Wez authored
Bug: 969252 Change-Id: Ia54129af9dbcb727aab1d3289be997a31143e004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649186 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672700}
-
Mandy Chen authored
This patch fills in the 'desc' tag for each <message> in the changes tab with auto-generated descriptions. Regarding the quality of these descriptions. Our plan is to fix descriptions that result in poor translations as reported by our translation team and end users. Follow-up patches will be made to add descriptions to other grdp files. Bug: 941561 Change-Id: I838baac8eb55f79a53e0f1e251713bc5a7237da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678842Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#672699}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b2367291125..54e38e370156 git log 2b2367291125..54e38e370156 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 saklein@chromium.org Build API: Added method discovery service. Created with: gclient setdep -r src/third_party/chromite@54e38e370156 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I90bf0cccc743016588139e9feb385f9231a0c795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672698}
-
Khushal authored
This was added to collect data about how often the compositor rasterizes downscaled images and the data is not required anymore. R=ericrk@chromium.org,holte@chromium.org Bug: 975326,976133 Change-Id: Id8224e1cb9653439dd93eb11126d19c6c44e547b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670276 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Chris Palmer authored
Bug: 978888 Change-Id: Ib16b2e35c2f88e7f554611b21bda48857127c77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678937Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#672696}
-
Manu Cornet authored
The |StatusAreaWidget| class implements this observer interface and gets registered as an observer but it never does anything with it. Bug: 973443 Change-Id: I060cc3477587edfec2d9ecd9f79496a517d9c774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679432Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#672695}
-
Lan Wei authored
For smart boards, the devices are receiving some touch move events when there is no finger touching on the screen, like hovering. For those touch move events, we do not release their ids. We should check if the touch pointer are in contact with the screen, if not, release the ids for these touch move events as well. Bug: 874948 Change-Id: I61f7cb75f92eb600b0dbbbd8f9fb7184c6c0bda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670159 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672694}
-
Rakib M. Hasan authored
If a test expectations non glob pattern is shorter than any test name then the presubmit check should raise an exception because the test expectation is for a non existing test. This CL will update CheckTestExpectationsAreForExistingTests so that it raises an exception when it finds one of these test expectations. Bug: chromium:978712 Change-Id: Ic80efccca659b7f35a345ebb187fb7dab08c423f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677510 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672693}
-
François Doray authored
This histogram is already scheduled to expire in M77 due to nobody looking at it. Bug: 970008 Change-Id: I746704ffc678233635e751af09d4a52261710865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649686 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#672692}
-
Nicolás Peña Moreno authored
The timestamp captured at onload does not seem to always be smaller than the render timestamp. This CL changes the lower bound so the test is no longer flaky. Bug: 978587 Change-Id: I48c058ac0abb684cb4406617500356d0aae019e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678836 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#672691}
-
Edward Jung authored
- Billing - Look alike URLs - Supervised users Screenshots can be see in: https://bugs.chromium.org/p/chromium/issues/detail?id=947840#c29 Bug: 947840,978833 Change-Id: I02ee5364bbf5747158090568b6959caead36265a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676130Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#672690}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/11cf0a3029ed..cff2a5619b04 git log 11cf0a3029ed..cff2a5619b04 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 zoddicus@users.noreply.github.com Catch low level exceptions instead of crash (#744) Created with: gclient setdep -r src/third_party/shaderc/src@cff2a5619b04 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Iad56a981d9550fcecf74ca4323d5040ae72dddf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678853Reviewed-by:
-
Joe DeBlasio authored
Previously, the Page Info bubble maintained a single variable to identify all reasons that a page might have a non-standard status. This lead to the display logic making assumptions about, for instance, the validity of a certificate when the page was flagged by Safe Browsing. This CL separates out the Safe Browsing status from the site identity status so that the page info bubble can inform the user that the site's certificate is invalid, even if it's also flagged by Safe Browsing. This reland includes fixes to prevent use of uninitialized memory. Bug: 869925 TBR: meacer@chromium.org TBR: bsep@chromium.org Change-Id: I237da104427002cce6972b3fdc30656c682b5e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678818 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#672688}
-
Andres Medina authored
Allowed a new type of media block that blocks cast_renderer initialization instead of webmediaplayer loading. Test: Manual test blocking is happening at the renderer by inspecting device logs Bug: b/134961542 Change-Id: I97b0e59a6752c43d14b8e96327079aa8669b1c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673829Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#672687}
-
Dale Curtis authored
We almost never have a valid pixel format anymore, so many places just hardcode it to I420 regardless of what's in the file. It's not used for anything, so just go ahead and remove it from the VideoDecoderConfig. What we do need is a signal about the presence of an alpha channel, so just use that directly instead of guessing at it based on the format. BUG=none TEST=bots pass R=sandersd Change-Id: Ifbd2357255650366d2bae0fa1fba1cfcbf01671d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673582 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672686}
-
Kurt Horimoto authored
Previously, when the OverlayPresentationContext's coordinator is reset, the presented UI was dismissed without notifying the presenter. This CL updates the implementation to have OverlayPresenter drive the dismissal when the coordinator is reset. This allows for the presenter to be aware of all presentation/dismissal events so that its observers can be notified when they occur (e.g. at the end of the tab grid => BVC transition animation). To pipe this information back to OverlayPresenter, the presentation context exposes IsActive(), which describes whether the context is currently able to present. When a coordinator is provided to the context implementation, it notifies the presenter via observation that it has become active, which triggers presentation. When the coordinator is reset to nil upon the BVC leaving the window, the presenter is again notified via observation that the context is deactivating, which triggers dismissal. Bug: 941745 Change-Id: If06a9cd2aed18f34cf820423b42f24df78d22eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672173 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#672685}
-
Mohamed Heikal authored
Latest aapt2 is required for enabling resource path shortening. This also fixes an xml resources size regression for bundles where raw xml values were being unnecessarily kept. reason for reland: Fixed data_dep on removed libc++.so Original CL: > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669171 > Cr-Commit-Position: refs/heads/master@{#671827} This reverts commit f063a96b. Bug: 978664, 753402, 912804 Change-Id: Ifaa6fb44fe9fd3bebd388d88aa53a581cebae543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678944 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#672684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e6505e6392f..b46998c50dd4 Created with: gclient setdep -r src-internal@b46998c50dd4 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: Ia8e8aeb0a782a5454f11143f08b0a05f27973e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672683}
-
Dale Curtis authored
ReadyState has never been suficient to test whether a video frame is actually present. Instead we need to know when the frame has actually been delivered to the compositor. This patch updates HTMLVideoElement to query a new WebMediaPlayer method which exposes the compositor's knowledge of the video frame. Note: This patch also fixes some spurious logs and HTMLVideoElement tests that were silently doing nothing. BUG=974012,974190 TEST=new unittest. TBR=eae Change-Id: I1df54491c1fd7c2246ce0f60bc6e794b8b84476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659490 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Aaron Colwell authored
- Added code that enables the default SiteInstance to use an unmatched service worker process for a site that is handled by the default SiteInstance. - Remove default SiteInstance specific conditions from tests that were testing process reuse and unmatched service worker process behavior. - Added code to BrowsingInstance that tracks what site URLs are associated with its default SiteInstance. This allows process reuse to be constrained to sites explicitly associated with a specific default SiteInstance. Bug: 958060 Change-Id: I9ce95dbd5ecc192cba8cd4e6046787d248ff3532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668449Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#672681}
-
Lukasz Anforowicz authored
Bug: 940785 Change-Id: I46be52c2b5e9a6e1311681f25b9a38e1562a23a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678161 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Intent to implement and ship: http://bit.ly/2J75JAQ Bug: 825895 Change-Id: Ib5ed82072e189f8c99f5ebc157127d389bf87375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678883 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#672679}
-
James Cook authored
Web page translations are a browser feature, not an OS setting. This code isn't used by OS settings, so remove it. There is more to remove here (language ordering in particular), but this is a first step. Bug: 967965 Test: manual, closure compiler Change-Id: Id7f95e2a6c88d9b5d086944736630aa38d4bc3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676616 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672678}
-
Sebastien Marchand authored
There's still a few left that I'll clean when moving this to performance_manager/ Bug: 977554 Change-Id: I6590c7cd188d656e0d36dd9aa7568f3d54e57d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670308 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Ken Rockot authored
ServiceProcessHost allows Content and its embedders to launch a new service process for any given mojom service interface. This CL wires up the support and converts a single test-only service to use ServiceProcessHost instead of integrating with Service Manager. Bug: 977637 Change-Id: I63e846bf816c51ba2c557bfdc8b41189a92d2890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673922Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#672676}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/751252e3724b..ebcf0d31c012 git log 751252e3724b..ebcf0d31c012 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 cwallez@chromium.org Add missing Reference count in null Device. Created with: gclient setdep -r src/third_party/dawn@ebcf0d31c012 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel BUG=chromium:976573 TBR=cwallez@google.com Change-Id: Ic2ed74c088756b027ecc388ccde190c88dfa6d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678268Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e269a0babac..1ff9ce92d17a git log 6e269a0babac..1ff9ce92d17a --date=short --no-merges --format='%ad %ae %s' 2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1ff9ce92d17a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I518b74baaf32f63e05668cce649a84c7defb5f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678272Reviewed-by:
-
Ben Kelly authored
In order to move cache_storage off the IO thread we must implement some cross-sequence glue code with the blob subsystem. Response and request bodies are returned as blobs. The blob subsystem, however, only works on the IO thread. This CL makes the DiskCacheBlobEntry a cross-sequence object that receives read requests from the blob code on the IO thread and then executes the operation on the cache_storage sequence. This CL also refactors the CacheStorageCacheEntryHandler a bit to reduce code duplication between cache_storage and background_fetch by moving it into the CreateBlob*() methods. Having a single place for creating blobs also makes it easier to support the cross-sequence initialization. This CL also fixes some problems with the cache_storage initialization code. It needs to make an explicit task hop to the IO thread to get the BlobStorageContext WeakPtr before passing it on to the manager. Bug: 960012 Change-Id: Ib9e57c9a637498e73a1f0a334d1cd90ff9450554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667623Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#672673}
-
Maks Orlovich authored
It's only used in some tests, and for those PartialCompare is sufficient, as it looks at all the fields for the key of the cookie database. Change-Id: I8b7fa9f86a21e4ed9afc85bd2e1f89e246fef83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678758Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#672672}
-
Peter Boström authored
Prevents GetWidget()->GetRootView() returning null during views hierarchy teardown. Bug: None Change-Id: I98833cb660ef6b9d30600e3805560926b186593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679349Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#672671}
-
Will Harris authored
Removed: ChildProcess.InvalidSandboxStateCrash.NoStartupWindow Windows.InCompatibilityMode These are all still used for stability regressions: BrowserRenderProcessHost.DisconnectedAlive BrowserRenderProcessHost.ChildLaunchFailureCodes ChildProcess.DisconnectedAlive2 BUG=975997,975199,975095 Change-Id: I4a63a9aa327b3994454c0ee4d81628335c7802d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662975Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#672670}
-
danakj authored
Without this, state persists between tests, which of course causes failures. R=sky@chromium.org Bug: 961849 Change-Id: Ie74936ebfed4bacfa721dcba446905f4fe770faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677591 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Evan Stade authored
This was used to close the collected cookies dialog (accessible from OIB) when clicking on the link in the content settings bubble. To test, 1. block some cookies on some site 2. reload site 3. open OIB, click Cookies 4. click on blocked cookie icon to open bubble 5. click on the link (which attempts to show the already-open dialog) Previously, this would destroy the dialog and re-create it. Now, we just focus the already existing window. The NotificationService notification wasn't very useful as it immediately preceded the call to open the new dialog, and hence can pretty much just be dropped. The rest of the changes here are polish. Bug: 268984 Change-Id: Ib88b7fd7f9a9eaba394498ca7147e116aafe4936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674707Reviewed-by:
-
