GitLab

BUG=664943

Review-Url: https://codereview.chromium.org/2514753002
Cr-Commit-Position: refs/heads/master@{#435085}

Also: Ensure all HasInitialStabilityMetrics methods get called as they
may do other setup.

BUG=546019

Review-Url: https://codereview.chromium.org/2524363003
Cr-Commit-Position: refs/heads/master@{#435084}

Since "Learn more" should show up unconditionally, this CL also removes the
include_details_label_link calculation/parameter.

BUG=646465

Review-Url: https://codereview.chromium.org/2506473002
Cr-Commit-Position: refs/heads/master@{#435083}

BUG=chromium:663372
R=stip@chromium.org

Review URL: https://codereview.chromium.org/2536213002 .

Cr-Commit-Position: refs/heads/master@{#435082}

New console.assert implementation is faster then any hacks.

BUG=chromium:663845
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2525543002
Cr-Commit-Position: refs/heads/master@{#435081}

BUG=669593

Review-Url: https://codereview.chromium.org/2539833003
Cr-Commit-Position: refs/heads/master@{#435080}

Scrolling/Fling speed is reduced to match with the UX prototypes.

BUG=

Review-Url: https://codereview.chromium.org/2539873003
Cr-Commit-Position: refs/heads/master@{#435079}

Revert of Insert logcat as part of test result for android instrumentation tests. (patchset #12 id:220001 of https://codereview.chromium.org/2451523002/ )

Reason for revert:
breaking on chromium.android: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/6567

Original issue's description:
> Insert logcat as part of test result for android instrumentation tests.
>
> In this cl, we are trying to add the logcat of each instrumentation
> test into the corresponding test result object, so that when we are
> checking the result of each test case, we would be able to see the
> corresponding logcat for that test case at the same time.
>
> BUG=631213
>
> Committed: https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3
> Cr-Commit-Position: refs/heads/master@{#435041}

TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631213

Review-Url: https://codereview.chromium.org/2539953002
Cr-Commit-Position: refs/heads/master@{#435078}

Part of the WTF Headers Audit, and needed for moving PartitionAllocator to base.

BUG=632441
R=danakj@chromium.org, yutak@chromium.org

Review URL: https://codereview.chromium.org/2525723004 .

Cr-Commit-Position: refs/heads/master@{#435077}

Changelog:
[ea4e050] SyzyAsan - Support the allocations with a size > 1GB.
[a1f6aa6] SyzyAsan - Remove support for the nested allocations.

BUG=656554

Review-Url: https://codereview.chromium.org/2537223002
Cr-Commit-Position: refs/heads/master@{#435076}

This CL is part 2 of changing Chrome Apps device permissions dialog
using the same chooser dialog as WebUSB and WebBluetooth.

I uploaded some screenshots on the issue page.

BUG=652445, 653228

Review-Url: https://codereview.chromium.org/2390823005
Cr-Commit-Position: refs/heads/master@{#435075}

These tests would flake through timing out while waiting for a switch to
be toggled. The toggle was triggered through a synthetic touch event
sent to the switch view. Observing the flake would reveal that the
switch stayed in its original position after the touch event was sent,
so the hypothesis is that the touch event was sent prior to the view
being ready to respond to it.

This CL deflakes the tests by replacing the touch event for triggering
the toggle with an explicit toggle() call on the SwitchCompat object.
This no longer simulates the user input, but the tests should now
reliably pass.

This CL also corrects the arguments used for
MediaTest#testCombinedPersistenceOffDialog to match those of
MediaTest#testMicrophonePersistenceOffDialog.

BUG=662294,663677,668700

Review-Url: https://codereview.chromium.org/2538603002
Cr-Commit-Position: refs/heads/master@{#435074}

https://codereview.chromium.org/2405453002 fixed some of it, but there
were still others. The subtractions to pick a different starting point
for the year and month may also underflow.

BUG=668445

Review-Url: https://codereview.chromium.org/2532243005
Cr-Commit-Position: refs/heads/master@{#435073}

The last usage is breakpoint-manager.html, which gets it inlined.

BUG=none

Review-Url: https://codereview.chromium.org/2540803003
Cr-Commit-Position: refs/heads/master@{#435072}

This CL:
- Moves out all export logic into its own class, TestExporter
- sync_wpt.py is still a shell that sets up all the classes and calls TestExporter
- Changes the 'exportable' logic to honor NOEXPORT=true
- Renames GitHub to WPTGitHub
- Adds a bunch more unit tests

This CL has not yet been tested on a real export. I hope to do a real export soon and improve/fix the code in the process.

BUG=666809
BUG=666884

Review-Url: https://codereview.chromium.org/2518313003
Cr-Commit-Position: refs/heads/master@{#435071}

In cases of mirroring cast requests where the user cancels the media
request dialog, provide a route request result code that distinguishes
other errors from a user-triggered cancellation. The return code is
added to sync up the necessary files with the Media Router component
extension code.

Review-Url: https://codereview.chromium.org/2522983002
Cr-Commit-Position: refs/heads/master@{#435070}

Revert of Add a crash key to record whether a windows machine is domain joined. (patchset #3 id:60001 of https://codereview.chromium.org/2514483002/ )

Reason for revert:
Reverting this; it appears to be causing 140+ failures in telmetry tests on Win7 (See the failures in https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55150/steps/telemetry_unittests%20on%20Windows-7-SP1/logs/stdio )

As far as I can tell (the log output is being suppressed,) it looks it's hitting the DCHECK in SetCrashKeyValue that would indicate that the key isn't registered as expected.

Also filed https://bugs.chromium.org/p/chromium/issues/detail?id=669633

Original issue's description:
> Add a crash key to record whether a windows machine is domain joined.
>
> BUG=660868
>
> Committed: https://crrev.com/bf33256aee8db58c30b9d36e991055f2a4ed62a4
> Cr-Commit-Position: refs/heads/master@{#435018}

TBR=siggi@chromium.org,sky@chromium.org,georgesak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660868

Review-Url: https://codereview.chromium.org/2536293002
Cr-Commit-Position: refs/heads/master@{#435069}

BUG=chromedriver:1617

Review-Url: https://codereview.chromium.org/2533963002
Cr-Commit-Position: refs/heads/master@{#435068}

Motivation: memory_infra is a team name, and should not be used as a way to name
a benchmark suite about memory.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2537153002
Cr-Commit-Position: refs/heads/master@{#435067}

It will allow the browser process to create a renderer with the right
settings, thus exposing the presentation.receiver object.

BUG=647296
R=mfoltz@chromium.org

Review-Url: https://codereview.chromium.org/2500273003
Cr-Commit-Position: refs/heads/master@{#435066}

- This CL adds AshDevToolsDOMAgent as an observer to all widgets and views.
The WidgetRemovalObserver is specifically to remove the RootView subtree,
while the ViewObserver is to update any other descendant views.
AddViewTree was created so that whenever any |view| is added, it can
be pushed to the frontend.
- Add tests for when views are inserted, removed, rearranged,
removed & inserted.
- Add test to check if a widget owned by a native widget is represented
properly in the DOM.

BUG=648701

Review-Url: https://codereview.chromium.org/2537163002
Cr-Commit-Position: refs/heads/master@{#435065}

BUG=651965
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2388393002
Cr-Commit-Position: refs/heads/master@{#435064}

Previously when Ctrl-C is pressed the script would print a message that
says it was interrupted, but wouldn't actually quit. Added explicit
exit(1) call in sigint_handler() to ensure it quits as expected.

Review-Url: https://codereview.chromium.org/2537673002
Cr-Commit-Position: refs/heads/master@{#435063}

NSWindow resizing is slow, so try to guess the right size when first creating
the window. Furthermore, resizing the window will create implicit animations for
the Window's views and layers. Disable those implicit animations.

BUG=667511

Review-Url: https://codereview.chromium.org/2539863002
Cr-Commit-Position: refs/heads/master@{#435062}

The translate ranker enforcement flag was redundantly enforced
within the ranker itself, thwarting the TranslateManagers attempts
to log the ranker result and enforc (or not) the result. The
check in the TranslateRanker should have been removed in the
last refactor.

BUG=669528

Review-Url: https://codereview.chromium.org/2533953003
Cr-Commit-Position: refs/heads/master@{#435061}

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

BUG=546060

Review-Url: https://codereview.chromium.org/2518403005
Cr-Commit-Position: refs/heads/master@{#435060}

The test has been failing intermittently on ChromeOS.

BUG=668335
TBR=kcarattini

Review-Url: https://codereview.chromium.org/2540793002
Cr-Commit-Position: refs/heads/master@{#435059}

https://pdfium.googlesource.com/pdfium.git/+log/05e016984447..708ef623c2e9

$ git log 05e016984..708ef623c --date=short --no-merges --format='%ad %ae %s'
2016-11-29 npm Do not clone in CPDF_ImageCacheEntry::GetCachedBitmap

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2538813002
Cr-Commit-Position: refs/heads/master@{#435058}

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits(). The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.

No Wait (default):
  The task does not wait on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191

Review-Url: https://codereview.chromium.org/2534513002
Cr-Commit-Position: refs/heads/master@{#435057}

This can be useful for serializing/deserializing ui::CompositionText, etc.

BUG=NONE

Review-Url: https://codereview.chromium.org/2531323002
Cr-Commit-Position: refs/heads/master@{#435056}

Mostly a matter of tweaking destruction order in test and adding an
additional flush instead of depending on ~MediaStreamManager() implicitly
flushing MediaStreamManager::video_capture_thread_().

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after that
fact.

BUG=653916

Review-Url: https://codereview.chromium.org/2535043003
Cr-Commit-Position: refs/heads/master@{#435055}

WithWait() tasks are allowed to wait on other things than file I/O. In
particular, they may wait on a WaitableEvent or a ConditionVariable, join a
thread or a process, or make a blocking system call that doesn't involve
interactions with the file system.

In upcoming CLs, this trait will be used in scheduling decisions (more
details on the bug).

BUG=669247

Review-Url: https://codereview.chromium.org/2531663003
Cr-Commit-Position: refs/heads/master@{#435054}

Remove useless class and struct forward declarations, and add
missing ones in net header files.

BUG=662195

Review-Url: https://codereview.chromium.org/2531373002
Cr-Commit-Position: refs/heads/master@{#435053}

Increase the max ranger to 100M.

BUG=
R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2498703002
Cr-Commit-Position: refs/heads/master@{#435052}

Now we can click while scrolling. The scrolling stops and Tap is sent.

BUG=668518

Review-Url: https://codereview.chromium.org/2533493002
Cr-Commit-Position: refs/heads/master@{#435051}

The IOSurface wasn't being released when the Canvas2DLayerBridge was destroyed
before the texture was returned.

BUG=662696

Review-Url: https://codereview.chromium.org/2537003002
Cr-Commit-Position: refs/heads/master@{#435050}

BUG=669597
TBR=dbeam@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2535293002
Cr-Commit-Position: refs/heads/master@{#435049}

This was causing the braille captions to not show up since change r431444.

BUG=669255
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2532003004
Cr-Commit-Position: refs/heads/master@{#435048}

Includes a working test case and basic functionality. Much more to come.

BUG=

Review-Url: https://codereview.chromium.org/2528483004
Cr-Commit-Position: refs/heads/master@{#435047}

https://skia.googlesource.com/skia.git/+log/e18c97b73a03..56b50792531c

$ git log e18c97b73..56b507925 --date=short --no-merges --format='%ad %ae %s'
2016-11-29 mtklein Make gather() look and work more like load().
2016-11-28 mtklein Use /MD for Windows builds.
2016-11-29 mtklein document x_tail encoding
2016-11-29 bsalomon Reland image storage with fixes.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2536193003
Cr-Commit-Position: refs/heads/master@{#435046}