GitLab

TBR=smut

Change-Id: I7a5aec9475404019a1ffe91941f53d2190c7477d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626932Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662486}

As part of the migration from Talk to FTL, we need to fetch new OAuth
tokens with additonal scopes. This fetching will happen in the network
process, which has no filesystem access. This new message will allow the
network process to inform the daemon process of the new token, so the
daemon process can update the on-disk config file accordingly.

Bug: 954427
Change-Id: I59d0498abe9d31c4789a95ff1371d700728eabca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625925Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662485}

https://chromium.googlesource.com/catapult.git/+log/dad31e0cc1e9..4d346fbec70e


git log dad31e0cc1e9..4d346fbec70e --date=short --no-merges --format='%ad %ae %s'
2019-05-23 benjhayden@chromium.org Add butterbars to /report and /group_report


Created with:
  gclient setdep -r src/third_party/catapult@4d346fbec70e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:918193
TBR=eyaich@google.com

Change-Id: Iedfe94cbbe7a5b2dcfb27558e3c1e4a91a1fe50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626694Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662484}

* Change the redirect URI to the new non-talk one.
* Remove the ME2ME OAuth scope check in OAuthTokenExchanger since it
  breaks IT2ME and test binaries.

Change-Id: I36e7778a9ee7a42ea77719277784bab2eb294a5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626400
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662483}

The fix at r662120
https://chromium-review.googlesource.com/c/chromium/src/+/1624074 was
insufficient to stop the bot failures. Convert more PostTaskWithTraits
to using a TaskRunner instead.

Bug: 963702
Change-Id: I57768cc53e9c6069acba19590a1dcbae19eda4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626195Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662482}

Replace gfx::AnimationDelegate with views::AnimationDelegateViews.
This will help gfx::AnimationContainer be driven by ui::Compositor.

TODO:
* files under ash/
* other files which can't use AnimationDelegateViews.

Bug: 953585
Change-Id: I39279bcc779c72bedb26f8c1e43661f0a0a9691d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616921Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662481}

Previously we couldn't capture OnceCallback because they are non-copyable.
Now that we allow capture expressions we can capture it by moving it
into the lambda.

Change-Id: I436d3d572cb7609b739acc518c7beb8fc5c73364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626054
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Auto-Submit: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662480}

This also fixes a few cases of not using =default, and uses STL algorithms where
it makes sense.

Bug: 940126
Change-Id: I509e832644893e409e37ff4550d594a0f3455c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625898
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662479}

ParseForms function was changed to OnFormsParsed and
it is not used anymore.

This patch removes unused function in autofill manager.

Bug: None
Change-Id: Ia9a887d7d506f11b5c2c943388d89d39fc74015b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624012Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#662478}

This CL adds the BackgroundTaskCoordinator class, which determines the
time that background task should run.

TBR=peter@chromium.org

Bug: 963283,930968
Change-Id: I82ecd3bb15ac2df73a546afa94c25fad5fded36d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614501
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662477}

https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/59d58d345f96..2a20a6899d0b


git log 59d58d345f96..2a20a6899d0b --date=short --no-merges --format='%ad %ae %s'
2019-05-22 featherless@google.com Merge branch 'release-candidate-hotfix' into stable


Created with:
  gclient setdep -r src/ios/third_party/material_components_ios/src@2a20a6899d0b

The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc
TBR=bling-p10-rolls@google.com

Change-Id: I5e1ac10c76463b307803bf8e57da39af2ec44171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626142Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662476}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c38aa9eb8666..2441fff8d6ff


Created with:
  gclient setdep -r src-internal@2441fff8d6ff

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: I61dcd6362bdd6b57b99ebe70f8ce7b3d96a8f014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626040Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662475}

Bug: 922813
Change-Id: I93ac2d5becdbc2a7109a67051e0cad46eb675adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625861Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662474}

When renaming a file, Windows will use an intermediate name and leave
that file around if the final destination name already exists.  These
files are unknown to Chrome and so tend to accumulate which is a
problem when the files are 1MB "metrics" files.

Bug: 934164
Change-Id: I30fa0d81db81af411d7c8775f389206904062412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611104
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662473}

This changes the discovery sessions to be tracked in a seamless way
across all platforms by moving the logic to the parent adapter class
and only passing the proper filter to the platform specific StartScan
functions.  This was needed in order to properly move bluetooth
filtering to the Android operating system(which will follow) and
is a cleaner workflow that is more easily followed.

Change-Id: I79bd02229762db67cbcf3c183fed3b9320643c48
Bug: 490401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480113
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662472}

Using wpt-import in Chromium 69ec0a08.
With Chromium commits locally applied on WPT:
c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed"
fec827fb "Added wpt tests for overscroll customization."
c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet"
d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions"
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
8e9cad0d "Cookies WPTs: Add test coverage for SameSite=None"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I09e6900a968293768ff3fd24bebf1322c0fb03e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626736Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662471}

There was only one caller and the pointer was used immediately
so returning raw pointer instead.

Bug: 940840
Change-Id: I4e8efaa214370a7dbd4bb9096322dd58030d2a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625274Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#662470}

This CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1600078

... inadvertently changed the behavior of
LocalFrameView::CrossOriginStatusChanged -- specifically, in the
case where an iframe becomes cross-origin and that causes it to
become throttled.

BUG=962382

Change-Id: Ida7e6f57694abe2cbc991446890386b3b4e9ac79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613707Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662469}

This patch fixes shutdown and ownership issues, which are needed for
Scopes integration. It:
* Refactors the IndexedDBFactoryImpl to have a per-origin factory,
* Creates a more explicit ownership and shutdown flow for the factory,
* Creates a more explicit shutdown flow for the databases,
* Makes most objects no longer refcounted in the IndexedDB codebase.

Doc:
https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.91yfo2eejgg8

Bug: 903515
Change-Id: Ic41e631d48cb4f045ef0d53037d341096bf046b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570815
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662468}

Change-Id: Ida47aef91ba5f1e424887ade29d94b5290354519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626453Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662467}

Bug: 944162
Change-Id: Ida4c249129686077b15ba9d2c246bcaf8067977e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603964
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662466}

Currently files toast will hide any existing toast
and display the new one if it is called whilst an existing
toast is being displayed.

This change creates a queue for toasts, and all are displayed
in order.

Bug: 949356
Change-Id: I44d531295eef5845fe5fb1fc7f313ebce38ad8f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617044Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662465}

Note:  The code that uses these strings is in a different WIP CL that
will follow this one.

Bug: 927957
Change-Id: Ia77dc06bd4fe4ecb8125360a259fe3571b9c0756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623532
Commit-Queue: Danan S <danan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662464}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/1b65f4e86204..779c4f0f8488

$ git log 1b65f4e86..779c4f0f8 --date=short --no-merges --format='%ad %ae %s'
2019-05-22 crouleau [Swarming Client] Print links to tasks after they are triggered.
2019-05-22 maruel [client] Enable specifying containment-type for trigger
2019-05-14 maruel [client] Disable ssl platform warning
2019-05-07 maruel Update client/third_party/depot_tools
2019-05-07 maruel Revert "[client] Clean up stale cacert.pem and cacerts.txt and use the one in certifi"

Created with:
  roll-dep src/tools/swarming_client

R=maruel@chromium.org

Bug: 965222
Change-Id: Ic6128afe904a6001cf6f5c5f6f20d271affd051c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625832Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662463}

Now that the IDBDatabase.GetAll method no longer uses the
IDBCallbacks.SuccessArray return method, this CL removes it.

Bug: 717812
Change-Id: Id91d074c6185932dbfb2e2cd404127e58e7804ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623452
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662462}

https://skia.googlesource.com/skia.git/+log/965de68dd7c1..47f6fc90c9f3


git log 965de68dd7c1..47f6fc90c9f3 --date=short --no-merges --format='%ad %ae %s'
2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@47f6fc90c9f3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Change-Id: I3e488960d300be7b6f3d170ae132be358956326c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626041Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662461}

The default JSON results version parsed in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/test_utils/util.py?q=test_utils+TestResults&sq=package:chromium&dr=CSs&l=52
is simplified. However, judging from issue 704066, it is confusing to understand what format things
are being written to if we aren't explicit about the version.

Bug: 704066

Change-Id: Ief890178e6b08fa1bea98bec18b6d27636672557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621875Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662460}

https://pdfium.googlesource.com/pdfium.git/+log/e912b62908ff..a1741dfd1f88


git log e912b62908ff..a1741dfd1f88 --date=short --no-merges --format='%ad %ae %s'
2019-05-22 tsepez@chromium.org Small tidy in fx_freetype.h


Created with:
  gclient setdep -r src/third_party/pdfium@a1741dfd1f88

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: I89ebd79521fefd6f41411473c03b46521eb63611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626042Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662459}

Changes all the button and axis IDs used for sending controller input
during the XR browser tests to be runtime-agnostic instead of using the
OpenVR constants.

This fixes the issue of WMR having to duplicate the constants since it
can't rely directly on OpenVR, and also simplifies things by using the
notion of primary/secondary axes instead of having to conditionally
change which axis type we use based on runtime.

Bug: 965306
Change-Id: Ide659c0c25958c1a732a5f893ce01a9cd88499e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625933
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662458}

In addition to tracking of outstanding IndexedDB transactions, also
track database transactions.

R=haraken@chromium.org,dmurph@chromium.org
BUG=966056

Change-Id: I4c426e3866c74a36b3dc2be1a62c52cb5a7f77b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625120
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662457}

This CL adds a button bar element containing navigation buttons that
drive the cellular activation flow.
See go/cros-cellular-activation-ui-design for UI design.

Bug: 962702
Change-Id: Iebbfddd1a6bb353b6f07f359923c3083a76e9f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611077Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662456}

Use $V instead of * to refer to the version number of the clang package,
and add a check for all files in want that don't contain '*' that they
actually exist.

The one exception that still needs '*' is 'lib/clang/$V/include/*'.

While here, make the formatting of additions to `want` more consistent.

Bug: 884608,959966
Change-Id: Ibcd3ca5869cffd2e049ca2dd746451fa8fe5f98f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625271Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662455}

The guidance provided doesn't match how this method is actually
implemented, so probably removing the guidance is better than
keeping it.

Change-Id: I672b41c8e457473dcd1110d820d5a6a27fa85d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625247
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662454}

Bug: 965908
Change-Id: I31ec09e9023afbb9b091cb31a18fe4434b8d0fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624485Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662453}

Bug: 965908
Change-Id: Ic87da5d17fa8e8470d5bceec73667a16dcb0b7bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624366Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662452}

Tablet.CountOfVolumeAdjustType
Count of each volume adjust type in tablet mode.

It includes four types of volume adjust:
kAccidentalAdjustWithSwapEnabled, accidental volume adjust that happens
when SwapSideVolumeButtonsForOrientation is enabled.

kNormalAdjustWithSwapEnabled, normal volume adjust that happens when
SwapSideVolumeButtonsForOrientation is enabled.

kAccidentalAdjustWithSwapDisabled, accidental volume adjust that
happens when SwapSideVolumeButtonsForOrientation is disabled.

kNormalAdjustWithSwapDisabled, normal volume adjust that happens when
SwapSideVolumeButtonsForOrientation is disabled.

Bug: 937907
Change-Id: I3993bde20b0da8e20dac8cc90cdf43492980a77e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617136Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662451}

We currently have some cases where certain LayoutObjects remain dirty
after layout update, which causes security bugs if we continue to visit
its subtree or fragment tree.

This patch adds a CHECK to make it crash safely when hit testing such
a LayoutInline. We should fix the root cause later.

Bug: 965976
Change-Id: I1de8faf6d76caa43bddf93ddabc20653c1f2803d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626349
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662450}

Allow it as a legacy compatibility.

Bug: 965365
Change-Id: If63ff37ef4a40669d824f994f73b5473819cc4c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623616Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662449}

Remove the virtual method ExtensionsClient::ShouldSuppressFatalErrors().
All clients just return `true`. The ChromeExtensionsClient
implementation previously checked the channel and returned false if the
channel was Canary or Dev; when this check was written, the channel info
was at the //chrome layer. Now, the channel info is a separate component
and accessible to the //extensions layer, so there's no reason to go
through the ExtensionsClient, even if we wanted to check the channel.

TBR=halliwell@chromium.org

Bug: None

Change-Id: I11160f64af2f8ae8d98eedd2fa08084450fed167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604065
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662448}

BUG=762641
TBR=minch@google.com

Change-Id: I44b459a3dfaeb4fbf7c6d1280d18fea67870d93e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626769Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662447}