- 12 Sep, 2017 40 commits
-
-
Ryan Sturm authored
Bug: Change-Id: I29b9c78a9e23afa819fe7d4ebf96ede206a1ac91 Reviewed-on: https://chromium-review.googlesource.com/661577Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501304}
-
John Chen authored
ChromeDriver relies on the user-data-dir switch for its operations, and ignores attempts by the client to exclude this switch. This CL adds a warning message if the client attempts to exclude user-data-dir. Bug: chromedriver:1981 Change-Id: I733f16fbdb6bea5dcf130ce7ad97664036f689be Reviewed-on: https://chromium-review.googlesource.com/662598 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501303}
-
Helen Li authored
Use JUnit4 for UploadDataProvidersTest. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I511a999a02a91d1f9c1f4ca076b96a4bc986d854 Reviewed-on: https://chromium-review.googlesource.com/663401 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501302}
-
sebsg authored
Bug: 764338 Tbr: oshima@chromium.org, reveman@chromium.org Change-Id: I8057386a40ee245786bd4a424e9f456aeee87673 Reviewed-on: https://chromium-review.googlesource.com/663560Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501301}
-
Gauthier Ambard authored
To hide the ink on the empty items, ContentSuggestions was using a transparent color for the ink instead of not starting the animation due to an MDC bug. As the bug is fixed, the correct method can be used. Bug: 724493 Change-Id: Id4a63ddcc9977b9c017f882bcf17c2a026ee13b2 Reviewed-on: https://chromium-review.googlesource.com/663340Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501300}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ff72a0857f4d..74dac545488c $ git log ff72a0857..74dac5454 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 stephana Make output of all tests verbose Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2338f153c51a8a07d4c6a67559a2615425a7abda Reviewed-on: https://chromium-review.googlesource.com/663658Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501299}
-
Gauthier Ambard authored
The users were not classified by NTP usage. This is needed to adjust fetching interval and metrics. Bug: 764257 Change-Id: I647b331332aa39237791667f9a43d9b34c445005 Reviewed-on: https://chromium-review.googlesource.com/663339Reviewed-by:
-
Xiaocheng Hu authored
TextIterator currently may add two consecutive newlines after an H4, H5 or H6 element, while the spec of innerText doesn't have this case at all. This patch removes the extra newline to make TextIterator more spec-complicant. Note: TextIterator should eventually remove double newline emission also for H1~3. This patch removes it only for H4~6 to keep the amount of rebaselined tests small. Bug: 752672,758816 Change-Id: I32583c194a829f52411555125e77590e36ccf838 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/661937Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#501297}
-
Peter Beverloo authored
BUG= Change-Id: Ib353c4cc5ae0fcbca4f9f5b69961a7c31edcdcf9 Reviewed-on: https://chromium-review.googlesource.com/657279 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501296}
-
Gauthier Ambard authored
When the user scrolls with voice over activated, the scroll is done by increasing the collection scroll by the height of the collection view. As the collection is displaying the fake omnibox as an overlay, the content hidden by the omnibox is not taken into account by the default computation. This CL fixes it by taking it into account. Bug: 763940 Change-Id: I3111037cbee73521096bbe9dbe264d809ac5088c Reviewed-on: https://chromium-review.googlesource.com/660220Reviewed-by:
-
Devlin Cronin authored
Extract a RendererMessagingService base class that can be used with both JS-based and native extension bindings. Pull out the logic that will be common to both implementations and put it in the base class, and have JSRendererMessagingService retain the JS-specific implementation logic. Bug: 653596 Change-Id: I6ccc81f45a32b4f83d75b34941fed73d9ee857de Reviewed-on: https://chromium-review.googlesource.com/658496 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501294}
-
Ella Ge authored
spec: https://drafts.csswg.org/css-ui-3/#cursor 1. When cursor:auto, cursor should be "text" over selectable text, default otherwise. Changed SelectAutoCursor and ShouldShowIBeamForNode to match spec. Use UA stylesheet to achieve different cursor on different element. (browser default behavior) 2. When cursor:text, use VerticalTextCursor when vertical-text. 3. Show pointer cursor when mouse hovering resizers no matter what cursor style set for its owner element. 4. When selecting anchor text, use I-beam when style cursor:pointer, otherwise keep style cursor. Bug: 737452 Change-Id: I71e0a63b1518cde261755c9339eb62f8e3e2c21f Reviewed-on: https://chromium-review.googlesource.com/600252 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#501293}
-
smcgruer authored
This change adds a WorkletAnimation object accessible in the main js scope, when the CompositorWorker (the old name for AnimationWorklet) Blink runtime feature is enabled. WorkletAnimation objects are hooked up to the document's animation lifecycle, owned by a WorkletAnimationController. The controller will attempt to start them on the compositor, but this currently fails due to lack of support in the animation logic. BUG=720080 Review-Url: https://chromiumcodereview.appspot.com/2869183002 Cr-Commit-Position: refs/heads/master@{#501292}
-
Alex Moshchuk authored
r498971 changed ReloadIfTerminated from looking up the extension ID directly from the site URL's host(), to using the GetExtensionIdFromFrame helper. Unfortunately, the latter isn't exactly equivalent: it returns the ID of an extension that it looks up via active_extensions(), which fails for terminated extensions. Instead, change GetExtensionIdFromFrame to just return the RFH's site URL's host(), the way it used to work for ReloadIfTerminated. Also have GetExtensionFromFrame use this as a helper. Bug: 763808 Change-Id: Ibc19ff484573f764732ffe13cc5f9d5d25b13999 Reviewed-on: https://chromium-review.googlesource.com/661359 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501291}
-
Peter Beverloo authored
This updates the use of the |action_index| and |reply| values throughout the notification event dispatching code to base::Optional<>, reflecting that neither has to be present. BUG= Change-Id: I930cd6a103138e91ffb2f4f0bfdf074c87a0c44b Reviewed-on: https://chromium-review.googlesource.com/655307Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501290}
-
edchin authored
This CL removes IDC_SHOW_SIGNIN_IOS Chrome command in favor of the dispatcher. Bug: 738881 Change-Id: I4ce80192f3db33097c4cf7537ba15190ccc7d9df Reviewed-on: https://chromium-review.googlesource.com/662557 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501289}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d5df04f53ce8..4298cb322ef3 $ git log d5df04f53..4298cb322 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 perezju [telemetry_mini] Fix pylint error Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic7af7b00818c31fe1638ab64e7798a1d89d38576 Reviewed-on: https://chromium-review.googlesource.com/663557 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501288}
-
Josh Karlin authored
Bug: 617963 Change-Id: I5c9dcd156dfb9a6cb1b950be1f7f1d1bf77380fb Reviewed-on: https://chromium-review.googlesource.com/663398Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501287}
-
Koji Ishii authored
Following bot results are included. 1259 1260 1261 1262 1263 1264 1266 1268 1269 1270 1271 1272 1273 1275 1277 1278 Skipped results before mstensho's adjustments. 75 lines were removed by consecutive passes since 1229. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I3ce8ef09ca8ddda3b2c04e59c679eb93728717c4 Reviewed-on: https://chromium-review.googlesource.com/663497 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
edchin authored
This CL fixes a bug that was introduced while refactoring IDC_REPORT_AN_ISSUE command. The command execution was originally wrapped in a dispatch_async so as to give enough time for the tools menu to disappear before taking a snapshot of the screen. The refactoring removed this necessary dispatch_async call. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/638840 Bug: 761964 Change-Id: Idf498559c5f6d5963204cb35e7efad5def1d3b81 Reviewed-on: https://chromium-review.googlesource.com/662405Reviewed-by:
-
Tomasz Garbus authored
This CL deletes all occurrences of "namespace credential_manager" because sdefresne@ pointed out to me that we should avoid using namespaces in application code. credential_manager namespace was present only in ios/chrome/browser/passwords code. Bug: 435048 Change-Id: I36459c557fcf2064c010208bbbe305da1c47d233 Reviewed-on: https://chromium-review.googlesource.com/652526 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501284}
-
Mohamad Ahmadi authored
- Adds 3x resources to components/resources/autofill. These missing resources where causing the ResourceBundle to load the 1x ones for iPhone plus devices which resulted in blurry icons. - Modifies the 1x and 2x resources for the generic credit card to match the 3x one. - Removes the imagesets from iOS bundle and changes the autofill suggestion code to use the resources in the components. Bug: 763499 Change-Id: I5463bc20c30b884ee4685a3fd2cd28d84625a709 Reviewed-on: https://chromium-review.googlesource.com/660802 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8539662e. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1659 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Ia24d4f19870cb2696c44c4487fde12feb5753c22 Reviewed-on: https://chromium-review.googlesource.com/663397 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501282}
-
Gauthier Ambard authored
When the user long press an item on the NTP, a context menu is shown. The omnibox should be unfocused when this context menu is presented. It is only necessary to specify it on iPad as showing the alert menu on iPhone automatically unfocus it. Bug: 763907 Change-Id: I9d1b8bcf94b64867464ba9ff1ab0a49c423f3a47 Reviewed-on: https://chromium-review.googlesource.com/663342Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501281}
-
Emircan Uysaler authored
Bug: 730365, 762110 Change-Id: I6a7c090385bc595171b82f73ba53635b1623b210 Reviewed-on: https://chromium-review.googlesource.com/634463Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#501280}
-
Michael Achenbach authored
This reverts commit b50598f3. Reason for revert: This was just an mksnapshot flake, see: https://crbug.com/700525 Cycled already green before revert was in. Original change's description: > Revert "Update V8 to version 6.3.113." > > This reverts commit cb14e960. > > Reason for revert: Compile error on Windows: > FAILED: gen/v8/snapshot.cc snapshot_blob.bin > C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./mksnapshot --startup_src gen/v8/snapshot.cc --random-seed 314159265 --startup_blob snapshot_blob.bin > ==== C stack trace =============================== > v8::internal::CEntryStub::MajorKey [0x01250990+0] > v8::internal::CodeStub::FindCodeInCache [0x010F8D09+25] > v8::internal::CodeStub::GetCode [0x010FAAA9+57] > v8::internal::MacroAssembler::CallRuntime [0x01495804+148] > v8::internal::TypeofDescriptor::TypeofDescriptor [0x014E4DB9+665] > v8::internal::SetupIsolateDelegate::PopulateWithPlaceholders [0x014E53DE+46] > v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal [0x014E5603+19] > v8::internal::SetupIsolateDelegate::SetupBuiltins [0x0149DDD1+17] > v8::internal::Isolate::Init [0x012E1778+4792] > v8::SnapshotCreator::SnapshotCreator [0x01058C26+150] > v8::V8::CreateSnapshotDataBlob [0x0105B181+33] > main [0x01051690+192] > __scrt_common_main_seh [0x015C7EEB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253) > BaseThreadInitThunk [0x7786338A+18] > RtlInitializeExceptionChain [0x77E69A02+99] > RtlInitializeExceptionChain [0x77E699D5+54] > > Original change's description: > > Update V8 to version 6.3.113. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/726c1912..e3965fde > > > > Please follow these instructions for assigning/CC'ing issues: > > https://github.com/v8/v8/wiki/Triaging%20issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org > > > > Change-Id: I52a756ba5f107262265018de222b0213e1ee1d92 > > Reviewed-on: https://chromium-review.googlesource.com/663297 > > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#501250} > > TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org > > Change-Id: I71255d8fcb1b281550f5f5d43e0671d36cb29c55 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/663599 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501266} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sebsg@chromium.org Change-Id: I5a4c7f19bc2584cbc3bc72b8983de5ade2f5595e No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/663697Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#501279}
-
Allen Bauer authored
Added blocked popup content to interactive invocation of blocked popups dialog. TBR=grt@chromium.org Bug: 652031 Change-Id: I1c3f4bca0fe682897e0ed98e61957735b0d46320 Reviewed-on: https://chromium-review.googlesource.com/612496Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#501278}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a8e5744afadd..ff72a0857f4d $ git log a8e5744af..ff72a0857 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 rmistry Add SK_DEBUG to SkUserConfig.h from upload_to_android.py if "--debug" flag is specified Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I077d2b0f6138211dd030b439dd237d5918ebbebd Reviewed-on: https://chromium-review.googlesource.com/663558Reviewed-by:
-
stkhapugin@chromium.org authored
Creates OmniboxPopupMediator and AutocompleteResultsWrapper, moves logic to these classes form OmniboxPopupMaterialVC. Bug: Change-Id: I753b37f4831d43956a146ac025cf6d166bf46500 Reviewed-on: https://chromium-review.googlesource.com/608242Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
-
sebsg authored
Bug: 764338 Tbr: reveman@chromium.org Change-Id: I37817bd0b9ac8f8a12b1d2336476741e0e7dd69c Reviewed-on: https://chromium-review.googlesource.com/663657 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Juan A. Navarro Perez authored
This change modifies the benchmark's story flow in two ways: - about:blank will no longer be loaded before pushing the browser to the background. Thus making the background measurement more realistic - the browser will now be restarted between each foreground/background pair of stories; this will make each pair stories independent of each other, helping to make results more reproducible and less noisy. Perf sheriffs warning: This is expected to affect memory measurements for this benchmark. Bug: 750055 Change-Id: I65ea9431d52f63ee3e7dfccad68a62476018ea99 Reviewed-on: https://chromium-review.googlesource.com/612980 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#501274}
-
Francois Doray authored
The file thread is no longer used. TaskScheduler should be used for all file operations. Bug: Change-Id: Iba07dc70a721c2c84cdb7ac00b7d4be057ae83aa Reviewed-on: https://chromium-review.googlesource.com/660599Reviewed-by:
Gene Gutnik <gene@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#501273}
-
Sebastien Seguin-Gagnon authored
This reverts commit a67f5458. Reason for revert: Suspecting this CL as cause of consistent failing of AnimationSimTest.CustomPropertyBaseComputedStyle on Linux. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI builds 1921 to 1929 failed Log output for the test: [ RUN ] AnimationSimTest.CustomPropertyBaseComputedStyle Received signal 11 SEGV_MAPERR 000000000008 #0 0x00000403655c base::debug::StackTrace::StackTrace() #1 0x000004036284 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fe54f260330 <unknown> #3 0x00000252b7a2 WTF::RefCountedBase::Ref() #4 0x000004fafad7 blink::InterpolationEffect::AddInterpolationsFromKeyframes() #5 0x000004fb6de5 blink::KeyframeEffectModelBase::EnsureInterpolationEffectPopulated() #6 0x000004fb635a blink::KeyframeEffectModelBase::Sample() #7 0x000004fbcf63 blink::KeyframeEffectReadOnly::ApplyEffects() #8 0x000004fbd3f8 blink::KeyframeEffectReadOnly::UpdateChildrenAndEffects() #9 0x000004f90916 blink::AnimationEffectReadOnly::UpdateInheritedTime() #10 0x000004f89f9d blink::Animation::Update() #11 0x000004f9cff6 blink::DocumentTimeline::ServiceAnimations() #12 0x000005d9307e blink::PageAnimator::ServiceScriptedAnimations() #13 0x000005597082 blink::WebViewImpl::BeginFrame() #14 0x0000030f61a2 blink::SimCompositor::BeginFrame() #15 0x0000028f2c7f blink::AnimationSimTest_CustomPropertyBaseComputedStyle_Test::TestBody() #16 0x000003e17584 testing::Test::Run() #17 0x000003e17e1e testing::TestInfo::Run() #18 0x000003e18672 testing::TestCase::Run() #19 0x000003e1db33 testing::internal::UnitTestImpl::RunAllTests() #20 0x000003e1d7fd testing::UnitTest::Run() #21 0x0000040fee72 base::TestSuite::Run() #22 0x00000287d729 (anonymous namespace)::runHelper() #23 0x00000287e041 _ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #24 0x000004101c40 base::(anonymous namespace)::LaunchUnitTestsInternal() #25 0x000004101b09 base::LaunchUnitTests() #26 0x00000287d69c main #27 0x7fe549324f45 __libc_start_main #28 0x00000244e029 <unknown> r8: 0000000000000000 r9: 00007ffcd7abb768 r10: 6e65622c656e696c r11: 00007fe54948e2d0 r12: 00007ffcd7abae40 r13: 00003a23d3438890 r14: 00002f60aeb47718 r15: 00003a23d3438810 di: 0000000000000010 si: 00007ffcd7abadf8 bp: 00007ffcd7abae30 bx: 0000000000000008 dx: 0000000000000000 ax: f050afb778fbfd01 cx: f050afb778fbfd01 sp: 00007ffcd7abacd0 ip: 000000000252b7a2 efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000008 [end of stack trace] Calling _exit(1). Core file will not be generated. Original change's description: > Make WTF::PassRefPtr an alias of WTF::RefPtr > > This CL converts WTF::PassRefPtr to an alias of WTF::RefPtr, and removes > the implementation. > > Bug: 494719 > Change-Id: Ide96ef03dfa69668c1de87891a712bcd46470e13 > Reviewed-on: https://chromium-review.googlesource.com/657786 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501218} TBR=haraken@chromium.org,tzik@chromium.org Change-Id: Ida686824debc5967f95055be5d1629bcf5351b3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 494719 Reviewed-on: https://chromium-review.googlesource.com/663600Reviewed-by:
-
kapishnikov authored
BUG=758711 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Iacfd99301c8924e4126c9684a2da24ef8a415a5a Reviewed-on: https://chromium-review.googlesource.com/660922Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#501271}
-
Rob Buis authored
No need for ParseShorthand or InQuirksMode. Bug: None Change-Id: I739a2f2e244cb21c11fe3a7b79ddcc95a655b4e8 Reviewed-on: https://chromium-review.googlesource.com/660757 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#501270}
-
John Mellor authored
This reverts commit ab640662. Reason for revert: ArticleSnippetsTest has failed consistently on KitKat Tablet Tester since this landed. Specifically the following tests are failing: ArticleSnippetsTest#testDownloadSuggestion__ChromeHomeEnabled ArticleSnippetsTest#testSigninPromo__ChromeHomeEnabled ArticleSnippetsTest#testSnippetAppearance__ChromeHomeEnabled Additionally, many other test suites that follow chrome_public_test_apk started failing when this landed; not sure if that's related. Original change's description: > Render snippets in ArticleSnippetsTest in isolation > > Remove the "snippets" render that shows all cards together, because > multiple, non-article sections are not realistic in the modern design > anymore. > > Rebaseline other renders: > * Use relative timestamp instead of Jan 17, 1970 > * Use only single-card backgrounds for pre-modern cards > * Update modern card background color after https://crrev.com/497799 > * Update pre-modern text color after https://crrev.com/500684 > > Also move card contents in the modern layout except for the rounded > corners into a RelativeLayout, to avoid a circular dependency between > the height of the containing layout and the position of the bottom > corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html). > > Bug: 757735 > Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91 > Reviewed-on: https://chromium-review.googlesource.com/628562 > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500975} TBR=bauerb@chromium.org,skyostil@chromium.org,perezju@chromium.org,peconn@chromium.org Change-Id: Iedb4e042448a8e4c8090d8af5fbdbb6e2f19a6b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757735 Reviewed-on: https://chromium-review.googlesource.com/663382Reviewed-by:
-
Mohamad Ahmadi authored
Many websites use 16 pixel favicons. This CL avoids stretching the favicon and results in a sharper image. Bug: 763499 Change-Id: I07208084990c22a05261bfce5d6d4b6c16fdfb8d Reviewed-on: https://chromium-review.googlesource.com/663577Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#501268}
-
Christopher Grant authored
This change gets rid of a no-longer-helpful scale operation on the Skia canvas, in preparation for some rework of how vector icons are drawn. Some other cleanup is included. BUG= R=bshe@chromium.org Change-Id: I4d709aa9a743e86639ef86627d39d4e2254b5695 Reviewed-on: https://chromium-review.googlesource.com/661019Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#501267}
-
Sebastien Seguin-Gagnon authored
This reverts commit cb14e960. Reason for revert: Compile error on Windows: FAILED: gen/v8/snapshot.cc snapshot_blob.bin C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./mksnapshot --startup_src gen/v8/snapshot.cc --random-seed 314159265 --startup_blob snapshot_blob.bin ==== C stack trace =============================== v8::internal::CEntryStub::MajorKey [0x01250990+0] v8::internal::CodeStub::FindCodeInCache [0x010F8D09+25] v8::internal::CodeStub::GetCode [0x010FAAA9+57] v8::internal::MacroAssembler::CallRuntime [0x01495804+148] v8::internal::TypeofDescriptor::TypeofDescriptor [0x014E4DB9+665] v8::internal::SetupIsolateDelegate::PopulateWithPlaceholders [0x014E53DE+46] v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal [0x014E5603+19] v8::internal::SetupIsolateDelegate::SetupBuiltins [0x0149DDD1+17] v8::internal::Isolate::Init [0x012E1778+4792] v8::SnapshotCreator::SnapshotCreator [0x01058C26+150] v8::V8::CreateSnapshotDataBlob [0x0105B181+33] main [0x01051690+192] __scrt_common_main_seh [0x015C7EEB+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253) BaseThreadInitThunk [0x7786338A+18] RtlInitializeExceptionChain [0x77E69A02+99] RtlInitializeExceptionChain [0x77E699D5+54] Original change's description: > Update V8 to version 6.3.113. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/726c1912..e3965fde > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org > > Change-Id: I52a756ba5f107262265018de222b0213e1ee1d92 > Reviewed-on: https://chromium-review.googlesource.com/663297 > Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> > Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501250} TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org Change-Id: I71255d8fcb1b281550f5f5d43e0671d36cb29c55 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/663599Reviewed-by:
-
Peter Beverloo authored
This should fix the crashes that we've been seeing on the bots, so those have been re-enabled as well. BUG=761060 Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551 Reviewed-on: https://chromium-review.googlesource.com/663219Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501265}
-
