- 14 Aug, 2018 19 commits
-
-
Trent Apted authored
bookmark_menu_bridge.mm is used to show bookmarks in the macOS main menu bar. It currently elides bookmark _titles_ to a custom width before sending to the Cocoa NSMenuItem. However, bookmark subfolder labels are not elided until NSMenuItem itself decides to do the elision, which is done with a much wider width. Make the widths consistent. This CL adopts the smaller width; used for bookmark titles. We could also drop our custom elision width and just let AppKit do it, but that's not the current intention. Bug: 869270 Change-Id: I2fe86d4e2c8e9d2256fa8b6bdabfa4c75c75faaf Reviewed-on: https://chromium-review.googlesource.com/1156188Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582774}
-
akaba authored
This CL implements an observer pattern for activated child surface, where each surface will be able to observe activation events happening in a subset of FrameSinkIds and update SurfaceReferences accordingly. This is needed since we will no longer refer to the fallback but instead will use GetLatestInFlightSurface to acquire references from the SurfaceRanges specified in CompositorFrameMetaData. Bug: 857575 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8ee1a9633273e116c5e7b1ae840dcc8db7a0407a Reviewed-on: https://chromium-review.googlesource.com/1157404 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582773}
-
Lei Zhang authored
Make PrintPreviewHandler remember which preview requests failed. So when out of order page ready events arrive after the failure due to compositing, PrintPreviewHandler can figure out those events are safe to ignore. BUG=872983 Change-Id: I8b493a9b1efb50112495cf47ab25d1b01897d4c2 Reviewed-on: https://chromium-review.googlesource.com/1170228Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582772}
-
Yuwei Huang authored
We are still seeing quite a few crashes happen when session disconnects remotely. Here are two issues that I have found: * It turns out calling WeakPtrFactory::InvalidateWeakPtrs() only invalidate WeakPtrs that are currently created, while calling WeakPtrFactory::GetWeakPtr() again will create new valid WeakPtrs. * ChromotingClient owns IceTransport, which runs a timer to periodically send pending transport messages. The timer should be stopped immediately after the session is disconnected, so we need to immediately destroy the ChromotingClient instance in this case. Bug: 840492 Change-Id: I6625af62001b0cdfb5745dcc863ed59617e440cf Reviewed-on: https://chromium-review.googlesource.com/1170174 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#582771}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I2a5cd718d8356b6d4ac3f31157ef5d9b1c859baf Reviewed-on: https://chromium-review.googlesource.com/1173150 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582770}
-
Ben Pastene authored
This reverts commit e6bbcbfa. Reason for revert: Breaks build determinism on linux https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/15728 See also crbug.com/873869 Original change's description: > Make sure that both official and local (unofficial) builds have ELF build-ids > > The local (unofficial) builds use --build-id=uuid, which unlike sha1 build IDs > does not slow down the build. > > Bug: 870919 > Change-Id: Ib55cbc86e11e8208fa8560d98b3288bbc6a149de > Reviewed-on: https://chromium-review.googlesource.com/1169903 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Leonard Mosescu <mosescu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582658} TBR=dpranke@chromium.org,mark@chromium.org,mosescu@chromium.org Change-Id: I0add42d7b05d1ffcebea83d1df6d29d6139f1b67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870919, 873869 Reviewed-on: https://chromium-review.googlesource.com/1173671Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#582769}
-
Tom Anderson authored
BUG=873002 R=pkasting Change-Id: I9ad2d5566ec0129a265e1f590ade2ccbc86a9541 Reviewed-on: https://chromium-review.googlesource.com/1171917Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582768}
-
Ella Ge authored
This Cl made a few change to correct scroll resampling behavior: 1. Adds a rule to prevent scroll predictor change direction of scroll delta. Otherwise it might cause the scroll to jump back, which is a very bad behavior. When new_delta and original delta is in different direction, makes new_delta to 0. 2.This CL also moved scroll_predictor_.HandleEvents() from DispatchSingleInputEvent to DispatchQueuedInputEvents. This makes events not in the compositor event queue do not affect by scroll_predictor. 3. The scroll predictor record phase of the event. When predictor gets a GSU with inertial_phase is kMomentumPhase, it stops resampling. This is because when fling, GSU is sent per frame, we don't need to resampe the event. 4. Adds some limits to resampling time. This is because we sometimes get incorrect timestamp from OS (android, see the example logout: https://docs.google.com/spreadsheets/d/1yY1CNaL6ovQpg7LDm_Uyq5dIbVMQy684od0J6OX0Hn0/). Besides that, since we value the accuracy in resampling, we don't want to predict to far in the future. Bug: 836352 Change-Id: I7d84c80e76d48596cf2012611a25133276474d71 Reviewed-on: https://chromium-review.googlesource.com/1136899 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582767}
-
Eugene But authored
This test verifies that a session with 100 items can be restored. 100 items is the max supported size by Slim Navigation Manager. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I65625e61a019dde44e6d96a6c3697776c6e95661 Reviewed-on: https://chromium-review.googlesource.com/1173068Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#582766}
-
Tibor Goldschwendt authored
Add an AR Dynamic Feature Module (DFM) and bundle it into the public Monochrome bundle. + Add loadable modules to the build config so that their paths can be passed to the module create target. + Add option to bundle targets to specify the Android SDK target for synchronized proguarding. This was necessary because the Monochrome base module uses a different Android SDK than the AR module, which made proguard sad. Also pass the Android SDK Jar as a dedicated classpath Jar to proguard and don't mix it with the other classpath Jars. Bug: 863063 Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e Reviewed-on: https://chromium-review.googlesource.com/1165533 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#582765}
-
Tom Anderson authored
BUG=871574 Change-Id: I8eca9b8fabf1e90b0e9c054dd5283be21508bae4 Reviewed-on: https://chromium-review.googlesource.com/1164536Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582764}
-
Wei-Yin Chen (陳威尹) authored
Diff since last roll: https://chromium.googlesource.com/chromium/dom-distiller/+/9596033e36..ccfe233400 Picked up changes: https://chromium.googlesource.com/chromium/dom-distiller/+log/9596033e36..ccfe233400 ccfe233 Fix EmbedExtractorTest.testDivCaption 8825eaf In tests, render elements before getting their innerText 8c9af2c Make generateOutput(textOnly=true) standard compliant Bug: 651764,859410,873291,873298 Change-Id: I66bf2c9a433751597fc4c7153ce5955e28dad064 Reviewed-on: https://chromium-review.googlesource.com/1171847Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582763}
-
Aldo Culquicondor authored
Also renaming WebVrRenderer to TextureCopyRenderer, given that it is not only being used for rendering WebXR. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib6ba330bde972b4d87b8e4b897957f5f37bb7364 Reviewed-on: https://chromium-review.googlesource.com/1168469Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#582762}
-
Bruce Dawson authored
With VC++ you could mark a function as non-optimized and that would prevent it from being inlined, however with clang-cl that does not work, leading to confusing crash stacks. The fix is to use NOINLINE instead of MSVC_DISABLE_OPTIMIZE, which is more explicit and specific anyway. Bug: 873286, 873359 Change-Id: I59b7fe981289ef7aded399a53a0c86b0449f1775 Reviewed-on: https://chromium-review.googlesource.com/1171817Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582761}
-
Tatiana Buldina authored
Change-Id: I397df2d47550081fb58bde7bd361d929c1006694 Reviewed-on: https://chromium-review.googlesource.com/1173486Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#582760}
-
Jian Li authored
Currently it is reported as "Download Home". We now add the logic to separate it out, together with the case that clicking from progress bar. This was previously reviewed at https://chromium-review.googlesource.com/c/chromium/src/+/1157644 It was landed and reverted due to test failure. I am relanding it to fix the test failure. Bug: 869692 Change-Id: I9bfe0a2b1fc0e984fe258c3c28be3491fe6bca99 Tbr: dgn@chromium.org Tbr: dimich@chromium.org Tbr: peter@chromium.org Tbr: holte@chromium.org Tbr: qinmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1173268Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582759}
-
Oystein Eftevaag authored
Previously this was done in the OnConnect() callback, but it turns out this is called via PostTask() so if tracing gets disabled immediately after it's enabled, the disable call can come in between and causes test failures due to the StopAndFlush callback never happening. Bug: 873073,872631 Change-Id: I343060c5e4b9d66575e6b8fe71a28cc9b706a429 Reviewed-on: https://chromium-review.googlesource.com/1171658Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#582758}
-
Findit authored
This reverts commit 5e9e06bd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 582711 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVlOWUwNmJkODM2MDcyNGJmODJmM2FkYTJlNTNkYTc2ZjkyMWEwMDkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/52049 Sample Failed Step: network_service_browser_tests Original change's description: > NQE servicification of data saver proxy > > Use network quality tracker instead of network quality estimator (NQE) > to obtain network quality in data reduction proxy component. > > Network quality tracker can provide network service when network > service is enabled as well as when network service is disabled. > > data_reduction_proxy_service.h receives network quality > estimates on UI thread from network quality tracker. > On receiving estimates, it posts them to d_r_p_io_data > which lives on IO thread, and consumes the estimates. > > Bug: 819244 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I8a89fae921c15d5e006c9d51cb19cb6116688fb1 > Reviewed-on: https://chromium-review.googlesource.com/1171592 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582711} Change-Id: Ida144bf271de7c3cf7a9794679c71ffcd9a55d07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819244 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1173573 Cr-Commit-Position: refs/heads/master@{#582757}
-
Jun Choi authored
Currently, ChromeAuthenticatorRequestDelegate implements FidoRequestHandlerBase::AuthenticatorMap interface, and each events in transport layer trigger observer function in the embedder. In order to make embedder interface simpler, aggregate all transport layer events that is required prior to initiating WebAuthN UI dialog in FidoRequestHandlerBase. Once all the information is gathered, combine all retrieved data in FidoUiAprioriData struct and invoke single OnTransportLayerInfoReceived() observer function in the embedder layer. Bug: 866601 Change-Id: Id9ac2456fca14351682a8c72a7813c3f8674c552 Reviewed-on: https://chromium-review.googlesource.com/1170041 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582756}
-
- 13 Aug, 2018 21 commits
-
-
Esmael El-Moslimany authored
The label when clicked toggles expansion. The bug as reported was selecting the label text causes expansion. Without the pointer cursor it's surprising to the user that an action will be taken while clicking on the label text during selection. The problem is the surprising expansion and not the expansion on clicking the text. Bug: 870205 Change-Id: I5c5200f54a54bba50cb6fc67c668b8d298b98c94 Reviewed-on: https://chromium-review.googlesource.com/1166216Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#582755}
-
Toni Barzic authored
Updates the location from which offline policy blobs are loaded to match the new location (set by demo_mode_resources package, rather than chromeos-assets) BUG=None Change-Id: If63e35898c9329d287364ba9f959007824e2db26 Reviewed-on: https://chromium-review.googlesource.com/1173490Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582754}
-
Christian Fremerey authored
Reason for the revert was duplicate initialization that happened because a different fix for the initialization issue had already landed in the master branch. Original CL description: Fixes an issue where VideoTrackRecorder when used in combination with VEAEncoder and very short recording durations (just 1 frame) would occasionally hold on to video frames forever, causing frame buffers from the buffer pool to become permanently blocked, eventually leading to video capture freezing. The cause was a circular ownership that would happen if only 1 frame is recorded. This CL additionally fixes a crash that could happen on initialization of VEAEncoder. This issue was revealed during testing of the above fix. Since it is not 100% if this crash was masked by the other issue, and would only start occurring with the above fix, I am making a fix for that part of this CL as well. The cause for the crash issue was that class VEAEncoder, which uses RefCountedThreadSafe<>, would post an asynchronous task from its constructor. If this task would finish executing before the newly constructed instance was assigned to a scoped_refptr<> by however called the constructor, the instance would destroy itself, because of the AddRef() and subsequent Release() done by the posting and running of the asynchronous task. The fix for this is to use a new method Initialize() instead of posting a task from the constructor. TBR=emircan@chromium.org Bug: 859610 Change-Id: I77d6865be574bf86afca7d0908ce2339f6ecd91e Reviewed-on: https://chromium-review.googlesource.com/1173408Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#582753}
-
gogerald authored
TBR: hayato@chromium.org Bug: 873829 Change-Id: I321d85a63971b1f9b01bb42d4b5d93db44125c92 Reviewed-on: https://chromium-review.googlesource.com/1173437 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#582752}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0c7cf97859dd..19b70815b4d1 git log 0c7cf97859dd..19b70815b4d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 thestig@chromium.org Split CFX_MemoryStream::m_dwFlags into two bools. Created with: gclient setdep -r src/third_party/pdfium@19b70815b4d1 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic175ff09df16a3600963519a833f3f6920643c12 Reviewed-on: https://chromium-review.googlesource.com/1173171Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582751}
-
Alex Newcomer authored
At request of PM, disable webstore search. Bug: 872949 Change-Id: I7d696f5f102c3a5b507fb59a4ff7aa240bdd7d0f Reviewed-on: https://chromium-review.googlesource.com/1170993Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#582750}
-
Calder Kitagawa authored
Phase 1 of the work to replace url_template with action and params as per the updated WebShareTarget spec: https://wicg.github.io/web-share-target/. Note: the work to add method and enctype will be done at a later date. This is primarily an effort to deprecate url_template and replace it with action and params. To avoid a large CL this work is being done in stages with this CL just adding the new fields the the manifest without deleting the old one to avoid breakages. See the bug for a detailed plan for performing these changes. Bug: 871788 Change-Id: I68e574ab88a6d9bf48c9adc9c8a13600aafd1761 Reviewed-on: https://chromium-review.googlesource.com/1165483Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#582749}
-
Wenzhao Zang authored
Bug: 873711 Change-Id: I35e6c04cc1d137db35ec1f02a41ce55d2b51b0e4 Reviewed-on: https://chromium-review.googlesource.com/1172068Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582748}
-
Lei Zhang authored
Change-Id: Ib8bbcc6efdd2b0a5cf6875a25d1ca1479b237de7 Reviewed-on: https://chromium-review.googlesource.com/1173403Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582747}
-
Trent Apted authored
Creates shared unit test helpers for MockMetadata and MockGalleryItem since these concepts are used in multiple unittest files. This means updating the corresponding unittest.html files that are not yet auto- generated. Bug: 867700 Change-Id: Ia77bac5f9dc14abb1f92bb90a8c545d6998e0160 Reviewed-on: https://chromium-review.googlesource.com/1172170Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582746}
-
Shakti Sahu authored
Bug: 868205 Change-Id: I9f4b2c8a47c9ad7d3405a5a5cf614e4d2e225435 Reviewed-on: https://chromium-review.googlesource.com/1166463 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#582745}
-
David Bokan authored
This patch prints the property tree logging by printing each line separately. This prevents truncation of the logging output on Android, where: LOG << ...long multiline string... Will be truncated after some finite number of characters. For long outputs such as the property trees we hit this quite easily. Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e70a5e66d8248b2faa478738db94c980c28e3f7 Reviewed-on: https://chromium-review.googlesource.com/1173156 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582744}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/21cd5a309631..501bed82a534 git log 21cd5a309631..501bed82a534 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 sbalana@google.com Add support for ES modules in third_party/idb. Created with: gclient setdep -r src/third_party/catapult@501bed82a534 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855252 TBR=sullivan@chromium.org Change-Id: Ib96332d41a3b8187d1fa323a543a987136e113ba Reviewed-on: https://chromium-review.googlesource.com/1173173Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582743}
-
Lei Zhang authored
According to metrics, this action is only firing a couple times a week. BUG=482176 Change-Id: I9532cd4db87e5c1a801484eef34c522dfcebf0a7 Reviewed-on: https://chromium-review.googlesource.com/1151087Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582742}
-
Doug Arnett authored
Bug: 870030 Change-Id: If46caf16806b64ed5516b548d3080a0a734ca614 Reviewed-on: https://chromium-review.googlesource.com/1159267Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582741}
-
Robert Liao authored
This is part 2 of 3 for aligning BubbleDialogDelegateView with its filename. BUG=873422 TBR=ellyjones@chromium.org Change-Id: Ie012caded8d230c81a5e4a0ced86195d679b45f6 Reviewed-on: https://chromium-review.googlesource.com/1173409Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582740}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f5e6287d3f6aec387ef5d04469c8f625ca884ad Reviewed-on: https://chromium-review.googlesource.com/1173500Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#582739}
-
Ben Kelly authored
This implements step 4.2.3 of the BatchCacheOperations algorithm: https://w3c.github.io/ServiceWorker/#batch-cache-operations-algorithm Bug: 720919 Change-Id: I679f786441b813ed816a183522021c417f4ab7b8 Reviewed-on: https://chromium-review.googlesource.com/1162362 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582738}
-
Tom Anderson authored
Also change the GTK theme background tab color to match the frame color. BUG=872383 R=pkasting TBR=sky Change-Id: I4f1f7e5acf3d989047d565d73964e88306dc97ab Reviewed-on: https://chromium-review.googlesource.com/1168513 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582737}
-
David Black authored
Previously, the back button immediately navigated backwards in the Assistant container's UI state. Now, the back button will navigate backwards in the WebContents history stack. Only when there is no more history do we return control to the Assistant container for handling. See bug for demo. Bug: b:112355878 Change-Id: I943407c85497f09a5360f21353301b6bc6823315 Reviewed-on: https://chromium-review.googlesource.com/1167646 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582736}
-
Robert Kaplow authored
This should change retries from 15s, 16.5s, ... 10min, 10min .. to 5 minutes, 10 minutes, 20 minutes, ... 24h, 24h.. Bug: 873282 Change-Id: Ib1e3fdebdf155f171a51c73b29724f4ba4673c73 Reviewed-on: https://chromium-review.googlesource.com/1171512 Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#582735}
-