- 02 Oct, 2020 40 commits
-
-
chinsenj authored
This CL changes hardcoded values to use their respective color providers, allowing them to handle light/dark mode. Test: manual Bug: 1127498 Change-Id: I81b7a877dc0aff37d2fe080e6ee15ff73c094704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444489 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813291}
-
Piotr Roguski authored
Adding TracingObserverProto for serializing memory dump in to proto format needed for migration of memory-infra to Perfetto. See crbug.com/1098746 for more details. Bug: 1098746 Change-Id: If78a00672263f0cb061d5f505a62da912c2d7091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324841 Commit-Queue: Piotr Roguski <piotr.roguski@mobica.com> Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813290}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/be82703d7841..be7345166a4f 2020-10-02 rwkeane@google.com [Discovery] Add Flag to Disable NSEC Record Receiving If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I61dd14b192ee7575b342d1718fb42de230bd0dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813289}
-
Dylan Cutler authored
This API leaks whether or not a particular Chrome client supports locking device orientation. This bit of information can be used to partially fingerprint users across different origins. The instrumentation reports digests of whether or not screen orientation locking is supported for UKM for us to analyze how much entropy about a user's origin this API leaks. Bug: 973801 Change-Id: I3c89aa6ecdabf166e490f359cb5493a95608d037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443511 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#813288}
-
Andre Le authored
This is a reland of 2e1031ec Original change's description: > [CrOS PhoneHub] Add enable hotspot and locate phone controller to quick > actions UI. > > - Add enable hotspot and locate phone quick actions controllers. > - Connect the controllers to quick actions UI. > - Minor changes in fake tether controller for testing. > > BUG=1106937,1126208 > > Change-Id: I1d4ace03120a4c51fcb351b7c19f33252b3fb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428735 > Commit-Queue: Andre Le <leandre@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812915} Bug: 1106937 Bug: 1126208 Change-Id: Ica4cafc1d2dac4d0c579fcbead6a7b771e35b87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445835 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813287}
-
Jazz Xu authored
This CL extends the freeze timer function to allow the controls freeze between sessions. This will avoid controls changing from one session to another when the active session goes next track. We will now always wait for a brief time to see if the previous session resumes before we update our controls. Bug: 1134458 Change-Id: I7b6d9d2ad1861b02c2399c6527b57cad685aba3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442195Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813286}
-
Tibor Goldschwendt authored
* Show modules even if there is no promo. Modules wait until the promo has sent a loaded event. Before, this event was only sent if there was a promo. This CL changes it so that the event is sent even if there is no promo. * Only log NewTabPage.Modules.ShownTime after modules are allowed to be visible. This could be after they are added to the DOM in case the promo takes longer to load. Bug: 1134269 Change-Id: I5975524ba3c783de66dda2b98d347442f6b73a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443693 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813285}
-
Yuly Novikov authored
- No longer sharing GCEs with Chromium in chromium.star - tools/build repo restructure - No more mb_config_buckets.pyl Bug: 1123215 Change-Id: I3874ba6a63873dc560837c87372ee22a6a7a061a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444440Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813284}
-
Francois Beaufort authored
This CL makes sure InvalidStateError and OperationError are respectively thrown when calling getPhotoCapabilitlies & getSettings if the MediaStreamTrack is ended and stopped while getting photo capabilities and settings. Bug: 1134569 Change-Id: Ie318319885b7796b17cb155ffcd2a81d7f98de17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445016Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#813283}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I322725001ea3c08514ff496b9ecb0f80b048b9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813282}
-
Darin Fisher authored
As part of this change, DesktopCaptureDevice will explicitly stop capturing frames if it encounters a permanent error. This should be a no-op since OnError implementations are supposed to destroy the DesktopCapturer. A test is added to confirm that the throttling logic still works properly when the callbacks run asynchronously, and the Lacros desktop capturer is modified to run OnCaptureResult asynchronously. This CL is important because it sets the stage for further improvements to the Lacros capturer. It will need to use mojo's QueryVersion method to check for newer methods on ScreenManager that will enable more optimal screen capture using shared memory. QueryVersion runs asynchronously, which is why this CL is needed. Bug: 1133046 Change-Id: I455294abaecdafa7e8e75d6ea660045e51c1ee4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440928 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813281}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/16ebcf601d7f..ed3a93f690de 2020-10-02 senorblanco@chromium.org Fix rectangular mipmap textures used as color attachments. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib456da342d0c3c99ec475dffa2a8358eb32676f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813280}
-
Jazz Xu authored
This CL modifies media tray bubble behavior such that when the dialog is opened and all media stops playing, we will show an empty state indicating there's no media playing instead of close the dialog immediately. Bug: 1134414 Change-Id: I3f0f2489da2189e6a71f74f6a00855d8b4a535f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444529Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813279}
-
George Steel authored
Allow checks which skip a prefix, as needed for proper behavior in TransformOperations::BlendRemainingByUsingMatrixInterpolation(). This method will now only create InterpolatedTransformationOperations which are actually box-size dependent (as originally intended) ans create a matrix otherwise. Add a DCHECK for this property. Note that the interpolation defined in the css-transforms-1/2 specs assume that transform styles are calculated after layout, with matrix interpolation always producing a Matrix3DTransformOperation. As style is calculated before layout, this isn't possible in cases where the inputs to matrix interpolation are layout-dependent, so we have InterpolatedTransformOperation to defer interpolation in these cases. There is a currently CSSWG resolution to spec this behavior and give InterpolatedTransformOperation a defined serialization, having interpolation return a matrix as per the current spec where possible (the inputs of matrix interpolation are layout-independent) and an interpolated operation otherwise (where the current spec is inconsistent). The added DCHECK enforces this behavior. Resolution: https://github.com/w3c/csswg-drafts/issues/2854 This is to prepare for using DependsOnBoxSize for invalidation of compositor animations, enabling acceleration of percent-containing transform. Design Doc: https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I2302546225ac52f47104d2dd77b02f874d2f6ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432194Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813278}
-
Haiyang Pan authored
The pool has plenty of 4-cores for extra builds: http://shortn/_yG5NjPy3mD And 100 more 4-cores are added to the pool in crrev.com/i/3308210 Bug: 997376, 1127110 Change-Id: I377f3192f5da13f59c1d057f28b2b97ab3f08dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446511Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813277}
-
Denis Kuznetsov authored
BUG=b:169122360 Change-Id: I7aac27aaaa769dec9a046c40e822d6f96b94d76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445500 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#813276}
-
Joshua Pawlicki authored
This prevents the --install process from exiting before the global service is actually available. Additionally, since we are going to call UpdateService to update the app registration anyways, this is the appropriate time to wait until its there. Bug: 1131654 Change-Id: Ifff75fafdf71a46877e9918bc26a40961703b86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441283 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813275}
-
Anastasia Helfinstein authored
This is a pure refactor with no functional change. TBR=akihiroota@chromium.org AX-Relnotes: n/a. Bug: None. Change-Id: Ic729688e78abc23769b56f6aceb0aff4201e40c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444433Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#813274}
-
Becca Hughes authored
This is a reland of af996d67 The break is fixed upstream and rolled into Chromium. TBR=calamity@chromium.org,steimel@chromium.org Original change's description: > Reland "Use JS modules for the NTP module" > > This is a reland of 7927c8a6 > > TBR=calamity@chromium.org,steimel@chromium.org > > Original change's description: > > Use JS modules for the NTP module > > > > Uses JS modules for the NTP module and updates > > closure so it can resolve chrome://kaleidoscope. > > > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > > Reviewed-by: calamity <calamity@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811807} > > Change-Id: I348d2116dc851394804866642a24da48d25e3edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812268} Change-Id: I2c7dde07d627238c7789f21be2fecc0f49bf2e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446110Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813273}
-
Scott Violet authored
It should only call OffsetFromScrollableContainer() if the supplied LayoutObject is a scroll container. BUG=1134184 TEST=covered by clusterfuzz Change-Id: I1109a8514590882246dfebe46b7340ac654829cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442895Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813272}
-
Marijn Kruisselbrink authored
This adds use counters for the entry points to the File System Access API (https://wicg.github.io/file-system-access/) to UKM use counters to record usage of the API and observe how it is being used to help with improvements to the shape of the API. Change-Id: I31a0491771f31a14b86c6f29fff42457e1503072 Bug: 1134624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438678 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#813271}
-
Joshua Pawlicki authored
Flakiness is expected to be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2441283 If not, revert this CL. Bug: 1131654 Change-Id: Iecc0f750e62349a94df04309974147ab23f46f92 Fixed: 1131654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441380 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813270}
-
Jamie Madill authored
Uses the new 'use_isolated_scripts_api' feature added here: https://crrev.com/c/2425210 to switch the tests to the ANGLE standalone testing harness. Bug: angleproject:5124 Change-Id: I363997060874df09653bcb78bb9c57f3cce3f6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441149 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813269}
-
Steve Kobes authored
A subframe's PaintTimingDetector is supposed to stop recording after an input, but we were only calling NotifyInputEvent on the same-site codepath (WebViewImpl) and not the OOPIF codepath (WebFrameWidgetImpl). This also ensures that we set first_input_or_scroll_notified_timestamp in PageLoadMetrics timing updates after an OOPIF input. Bug: 1115529 Change-Id: I9599d1cc7094551b899cfa19591eeaf5c85eb88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436770Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813268}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02818d1fdd05..375fee944c76 2020-10-02 zzyiwei@google.com Use vndk/window.h instead of the system one If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I693c1d7442c2211dbbb7f98d1fb26a8b65b95ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813267}
-
Chris Hamilton authored
This CL implements the data structures that are needed for bookkeeping V8 contexts, and related concepts. The lifetime management of these structures is testing in isolation. A further CL will implement business logic on V8ContextTracker, and add tests for that. BUG=1085129 Change-Id: Iececc631fa38f04359ebeb823c53b641e57a4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443490 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#813266}
-
Xiaodan Zhu authored
The M87 changes the switching desk gesture direction when reverse scrolling for touchpad is off. This CL flips gesture direction of switching desks and show a toast when reverse scrolling is off. Bug: 1107183 Change-Id: I58dc18331bc9f917a571b033b8caac63a3da95bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444438 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813265}
-
Guillaume Jenkins authored
It appears that in some rare cases that aren't fully understood yet, old versions of intents are passed to Chrome instead of the new intents. This makes it so any new intent parameter isn't there or is of the wrong type, which can lead to crashes. This CL attempts to prevent these crashes by adding type checks and null checks for properties missing in old intent versions. Bug: 1133825 Change-Id: I55ec931ccdaf1afaf36ab31f73c405ac7c2b49b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441631Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#813264}
-
Erik Chen authored
A full test cannot be written right now because the ash instance being launched does not support attestation. The stub is a browser_test because there is no infrastructure for creating low-level crosapi integration tests. Bug: 1134349, 1134340 Change-Id: I54c47be5d2e22b0efa1dec3d130e1223bffd56a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443515 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813263}
-
Joshua Pawlicki authored
These will be uploaded together to the signing infra. Bug: 926234 Change-Id: Ie6939d996687727db3c67be444fa8d7062b80433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443792 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813262}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I193b419c898ae177d40d57831fa4b4cebce30600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443971Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#813261}
-
Alice Wang authored
This CL refactors AccountPickerDelegateTest by moving some common part to the test setup. Bug: 1121536 Change-Id: I758ed411a0e9e91129e917d214a3ad4e0afb3e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444313Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813260}
-
ssid authored
BUG=1132511 Change-Id: Ic6d3b50b5c2cd5a7bed896d8afe6108f73ccea98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443939 Commit-Queue: ssid <ssid@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813259}
-
Ben Joyce authored
Reduces time 56683ms from 4247ms Bug: 989569 Change-Id: I1c4a1fbeca865bbce30c3cdf769954425fd3f845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439434Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#813258}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3e40e9e1f3d..13f6549d5a10 2020-10-02 tvanderlippe@chromium.org Typecheck sources/CallStackSidebarPane.js with TypeScript 2020-10-02 jobay@google.com Typecheck quick_open/QuickOpen.js with TypeScript 2020-10-02 alexrudenko@chromium.org Migrate ScreencastView.js to TypeScript 2020-10-02 jacktfranklin@chromium.org Add text node updates to Mutation test helpers 2020-10-02 changhaohan@chromium.org TypeScriptify elements/ColorSwatchPopoverIcon.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I088d68443996943c0bf5799568720c42e29f5469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813257}
-
Caitlin Fischer authored
The feature was added in https://codereview.chromium.org/1294923003. Bug: 1126640 Change-Id: Ic725b63fd699f1d1ab46534e27deb2536814c582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427883Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813256}
-
Maria Kazinova authored
Adding a check for _suggestionHandledCompletion in a block prior to calling it. Bug: 1134005 Change-Id: I8a8fae7abe4567925514bd98841d5866f70c2dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445010Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#813255}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010020800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/4PfglR4idxErCwlOi4wGGe41pnR_tcljR1Vo_Sa5OzcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Iaacfa75bf3a4771c0ce23527843d0b2c90d7781b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445728Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813254}
-
Dave Tapuska authored
Keep the API internal on WebFrameWidgetBase but change the API to use gfx::Rect. The return value from SelectionBounds was removed since the return code was never checked. BUG=1097816 Change-Id: I0d4427eb78f646da06763fb99dc701726d73ce91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442642 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813253}
-
Charlene Yan authored
Logging the number of tabs in a particular domain along with a rough estimate of the total number of tabs across all windows. Bug: 109917 Change-Id: I7c88cc6693b41d34b671342697b20772ef377f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441285 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813252}
-