- 07 Jun, 2019 40 commits
-
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //tools. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=rhalavati@chromium.org TBR=tsepez@chromium.org Bug: 970209 Change-Id: I53e4f75e0f6218f7e240f0f767a75b7d13e92cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648231Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667056}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //device/bluetooth/bluez. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=mcchou@chromium.org Bug: 970209 Change-Id: I1c5a45e7e13f822afd049090723cb9c1c7dcf9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648339 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667055}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //ipc. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. TBR=tsepez@chromium.org Bug: 970209 Change-Id: Ic4d52830490eda6fc3aca546f390a2287142c7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648341Reviewed-by:
-
Hayato Ito authored
The context is http://crbug.com/946719. We want to fix a crash, however, it would be difficult to reproduce it locally. To get an insight on a crash, it would be better to distinguish an error state of ResourceRecord, so that we can know who sets "-1" here. Now an error state has two kinds of values, instead of just -1, and we can know who sets an error state clearly when WriteResourceRecoredInBatch is called and DCHECK is hit. Note that |ResourceRecord::size_bytes| is a public field, so this CL is not perfect, however, that could be okay for the purpose of debugging. Bug: 946719 Change-Id: I592e1a4622220f5c7ff4eb5112947100b5562e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645113Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#667053}
-
Mohamed Amir Yosef authored
This reverts commit 2018af5b. Reason for revert: launch is now approved for beta! Original change's description: > Revert "Enable new session sync logic by default" > > This reverts commit cda7826e. > > Reason for revert: launch approvals pending. > > Original change's description: > > Enable new session sync logic by default > > > > The new logic has better privacy and reliability properties, and has > > been experimented with on dev and canary channels. We now enable it by > > default to launch with M75. > > > > Some unit tests had to be updated to reflect the new behavior, and some > > additional refactoring is used to improve the accuracy of some function > > names. > > > > Bug: 882489 > > Change-Id: I9eb0816cbec1024581efc227b551781a6fbd6559 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543389 > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#645925} > > Bug: 882489,965951 > Change-Id: I04b12de7ab33368fbfe4e5579b2ed974ba78a7c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624574 > Auto-Submit: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662168} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882489, 965951 Change-Id: If992df3e164fdfc605964cfc30d0893d726ee99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649317Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#667052}
-
Etienne Pierre-doray authored
Change-Id: I08289ef9d8e1cb665393823495e292a9cbc236c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645220Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#667051}
-
A Olsen authored
Screenshot (google internal) https://screenshot.googleplex.com/Ho2vcfZ8PHt.png Bug: 930109 Change-Id: I1eff83104085b1fff498fb4817dda196ee3a7a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640648Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667050}
-
Eric Seckler authored
Both tracing and the sampling profiler need to know when the current thread's name changes. Make it possible to add multiple thread name change observers to support this. Bug: 971642 Change-Id: I824e1fec7c7b59cd85e4aa93b7f5ee1e9875ab68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648239 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#667049}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/726acb457e59..8f23fb0caa01 Created with: gclient setdep -r src-internal@8f23fb0caa01 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: I222d0b55834498ac1e24a65958e24028a5118aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648990Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667048}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib244691e1ec503a2b62f432aad7f944f53ba51de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667047}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey and base::ContainsValue with base::Contains in //base. Bug: 970209 Change-Id: I7457bcfadd8501159d0a44a32b30e45cf4af7aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646778Reviewed-by:
-
Jérôme Lebel authored
Switching from CreateWebAndAppSettingDetailsController() to PresentWebAndAppSettingDetailsController(), to open Account Settings Manager. Related to: crrev.com/c/1349969 (Adding new API in ChromeIdentityService) crrev.com/i/721689 (Implementation in ChromeIdentityServiceImpl) crrev.com/i/721693 (Removing old implementation in ChromeIdentityServiceImpl) crrev.com/c/1350185 (Removing old API from ChromeIdentityService) Bug: 905680 Change-Id: I2d895e5472a44cd61121a6a51295afb823398438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1350630 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#667045}
-
Etienne Bergeron authored
This CL is adding events on potentially expensive calls. see: https://bugs.chromium.org/p/chromium/issues/detail?id=938971#c5 We are adding some trace events to the fonts category. They still belongs to UI since the global effect on font-cache will affect the UI. We are proposing to put in "fonts" only category the basic fonts accessors. Calls that has a global effect should stay in "UI" category. R=drott@chromium.org CC=benck@google.com Bug: 938971 Change-Id: I15b7939e63a9fb27d5ba70f79a851c00628cf94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646994 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#667044}
-
Takashi Toyoshima authored
Bug: 905971 Change-Id: If8e1339831394e9bdaed5d1f28a89a1aacfa9101 Tbr: yhirano@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644892 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#667043}
-
Armando Miraglia authored
This reverts commit 91948560. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/38757, consistent failures on mac of the following tests: TabDragging/DetachToBrowserTabDragControllerTest.DragToPinEnabled_DragToUnpinInNewWindow/0 TabDragging/DetachToBrowserTabDragControllerTest.DragToPinInNewWindow/0 Original change's description: > Add ability to drag tabs between pinned and unpinned tabs to modify the > pinned state. > > Bug: 965681 > Change-Id: I4cebf850839a1fdbee702ab2cd3c2fccbdba811e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637045 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666796} TBR=bsep@chromium.org,cyan@chromium.org Change-Id: I0a68811b31c718fcdccba6058ab6bdf664a1547a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649316Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#667042}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e8362655a66..6faf8d662af8 git log 0e8362655a66..6faf8d662af8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b91f87b6ce1c..ea49f6f5d4e3 (8 commits) Created with: gclient setdep -r src/third_party/skia@6faf8d662af8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I40e9ecded836a813462e0f5fb35bfa54a3667b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648986Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ac0bd6cc3e5..c2c829bc9a63 git log 8ac0bd6cc3e5..c2c829bc9a63 --date=short --no-merges --format='%ad %ae %s' 2019-06-06 swiftshader.regress@gmail.com Regres: Update test lists @ 5c9e165b Created with: gclient setdep -r src/third_party/swiftshader@c2c829bc9a63 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I31e3d7f44206679845db06f2555521e6a7f49356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648878Reviewed-by:
-
Mike West authored
This patch adds web platform tests to verify the behavior of the referrer header and `document.referrer` after flipping the length limitiation flag to on-by-default. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/lckJ5OAkUNo/ooVNdvhLAgAJ Bug: 959757 Change-Id: I385f8f12f20109c50ededb9018a08cd665cb6868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646784 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667039}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/104f3fc6931f..726acb457e59 Created with: gclient setdep -r src-internal@726acb457e59 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I75acdcdf66273e2153c209e27346b15108e9a1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648984Reviewed-by:
-
Abhijeet Kandalkar authored
ListHashSet is deprecated in favor of LinkedHashSet. HeapLinkedHashSet's invalidate iterators when the container is modified. This does not happen in this usage, so replacement is simple. Bug: 614112 Change-Id: Idd46f56d4d5a649799476a84b5ad8cfda8da8973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646292Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#667037}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/44425cc746ac..0e8362655a66 git log 44425cc746ac..0e8362655a66 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5f60135c..6406ce90 (429 commits) Created with: gclient setdep -r src/third_party/skia@0e8362655a66 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I93cece50cdc69890e247cc3ccae3f6ba7c2675b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648627Reviewed-by:
-
Darwin Huang authored
Change-Id: Ia44cf1d48996f407e6de55274d5e1c7579826ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649088 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Hayato Ito authored
Fixes a crash caused by the wrong assumption on FrameTreeNodeIdRegistry. FrameTreeNode id may already be removed from the registry so we have to do a null-check for IsMainFrameGetter callback. Bug: 971719 Change-Id: I370cfc83c3e72327824b6f76e81031a961839709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646683Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#667034}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6b5832c0b801..8cb795c23d5c git log 6b5832c0b801..8cb795c23d5c --date=short --no-merges --format='%ad %ae %s' 2019-06-07 dberris@chromium.org SheriffRedux: Limit some APIs to the luci-config service account Created with: gclient setdep -r src/third_party/catapult@8cb795c23d5c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181 TBR=skyostil@google.com Change-Id: I85f13d6746ef2cb6887243826ded3638ff79a49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648983Reviewed-by:
-
David Benjamin authored
https://chromium-review.googlesource.com/c/1447046 removed most of it, but certificate_warning_origins_ remains. (I was in the neighborhood and noticed this.) Bug: 766981 Change-Id: Icc7c83e9f1953c9052273b94133490bef779806c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646668 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Mei Liang authored
This API is for manually group multiple tabs through the TabSelectionEditor. Change-Id: I8782eb2185e69b60b72ad61ef0fd3be8724ae210 Bug: 971872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649138 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667031}
-
Andrew Stone authored
1. Make GetMatchingIsolatedOrigin() respect wildcard isolated origins. The matching behaviour for GetMatchingIsolatedOrigin() is changed such that when iterating the list of isolated origins per site, if a wildcard origin is encountered, the function returns immediately. This prevents a non-wildcard isolated origin elsewhere in the set being matched. 2. Add isolating wildcard domains to ChildProcessSecurityPolicy. Provide an additional implementation of AddIsolatedOrigins which accepts a list of IsolatedOriginPatterns, correctly preseving whether or not they are wildcard isolated origins when converted to IsolatedOriginEntries. 3. Add IsolatedOriginPattern, a container class for wildcard patterns. In order to add support for isolating all sub-domains of an origin, expressed by a double asterisk (e.g. https://**.foo.com) a new container class is required. We are unable to use GURL or url::Origin to hold these patterns as they escape the '*' character to '%2A', which would make parsing brittle if this behaviour ever changes in the future. Instead we propose to hold user-supplied data in an IsolatedOriginPattern instance, which correctly identifies and removes wildcards. After removal of the wildcards conversion to url::Origin() is possible, requiring only minimal changes to code that calls ChildProcesssecurityPolicyImpl::AddIsolatedOrigins(). 4. Add double-wildcard support to IsolatedOriginEntries. Double wildcard origins are origins for which any sub-domain should be subject to site isolation. By default the varaiable is initialised to false; future commits will permit callers of ChildProcessSecurityPolicy::AddIsolatedOrigins() to specify URLs of the form https://**.foo.com to isolate any sub-domain that matches the specified pattern. Design doc for these chanes is available here: http://doc/1nAL_ZH64weVOaTSpfA85MOdNW1RzTAZg2A3i1oixAuE Bug=chromium:926997 Change-Id: I5259cf1e7fd69ad933ce741debb979c155d0a9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589080Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Andrew Stone <ajws@google.com> Cr-Commit-Position: refs/heads/master@{#667030}
-
Kinuko Yasuda authored
This reverts commit 7b716004. Reason for revert: Suspected to cause content_browsertests crashes: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/59142 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/59143 Original change's description: > Add more crash keys to understand Android NTP renderer kills. > > Bug: 970046 > Change-Id: I9c33146f4061afacee57a2b85dad4c29627434ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647151 > Commit-Queue: Charlie Reis <creis@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666875} TBR=creis@chromium.org,alexmos@chromium.org Change-Id: I90c8d916937be0713fb98a1acc45ab189d3cc9f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 970046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647228Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I255aa075c8cee3947c802b099bd561ff52b39243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649437Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/823103161359..44425cc746ac git log 823103161359..44425cc746ac --date=short --no-merges --format='%ad %ae %s' 2019-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5c9e165bc4d5..c2c829bc9a63 (4 commits) 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-07 bungeman@google.com Remove duplicate simple samples, make one a gm. 2019-06-07 brianosman@google.com Remove unused caps: UnsignedSupport and ImageLoadStoreSupport 2019-06-07 fmalita@chromium.org [skottie] Fix text selector sub-unit range handling 2019-06-07 brianosman@google.com Fix line numbering problem when reporting SkSL compile errors Created with: gclient setdep -r src/third_party/skia@44425cc746ac The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: I390fc36d61f310faf9d4510410de353b02e25ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649439Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/991302572440..6b5832c0b801 git log 991302572440..6b5832c0b801 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 dberris@chromium.org SheriffRedux: Cloud Build for sheriff-config Created with: gclient setdep -r src/third_party/catapult@6b5832c0b801 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Change-Id: I8798bf367183baa68f4e7c21132d96cd94f3fdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649438Reviewed-by:
-
Xianzhu Wang authored
Those are "logical block coordinates", without considering text direction. Examples are "LogicalLeft" and "LogicalRight". Bug: 969383 Change-Id: I80ebf01fd4335e3fff982fa8a5c8e04875024268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648807Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#667025}
-
François Degros authored
Bug: 778674 Change-Id: I9034aef90b8b613941727195000dfe25f93fedaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644732 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#667024}
-
Tomasz Wiszkowski authored
This change aligns visual style of EditUrl suggestion with other suggestion types when Favicons are shown. Bug: 960464 Change-Id: I2b3050dd5d644765b30edd8526f0fc9e12335278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642680 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#667023}
-
Nigel Tao authored
The App Service refactors how Chrome OS programatically lists its apps, regardless of app platform (e.g. Web apps, Android apps, Crostini apps, etc.). It is a Mojo service, as one of the design goals is to be able to, at some later date, spin the App Service out-of-process. For more details on the App Service, see https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/services/app_service/README.md Being a Mojo service means that some tests need updating, as Mojo calls are asynchronous (because they are potentially IPC calls). This commit also adds another check that, when sync items are created, they are populated with actual data. Having a non-empty name is one simple way to check this. This fixes `sync_integration_tests --enable-features=AppServiceAsh --gtest_filter="SingleClientAppListSyncTest.*"`. It fails before and passes after this commit. Note that `sync_integration_tests --gtest_filter="SingleClientAppListSyncTest.*"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: I1f08999a2dc606152b9405f6b3ef3704426006bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637014 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
Change-Id: Id64ca1f1744001c34d8fa1bea04043c9c22b2857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646698Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#667021}
-
Hiroki Nakagawa authored
This issue was already fixed. Bug: 940316 Change-Id: I1e181dc914e05a6c22f56328d909f1ed86bc0439 Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647260Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#667020}
-
Xiaocheng Hu authored
NGInlineItems does nothing but a standard span, so this patch replaces it by a standard span. Change-Id: I750e1e4522658999b8570d9660fa3196acec14ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649295 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Noel Gordon authored
RAW images from PiexWasm provide image photographic details in the so- called |ifd| data. Record that ifd data in the Image Loader IDB cache, along with all the other metadata cached about a RAW image. Return the ifd in Image Loader {LoadImageResponse} to client requests. Image Loader clients maintain a local cache of {LoadImageResponse} (to avoid calling Image Loader when possible). Include the ifd data in the client local cache. Because most images have no ifd, caching it as a |null| value is fine: for debug, but also for cache size/performance considering the size of their image data. And the same for RAW images: ifd is order 100 bytes and small compared to the RAW image data size. Bug: 965370 Change-Id: I762360280ad23529c1ac7c113b854a58081aadbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647895 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
When console.error() is called, only the first argument is logged to profile logs (crbug.com/967927). Further, if an object is stringified, it shows up as "[Object object]" in the profile log. To help track down zip file creation problems, explicitly log the error code as part of the first argument of console.error(). BUG=None Change-Id: I0a793a11c14d803f26db1d93268594dc42a0aea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646682 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#667017}
-
