GitLab

BUG=124330
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10206016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133683 0039d316-1c4b-4281-b951-d872f2087c98

Revert 133663 - 1. Fix JSDocs in directory_model.js.
2. Replace all getters and setters in directory_model.js with get*() and set*() methods.
Review URL: https://chromiumcodereview.appspot.com/10206015

TBR=oleg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10201018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133679 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133678 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133677 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133676 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10200014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29914
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10198010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124244
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10203011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133672 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10203009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123140
TEST=Manual


Review URL: http://codereview.chromium.org/10207009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:8092
TEST=MobileConfigTest


Review URL: http://codereview.chromium.org/10141006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:26471
TEST=After entering the folder none of the files is selected.
Review URL: https://chromiumcodereview.appspot.com/10204015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133666 0039d316-1c4b-4281-b951-d872f2087c98

This was broken by columns rename.

BUG=chromium-os:29874
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/10205011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133665 0039d316-1c4b-4281-b951-d872f2087c98

Adding a led icon for media stream. This icon will show up in the status tray when media stream starts using capture devices.
Added separately to avoid problem with the try bots.

BUG=123767
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10180005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133664 0039d316-1c4b-4281-b951-d872f2087c98

2. Replace all getters and setters in directory_model.js with get*() and set*() methods.
Review URL: https://chromiumcodereview.appspot.com/10206015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133663 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133662 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10197006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133661 0039d316-1c4b-4281-b951-d872f2087c98

Times out on Win7 Debug - see bug for details.

BUG=124776
TEST=None
TBR=willchan@chromium.org


Review URL: http://codereview.chromium.org/10207008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133658 0039d316-1c4b-4281-b951-d872f2087c98

Special handling of CWS icon.
Also correctly handle URL rewrites in favicon requests.

BUG=chromium-os:28314,chromium:120471
TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon.
Review URL: https://chromiumcodereview.appspot.com/9979001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124374
TEST=PolicyServiceTest.* in unit_tests are green


Review URL: http://codereview.chromium.org/10191005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133656 0039d316-1c4b-4281-b951-d872f2087c98

Reimplement RequestNetworkServiceConnect, RequestRequirePin, RequestEnterPin, RequestEnterPin, RequestChangePin, RequestCellularRegister without Libcros

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/10134027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133654 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133653 0039d316-1c4b-4281-b951-d872f2087c98

Do not include Ctrl+N and Ctrl+Shift+N in chrome/browser/ui/views/accelerator_table.cc when USE_ASH is #defined.

The shortcuts should be excluded since they're already included in ash/accelerators/accelerator_table.cc. Removing this kind of duplication is necessary for implementing crbug.com/123856 correctly. Along with the change, add unit tests for preventing the same mistake in the future.

BUG=123856
TEST=ran unit_tests

Review URL: http://codereview.chromium.org/10177002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133651 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org

BUG=124779

Review URL: https://chromiumcodereview.appspot.com/10140018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133650 0039d316-1c4b-4281-b951-d872f2087c98

Add comment to explain why some of the strings are typed as string16, and a TODO as a reminder to change this down the road.

BUG=113688
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10181004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133649 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org

BUG=124777

Review URL: https://chromiumcodereview.appspot.com/10202006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29835
TEST=1. Double click on an image A to open the Gallery, navigate to image B in the Gallery, exit the Gallery. Image B should be selected in the File Manager.
2. Select several images, click "Open", exit the Gallery. The selection should stay the same.

Review URL: https://chromiumcodereview.appspot.com/10184008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133647 0039d316-1c4b-4281-b951-d872f2087c98

IDL defines close behavior as it ignores the reason argument if the type of
reason is PP_VARTYPE_UNDEFINED.

BUG=124609
TEST=browser_tests --gtest_filter='*WebSocket*'


Review URL: http://codereview.chromium.org/10167028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133646 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses NSS leaks happening after changing the "Chromium OS Heapcheck" bot from i386 to x86_64.

TBR=thakis
BUG=51988
TEST=make the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10206012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133645 0039d316-1c4b-4281-b951-d872f2087c98

Replace them with GetOperationRegistry(), in favor of less
public member functions from GDataFileSystem class, which is
overly large.

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10196007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133644 0039d316-1c4b-4281-b951-d872f2087c98

Make functions being routed by NativeHandlers throw an exception if there is no ModuleSystem in the current context.


BUG=124208
TEST=existing tests


Review URL: http://codereview.chromium.org/10208001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133643 0039d316-1c4b-4281-b951-d872f2087c98

This CL is for crbug.com/123856 (Aura shell applies accelerators without giving apps the option of handling key events). Currently, shortcuts for IME/layout switching (Shift+Alt, Ctrl+space, and so on) are processed before InputMethodEventFilter, and other Ash global shortcuts are processed after the filter. This is for ensuring that the IME shortcuts always work even if an IME (or an IME extension - http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/input-method-editor) tries to consume the shortcuts. However, this strategy is not compatible with crbug.com/123856. In order to fix crbug.com/123856, we sometimes have to process an Ash global shortcut key (including IME ones) after the key is passed to a web page.

This CL modifies accelerator_table.cc and shell.cc so that they process IME shortcuts after InputMethodEventFilter, and also simplifies ash/accelerators/ and ui/base/accelerators/accelerator_manager.cc by removing code for processing pre-IME shortcuts.

BUG=123856
TEST=ran aura_shell_unittests and ui_unittests

Review URL: https://chromiumcodereview.appspot.com/10155015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124605
TEST=none


Review URL: http://codereview.chromium.org/10175005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133641 0039d316-1c4b-4281-b951-d872f2087c98

This change adds suppression rules for the leaks happening in the above test. Also, it removes an obsolte suppression for GoogleURLTrackerTests.

TBR=thakis,pkasting
BUG=124766
TEST=make the "Linux Test (valgrind)(8)" bot, the "Linux Heapcheck" bot, and the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133640 0039d316-1c4b-4281-b951-d872f2087c98

Replace them with GetCacheDirectoryPath(), in favor of less
public member functions from GDataFileSystem class, which is
overly large.

Wanted to make them just utility functions in gdata_util.cc
but turned out we needed Profile* to compute these directory paths.

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10198003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114148
TEST=browser_tests --gtest_filter=ExtensionApiTest.FontSettings


Review URL: http://codereview.chromium.org/10177003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133638 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10207005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133637 0039d316-1c4b-4281-b951-d872f2087c98

This was a bit tricky since some of the functions had no instance context, so I added global functions on the PpapiGlobals interface for them. It would be nice to add a PP_Instance argument and fix this in the future.

I did a new style of doing the thunking. The "function APIs" haven't really worked out since it's almost always easier to add the functions directly on the instance one. Since this is a larger and more separable chunk, I just added a getter on the instance API for the flash API and thunk through that. I'd like to convert the remaining ~3 function APIs to either call directly on the instance or use this method, but that's not addressed by this patch.

I moved the flash command line switch to plugin_switches so this could be hooked up properly. It allowed me to delete the delegate API for this.

I combined the flash fullscreen functions into the new Flash API which removed a bit of code.

Review URL: https://chromiumcodereview.appspot.com/10091003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133636 0039d316-1c4b-4281-b951-d872f2087c98

This change updates suppression rules for Bug 90013 to remove unknown symbols as much as possible. We need to install more debug symbols, though.

TBR=thakis
BUG=90013
TEST=make the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10140015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133635 0039d316-1c4b-4281-b951-d872f2087c98