- 15 Jun, 2018 40 commits
-
-
Patrick Monette authored
Bug: 798612 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie9bb7d1af812a96f11058c928cb32fa6491d96db Reviewed-on: https://chromium-review.googlesource.com/981079 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#567797}
-
Kyle Horimoto authored
Creates connections to remote devices over Bluetooth, using either the listener role (BLE scans only) or the initiator role (a combination of BLE advertising and scanning). When a connection is attempted, it remains active until either an AuthenticatedChannel is returned successfully or until the request is explicitly removed via one of the Cancel*() functions. Bug: 824568, 752273 Change-Id: Icda1cde32e3d4455742c1570df15b82979cd0ace Reviewed-on: https://chromium-review.googlesource.com/1100133 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#567796}
-
Ryan Tseng authored
* Default Mac to 4 cores * Add recipe names to non chromium recipes Bug: 840631 Change-Id: Ib90206c80f41efa9e9d6aaed6977b39101a8f5a0 Reviewed-on: https://chromium-review.googlesource.com/1103221Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#567795}
-
kylechar authored
This reverts most of commit a51e3935. The thread configuration for --enable-features=Mus doesn't exist anymore and fixing mus introduced a different race for the non-mus configuration. Since mus is no longer the plan of record, revert the initialization order changes but keep logging and code cleanup. Bug: 840474 Change-Id: Ifec0e3dd9601e3895d0549109be5d10387f3b8b4 Reviewed-on: https://chromium-review.googlesource.com/1101139Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#567794}
-
Steven Bennetts authored
NetworkConfigurationObserver::Source is no longer used for anything useful in the code and should be removed. TODO: NetworkConfigurationObserver itself is appears to only be used in tests and could also be removed. The affected tests will need to be re-factored however. Bug: None Change-Id: Iaee8bf535bcb24488d294a33867e1137d548eda0 Reviewed-on: https://chromium-review.googlesource.com/1099600 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#567793}
-
chrome://enable-web-authentication-ctap2-supportJun Choi authored
This patch addes UI flag that enables by default support of CTAP2 security keys. Bug: 780078 Change-Id: Ib182644ddf98ebc80e7ffe9fb4bc66c76c44a98b Reviewed-on: https://chromium-review.googlesource.com/1101900 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#567792}
-
Georges Khalil authored
Bug: 847265 Change-Id: I332cd4d5bd6996019e132abbd313e765f4e080d3 Reviewed-on: https://chromium-review.googlesource.com/1082662Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#567791}
-
John Budorick authored
Change-Id: I670121d3b5de8720c626dedbf55218930bfd47fa Reviewed-on: https://chromium-review.googlesource.com/1102830Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567790}
-
Rohit Rao authored
BUG=853330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia30d658545ce7d3eb3397f1d1e282cbb7d581dc7 Reviewed-on: https://chromium-review.googlesource.com/1103117Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567789}
-
Filip Gorski authored
* Updates ContextualSuggestionsResult to carry finch trials * Updates tests that use the result * Register synthetic field trials with Chrome Metrics. Bug: 833867 Change-Id: Id40dfc098e2165f0c6ef3228b77d47e10857ffa1 Reviewed-on: https://chromium-review.googlesource.com/1097940Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#567788}
-
Nate Chapin authored
They appear to map acceptably to kReplaceCurrentItem and kBackForward. Change-Id: If727347cce399d0db74e28f014dd7f2e1bb1a95b Reviewed-on: https://chromium-review.googlesource.com/1097592Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#567787}
-
Ryan Hamilton authored
Merge internal change: 200745921 Clean up the QUIC end-to-end-test GetTestParams loop and comments. Merge internal change: 200748036 Only run the stateless reject versions of QUIC end-to-end tests for a single test. Currently the end-to-end tests are parameterized in such a way that we run 60 different versions of each of the 80 tests in end_to_end_tests.cc. This is a *ton* of tests and contributes to net_unittests in Chromium taking a very long time. One of the dimensions that these tests are parameterized by is stateless reject support: * supported by the client? * supported by the server? * using cheap stateless rejects? But this only affects the *handshake* and does not affect subsequent operations. So there's really no need to run all 80 tests with all the combinations of stateless reject-ness. This CL changes things so that only a single test runs with all the various stateless reject configurations and cuts the end_to_end_test runtime in half. Merge internal change: 200763662 Change-Id: I83ac58d0b8d34692d9db309cb45cfd7c6c64622b Bug: 806109 Reviewed-on: https://chromium-review.googlesource.com/1102895 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#567786}
-
Eugene But authored
TBR=mahmadi@chromium.org Bug: 852964 Change-Id: I37c1b3ef02b072abf139037d28f5fa43623ec1d8 Reviewed-on: https://chromium-review.googlesource.com/1101713Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#567785}
-
Ryan Hamilton authored
instead of a raw pointer. Remove uses of std::unique_ptr constructor in quic_test_packet_maker.cc. Merge internal change: 198628722 Change-Id: I94208e9684606a5415db12c84250696b2b33fa09 Reviewed-on: https://chromium-review.googlesource.com/1080068Reviewed-by:
-
Xiaoqian Dai authored
See mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQkoNXdY_I0T/files/MCHbtQVoQ2HCZQdO-rPhnZZs and https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQkoNXdY_I0T/files/MCFZleLj6_wSjPNtk9TKJWXx See recorded video: https://drive.google.com/open?id=1Dyz1kLKM0pbzMV3H2gXCNKrnjZmjJnIq Bug: 823769 Change-Id: Iad378e342477ba42fbf506dba751396f2f14b943 Reviewed-on: https://chromium-review.googlesource.com/1100378 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567783}
-
John Z Wu authored
Navigation may not occur right away after tapping on links, causing WaitForWebViewLoadCompletionOrTimeout to return immediately. Bug: 851472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5bf173f696dceeebc0118105a74fd0b19ebb27c9 Reviewed-on: https://chromium-review.googlesource.com/1103008 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Ted Choc authored
The .Main alias is meant for the launcher activity triggering only, so we want to ensure we don't pollute that with intents from within Chrome. The two sources found thus far are bookmarks and history. BUG=789732 Change-Id: I90dc10019a2d07076439f80f3f280d4635f2e02e Reviewed-on: https://chromium-review.googlesource.com/1102573Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567781}
-
Evan Stade authored
Pass inactive image, overlay images, frame colors over mojo. For the frame colors, it's easiest to verify it's working with a theme that doesn't have frame images but does set colors. These are relatively rare but here's an example: https://chrome.google.com/webstore/detail/simple-silver-aero/cnjlfhkndhkliabjhkikpnmkadfcndnd Bug: 836992 Change-Id: I7141c6c79e1ee1229eb430e8178271ecc4673689 Reviewed-on: https://chromium-review.googlesource.com/1081161Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#567780}
-
Pedro Amaral authored
The layout_gravity value center does the same thing as center_vertical|center_horizontal. This CL makes use of center. Change-Id: I625ffe5dc5b147ed39d986d862f38ee432fbfa7a Reviewed-on: https://chromium-review.googlesource.com/1102909Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567779}
-
Lindsay Pasricha authored
From version 1.13.0 to 1.14.0 And also remove the disable deprecated warning workaround. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b7297c224fd8da40e11d0c7043671f3979f6905 Reviewed-on: https://chromium-review.googlesource.com/1101561Reviewed-by:
-
Ryan Tseng authored
TBR: tandrii Bug: 840631 Change-Id: Iddeb2dc15402138468ad66552c148be1304dd96c Reviewed-on: https://chromium-review.googlesource.com/1103066Reviewed-by:
-
Sammie Quon authored
Previously disabled because failing in asan in mash. Change to use local functions instead of event generator and runs locally. Test: run tests Bug: none Change-Id: I9aeb99fef0da41b44074cf40608db5c29bfef137 Reviewed-on: https://chromium-review.googlesource.com/1101964Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5540528f81c0..6ae5d74e8671 git log 5540528f81c0..6ae5d74e8671 --date=short --no-merges --format='%ad %ae %s' 2018-06-15 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader a62cf68ca10c..700a1a67d569 (1 commits) 2018-06-15 stephana@google.com Refresh clang_win asset 2018-06-15 egdaniel@google.com Add to include path for vulkan memory allocator so SkTypes can be found. 2018-06-15 egdaniel@google.com Fix unused propFlags in GrVkMemory. Created with: gclient setdep -r src/third_party/skia@6ae5d74e8671 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I95a124838331684959d332a247d07b0ceaf83948 Reviewed-on: https://chromium-review.googlesource.com/1102860Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567775}
-
Sean Topping authored
This provides an entry point for adjusting the display color matrix. Bug: internal b/77489352 Test: CQ Change-Id: I6cd67bdef8c41d2e5b0e219250de6a3bcedee301 Reviewed-on: https://chromium-review.googlesource.com/1087330Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#567774}
-
Ehsan Karamad authored
This CL implements the logic required for enforcing 'vertical-scroll' (through feature policy) on frames where a preventing mouse wheel handler may block vertical scrolling. The CL essentially overwrites the value of dispatch type from mouse wheel handlers iff the suggested direction of scrolling is vertical. Bug: 611982 Change-Id: I15230f11f616d093b21984fe0b526d94dc62dada Reviewed-on: https://chromium-review.googlesource.com/1073729 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567773}
-
Charlie Harrison authored
Bug: 812767 Change-Id: I2e3d2653153fa66b47cc533cdaeb97c4786a2478 Reviewed-on: https://chromium-review.googlesource.com/1102480Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#567772}
-
James Wallace-Lee authored
This adds utility classes ApiHelperForM in android_webview/glue and content/browser/selection. It moves references to WebResourceErrorAdapter and FloatingActionModeCallback into these utility classes. On L devices, this reduces logspam caused by class verification on startup. Bug: 791099, 838702 Test: adb logcat | grep 'Rejecting re-init on previously-failed class' Change-Id: I3c5f096d58fbe710c6429f48b8cc11268683af0d Reviewed-on: https://chromium-review.googlesource.com/1100048 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567771}
-
Roberto Carrillo authored
R=hinoka Bug: 852883 Change-Id: Ia24d6f2b470097331510904b2ad46154e004d3ea Reviewed-on: https://chromium-review.googlesource.com/1101475 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
EasyUnlockServiceRegular now uses either CryptAuthService or DeviceSyncClient to get remote device info or perform Cryptauth calls, depending on whether the chromeos::features::kMultiDeviceApi is enabled. Once the migration to DeviceSyncClient has been completed across all of Smart Lock, code that references CryptAuthService will be removed. This is the last of other similar CLs which are migrating Smart Lock to use DeviceSync Mojo API instead of directly using the CryptAuth API. This CL also injects DeviceSyncClient into EasyUnlockServiceRegular, making Smart Lock rely entirely on DeviceSyncClient if chromeos::features::kMultiDeviceApi is enabled. I have manually verified that it works correctly by testing the following: 1. Setting up Smart Lock. 2. Using Smart Lock in the regular lock-screen manner. 3. Using Smart Lock in the login-screen manner. 4. Ensuring that notifications display at the correct time. 5. Turning off Smart Lock. 6. Ensuring that permits are correctly saved to prefs (the new model can't use the old way of grabbing the user's AccountId). TBR=jhawkins@chromium.org Bug: 824568, 752273, 848956 Change-Id: I3acc6dec46ff1ddc2875fbfe97261bb195a9494b Reviewed-on: https://chromium-review.googlesource.com/1102164 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#567769}
-
Robert Ogden authored
Bug: 853157 Change-Id: I72c1da0825f10f1102d2dcb003fc9fd525a1f577 Reviewed-on: https://chromium-review.googlesource.com/1102663Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Scott Violet authored
It assumed the root windows were all from the same WindowTree, which is not necessarily the case. BUG=837702 TEST=covered by test Change-Id: Ie1612d01c4e05d6a5d6b7228d1d0c1c01ba89902 Reviewed-on: https://chromium-review.googlesource.com/1102879Reviewed-by:
-
Aaron Leventhal authored
General fixes for active descendant and list boxes on Mac. - Introduce missing focusedAncestor property. Also, since there are 3 properties that always point to an ancestor. Group them together in the code and do not expose for root of contents. (Note: this is now similar to related WebKit code). - In a list, do not force focus to the listbox, as this breaks ARIA list boxes, by causing focus events to not be fired for active descendant changes. It also appears to be unnecessary despite the provided code comment. Bug: 666049,829945 Change-Id: I14c8c6836f2bb26d9ae0fe43d3e1b4d200abd413 Reviewed-on: https://chromium-review.googlesource.com/1096060Reviewed-by:
-
Orin Jaworski authored
Use 14x14 DIP icon in touchable mode, change icon color from COLOR_TAB_TEXT (GG800) to COLOR_BACKGROUND_TAB_TEXT (GG700), and turn on the ink drop hover highlight. Bug: 851041 Change-Id: I6b415d03a39914f7f35003be511b45332d1543f7 Reviewed-on: https://chromium-review.googlesource.com/1100196 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Yue Cen authored
If the user clicks the Install button after ARC++ is provisioned, we should start the flow right away. If not, we delay the flow until Play Store is ready. ARC++ changes: ag/4174872 This reverts commit 245e6851. This CL fixes the memory leak in the unittest from the original CL (https://chromium-review.googlesource.com/c/chromium/src/+/1080012). TBR=alemate@chromium.org, khmel@chromium.org, lhchavez@chromium.org TBR=yusukes@chromium.org, kerrnel@chromium.org, wzang@chromium.org Bug: 835029 Change-Id: Iedeca0ad5abd9033a0472bfeaa67ef818d9584ca Reviewed-on: https://chromium-review.googlesource.com/1102828Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#567764}
-
John Budorick authored
We were previously passing --gtest_shuffle down to gtest. However, in some cases (e.g. browser_tests, or other suites using content::TestLauncherDelegate), gtest wasn't seeing the flag until it was already in a test-specific worker process -- i.e., until it only had one test to shuffle. This moves the shuffling into the test launcher, before we hand off to the delegate, ensuring that we shuffle across the entire shard. The implementation is largely based on gtest's: reproducible given a seed, w/ a seed range of [0, 100000). This also uses --gtest_shuffle on browser_tests on Mac in an attempt to collect more data on what's causing VM WindowServer deaths there. Bug: 767397 Change-Id: I8aced17cdc5a574e3dc127143c0d0a553f62bf62 Reviewed-on: https://chromium-review.googlesource.com/1100966Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#567763}
-
Peter Boström authored
Exposes the avatar toolbar button for Incognito and Guest profiles on ChromeOS. While doing this the button is disabled so that it only acts only as a badge and not a way to invoke a profile switcher. Without this change under Refresh modes there were no visible Incognito or Guest indicator icons in the browser window. Bug: chromium:834522 Change-Id: If1cc5bea8da5a5e87d506a48ae8c668cc75c86e2 Reviewed-on: https://chromium-review.googlesource.com/1101546 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567762}
-
Vaclav Brozek authored
This CL lets the new FormData -> PasswordForm parser initialize some fields which always have the same value in this context: scheme, preferred, blacklisted_by_user, type Bug: 845426 Change-Id: I66f83bbc4f2031c4eb349786694110a4a3bbd89e Reviewed-on: https://chromium-review.googlesource.com/1100885 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#567761}
-
Bret Sepulveda authored
The Refresh tabstrip does not draw the toolbar top separator, so the test, BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor, is unnecessary in that mode. Bug: 846410 Change-Id: I1d9b0c386f51d57bf7cfef778e5e2892644b3ea9 Reviewed-on: https://chromium-review.googlesource.com/1102123Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567760}
-
Bret Sepulveda authored
Temporarily disabling the test so we can enable the feature by default. The test passes on other platforms. Bug: 853044 Change-Id: I81e0e8cbba01263a28f1eb567f9ac168c715982e Reviewed-on: https://chromium-review.googlesource.com/1102114Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567759}
-
Bret Sepulveda authored
Temporarily disabling the test so we can enable the Refresh feature by default. The test passes on other platforms. Bug: 853057 Change-Id: I95c330f0531e58a94fda4813bc4bffd3fa8bbedf Reviewed-on: https://chromium-review.googlesource.com/1102126Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567758}
-
