- 02 Dec, 2019 19 commits
-
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL reduces dependencies on ServiceWorkerProviderHost from navigation in favor of ServiceWorkerContainerHost. Conceptually, navigation for service worker clients don't have to depend on ServiceWorkerProviderHost to be renamed to ServiceWorkerHost. See the design doc for details. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I51c3bcb2e96149a576e58c98dceaa40ff88355fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942673 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#720380}
-
Hiroki Nakagawa authored
This CL renames ServiceWorkerContextWrapper::GetProviderHostIds() to GetWindowClientFrameRoutingIds() based on the following reasons: - GetProviderHostIds() returns pairs of process id and frame routing id (i.e., GlobalFrameRoutingId) contrary to its name. - GlobalFrameRoutingId doesn't make sense for worker clients because they don't have frame routing ids. The original GetProviderHostIds() contains GlobalFrameRoutingId for worker clients. The callers of GetProviderHostIds() filter them out by themselves, so that hasn't been problematic. However, worker clients should be filtered out by GetProviderHostIds() in the first place. This CL makes GetWindowClientFrameRoutingIds() filter out worker clients. Bug: 931087 Change-Id: I5c5c0a85a1ec68723453262066663b9aa030979c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942899 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Tab.enter/exitFullscreenMode() doesn't actually do any mode toggling job but is used as a means to plumb the request from content layer to ChromeFullscreenManager via TabObserver.onFullscreen{Enter/Exit}Mode. This CL gets Tab/TabObserver out of the flow, lets the call sites deal with it using FullscreenManager.FullscreenListener to achieve the same effect. The change assumes fullscreen mode switching can take place only when the underying activity is ChromeActivity. Added assert's to prevent future change from introducing bugs. Bug: 995903 Change-Id: Ib875da5555d2895450dc970901c2b3e51922174a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909956 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#720378}
-
Noel Gordon authored
No need to invoke the HTML parser from a template, when we can create the <icon-icon> directly using DOM createElement. Bug: 1026943 Fixed: 1026943 Change-Id: I2d026ac135310eb6cc4e997e5e9ffb0987f88cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942676Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720377}
-
Yuta Kasai authored
This CL doesn't change any behaviors. This just fixes typo. Change-Id: Idf8f85314d8d718bec7562f7b25de3a2f8ce8b28 Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943069 Auto-Submit: Yuta Kasai <yutakasai@google.com> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#720376}
-
Jeremie Boulic authored
Fix unaddressed comments in CL:1935772 post-landing. Bug: 999825 Change-Id: Ieca3c0440c697e8e6c4291f3cf3270b022cbe396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943083Reviewed-by:
-
David Staessens authored
When logging errors in the VaapiVideoDecoder the DVLOGF(3) and VLOGF(1) macros are currently used. The DVLOGF macro removes log messages in non-debug builds. The VLOGF macro hides error messages by default. This CL changes these macros to LOG(ERROR), so error messages are always immediately visible in the log. TEST=./video_decode_accelerator_tests on hana BUG=None Change-Id: I6abea849670e6a1ec4260e4ff8bfe6efdb143cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939992 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#720374}
-
Jeevan Shikaram authored
Rename permission-view to detail-view for better clarity. Bug: 999016 Change-Id: I365ea44f97cb3c7b261176310f5372acfb28154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943072 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720373}
-
Koji Ishii authored
This patch invalidates |LayoutBlockFlow| when inline |DisplayItemClient|s (i.e., |FragmentItem|s) will be destroyed. Currently, we invalidate |NGPaintFragment| for the root of the inline formatting context. With [FragmentItem], the containing |LayoutBlockFlow| is the |DisplayItemClient| for the root box, regardless whether it has inline children or not. Fixes ~70 crashes (DCHECK failures in paint_controller.cc). Bug: 982194 Change-Id: If3bfaad632b0cd3d2dc7bd3fce23b5bd99aa2b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943079Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720372}
-
Xianzhu Wang authored
to avoid confusion in VisualViewport about the element ids for page scale and scroll. This allows us to use ScrollableArea::GetScrollElementId() to find scrolling related entities, for all ScrollableArea subclasses. Previously PaintLayerScrollableArea::GetCompositorElementId() was the scroll element id, while VisualViewport::GetCompositorElementId() was not. Change-Id: Ic99b9ddf2ddda7cac8c68e7b8ce172bcb0b64c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942675 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720371}
-
Andres Calderon Jaramillo authored
This CL adds the guado-cfm and rikku-cfm builds to the IMPORT mode blacklist used by the video_decode_accelerator(_perf)_tests. The reason is that these boards decode VP8 using V4L2, so we need to force ALLOCATE mode for them. Bug: 1028329 Test: Run tast.video.DecodeAccel.vp8 in guado Change-Id: I7fb9b6d374cc65026b91c0ceafd82ece3d0c530e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943467 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#720370}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bcfcc04c53f0..0317de96ccff git log bcfcc04c53f0..0317de96ccff --date=short --first-parent --format='%ad %ae %s' 2019-12-01 perezju@chromium.org [dashboard] Skip identity test_path migration tasks Created with: gclient setdep -r src/third_party/catapult@0317de96ccff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1022380 Tbr: crouleau@chromium.org Change-Id: If9f1e41274b94a2ea04719e2a9273d689ab45fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944620Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720369}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cf5df561. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I7fc233be0df0c2989c51cf3156c518de6ef9bf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944381Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720368}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/page as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: I89d73850a0d6e5a7937ede262c166e317e63b253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942674Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#720367}
-
Nicholas Verne authored
This is to allow different UI treatments. Currently, Export/Import progress is surfaced in ChromeOS notifications. The current design for the container upgrade needs to show export progress in main dialog rather than a notification. This refactor enables both UI options. Bug: 1024693 Change-Id: Icb39ae531dab34b673ad0e5f86ee4de804665c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930271 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#720366}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/core/dom as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. Bug: 939691 Change-Id: Ief07b2217b90c859048b83aef1e8138ba0aaa14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942896Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c615f527533..df12488bf4f8 Created with: gclient setdep -r src-internal@df12488bf4f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I0b8839485e152dcca35540ffe0c1308225ceec05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944619Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720364}
-
Noel Gordon authored
The files-ng directorytree CSS uses box-sizing: border-box, and does not need a .file-row transparent border anymore. Remove it. Bug: 992819 Change-Id: Ie007ef3d8783c53c7ae8c636404f87c4bddd824c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943774Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720363}
-
Jing Wang authored
Add contextual function information in all errors in input ime api calls. Make all error messages to be a constant instead of plain string. Polish the text in some error messages. R=keithlee, shend Bug: 1024606 Change-Id: I1ce4dfc7275d2a88fb63c63bde1a3db11c50f7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939131Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720362}
-
- 01 Dec, 2019 21 commits
-
-
Chris Harrelson authored
A previous patch regressed performance due to the need to walk the containing block chain to find containing scrollable areas, in order to notify them of anchor adjustments. This patch iterates over all ScrollableAreas and notifies each of them. Bug: 1024434 Change-Id: Ibee4d9383ec1456c5e020c95aea941124fca048b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931148 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Alan Cutter authored
Our hit testing for the title bar window control buttons was not taking RTL mirroring into account. This CL fixes that. Without this CL the user was not able to drag the window in the top right corner when in RTL mode. Fixed: 1008371 Change-Id: Id84d381dca00ebb70931e3692fe4982df8827471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943491 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#720360}
-
Greg Thompson authored
Explicitly shut down the ShortcutsBackend and HistoryService in TearDown before cleaning up the ScopedTempDir. BUG=546640 Change-Id: I961dc49376116550e63a9c353d3d15a436731e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943130 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/487dd6fe1154..4c615f527533 Created with: gclient setdep -r src-internal@4c615f527533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib78c85b249e3e45e387b31935cabf7665abd83c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945523Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I6b12640aaa12422197b463b67b9d4f3e1eec4db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945477Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720357}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/877dd541e6bc..487dd6fe1154 Created with: gclient setdep -r src-internal@487dd6fe1154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2f71e7b2975a6468d66a0d497bdd6a9f6007d082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945521Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 477 478 479 480 481 482 483 487 488 879 lines were removed and 130 lines were deflaked by consecutive results since 474. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ie9fb740f80e6b988f551fbcbbda92bcc9beb98d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943772Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720355}
-
Mia Glaese authored
Bug: 982018 Change-Id: Id688ee3656a57e1853715dda09273b3bebc94b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932476 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#720354}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75b70f1566b6..877dd541e6bc Created with: gclient setdep -r src-internal@877dd541e6bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I88985121952442180debd95647ce8d14a7f78a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945515Reviewed-by:
-
Liquan (Max) Gu authored
This CL is to implement the PaymentHandler toolbar's close button. Given the fact that the sheet_tab_toolbar layout has added a close button, PaymentHandler UI who implements the layout should implement the button as well. Q: Why does the mediator of the PaymentHandlerUI observe the toolbar UI? A: The mediator is in charge of observing the components external to the PH UI itself, so it should observe the toolbar UI. Bug: 999196 Change-Id: Ic82053a38fc5a08924d764ef349b33b7af77f90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944609Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720352}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/485d5e9b4f96..75b70f1566b6 Created with: gclient setdep -r src-internal@75b70f1566b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I02783093dcfd39c07ddee56b355b63ce3323184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945513Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Iafd000269b6a31ac9d398625f485cb7646b495be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943345Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f68831184db..485d5e9b4f96 Created with: gclient setdep -r src-internal@485d5e9b4f96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I198e86ef03f1f1fa877fa3f3b4c2721b3cf97536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945512Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40d34e36512a..fd0c2574518c git log 40d34e36512a..fd0c2574518c --date=short --first-parent --format='%ad %ae %s' 2019-12-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@fd0c2574518c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Ic0cb02b42cba5902875b37ff7f41d2c963dd2d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943316Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a9764098e30..9f68831184db Created with: gclient setdep -r src-internal@9f68831184db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I57f9c5586f05c29cb668e9210e3e26d06ce955f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943315Reviewed-by:
-
Reilly Grant authored
Bug: 1007633 Change-Id: I91945e13761da0dcd237ce0667d5a72054f2e498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934524 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720346}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a763d19e5fe..0a9764098e30 Created with: gclient setdep -r src-internal@0a9764098e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Icfe1ca35687b4517ea22dcba3cdd31195f20a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945371Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGTSpanElement>(element) in place of IsSVGTSpanElement(element) Bug: 891908 Change-Id: Idae91831dfddadf9fe83ff26ce4689a336dac05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936624 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720344}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGFEDiffuseLightingElement> as new downcast helper 2. Use IsA<SVGFEDiffuseLightingElement>(element) in place of IsSVGFEDiffuseLightingElement(element) Bug: 891908 Change-Id: I49b225ca6095376c1c72352569a845f02987e5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936574 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by: -
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGSymbolElement>(element) in place of IsSVGSymbolElement(element) Bug: 891908 Change-Id: Ib5a0ea84c79388daca85cd8af541ba42522f92cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936623 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGTextElement>(element) in place of IsSVGTextElement(element) Bug: 891908 Change-Id: Ie5f192bb485ee66fcc7ba9b0d13082cbcb6b572c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936625 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
