- 02 Oct, 2018 40 commits
-
-
Corentin Wallez authored
This reverts commit 1c700bea. Reason for revert: Causes flakiness on the WebGL2 video tests on Mac. See crbug.com/891249 Original change's description: > [media] Reland: Fix video to canvas GPU-CPU race. > > VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED > must be retained until all reads have been completed. Such frames are > produced when software frames are uploaded to GpuMemoryBuffers. The > VideoResourceUpdater handles this, but PaintCanvasVideoRenderer > implemented only sync tokens. > > As a result, WebGL reads of software-decoded frames can tear when the > storage is reused for later frames. > > This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential > VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to > the VideoFrame until it completes. This ensures that the memory is not > reused until after the reads complete in the GPU process. > > TBR=pfeldman@chromium.org > > Bug: 819914 > Change-Id: Id181a476b78e2799bdbff149c9655427ae552743 > Reviewed-on: https://chromium-review.googlesource.com/1252962 > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595676} TBR=pfeldman@chromium.org,tedchoc@chromium.org,sandersd@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I5a1c66dc55ef5d4a5980704ef97dadea7ab41051 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819914 Reviewed-on: https://chromium-review.googlesource.com/1256372Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#595808}
-
Mythri Alle authored
V8 compile options related to producing code caches (kProduceParserCache, kProduceCache, kProduceFullCodeCache) are no longer supported and would be deprecated. This cl fixes chrome to not use those options. V8 provides an explicit API (CreateCodeCache) to generate code caches. Change-Id: I8039c6e4ef84133af5b1e406f10fbd5b166acdb4 Reviewed-on: https://chromium-review.googlesource.com/1254147 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#595807}
-
Sam Zackrisson authored
echo_control_mobile() and echo_cancellation() interfaces are replaced with AudioProcessing::Config. Some configuration is now hardcoded defaults in APM, and hence should not (can not) be configured in these processors. Statistics are now accessed through AudioProcessing::GetStatistics. A UMA metric disappears. Bug: webrtc:9535 Change-Id: Ia23d58cf1a1315605beef3ec72e080844bb94e5d Reviewed-on: https://chromium-review.googlesource.com/1243123Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595806}
-
Camille Lamy authored
This reverts commit 05ee0393. Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina. See https://crbug.com/891230 Original change's description: > remove SK_SUPPORT_LEGACY_SVG_ARC_TO > > Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd > Reviewed-on: https://chromium-review.googlesource.com/1254341 > Commit-Queue: Mike Reed <reed@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595627} TBR=fmalita@chromium.org,reed@chromium.org Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891230 Reviewed-on: https://chromium-review.googlesource.com/1256825Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595805}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/121ad83c50b6..1cae4d538d01 git log 121ad83c50b6..1cae4d538d01 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 taylori@google.com Merge "trace_processor: Parse SysStats trace events and add to counters table" Created with: gclient setdep -r src/third_party/perfetto@1cae4d538d01 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibdb778a6f1fa576719b7e6d1b351cc510c43a085 Reviewed-on: https://chromium-review.googlesource.com/1256234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595804}
-
Antonio Gomes authored
Fixes crash when focusing textfield with pointer click Bug: 878692 Change-Id: Ifb66115e42bdd06c572f784dff673309a2562598 Reviewed-on: https://chromium-review.googlesource.com/1193870Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Cr-Commit-Position: refs/heads/master@{#595803}
-
Rayan Kanso authored
Make sure that only the fetch that is being processed has a notification. This CL also fixes a few bugs encountered: - MarkRegistrationForDeletion was deleting prefixes of the registration - Scheduler errors were not propagating the error to the Delegate, which was keeping abandoned fetch notifications on screen. This was fixed by adding a data manager observer which communicates these errors to the delegate. Change-Id: Ie4abada89c3ba0c98a7e7219ba3aebeb0f8e640d Reviewed-on: https://chromium-review.googlesource.com/1249075Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595802}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe79649..810f3db BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5cf7dfe1e1a84a8eb4cad57bd2d6a6138e006aaf Reviewed-on: https://chromium-review.googlesource.com/1254749 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595801}
-
Greg Kraynov authored
Bug: 865411 Change-Id: I068554583da9190c6d2e84c510f4d76d1bf4d742 Reviewed-on: https://chromium-review.googlesource.com/1245715 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595800}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ec8e0059. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25749 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2136a3b1976296cfd8256679c80c256d3d2f388f Reviewed-on: https://chromium-review.googlesource.com/1256625 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595799}
-
Michael Lippautz authored
Avoid calling the string version of 'gc()'. Bug: 889396 Change-Id: I752b7726d11c748c441cc119d015f21a45529305 Reviewed-on: https://chromium-review.googlesource.com/1254204 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
A Olsen authored
Weeklytime package has no dependencies of its own, and few things depend on it, so it is relatively easy to move out of src/chrome/browser and into src/chromeos. This is useful as part of bug 446937 - moving CrosSettings out of chrome/browser - since CrosSettings depends on this class for the DeviceOffHoursPolicyController. Bug: 446937 Change-Id: I9866f341a15f67b452b57cc219b5ca88cd18cfdb Reviewed-on: https://chromium-review.googlesource.com/1254661 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#595797}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee216640ddcc..895ce82cabc8 git log ee216640ddcc..895ce82cabc8 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 kwiberg@webrtc.org VAD/DTX tests: Don't let the ACM create audio encoders 2018-10-02 sprang@webrtc.org Split TemporalLayers and TemporalLayers checker, clean up header. Created with: gclient setdep -r src/third_party/webrtc@895ce82cabc8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7c6021dfa8dbf1f2e740c101f44043c659af404 Reviewed-on: https://chromium-review.googlesource.com/1256230Reviewed-by:
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-request/pull/789 Bug: 890660 Change-Id: Id5e9b33ac8544f36d75cdfbd37e690e94a7a29ae Reviewed-on: https://chromium-review.googlesource.com/1253942Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#595795}
-
Camillo Bruni authored
Initial version shows predictably 29 network errors: - 28x times https://abs.twimg.com/k/en-gb/13.hls.js.en-gb.43b6de858df39857f6b2.js - 1x https://twitter.com/manifest.json Bug: 878390 Change-Id: Ifa4dd5dae68f1450d47d22241f094a6e454593cd Reviewed-on: https://chromium-review.googlesource.com/1219003 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#595794}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/daa3b5e9795b..9c1070ec18e9 Created with: gclient setdep -r src-internal@9c1070ec18e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I427060c5916b114c96a073aacc6a369728b0f42b Reviewed-on: https://chromium-review.googlesource.com/1256232Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595793}
-
Kent Tamura authored
- Consolidate 'origin' and 'queueMicrotask' - Move 'customElements' to the top section - Move requestAnimationFrame() and cancelAnimationFrame() to their own section - Move requestIdleCCallback() and cacelIdleCallback() to their own section - Update comments This CL has no behavior changes. Change-Id: I4472c1582933a53703510ab33d35f4f1a0824541 Reviewed-on: https://chromium-review.googlesource.com/1256391Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#595792}
-
Noel Gordon authored
Teach the <file-safe-media> element more about the loaded state of its child <webview>: make the <webview> send webview-loaded/cleared events to its parent <file-safe-media>, and have the parent set that state in the 'loaded' attribute of the child <webview>. Add an html scroll test: wait for the <webview> to load its content by waiting for the 'loaded' attribute. Then call window.scrollBy() on the <webview> and verify that the <webview> was scrolled. Minor: files_safe_media_webview_content.js: use document.querySelector to get the #content element to silence a presubmit warning. Test: browser_tests --gtest_filter="QuickView*openQuickViewScrollHtml" Bug: 891150 Change-Id: I7bc10a47ff4e50a16ece910174959596615e6fd7 Reviewed-on: https://chromium-review.googlesource.com/1256399 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#595791}
-
Jose Dapena Paz authored
On using keyboard with Wayland, we get performance timing asserts. It is caused by inconsistency in how we generate the timestamps from the native events. This replicates the reasoning of Windows EventTimeFromMSG, as the problem is the same. For platform independent events we use TimeTicks::Now, but for native events we use a different time origin. So let's use for keyboard also EventTimeForNow(). Bug: 891205 Change-Id: Iaf1c2e106ea39c7ea3fc6da5c5ab647109f87c7a Reviewed-on: https://chromium-review.googlesource.com/1256569Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 887201 Change-Id: Ife32574b7014616f13b5ac3ede174c6a72c7bf4e Reviewed-on: https://chromium-review.googlesource.com/1253921Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595789}
-
Oleg Maximenko authored
Passing desired_size to ImageDecoder::Create() means that caller have checked that the size is possible by calling ImageDecoder::GetSupportedDecodeSizes(). Otherwise some issues may arise even for the formats that don't support decode-to-scale. On the other hand the only supported format (JPEG) isn't very popular for the icons. Better to simplify the code. Change-Id: I24e173ee0540bb5d7adc055ffaa8285bef8f90de Reviewed-on: https://chromium-review.googlesource.com/1253901Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595788}
-
Marc Treib authored
AutofillWalletDataTypeController is used (pre-USS) for both AUTOFILL_WALLET_DATA and AUTOFILL_WALLET_METADATA. When Sync is stopped, it calls PersonalDataManager::ClearAllServerData. Since there are two instances of the controller, that happens twice (which is unnecessary but doesn't hurt). However, when AUTOFILL_WALLET_DATA is on USS, then the remaining ClearAllServerData call (for the metadata controller) still happens, which brings Sync into a bad state since the data is now gone, but the progress marker is still there (see bug 885211). This CL changes AutofillWalletDataTypeController to only call ClearAllServerData for AUTOFILL_WALLET_DATA (i.e. it won't be called anymore if Wallet is on USS). Instead, AUTOFILL_WALLET_DATA gets special-cased in ModelAssociationManager to clear even in the STOP_SYNC case. This achieves the same "clear data on stopping sync, but *not* on browser shutdown", but without requiring a special side channel to the SyncService. One consequence is that with AUTOFILL_WALLET_DATA on USS, the clearing now happens asynchronously (because it goes through the DB), which requires some test changes. Bug: 889941 Change-Id: I54c36050c81fa862acfc0052f355ff1645a8b292 Reviewed-on: https://chromium-review.googlesource.com/1251041 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#595787}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f61afaa6ec3..121ad83c50b6 git log 7f61afaa6ec3..121ad83c50b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 hjd@google.com Add libfuzzer to buildtools gitignore Created with: gclient setdep -r src/third_party/perfetto@121ad83c50b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If22e3137e25ca856e41afdc3e1666ba504fe412d Reviewed-on: https://chromium-review.googlesource.com/1256231Reviewed-by:
-
Camillo Bruni authored
Several login pages do no longer work by simply settings the value of the email and password inputs. Using EnterText single KeyboardEvents are dispatched to the currently selected input thus simulating more closely real input. Bug: 878390 Change-Id: I86ba8edbac681d6739acaaebe74ed4e6b1034096 Reviewed-on: https://chromium-review.googlesource.com/1254962 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: 878390 Change-Id: I496645dbfe68a1e5603035647ad70167b1107164 Reviewed-on: https://chromium-review.googlesource.com/1236793 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Mikel Astiz authored
OnSyncStarting() should be completed (replied to) when a model is ready to sync and the initial sync metadata has been loaded. This is important to honor the processor's invariant that no remote changes are expected (from the worker) unless the model is ready to sync. For the (unlikely) case where OnSyncStarting() detects a cache GUID mismatch (e.g. database in a corrupt state), *AND* the bridge becomes unready to sync (currently the case for SESSIONS) as a reaction to that, we should make sure no reply is issued for OnSyncStarting() until the model becomes ready to sync. Specifically, for SESSIONS (SessionSyncBridge), this scenario could lead to MergeSyncData() being called too early, before the model was ready to handle it, running into DCHECKs (for DCHECK-enabled builds) or crashes. This becomes more likely if the UssMigrator is exercised (i.e. clients that transition from the directory-based sessions implementation to the USS implementation for the first time), because the migrator mimics a response from the server that is very fast (no actual network involved). Bug: 876490 Change-Id: I83e851fbbff235bb49ee03fd7f98d9764830ed83 Reviewed-on: https://chromium-review.googlesource.com/1256565 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#595783}
-
Manuel Rego Casasnovas authored
Spec text (https://drafts.csswg.org/css-contain/#containment-size): "2. Elements with size containment are monolithic." This patch updates LayoutBox::GetPaginationBreakability() to check if the element has size containment. BUG=855263 TEST=external/wpt/css/css-contain/contain-size-breaks-001.html TEST=external/wpt/css/css-contain/contain-size-monolithic-001.html Change-Id: I372888eec2e3ab7ca51ad9c9b397ea6b8c89b629 Reviewed-on: https://chromium-review.googlesource.com/1256566Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#595782}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/95ed233ed1a3..59297c6f73a6 git log 95ed233ed1a3..59297c6f73a6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 mattcary@chromium.org Tracing: add java_base* executable memory metrics. Created with: gclient setdep -r src/third_party/catapult@59297c6f73a6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:875276 TBR=sullivan@chromium.org Change-Id: I0f47af7fffdfbc9c497d5cdce9c61dc82782c527 Reviewed-on: https://chromium-review.googlesource.com/1256077Reviewed-by:
-
Yutaka Hirano authored
- Fix beacon-common.sub.js and so that it can handle exceptions thrown from sendBeacon. - Simplify beacon-common.sub.js. - Remove navigate.iFrame.sub.html. Replace it with scripts in the main page. Bug: 876670, 626703, 848275, 876669 Change-Id: I847dec3a71b27c76df156326637be243876daaab Reviewed-on: https://chromium-review.googlesource.com/1237796Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#595780}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/674c0aa15399..daa3b5e9795b Created with: gclient setdep -r src-internal@daa3b5e9795b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ec528525fa6add94519451bc47cd6aa0976b858 Reviewed-on: https://chromium-review.googlesource.com/1256228Reviewed-by:
-
Ian Kilpatrick authored
During computing the size of an SVG we may end up calling: ContainingBlock()->AvailableLogicalWidth() This is invalid inside LayoutNG as we should always use the override set by the LayoutNG algorithm. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia9f32ac921726cf3f3f0d76dcccd2a0497cb25cf Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1255598 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
A Olsen authored
SystemSettingProvider had a dep on both LoginState and ProfileManager, in order to check if the user had permission to change the timezone. ProfileManager is in chrome/browser and I am trying to remove chrome/browser deps, so I changed the code to use only UserManager. See https://chromium-review.googlesource.com/1238450 I realized afterwards that UserManager deps are also currently not allowed in src/chromeos, where this code will soon live. Rather than expand the list of deps (which should be kept small), I have updated LoginState so that only it is needed here (instead of ProfileManager or UserManager). So, the last change is no longer needed, and is reverted. I also tidied up conversion code in ChromeUserManager slightly - Moving if-else-else chain into a helper function with switch + return means that the compiler checks that all cases are handled. Bug: 446937 Change-Id: I3aa44cacdef752f997d12b647d6e073f806371d3 Reviewed-on: https://chromium-review.googlesource.com/1249209Reviewed-by:
-
Olga Sharonova authored
The theory is that the count difference is due to different timing of events when navigation happens during the output stream creation. That situation would correspond to the cases when AudioOutputStreamBroker is destroyed while its internal |disconnect_reason_| state is DisconnectReason::kDocumentDestroyed. We'll measure both probability of this situation as well as duration of stream creation as seen by AudioOutputStreamBroker. Bug: 867827 Change-Id: I226fd275b485cccbc3899ec4c6fa39232a719979 Reviewed-on: https://chromium-review.googlesource.com/1249841 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#595776}
-
Maksim Sisov authored
The wl_surface_damage method was used in a wrong manner - if a damage region is not supplied, the wl_surface_damage still must be provided with the width and the height of the buffer to update the surface with a new content. This happens when partial swap is disabled and there is no damage region provided. What is more, instead of using wl_surface_damage, start using wl_surface_damage_buffer, as long as the damage region corresponds more to the buffer region contents rather than the surface itself (and which is claimed to be a better approach by the Wayland documentation) Bug: 891188 Change-Id: Iff3a4eb50eae1a113818ef7881b6529b906f4820 Reviewed-on: https://chromium-review.googlesource.com/1255635Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#595775}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2f9fe770. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 534cd7bb "isXXX methods added to TrustedTypePolicyFactory" a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25748 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1af14b5a781a6dc1982de8c68f04a42962972f88 Reviewed-on: https://chromium-review.googlesource.com/1256623 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
On non-iOS platforms, the PasswordStore reports metrics about the usage of password manager on every start. For iOS, all the pieces are there, but have not been used. This CL adds the reporting on iOS. Bug: 887409 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icef32ced5cbc7e61776e0f1ca41466d4ef65f032 Reviewed-on: https://chromium-review.googlesource.com/1255523Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595773}
-
Alex Clarke authored
This reverts commit c8c4a655. Reason for revert: I fixed a bug in LazilyDeallocatedDeque here https://chromium-review.googlesource.com/c/chromium/src/+/1253982 which might be responsible for the crashes. Lets re-enable LazilyDeallocatedDeque and see. Original change's description: > Revert "Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue" > > This reverts commit 6410ee3d. > > Reason for revert: This is causing some crashes. > > Original change's description: > > Second try at using LazilyDeallocatedDeque instead of circular_deque in TaskQueue > > > > Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792 > > > > Our usage pattern is unfortunate for existing queues such as > > base::circular_deque. We tend to fill up an empty queue and then drain all > > those tasks until it's empty. This means the queue yo-yos in size which > > confuses the memory reclamation schemes of most queues. > > > > As an optimisation we introduce a deque specialised for TaskQueueManager's > > usage patterns. For performance (memory allocation isn't free) we don't > > automatically reclaim memory when the queue becomes empty. Instead we rely > > on the surrounding code periodically calling MaybeShrinkQueue, ideally when > > the queue is empty. > > > > We keep track of the maximum recent queue size and rate limit > > how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary > > churn. > > > > This yields a nice win on our microbenchmark: > > > > Patch: us/run for 10000 delayed tasks with N queues > > 1 queue 4 queues 8 queues 32 queues > > 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 > > 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 > > 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 > > 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 > > 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 > > 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 > > 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 > > 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 > > 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 > > 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 > > Average 35812.1871 35430.24471 35636.02188 36204.63076 > > > > ToT: us/run for 10000 delayed tasks with N queues > > 1 queue 4 queues 8 queues 32 queues > > 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 > > 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 > > 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 > > 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 > > 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 > > 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 > > 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 > > 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 > > 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 > > 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 > > Average 37942.951 37481.78685 36983.47337 36634.15632 > > > > Percentage improvement > > 5.61570422 5.473437399 3.643388159 1.172472933 > > > > NB the reason the improvement goes down with the number of queues is because > > we're saving malloc overhead in the queue, but a constant number of tasks are > > posted across N queues. This means the more queues we have in this test, the > > less loaded the queues are individually. > > > > Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4 > > Reviewed-on: https://chromium-review.googlesource.com/1169043 > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#582586} > > TBR=skyostil@chromium.org,alexclarke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Id8290646dba1dcea9fcf92d490b9ce4ac63ae702 > Reviewed-on: https://chromium-review.googlesource.com/1177561 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584314} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia3931cc50bc18fda4df3f385927498728c7a2e8f Reviewed-on: https://chromium-review.googlesource.com/1254301Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595772}
-
Mikel Astiz authored
This is part of a patch series where we leverage the recently introduced layer that allows integrating legacy SyncableService implementations within the newest architecture, USS. This requires forking custom controllers because a different class hierarchy is used. Bug: 870624 Change-Id: I0931243109eef8f757692c5a932f03004f8ce039 Reviewed-on: https://chromium-review.googlesource.com/1254211 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#595771}
-
Gauthier Ambard authored
The toolbar model is only used by the location bar. It is called toolbar model to because of the components code. It has nothing to do with the ios/chrome/browser/ui/toolbar. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3161f3bb47ec16e21331266a4e1a2bcfa091b325 Reviewed-on: https://chromium-review.googlesource.com/1246164Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595770}
-
Mark Cogan authored
Bug: 884724 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I53368d4beeb536695e2190f0fdebf64f4198c6a4 Reviewed-on: https://chromium-review.googlesource.com/1251545 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595769}
-
