Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 10 Aug, 2018 22 commits
  3. 09 Aug, 2018 18 commits
    • Alex Moshchuk's avatar
      Remove the list of isolated origins from chrome://process-internals. · e5f283dc
      Alex Moshchuk authored 
      The full list of isolated origins might include sensitive info in
upcoming field trials, so show the number of isolated origins instead
of actual list.

Bug: 872375
Change-Id: I944919cc9ce2afa953bbca77a489c9df62105ab8
Reviewed-on: https://chromium-review.googlesource.com/1167962Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581965}
      e5f283dc
    • Min Qin's avatar
      Fix a DCHECK failure as RemoveEntry() can be called before UpdateDownloadDB · 079fa669
      Min Qin authored 
      When AddOrReplaceEntry() posts a UpdateDownloadDB task, RemoveEntry()
could be called before the posted task to get a executed.
This will cause the DCHECK to fail.

BUG=872279

Change-Id: I90c19a66814b050ef4cded72ee35380790d16d4c
Reviewed-on: https://chromium-review.googlesource.com/1169979Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581964}
      079fa669
    • Alexei Filippov's avatar
      [sampling heap profiler] Implement CreateModuleForAddress for Win platform. · bf5264fd
      Alexei Filippov authored 
      Also move the function and its helpers to ModuleCache.

BUG=803276
TBR=dcheng@chromium.org
TBR=wittman@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/1166206Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
Change-Id: I28ad62df7a3f2f597f1a4f36069c51b541e7dc29
Reviewed-on: https://chromium-review.googlesource.com/1169533Reviewed-by: default avatarAlexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581963}
      bf5264fd
    • Muyuan Li's avatar
      assistant: fix garbage data at end of audio stream. · abdf1cba
      Muyuan Li authored 
      Bug: b/112431554
Test: Manual
Change-Id: I10e52dad59b2989fe9ba223b3c8cf130143ea9b8
Reviewed-on: https://chromium-review.googlesource.com/1170031
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581962}
      abdf1cba
    • Trent Apted's avatar
      Make js_binary.py a thousand times faster (literally) by caching dependency subtrees. · 131641f0
      Trent Apted authored 
      Targets like ui/file_manager/file_manager/foreground/js:closure_compile
were causing js_compile.py to spend upwards of one minute of CPU time
in Python before even invoking the closure compiler.

Caching dependency subtrees takes the python CPU time down to about 50
milliseconds. That is, a 1000x performance boost.

Note the _set_ of arguments passed to closure is identical. However, the
order can change slightly without violating dependencies specified. This
shuffling exposed a couple of errors due to underspecified dependencies.
(Fix them):

ui/file_manager/file_manager/background/js/test_util_base.js:589:
  ERROR - Property args never defined on request

chrome/browser/resources/settings/site_settings/site_data_entry.js:15:
  ERROR - Variable referenced before declaration: I18nBehavior

TBR=hcarmona@chromium.org

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10c27bb76b404bb40828dfd54f99be059adf0fdb
Reviewed-on: https://chromium-review.googlesource.com/1166775
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: default avatarNaoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581961}
      131641f0
    • Christopher Cameron's avatar
      RemoteMacViews: Remove most views calls from BridgedContentView · ab8d9781
      Christopher Cameron authored 
      In BridgedContentView, change most calls that refer to the views::View
hostedView_ to be routed through the BridgedNativeWidgetHost interface.

Leave keyboard events, text input, and a11y unchanged for now.

Add a BridgedNativeWidgetHostImpl::SetRootLayer method which now calls
through to BridgedNativeWidget::SetRootLayer. Once the remaining uses
of hostedView_ are removed, the BridgedNativeWidget::SetRootLayer method
will be removed.

Bug: 859152
Change-Id: I2a010b3149357af4f9aeaec0088eb9fcde53db13
Reviewed-on: https://chromium-review.googlesource.com/1168459
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581960}
      ab8d9781
    • Nektarios Paisios's avatar
      Reland "Changed STDMETHODIMP to IFACEMETHODIMP and long to LONG where appropriate" · 477d9955
      Nektarios Paisios authored 
      This reverts commit f6c63d90d7b8a6f689b135fefc181a8e539debf9.

Reason for revert: Commit queue is working now.

Original change's description:
> Revert "Changed STDMETHODIMP to IFACEMETHODIMP and long to LONG where appropriate"
> 
> This reverts commit 641067d28a56deb5b2432a3f603eae029f461170.
> 
> Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > Changed STDMETHODIMP to IFACEMETHODIMP and long to LONG where appropriate
> > 
> > 1. STDMETHODIMP is defined as
> > HRESULT STDCALL
> > but the new macro IFACEMETHODIMP is defined as having an additional override modifier which
> > checks that the method we are defining or declaring is indeed an override of a method in a superclass.
> > 2. long is the same as LONG on Windows, but in order to avoid any confusion or any linter errors, I changed all uses to the capitalized version LONG.
> > 
> > Advantages:
> > A) This sends the message to developers that this is not the standard long type. It is actually an int.
> > B) It is the same as the type used in most of the MS documentation.
> > TBR=dtseng@chromium.org, dmazzoni@chromium.org, aleventhal@chromium.org
> > Change-Id: Ib73dc3b362c0297f7a9038f289710d66fa5c698c
> > Reviewed-on: https://chromium-review.googlesource.com/1169305
> > Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> 
> TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,aleventhal@chromium.org
> 
> Change-Id: Ia0655ece63c2dea8819130c0041e3cc4fd24a345
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1169848
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=dmazzoni@chromium.org,dtseng@chromium.org,nektar@chromium.org,tandrii@chromium.org,aleventhal@chromium.org

Change-Id: I997abd90e3da0f4424d4e61853fdbb17cbae0cd2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1169883Reviewed-by: default avatarNektarios Paisios <nektar@chromium.org>
Reviewed-by: default avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581959}
      477d9955
    • Kenneth Russell's avatar
      Suppress flaky tests on macOS 10.13.6 with AMD GPUs. · 25ed0ad3
      Kenneth Russell authored 
      WebGL conformance suppressions:
  conformance2/textures/misc/tex-mipmap-levels.html
  conformance2/textures/misc/tex-base-level-bug.html

Pixel test suppressions:
  Pixel_CSSFilterEffects
  Pixel_WebGLSadCanvas

Tbr: ynovikov@chromium.org
Bug: 870856, 872423
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1420fe20b7a64bb40f3ba0209fd9bb08b3213b14
Reviewed-on: https://chromium-review.googlesource.com/1168470Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarYuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581958}
      25ed0ad3
    • Michael Thiessen's avatar
      VR: Turn VR mode off when restoring Activity from saved instance. · a0ba0c66
      Michael Thiessen authored 
      When Chrome is killed in the background while VR mode is on, we can't
turn VR mode off (the platform doesn't respect VR mode changes for
backgrounded apps).

We also can't check whether VR mode is currently on on Android N, so
instead this CL records whether we were in VR mode when killed using
saved instance state, and turns VR mode off on startup when restoring.

Test/Repro steps:
1. Turn on "Don't keep activities" in developer settings
2. Launch Chrome in VR
3. Press the Daydream controller Home button
4. Exit VR
5. Use task switcher to return to Chrome.

> Chrome should resume without VR mode on (the display will flicker
if it's on)

Bug: 854740
Change-Id: I4fc8e9c076a8cb31ca2bdb74be1124bec3826193
Reviewed-on: https://chromium-review.googlesource.com/1167116
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581957}
      a0ba0c66
    • Andrey Kosyakov's avatar
      Reland "Deflake inspector-protocol/input/dispatchKeyEvent-focus.js" · 8b90885e
      Andrey Kosyakov authored 
      This reverts commit 4af14ca3c99bd7edbf100e05db93564b7107cc62.

Reason for revert: relanding once the outage is over.

Original change's description:
> Revert "Deflake inspector-protocol/input/dispatchKeyEvent-focus.js"
> 
> This reverts commit 27378e0364b705643275c861f4ba64b70572dff1.
> 
> Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > Deflake inspector-protocol/input/dispatchKeyEvent-focus.js
> > 
> > The keystrokes injected via Input.dispatchKeyEvent through the browser are
> > racing against Runtime.evaluate in the renderer, so we need to wait for
> > the async completion of the last dispatchKeyEvent before validating the
> > tests results with evaluate.
> > 
> > Bug: 872081
> > Change-Id: Ic5ef41feba6a877c76c05de2e09e019a826756a1
> > Reviewed-on: https://chromium-review.googlesource.com/1168200
> > Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
> 
> TBR=dgozman@chromium.org,lushnikov@chromium.org,caseq@chromium.org
> 
> Change-Id: I6f7e8e41eab2c756875103cae24576c37784baf3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 872081
> Reviewed-on: https://chromium-review.googlesource.com/1169789
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=dgozman@chromium.org,lushnikov@chromium.org,caseq@chromium.org,tandrii@chromium.org

Change-Id: Ia8e5d3e56d923c31451474969afad7450e8e734d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872081
Reviewed-on: https://chromium-review.googlesource.com/1170007Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581956}
      8b90885e
    • Matt Falkenhagen's avatar
      S13nServiceWorker: Add nav preload UMA. · e1784f56
      Matt Falkenhagen authored 
      This will help debug the linked bug, by comparing S13nServiceWorker on
vs off.

Bug: 866335
Change-Id: Idd1d027971cb9fd5122cda4f1cf383b55119fa83
Reviewed-on: https://chromium-review.googlesource.com/1168952Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581955}
      e1784f56
    • Dan Sanders's avatar
      Detect reentrancy in MojoVideoDecoder::Stop(). · 1c0c058e
      Dan Sanders authored 
      DecoderSelector provides an InitCB that destroys the VideoDecoder
immeidately when initialization fails. This means that |this| is
invalidated immedately upon calling |init_cb_| in MojoVideoDecoder.

This CL adds a WeakPtr-based test for |this| destruction to the
potentially problematic callbacks in MojoVideoDecoder::Stop().

Bug: 839881
Change-Id: I9b1302ad3007a834c95ed1d3845e24b0d07158f8
Reviewed-on: https://chromium-review.googlesource.com/1169907Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581954}
      1c0c058e
    • Emircan Uysaler's avatar
      Move desktop picker ui implementation out of extensions · 54124ea8
      Emircan Uysaler authored 
      This CL moves the picker UI triggered from extensions into
DesktopMediaPickerFactoryImpl which lives under
/chrome/browser/media. We are planning to use this common
implementation to trigger the same picker UI for getDisplayMedia().

Bug: 326740
Change-Id: Idb8b9d094ce55ecc8281c3db1f1acb0f5e3a24f1
Reviewed-on: https://chromium-review.googlesource.com/1169594
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: default avatarWeiyong Yao <braveyao@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581953}
      54124ea8
    • Antonio Gomes's avatar
      s13n: Expose an API to get the total of decompressed bytes of a response body · 8d36e829
      Antonio Gomes authored 
      While migrating some classes from URLFetcher to SimpleURLLoader,
it is useful to have the size of the resulting decompressed body.

In case of DownloadToString* calls, this is straightfoward:
the length to the string is the size.
However, in the case of DownloadTo{Temp}File calls, where only the
resulting file path is passed to the completion callback, having
an API to get the decompressed body size is useful. It also avoids
sync calls to access the file data.

This CL adds a SimpleURLLoader::GetContentSize API that provides such
value. When used with SimpleURLLloader::SetAllowPartialResults(true),
the API returns the total decompressed body size even in the case of
errors.

BUG=773295,844972

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia8cdb3326b5d5c74276e384f966a7e98f61a8c46
Reviewed-on: https://chromium-review.googlesource.com/1167683Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581952}
      8d36e829
    • Scott Violet's avatar
      reland: window-service: ignore requests to focus null · bef3de4c
      Scott Violet authored 
      This differs from the first version in that SetFocus(null) now returns
true. As you suggested in the last patch, returning false caused the
client to attempt to revert, which lead to some oddities. So, it seems
safer to return true.

views_mus_unittests no longer fails with this version, and
https://chromium-review.googlesource.com/c/chromium/src/+/1169525 fixs the
issue with the browser_test NavigatingExtensionPopupBrowserTest.Webpage.

Here's my comment as to why this is ignored:

  // The client is asking to remove focus from a window. This is typically a
  // side effect of the window becoming, or about to become, an unfocusable
  // Window (for example, the Window is hiding). Windows becoming unfocusable is
  // handled locally. Assume the request is for such a scenario and return
  // true. Returning false means the client will attempt to revert to the
  // previously focused window, which may cause unexpected activation changes.
  //
  // To process null requests conflicts with top-level activation changes. For
  // example, the typical sequence when a window is hidden is to first remove
  // focus, and then hide the window. FocusController keys off window hiding to
  // move activation. If this code were to set focus to null, FocusController
  // would not see the window hiding (because the active window was set to null)
  // and not automatically activate the next window.
  //
  // Another possibility for this code is to handle null as a signal to move
  // focus to the active window (if there is one). I'm going with the simpler
  // approach for now.

BUG=867654, 871652
TEST=covered by tests

Change-Id: Iff2ddb31c2b99b977bca8e56fb653b6ce4eb6813
Reviewed-on: https://chromium-review.googlesource.com/1165692
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581951}
      bef3de4c
    • Mike Klein's avatar
      add guard for skia-review.googlesource.com/146522 · 593fa77c
      Mike Klein authored 
      Should be a good number of teensy layout test diffs.

Change-Id: I3dc74252fab7ec8ee4aa38d95ba1f60ed3e96b01
Reviewed-on: https://chromium-review.googlesource.com/1169313
Commit-Queue: Mike Klein <mtklein@chromium.org>
Reviewed-by: default avatarFlorin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581950}
      593fa77c
    • James West's avatar
      [Chromecast] Disable audio focus on non-Android Cast devices · 72cee639
      James West authored 
      Bug: internal b/112331554
Test: manual
Change-Id: Ib7670d56a1d8444ac895cae7117365ccda0ef9e4
Reviewed-on: https://chromium-review.googlesource.com/1168507Reviewed-by: default avatarLuke Halliwell <halliwell@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581949}
      72cee639
    • Tommy Steimel's avatar
      [Media Controls] Remove CSS rules causing overflow menu scrollbar · e2ed29c1
      Tommy Steimel authored 
      This CL removes some obselete sizing-* CSS rules that were
inadvertently causing a scrollbar to appear in the overflow menu at
certain zoom levels.

Bug: 851492
Change-Id: Ibafa0b74312d3f18b5ca5c3ee1050f1710c1e810
Reviewed-on: https://chromium-review.googlesource.com/1168394Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581948}
      e2ed29c1