GitLab

The message containing 'notification type' from
CheckNotificationTypeMatchesProtoMessageName is confusing since the source
of the error contains many similar strings.  Remind committers to refer to
the definition of the struct for more information.

New message:
'Error at lines 127-129 in model_type.cc: In the construction of ModelTypeInfo: notification type "WIFI_CREDENTIALIEA" does not match proto message name defined in sync.proto: "wifi_credentials"'

BUG=

Review-Url: https://codereview.chromium.org/2335413002
Cr-Commit-Position: refs/heads/master@{#419263}

These are not used anymore.

BUG=none

Review-Url: https://codereview.chromium.org/2341343002
Cr-Commit-Position: refs/heads/master@{#419262}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/12183cc1619b..3c7a09882102

$ git log 12183cc16..3c7a09882 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 brucedawson Renable /analyze in ffmpeg builds
2016-09-16 phajdan.jr generate_gn.py: use proper comment style for asm and C files

TBR=dalecurtis@chromium.org
BUG=427616

Review-Url: https://codereview.chromium.org/2345313002
Cr-Commit-Position: refs/heads/master@{#419261}

This reverts 7d6c8b29, which made window server have access to the
clipboard, as at the time, I thought that drag and drop would read/write
to/from a dedicated drag clipboard and that the window server would have
to manipulate it. Due to timing issues, this didn't work out.

Now that we aren't using a drag clipboard as the backing for mus drag
and drop, also remove the drag clipboard from our mus clipboard
implementation.

BUG=614037

Review-Url: https://codereview.chromium.org/2339353003
Cr-Commit-Position: refs/heads/master@{#419260}

Converts ChromeViewHostMsg_RunNetworkDiagnostics and
ChromeViewMsg_SetCanShowNetworkDiagnosticsDialg to mojom without
impacting message ordering.

The browser-side interface is exposed via a
WebContentsFrameBindingSet<T>.

The renderer-side (client) interface is exposed via
RenderFrameImpl's AssociatedInterfaceRegistry.

This CL serves as a simple example of converting routed IPC
messages which are handled by WebContentsObservers or other
WebContents-bound things.

BUG=612500

Review-Url: https://codereview.chromium.org/2310583002
Cr-Commit-Position: refs/heads/master@{#419259}

A StopProvider call from the Engine was being received while a message
was being processed to go to the Engine from the Client. This caused
the LocationArbitrator to reset. When we came back from sending,
the callback tries to get the new location from the LocationArbitrator,
but since it was reset, it now has an invalid location. This adds a
check for this case.

BUG=645230

Review-Url: https://codereview.chromium.org/2331513002
Cr-Commit-Position: refs/heads/master@{#419258}

BUG=647395

Review-Url: https://codereview.chromium.org/2338293004
Cr-Commit-Position: refs/heads/master@{#419257}

BUG=None

Review-Url: https://codereview.chromium.org/2285043002
Cr-Commit-Position: refs/heads/master@{#419256}

BUG=none

Review-Url: https://codereview.chromium.org/2346723002
Cr-Commit-Position: refs/heads/master@{#419255}

https://chromium.googlesource.com/skia.git/+log/046cb56c6c1b..c0444615ed76

$ git log 046cb56c6..c0444615e --date=short --no-merges --format='%ad %ae %s'
2016-09-16 msarett Support Float32 output from SkColorSpaceXform
2016-09-16 mtklein Build with GN on CT bots.
2016-09-16 robertphillips Improve join between the two RRects in SkRRectsGaussianEdgeShader
2016-09-16 mtklein Promote the N5 to the CQ for real.
2016-09-16 rmistry Run SVGs through nanobench on all Perf bots.
2016-09-16 stani Clear stencil buffer before using it for drawing
2016-09-16 msarett Revert of Support Float32 output from SkColorSpaceXform (patchset #7 id:140001 of https://codereview.chromium.org/2339233003/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2345873003
Cr-Commit-Position: refs/heads/master@{#419254}

BUG=555865

Review-Url: https://codereview.chromium.org/2314833002
Cr-Commit-Position: refs/heads/master@{#419253}

BUG=479009

Review-Url: https://codereview.chromium.org/2345293002
Cr-Commit-Position: refs/heads/master@{#419252}

Creates an global persistent metrics storage helper in base/metrics to
allow stubbing in Crashpad when built outside of Chrome.

Uses a pair of persistent metrics files, one that is the currently
active one, which is renamed to a "previous run" on startup. In normal
operation -active will be created, used, and removed on shutdown.
However, if Crashpad itself crashes, then on next startup, -active will
be moved to previous so that previous can be slurped in on startup to
retrieve data from the crash.

BUG=crashpad:100

Review-Url: https://codereview.chromium.org/2308763002
Cr-Commit-Position: refs/heads/master@{#419251}

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2333553002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#419250}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7f777213..66c91bb5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2344233002
Cr-Commit-Position: refs/heads/master@{#419249}

In display_compositor, we have CompositorFrameSink and CompositorFrameSinkClient
interface. Since we already have cc/output/compositor_frame_sink class,
it makes more sense to move these two interfaces to cc/ipc.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2344183002
Cr-Commit-Position: refs/heads/master@{#419248}

BUG=646443

Review-Url: https://codereview.chromium.org/2342403002
Cr-Commit-Position: refs/heads/master@{#419247}

BUG=487804

Review-Url: https://codereview.chromium.org/2346703002
Cr-Commit-Position: refs/heads/master@{#419246}

Revert of CertVerifyProcMac: Add Keychain re-ordering hack, check CRLsets in path pruning loop. (patchset #11 id:300001 of https://codereview.chromium.org/2101303005/ )

Reason for revert:
This breaks verification on OS X 10.12 and probably needs some further investigation.

Original issue's description:
> CertVerifyProcMac: Add Keychain re-ordering hack, check CRLsets in path pruning loop.
>
> This also removes the native hostname checking workarounds.
>
> BUG=570909,588789,621684
>
> Committed: https://crrev.com/9cedf75377d817c6b32a01f1d30fbe10663b8bb8
> Cr-Commit-Position: refs/heads/master@{#418732}

TBR=rsleevi@chromium.org,mattm@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=570909,588789,621684,647241

Review-Url: https://codereview.chromium.org/2347893002
Cr-Commit-Position: refs/heads/master@{#419245}

OfflineAudioContext cannot be closed so it makes more sense to have
close() be defined on AudioContext instead of BaseAudioContext.

This is a very minor tweak to the API, so no Blink intent submitted.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/948
Resolved:   https://github.com/WebAudio/web-audio-api/issues/974
Chrome feature: https://www.chromestatus.com/feature/5683205155848192

BUG=647261
TEST=audiocontext-close.html

Review-Url: https://codereview.chromium.org/2345693002
Cr-Commit-Position: refs/heads/master@{#419244}

This change was originally part of https://codereview.chromium.org/2317033002,
but fell on the floor. Oops!

BUG=644709

Review-Url: https://codereview.chromium.org/2342783004
Cr-Commit-Position: refs/heads/master@{#419243}

There's a need to distinguish clicks on different elements on the NTP:
a) clicks on Most Visited tiles.
b) clicks on (newly introduced) article suggestions (aka snippets).

The first should contribute to Most Visited tiles (i.e. boost tiles
that have been clicked in the past). The second shouldn't.

We choose to achieve this by specifying a referrer for article
suggestion clicks. This exposes the referrer to third parties, which
has been discussed and considered a desirable feature.

The fix relies on such a workaround due to the current lack of
infrastructure to propagate opaque feature-specific data from upper
layers to navigation history (and sync).

The approach competes with more intrusive/controversial alternatives to
achieve the same:

1. Use page transition types (LINK vs AUTO_BOOKMARK) to distinguish
   tile clicks from article suggestion clicks: unfortunately both types
   have been used in the past (older versions of Chrome).

2. Introducing a new page transition type or qualifier: this can be
   considered a layering violation.

3. Introduce a dummy redirect by means of a data: schema page.

BUG=645895

Review-Url: https://codereview.chromium.org/2338133006
Cr-Commit-Position: refs/heads/master@{#419242}

BUG=None

Review-Url: https://codereview.chromium.org/2339323002
Cr-Commit-Position: refs/heads/master@{#419241}

At times, we receive multiple focus events. This is technically fine, but it can cause lots of queued up chatter.

In the linke to bug, we are reading a focus event from a previous tab. Ideally the focus event shouldn't be fired (as it once was not), but ChromeVox should be robust enough to not over speak in this case.

Note that in braille, this results in a "shuffling" effect where one focus event flashes briefly before the expected event comes through.

BUG=646126

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2331253002
Cr-Commit-Position: refs/heads/master@{#419240}

BUG=617204
TEST=This enables existing test on more bots

Review-Url: https://codereview.chromium.org/2338023005
Cr-Commit-Position: refs/heads/master@{#419239}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/be85e5fd4bf5..b22608753f37

$ git log be85e5fd4..b22608753 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 washingtonp Replace profile_chromes atrace agent with Systrace's.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2343223002
Cr-Commit-Position: refs/heads/master@{#419238}

This CL uses margins rather than max-width to determine when the avatar
icon grid layout should wrap.

BUG=646253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338003004
Cr-Commit-Position: refs/heads/master@{#419237}

This CL lands server change 129028211 by birenroy.

BUG=488484

Review-Url: https://codereview.chromium.org/2237113005
Cr-Commit-Position: refs/heads/master@{#419236}

This CL lands server change 133042402 by yasong@.

BUG=488484

Review-Url: https://codereview.chromium.org/2348603003
Cr-Commit-Position: refs/heads/master@{#419235}

This CL is aimed at solving the bug described in comment 7 in crbug.com/468969. The original method only considered the system tray alone.

After the fix:

On signin screen, tabing focus order is:
three dots -> system tray -> (virtual keyboard) -> user login
shift-tabing focus order is:
user login -> (virtual keyboard) -> system tray -> three dots

On locked screen, tabing focus order is:
signout -> system tray -> notification tray -> (virtual keyboard) -> user login
reverse tabing focus order is:
user login -> (virtual keyboard) -> notification tray -> system tray -> signout

BUG=468969
TEST=device test, works good on the above description.

Review-Url: https://codereview.chromium.org/2295843006
Cr-Commit-Position: refs/heads/master@{#419234}

In short, an LTO optimization pass might recognize
naive implementations of builtins (such as memset)
and replace them with references to the real builtins,
which, in the case of -nostdlib, might cause the binary
to get undefined references to those symbols.

See more details:
https://llvm.org/bugs/show_bug.cgi?id=30403

BUG=645295

Review-Url: https://codereview.chromium.org/2343063002
Cr-Commit-Position: refs/heads/master@{#419233}

It uses a flood fill ripple that remains active while the overflow shelf
is active. InkDropHostView and CustomButton are updated to handle active
case:
 - CustomButton does not hide the ripple if it is not a pending ripple;
 - InkDropHostView does not show or hide a pending ripple if it is
   showing an active ripple.

BUG=612579
TEST=OverflowButtonInkDropTest.* in ash_unittests, manual

Review-Url: https://codereview.chromium.org/2178163002
Cr-Commit-Position: refs/heads/master@{#419232}

Unlike web::shell_test_util::LoadUrl this new method waits until the
load is completed.

BUG=629116

Review-Url: https://codereview.chromium.org/2343453002
Cr-Commit-Position: refs/heads/master@{#419231}

https://chromium.googlesource.com/skia.git/+log/43d665111137..046cb56c6c1b

$ git log 43d665111..046cb56c6 --date=short --no-merges --format='%ad %ae %s'
2016-09-16 mtklein GN: build get_images_from_skps.
2016-09-16 cblume Keeping asserts in release.
2016-09-16 bsalomon Allow GrCaps access from GrDrawContext GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348923002

BUG=643845

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2342213003
Cr-Commit-Position: refs/heads/master@{#419230}

BUG=647679

Review-Url: https://codereview.chromium.org/2346913003
Cr-Commit-Position: refs/heads/master@{#419229}

Make EasyUnlockGetKeysOperation wait for the cryptohome
D-Bus service to be available before making a GetKeyDataEx
method call to it. Otherwise, we get repeated log spam at
boot:

  [1912:1912:0916/102203:ERROR:object_proxy.cc(583)] Failed to call method: org.chromium.CryptohomeInterface.GetKeyDataEx: object_path= /org/chromium/Cryptohome: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.Cryptohome was not provided by any .service files
  [1912:1912:0916/102203:ERROR:easy_unlock_get_keys_operation.cc(61)] Easy unlock failed to get key data, code=1

BUG=636554

Review-Url: https://codereview.chromium.org/2343213002
Cr-Commit-Position: refs/heads/master@{#419228}

ViewportControl's _selectedText currently does this:
1 - get a selection+range with native window/shadowRoot.getSelection()
2 - calculate first and last viewport items that are part of the selection
3 - get the deepTextContent() of all those items
4 - trim out text based on the offsets provided by the selection

Step 4 is done by _textOffsetInNode(), which takes an itemElement, container,
and offset. Beforethis CL, it would start at the item and traverse all text
nodes until it stops at the container (node !== container). In this logic, it
assumes that the container is a text node itself so that (node !== container)
will be false and we will stop before counting the container's text length. In
reality, a user can drag to create a selection where the
range.start/endContainer can be an element that is not a text node (e.g. <span>
containing a text node). Then, _textOffsetInNode() would continue to traverse
and node.traverseNextTextNode() will never return a node that is === container.
This results in extra text length being counted which breaks the offset logic.

This CL makes sure that in those cases where the range.start/endContainer is not
a text node, such as a <span> containing the boundary text, we will stop
traversing when we hit a text node that is the end or is a descendant.

BUG=647287

Review-Url: https://codereview.chromium.org/2340223002
Cr-Commit-Position: refs/heads/master@{#419227}

Run mus_demo_unittests on the X11 Chrome OS trybot. This test just
checks that mojo:mus_demo starts and draws a frame. When tcmalloc
problems are fixed this should run on Ozone Chrome OS trybot (ideally
with Ozone X11).

BUG=611473

Review-Url: https://codereview.chromium.org/2151093003
Cr-Commit-Position: refs/heads/master@{#419226}

This makes the test interface almost exactly like any other origin trial, and
means that we don't have to do any special handling at internals construction
time to support it. Because it lives on window.internals.originTrialTest() now,
I renamed the various test methods and attributes to be more descriptive of what
they are actually testing, rather than prefixing them with 'frobulate' to avoid
polluting the internals namespace.

BUG=647273

Review-Url: https://codereview.chromium.org/2340323002
Cr-Commit-Position: refs/heads/master@{#419225}

BUG=647112

Review-Url: https://codereview.chromium.org/2340923004
Cr-Commit-Position: refs/heads/master@{#419224}