- 10 Apr, 2020 40 commits
-
-
Torne (Richard Coles) authored
I accidentally shadowed a variable in testDisconnectedViewLoadsContent leading to the test still flaking. Fix that, and also apply the same change to VisualStateTest which also uses a detached view and thus can be vulnerable to the same issue. Bug: 949391 Bug: 1058304 Change-Id: Ifc1d8305dca265368c1fa2dc7d8c1cc9bb487e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145754 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758215}
-
Scott Violet authored
Calling WebContents::Stop() from WebContentsObserver::DidStartNavigation() or WebContentsObserver::DidRedirectNavigation triggers a crash. This patch works around this by installing a NavigationThrottle. The NavigationThrottle cancels the navigation as necessary. Does this ensures we don't attempt to call Stop() while servicing these functions, yet ends up with the same result. BUG=1068115 TEST=Covered by weblayer_browsertests Change-Id: I284842120c2466a2a74856c0f72201200137b9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141232 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#758214}
-
Alex Turner authored
The scripts added by createAdFrameWithWindowStopAbortedLoad must have async set to false to ensure that they are loaded in insertion order. This allows the last script's onload handler signal that all three scripts have loaded. The current behavior -- with non-deterministic ordering -- is believed to be the cause of a flaky test (AdTaggingBrowserTest. ChildrenOfFrameWithWindowStopAbortedLoad_StillCorrectlyTagged) Bug: 1069346 Change-Id: I854eeee46c924920b9842701a6256a119cf676ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144832Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758213}
-
Charlie Hu authored
Previously, |message| field in DocumentPolicyViolationReportBody was always set to "Document policy violation", which was not helpful in tracing down the issue. This CL includes the customized message set at callsite of IsFeatureEnabled(DocumentPolicyFeature...) to DocumentPolicyViolationReportBody. Change-Id: If6eaa87140df26f2e8bd1dd45a94a1cfec88e803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110430 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#758212}
-
Rainhard Findling authored
* Removes |IDS_SHORT_PRODUCT_NAME| from the strings, and moves the strings into the Chrome and Chromium string files. * This is done for translation reasons, see chrome/app/PRESUBMIT.py for details. Bug: 1067175 Change-Id: I963a94a6684f2a2dbdba76c4d790da6c1eb06a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141104 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758211}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/469c029a7c22..cf2c8e6068c8 git log 469c029a7c22..cf2c8e6068c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 m.maiya@samsung.com EGL: Relax test skip conditions for a few colorspace ImageTests Created with: gclient setdep -r src/third_party/angle@cf2c8e6068c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I5afeb3ec849767d3ba2ab8950d0f7392aba54930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145603Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758210}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib339e816175670df686263a95bedfe5da5060ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145607Reviewed-by:
-
Manu Cornet authored
Change-Id: Icd18465789966a8f00c4ad1884eafd84c5a4c5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144213Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#758208}
-
Tommy Li authored
This CL adds some mouse hover handling to the omnibox Views headers, analogous to what OmniboxResultView already has. The logic is slightly duplicative but I would hesitate to add any abstraction at this point, given the experimental nature of the feature, as well as the fact that it's just two locations. Bug: 1052522 Change-Id: Ib0211c1e168bf17e0ff6ad487cc43c986801e064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145077Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#758207}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7255d72f8da..f4403e7a7805 git log f7255d72f8da..f4403e7a7805 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 fmalita@chromium.org Revert "[SVG] Replace custom attribute value wrappers with std::variant" 2020-04-10 fmalita@chromium.org [SVG] Replace custom attribute value wrappers with std::variant Created with: gclient setdep -r src/third_party/skia@f4403e7a7805 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I2ab89250f0c28cbd18cb79fd269791bfe0c4dce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145604Reviewed-by:
-
Stepan Khapugin authored
Assigns IDs semi-randomly to created scenes and restores the session from a given session ID into a scene. This fixes a bug where opening a new window would restore the previous session from the first window. However, a permanent solution here would be to actually implement session restoration that is not based on non-persistent integer window IDs. Bug: 1069747 Change-Id: I4a5352d56f4a7d506ff618944b9868c688a5b612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144274 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758205}
-
David Jean authored
Screenshots: https://drive.google.com/open?id=1wO5R_D_1ogzaLFIfoaj-puXGwgVGmt2g https://drive.google.com/open?id=1XViRY_5zc_K7zmvznBDsmOTKiJpOwRZD https://drive.google.com/open?id=1ppZj1vKlvHXd8HGxIAUczyCvD4DZ_4a6 Bug: 1052143 Change-Id: I883f97f34be0999171f16075abd975166a53f7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141900Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#758204}
-
Nate Fischer authored
This documents the cool stuff hiding in Dev UI's options menu. This also links to instructions for hooking up WebView to Chrome DevTools, in case folks find this page looking for that. Bug: 1058571 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I6ecd5ac4b8e102b36a5cbdd28c9ce60958057a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144263 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758203}
-
Maksim Sisov authored
This is part of the effort to move X11WholeScreenMoveLoop and X11DesktopWindowMoveClient down to ui/base/x outside ui/views. To do so, we need to stop using such components as aura:: or views:: there. Bug: 1069469 Change-Id: Ifa32ed167720985ec24c40a246340799d7339bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144055Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#758202}
-
Koji Ishii authored
This patch adds `const` to the instances of |NGFragmentItem|. Bug: 982194 Change-Id: Id8262130e0e516c904c4f441fb05b04076d866d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139635Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758201}
-
Monica Basta authored
This CL implements showing the user manager on startup if |kNewProfilePicker| feature is enabled and there is no policy to force signin. The next step will be to create the profile picker and show it instead of the user manager. Bug: 1063856 Change-Id: I9a8efd1267191e590b2087a3bbfbf0b828c91584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133983 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#758200}
-
Dominic Farolino authored
This CL removes lazy load image placeholder logic and tests. It somewhat accompanies https://crrev.com/c/2125570, and the specific changes are summarized below: - Removes FetchParameters::SetAllowImagePlaceholder, which turns eligible image requests into range requests for the first 2k of the real image, such as to fetch the placeholder. This was originally added in codereview.chromium.org/2423683002. - Removes the LAZY_IMAGE_LOAD_DEFERRED previews state, and its associated Blink enum value. This was originally added in crrev.com/c/1260926, which also stored some lazy loaded image state in PlaceHolderImage, and added some placeholder creation logic. This CL removes those changes as well. - Removes the LAZY_IMAGE_AUTO_RELOAD previews state, and its associated Blink enum value. This was originally added in crrev.com/c/1529865, which also recorded estimated data savings of Lo-Fi and lazy loaded images whose placeholders were first fetched. The Lo-Fi recording was removed in crrev.com/c/1652012, and this CL removes the recording for lazy loaded images. - Removes FetchParameters::ImageRequestOptimization::kAllowPlaceholder, and replaces all invocations of CSSImageValue::CacheImage that pass in kAllowPlaceholder, with invocations that pass kNone. - [TEST]: Removes TestThatReloadIsStartedThenServeReload, and TestThatIsPlaceholderRequestAndServeResponse in the image resource tests, and the tests that use them, as they test placeholder/partial image fetching, and use FetchParameters::SetAllowImagePlaceholder which is going away in this CL. - [TEST]: Remove other tests that use FetchParameters::SetAllowImagePlaceholder. Bug: N/A Change-Id: Ic39036a5a240df483970375a89f35678e0f10866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137860Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#758199}
-
Benoit Lize authored
The lock only ensures that initialization is done once. This does not require a lock, and actually would not require to be done only once at all since the initialization is idempotent. This is part of a larger PartitionAlloc refactoring (see linked bug). Bug: 1061437, 787153 Change-Id: Ie2898b59114216ab76050c47e6d998051d3f3998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144138Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#758198}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05e2350de5a9..f7255d72f8da git log 05e2350de5a9..f7255d72f8da --date=short --first-parent --format='%ad %ae %s' 2020-04-10 bsalomon@google.com Try out plane/channel index scheme in wacky yuv format GMs. Created with: gclient setdep -r src/third_party/skia@f7255d72f8da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I3f66cf4b8e91b455230d1bee2d3328b5364eec40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145601Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ef5a232. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idb4e0d7909f0e9a9782ee9cb977f423476d8c9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143856Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758196}
-
David Jean authored
Bug: 1045454 Change-Id: I187eec6794ba509f32560c0d422124a628ee4d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144176Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1260c0bbd0ae..cf9ec0ae80a4 git log 1260c0bbd0ae..cf9ec0ae80a4 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@cf9ec0ae80a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2b19436423b3b8df9a5c709a2d07078b1d08393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145596Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/75de196cecab..fd593d5f0834 git log 75de196cecab..fd593d5f0834 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 h.baensch.92@gmail.com Get rid of all warnings with MSVC and clang-cl (#2177) Created with: gclient setdep -r src/third_party/glslang/src@fd593d5f0834 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Id62467a67fb258ddd6f8ab148743654682d2b97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145440Reviewed-by:
-
Monica Basta authored
Bug: 1063856 Change-Id: Ic5ca250b80ee2a76c22d18ed2724f33550afb35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116190 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
Jaeyong Bae authored
This patch means removing spelling markers if the form element is marked as readonly and disabled. The spec seems pretty clear regarding this [1]: The value of textarea elements that do not have a readonly attribute and that are not disabled. [1] https://html.spec.whatwg.org/multipage/interaction.html#spelling-and-grammar-checking Bug: 687949 Change-Id: I716d1607d12a603c821211cc0b1933d05b9fdda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120992 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#758191}
-
Scott Violet authored
Here's the doc for the new function, which is added to Navigation: Sets a header for a network request. If a header with the specified name exists it is overwritten. This method can only be called at two times, from {@link NavigationCallback.onNavigationStarted} and {@link NavigationCallback.onNavigationStarted}. When called during start, the header applies to both the initial network request as well as redirects. @param name The name of the header. The name must be rfc 2616 compliant. @param value The value of the header. The value must not contain '\0', '\n' or '\r'. @throws IllegalArgumentException If supplied invalid values. @throws IllegalStateException If not called during start or a redirect. @since 83 public void setRequestHeader(@NonNull String name, @NonNull String value) { BUG=1065536 TEST=covered by tests Change-Id: Ibe6487bcc7167fd2e68fcaee46915a877f4619b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133171Reviewed-by: -
Scott Violet authored
This makes changing the active tab trigger exiting fullscreen, so that we don't end up trying to do something bad. This also makes TopControlsContainerView.destroy() remove a callback, just to be safe. This also consolidates code for notify of active change. The net result is a slightly different notification order, but I'm hoping it won't cause problems. BUG=1069417 TEST=FullscreenCallbackTest.testExitFullscreenWhenTabDestroyed Change-Id: I59a8f40b05a4f94b0720cbb4930cb3a87892d4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145093Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758189}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Id6f952376c4be6528664dc2ec765ec6359733b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144748Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758188}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e9713ba15b38..469c029a7c22 git log e9713ba15b38..469c029a7c22 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 538512e8e898..34be23373b9e (2 commits) 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 75de196cecab..fd593d5f0834 (1 commits) 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 47d5e27460af..e7bbc302dff2 (1 commits) 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ae6787114fb5..2fd41fab58c8 (2 commits) Created with: gclient setdep -r src/third_party/angle@469c029a7c22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I8c1b9d3271bcb9d101858dcee05a2137f0e4c89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145593Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8277ecb30334..c2dcb3eec9ad git log 8277ecb30334..c2dcb3eec9ad --date=short --first-parent --format='%ad %ae %s' 2020-04-10 btolsch@chromium.org Force test logic checks in e2e tests Created with: gclient setdep -r src/third_party/openscreen/src@c2dcb3eec9ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ieee34ef9d103ad5dffad07776a4a30a3bceb6fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145592Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f13dee83. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Id13d71e6a0bf07803b42494d82ca52b08286336c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144700Reviewed-by:
-
Nikita Podguzov authored
We are not going to have page size restriction policy in the near future. If we ever implement this policy it will have more scalable format (see follow-up CL). Taking into the account the above, we delete PrintingAllowedPageSizes policy from the code. It's safe as we have never released this policy ('future': 'true') and have even never had appropriate handler for it. Bug: 1015690 Change-Id: I38129f8012e82c6a27413597b615c3111593d821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135690 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758184}
-
Kenichi Ishibashi authored
This CL adds ServiceWorkerResourceMetadataWriter which will be used by browser/embedders to write metadata (V8 code cache) to storage. This will be used after ServiceWorkerStorage is migrated to the storage service. Bug: 1055677 Change-Id: If2a18d89ce5483f8c4792c78309eceeedbdc22d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138659 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758183}
-
Koji Ishii authored
This patch adds a DCHECK to ensure |NGFragmentItemsBuilder| computes the capacity of items before it adds them. Bug: 982194 Change-Id: I50f64eaa6f3f9f1c31ebd5f27b16e2c8e5d20a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145378Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/059c1b75eb67..9f0b36c4610d git log 059c1b75eb67..9f0b36c4610d --date=short --first-parent --format='%ad %ae %s' 2020-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 407aa3d6..bc4df9dd (758038:758140) 2020-04-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ca551bc6..407aa3d6 (757925:758038) Created with: gclient setdep -r src/third_party/webrtc@9f0b36c4610d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ife89aeabe76f31eb3ed3675ae2f156afbae88fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145441Reviewed-by:
-
Takuto Ikuta authored
Bug: 1069704 Change-Id: Ibb832d55710f5d7cc8546e41100401bec55798e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144807 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#758180}
-
Benoit Lize authored
FontResource clears the decoded data when all clients are removed. This is not interacting well with a recent change, https://chromium-review.googlesource.com/c/chromium/src/+/2134291. The change above discards the encoded data after it has been decoded, as the encoded data is never used afterwards. However, when all clients of a FontResource instance are destroyed (typically when the @font-face src value object is destroyed), we clear the decoded data, but do not remove the FontResource from the memory cache. This means that the following scenario: 1. CSSFontFaceSrcValue is destroyed (typically after a navigation) 2. *No GC* 3. A new document is parsed, and the font is found in the memory cache The newly-matched FontResource is not usable, since it doesn't hold a decoded or encoded representation, triggering console messages, which appear as a regression in the linked bug. This can be fixed in two ways: - Revert the encoded data clearing patch above - Don't drop the decoded data when clients disappear The second solution is preferable, since once all clients have disappeared, the resource will not outlive the next GC cycle unless claimed in the meantime. However clearing the encoded data reduces memory footprint in steady state. In addition, the current behavior leads to a new decompression of the font resource at each navigation, which is wasteful. As a consequence, this patch removes the clearing of decoded data once clients are gone. This was verified as removing the console warnings on cnn.com, which is one of the sites triggering the alert on perf bots. Bug: 1067226, 1067930 Change-Id: I3ebb96b8e310a2d6cf46fbbedfdce95999b520de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141924Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/538512e8e898..34be23373b9e git log 538512e8e898..34be23373b9e --date=short --first-parent --format='%ad %ae %s' 2020-04-09 stevenperron@google.com Handle more cases in dead member elim (#3289) 2020-04-09 h.baensch.92@gmail.com Fix pch macro to ignore clang-cl (#3283) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@34be23373b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I4da9d1a7e21e6346c423d03b6ee52bb113993272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145434Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:1049995 Change-Id: Iac13d70fb24f9dc5f36937d625ce33bd7152b092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144079 Auto-Submit: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#758177}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c68dfaf3a529..e9713ba15b38 git log c68dfaf3a529..e9713ba15b38 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 3cfa8e28be80..e6f65d9265e7 (5 commits) Created with: gclient setdep -r src/third_party/angle@e9713ba15b38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Idbb9bcf6eaf7e0d89f4feda21a25a94f7bc3cb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145435Reviewed-by:
-
