GitLab

There's currently a dependency cycle between gyp files: components.gyp
and extensions.gyp. extensions.gyp depends on a number of components,
and two components depend on exetensions.gyp. These are:
 - components/renderer_context_menu/
 - components/native_app_window/ (more recently)

renderer_context_menu has an "optional" extensions dependency, which can
be skipped when ENABLE_EXTENSIONS is not defined. Still, it is necessary
for renderer_context_menu.gyp to omit its extensions.gyp dependency and
build as a static library.

For native_app_window, since it is not compiled on Mac, the gyp circular
check is not performed on the bots.

This CL fixes the layering by adding a folder,
src/extensions/components. Things here may depend on extensions, but not
on other extensions/components folders in a way that creates a cycle.
This also allows the benefits of a component-architecture to make sense
of interdependencies between the ~1337 files under src/extensions.

This layout also makes it clear that by depending on one of these
components, a target is also depending on src/extensions. Currently,
this is not clear.

BUG=35878, 418455
TBR=reed@google.com

Review URL: https://codereview.chromium.org/606953002

Cr-Commit-Position: refs/heads/master@{#297952}

Refactor FakeAttachmentStore into AttachmentStoreProxy and
InMemoryAttachmentStore backend. Break AttachmentStore interface into
AttachmentStoreBase (common interface for backends) and AttachmentStore
(referenced by datatype and AttachmentService).

BUG=
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/616983002

Cr-Commit-Position: refs/heads/master@{#297951}

RenderWidgetHostImpl maintains a rolling estimate of composite times
to be passed to RenderWidgetHostViewAndroid::SendBeginFrame to
improve deadline estimate.

Latency info is still currently tied to input events. Future patch
should make the latency_info update on a per frame basis.

BUG=414365

Review URL: https://codereview.chromium.org/577273003

Cr-Commit-Position: refs/heads/master@{#297950}

Review URL: https://codereview.chromium.org/610733002

Cr-Commit-Position: refs/heads/master@{#297949}

Revert of [Android] Don't push deps when listing gtests. (patchset #1 id:1 of https://codereview.chromium.org/560133002/)

Reason for revert:
While we do want to only attempt to push once, this isn't the right way to do it. We should push _before_ attempting to list the tests, then be done with it.

Also, this breaks https://codereview.chromium.org/537063002/

Original issue's description:
> [Android] Don't push deps when listing gtests.
>
> PushDataDeps takes a long time even when all files are on the device
> because calculating the digests of all the files takes _much_ longer
> on a device than it does on a host.
>
> Skipping the push step during test listing -- where the data deps are
> unnecessary -- means that we don't try to push files twice in each
> gtest run, so we skip all of the device-side MD5 calculations that
> would happen in the second run.
>
> BUG=400440
>
> Committed: https://crrev.com/5c10479a0c3572cd41062b453c3e85527b5cfbad
> Cr-Commit-Position: refs/heads/master@{#294667}

TBR=starodub@chromium.org,cjhopman@chromium.org,klundberg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400440

Review URL: https://codereview.chromium.org/627553002

Cr-Commit-Position: refs/heads/master@{#297948}

TBR=jwd@chromium.org
BUG=325447

Review URL: https://codereview.chromium.org/619423002

Cr-Commit-Position: refs/heads/master@{#297947}

There are three subtle bugs that appear when using the
redesign that this fixes:
1. You can drag the container to be only 3 pixels wide,
   but then it expands back to 6 pixels wide.
2. Expanding the container enough to see an icon won't
   necessarily make the container "stick" with the icon
   visible.
3. The highlight painter should still be initialized for
   the main container with the redesign.

Also tweak the function signature of IconCountToWidth(),
and have it determine the need for a chevron.

Review URL: https://codereview.chromium.org/602613003

Cr-Commit-Position: refs/heads/master@{#297946}

Content shell doesn't support fullscreen video currently, this change fixes that issue.

Review URL: https://codereview.chromium.org/627513002

Cr-Commit-Position: refs/heads/master@{#297945}

Keyboard does not show up in certain cases (like landscape phones on JB devices)
by simply using InputMethodManager.SHOW_IMPLICIT.

BUG=411854

Review URL: https://codereview.chromium.org/620263002

Cr-Commit-Position: refs/heads/master@{#297944}

Chromium side for https://codereview.chromium.org/620003005/

BUG=352380

Review URL: https://codereview.chromium.org/621023003

Cr-Commit-Position: refs/heads/master@{#297943}

Reland Unit test for sync online wallpaper (https://codereview.chromium.org/618743003/)
It was reverted because failure on linux_chromium_os with this error:
[7412:7412:0930/164710:INFO:CONSOLE(180)] "ReferenceError: Constants is not
defined
    at testSyncOnlineWallpaper
(file:///tmp/run_tha_teste4P5jV/chrome/test/data/chromeos/wallpaper_manager/unit_tests/event_page_unittest.js:24:11)
    at continueTesting (\u003Canonymous>:177:19)
    at runTests (\u003Canonymous>:153:5)
    at \u003Canonymous>:1:51", source:  (180)
../../chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc:89:
Failure
Value of: ExecuteWebUIResourceTest(web_contents, empty_libraries)
  Actual: false
Expected: true

BUG=416130

Review URL: https://codereview.chromium.org/611233004

Cr-Commit-Position: refs/heads/master@{#297942}

This patch adds convenience defines for implies relationship.

a implies b is equivalent to !a || b.

This allows things like the following:
CHECK_IMPLIES(ptr, ptr->is_good);
instead of the more cumbersome:
CHECK(!ptr || ptr->is_good).

Review URL: https://codereview.chromium.org/576073007

Cr-Commit-Position: refs/heads/master@{#297941}

BUG=None

Review URL: https://codereview.chromium.org/626633002

Cr-Commit-Position: refs/heads/master@{#297940}

The web_request_permission.cc has been moved to //extensions, but for some reason its copy is still in //chrome. This CL does a clean up for it.

BUG=352293

Review URL: https://codereview.chromium.org/610323006

Cr-Commit-Position: refs/heads/master@{#297939}

BUG=227092
TBR=meacer@chromium.org

Review URL: https://codereview.chromium.org/603793003

Cr-Commit-Position: refs/heads/master@{#297938}

C++11 in Chromium! http://g/quic-dev/iBPFBDwPMjQ

Merge internal change: 76451118

R=rch@chromium.org, rjshade@chromium.org

Review URL: https://codereview.chromium.org/612323013

Cr-Commit-Position: refs/heads/master@{#297937}

This is a regression.
The CL crrev.com/585203002 did incorrectly handle a StatsTable FD
as its ownership was passed. The ownership should be retained by
StatsTable instead.

BUG=419655
R=jam@chromium.org, creis@chromium.org

Review URL: https://codereview.chromium.org/625633002

Cr-Commit-Position: refs/heads/master@{#297936}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3d06386..ef8cdb9

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/609383003

Cr-Commit-Position: refs/heads/master@{#297935}

This was fixed in: https://codereview.chromium.org/622823002

BUG=419644

Review URL: https://codereview.chromium.org/625623003

Cr-Commit-Position: refs/heads/master@{#297934}

Currently when WebRTC isn't visible (app is in background or tab is not visible) in chrome Android, we stop sending captured video frame, but still hold the camera, this makes camera can not be used by other apps.

This patch releases the camera on pause, and allocate it again when resume, since SuspendDevices() is only called in Android, this is Android only behavior.

BUG=417659

Review URL: https://codereview.chromium.org/615043006

Cr-Commit-Position: refs/heads/master@{#297933}

TBR=cpu

Review URL: https://codereview.chromium.org/619373003

Cr-Commit-Position: refs/heads/master@{#297932}

In most files this means removing unused variables/code.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/614813002

Cr-Commit-Position: refs/heads/master@{#297931}

These additional calls were preempting the initial load animation from
finishing. Keyboard show animations would start, then a SetBounds call
would skip the animation resulting in an abrupt first-load experience of
the keyboard jumping right to the end position and being blank (still
loading). After this fix the keyboard nicely animates till the end and
by the time the animation is finished the keyboard is loaded as well.

BUG=356753
TEST=Verified on linux chromeos.

Review URL: https://codereview.chromium.org/617013002

Cr-Commit-Position: refs/heads/master@{#297930}

Add various cflags/cflags_cc and disable clang chromium-style
enforcement on third_party/khronos_glcts sourcecode and support.

This is a workaround for various compile time warnings on desktop
linux (e.g. Ubuntu 12.04) that are treated as errors (i.e. by
-Werror).  The source of these warnings are from the
third_party/khronos_glcts sourcecode.  With these workarounds
the khronos_glcts_test is able to finish compilation.

The plan is to eventually fix the third-party code so we can
remove these workarounds.

BUG=chromium:412865
R=piman@chromium.org, kbr@chromium.org
TBR=piman@chromium.org
TEST=export GYP_DEFINES="internal_khronos_glcts_tests=1"
TEST=gclient runhooks
TEST=ninja -C out/Release khronos_glcts_test
TEST=./out/Release/khronos_glcts_test
TEST=ninja -C out/Debug khronos_glcts_test
TEST=./out/Debug/khronos_glcts_test
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>

Review URL: https://codereview.chromium.org/615063004

Cr-Commit-Position: refs/heads/master@{#297929}

Depends on https://codereview.chromium.org/620793004/

BUG=413057

Review URL: https://codereview.chromium.org/619273002

Cr-Commit-Position: refs/heads/master@{#297928}

Combine ManifestHandlers for PageActions and BrowserActions.
Remove support for the uber-deprecated "page_actions" (plural) manifest key.
Clean up related tests.

TBR=avi@chromium.org (c/b/ui/cocoa)
BUG=419475

Review URL: https://codereview.chromium.org/624453003

Cr-Commit-Position: refs/heads/master@{#297927}

And update help text.

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/613083003

Cr-Commit-Position: refs/heads/master@{#297926}

This gives the flag a possible value of "default", which will allow us to enable the feature for some users who haven't explicitly opted in/out.

BUG=410824

Review URL: https://codereview.chromium.org/611233005

Cr-Commit-Position: refs/heads/master@{#297925}

Applications can retrieve the configuration arguments with the ApplicationImpl args() method (see https://codereview.chromium.org/568173003).

A Mojo application can be specified with a URL followed by one or more arguments, so long as the entire expression is within quotes:

  mojo_shell 'mojo://mojo_wget http://www.google.com'

The "args-for" switch can be used to specify arguments for Mojo applications that are started by the specified app:

  mojo_shell args-for='mojo:mojo_native_viewport_service foo bar' mojo:mojo_surfaces_app

The args-for switch can be used repeatedly to specify arguments for multiple Mojo apps.

BUG=418797

Review URL: https://codereview.chromium.org/617943002

Cr-Commit-Position: refs/heads/master@{#297924}

TBR=cpu

Review URL: https://codereview.chromium.org/626643002

Cr-Commit-Position: refs/heads/master@{#297923}

I have verified that no other certificates in the CT logs uses this key.

(This change also removes an expired ANSSI intermediate.)

BUG=none

Review URL: https://codereview.chromium.org/616773004

Cr-Commit-Position: refs/heads/master@{#297922}

$ git log 6b1084e27..f4e9ccbec --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-10-01 vadimsh Add --dump-json option to 'isolate.py batcharchive'.
2014-10-01 maruel Fix regression in 12a7da4e37; swarming.py collect collecting isolated output
2014-10-01 maruel Stop using get_matching_test_cases and get_results; use new client API.
2014-09-30 vadimsh Initial implementation of 'batcharchive' command.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/623793002

Cr-Commit-Position: refs/heads/master@{#297921}

This avoids early restart to apply guest profile user flags
if device owner has some flags set.

BUG=411049
TEST=
1. Login as the device owner and set some flags in about::flags
2. Log out and enter guest mode
3.1. Press alt + shift + I -> Feedback report dialog should be launched
3.2. In chrome://help click "Report an issue" -> Feedback report dialog
should be launched

Review URL: https://codereview.chromium.org/611383007

Cr-Commit-Position: refs/heads/master@{#297920}

BUG=none
TEST=none
R=tbarzic@chromium.org

Review URL: https://codereview.chromium.org/622893002

Cr-Commit-Position: refs/heads/master@{#297919}

Bisect builders fail to apply patches sent via try_job_http,
because of this we were not able to build revisions with DEPS patches.
Now we are using "git try" instead to trigger build request on bisect builders.

BUG=411418
NOTRY=true

Review URL: https://codereview.chromium.org/607803005

Cr-Commit-Position: refs/heads/master@{#297918}

- Allowing users to paste into the fakebox using the middle click, for supporter OS.

- Moving #fakebox-text behind #fakebox-input to prevent blocking.

BUG=370343

Review URL: https://codereview.chromium.org/623603002

Cr-Commit-Position: refs/heads/master@{#297917}

BUG=419505

Review URL: https://codereview.chromium.org/617183005

Cr-Commit-Position: refs/heads/master@{#297916}

BUG=418979

Review URL: https://codereview.chromium.org/619333002

Cr-Commit-Position: refs/heads/master@{#297915}

Recent change https://codereview.chromium.org/612093007/ in install_worker.cc
uses BrowserDistribution::CHROME_APP_HOST, which we wish to remove. So we
refactoring this to use AppRegistrationData instead.

BUG=297647

Review URL: https://codereview.chromium.org/619203002

Cr-Commit-Position: refs/heads/master@{#297914}

When a text field is focused on Android, the keyboard comes up and the field
is zoomed into the viewport. The page scale animation that is created would
happen in LayerTreeHostImpl, however, the resized viewport layers were still
in the sync_tree until it got activated. This led to incorrect clamping of
the viewport when the text field was near the bottom of the document and
becomes more visible when virtual viewport pinch to zoom is turned on.

BUG=364217,419450

Review URL: https://codereview.chromium.org/615953005

Cr-Commit-Position: refs/heads/master@{#297913}