- 06 Jan, 2017 40 commits
-
-
gab authored
BUG=661143 Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f Cr-Commit-Position: refs/heads/master@{#440418} Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f Cr-Commit-Position: refs/heads/master@{#440479} Cause of revert fixed in https://codereview.chromium.org/2611053003/. Review-Url: https://codereview.chromium.org/2592813002 Cr-Commit-Position: refs/heads/master@{#441997}
-
phulce authored
Paving the way to expose all relevant cookies per 673934. * Adds filter bar with text match on name, value, and domain * Converts invisible state buttons into disabled states BUG=673934 Review-Url: https://codereview.chromium.org/2617043002 Cr-Commit-Position: refs/heads/master@{#441996}
-
bokan authored
With inert-top-controls turned on by default, we don't change the layout height when the top controls are normally hidden. That is, if a user hides the URL bar by scrolling, the page won't resize to use the newly available space. It'll lay out as though the URL bar was still showing. This patch makes an exception for cases where Chrome locks the URL bar in the hidden state. e.g. Fullscreen or WebApp mode. In those cases, since the URL bar can't be shown at all, there's no reason not to use the full height. BUG=678649 Review-Url: https://codereview.chromium.org/2614993002 Cr-Commit-Position: refs/heads/master@{#441995}
-
nasko authored
This CL prefixes the DidFinishLoading and DidReceiveData methods in BrowserPluginDelegate, so they don't conflict with the WebAssociatedURLLoaderClient versions which currently start with lowercase letter. As part of the Blink rewrite to match Chromium style, those will be colliding in MimeHandlerViewContainer. BUG=582312 Review-Url: https://codereview.chromium.org/2616123002 Cr-Commit-Position: refs/heads/master@{#441994}
-
klausw authored
Replace the GLSurface::Format enum with a proper class in preparation to supporting types with configurable depth_size / samples / stencil_size. Doing this in the current enum format would lead to a combinatorial explosion. The basic idea is that GetFormat can be used to initialize a new surface with the same format as a pre-existing surface, and a IsCompatible predicate is used to check if two formats are equivalent for the purpose of avoiding BAD_MATCH errors. Code should no longer be comparing formats to SURFACE_DEFAULT or similar. Also add a new CreateOffscreenGLSurfaceWithFormat function that can be used to request a specific surface format. (These changes were suggested during review of https://crrev.com/2461803002 which is now forked into https://crrev.com/2586803003 .) BUG=655722 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2616723002 Cr-Commit-Position: refs/heads/master@{#441993}
-
sebsg authored
BUG=678983 TBR=rouslan@chromium.org Review-Url: https://codereview.chromium.org/2617943003 Cr-Commit-Position: refs/heads/master@{#441992}
-
eugenebut authored
These fakes will be resued in CRWWebControllerPageDialogOpenPolicyTest instead of CRWWebUserInterfaceDelegate mock. BUG=661445 TRR=kkhorimoto@chromium.org Review-Url: https://codereview.chromium.org/2615093004 Cr-Commit-Position: refs/heads/master@{#441991}
-
wkorman authored
Improves code readability, sharing, and future maintenance. I don't expect a performance impact but if we do see something material we could inline. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2611253003 Cr-Commit-Position: refs/heads/master@{#441990}
-
cavalcantii authored
The idea is to allow to monitor performance gains while optimizing parts of the JPEG code path. BUG=674264 Review-Url: https://codereview.chromium.org/2617843002 Cr-Commit-Position: refs/heads/master@{#441989}
-
elawrence authored
Web forms may not contain a username element, therefore it is not safe to assume that such an element exists when calling ShowNotSecureWarning. Instead, use the actual element found by the autofill logic. BUG=678769 Review-Url: https://codereview.chromium.org/2612893003 Cr-Commit-Position: refs/heads/master@{#441988}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/469f6da247ff..8d94b6687f27 $ git log 469f6da24..8d94b6687 --date=short --no-merges --format='%ad %ae %s' 2017-01-06 rbpotter Revert postscript code removal. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2612303005 Cr-Commit-Position: refs/heads/master@{#441987}
-
mef authored
BUG=666792 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2617853002 Cr-Commit-Position: refs/heads/master@{#441986}
-
sigbjornf authored
Fixes compilation failures with various < gcc-5.0 toolchains lacking std::is_trivially_copyable<T>. Without it, compile errors like ../../base/template_util.h:189:36: error: no type named 'is_trivially_copyable' in namespace 'std' using is_trivially_copyable = std::is_trivially_copyable<T>; ~~~~~^ ../../base/template_util.h:189:57: error: expected ';' after alias declaration using is_trivially_copyable = std::is_trivially_copyable<T>; ^ ; will be encountered. R=danakj BUG=555754 Review-Url: https://codereview.chromium.org/2612933003 Cr-Commit-Position: refs/heads/master@{#441985}
-
tedchoc authored
Currently, all intents received by ChromeTabbedActivity are logged as MobileReceivedExternalIntent despite there being many codepaths within Chrome that also trigger intent dispatch. A code search for Browser.EXTRA_CREATE_NEW_TAB shows a bunch of callers that trigger intents and we logged them all as external. This conflates whether we are receiving intents from other applications or ourself. The intent of this change (yuck, yuck, yuck) is to split out intents that we dispatch ourselves and ones that an actual external app did. BUG=648386 Review-Url: https://codereview.chromium.org/2604063002 Cr-Commit-Position: refs/heads/master@{#441984}
-
chrishtr authored
BUG=678452 Review-Url: https://codereview.chromium.org/2617433005 Cr-Commit-Position: refs/heads/master@{#441983}
-
eyaich authored
BUG=chromium:677972 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2615003003 Cr-Commit-Position: refs/heads/master@{#441982}
-
jcivelli authored
Ensures the thread safe interface pointer returned by ThreadSafeAssociatedInterfacePtrProvider can be called before the interface pointer is actually bound. BUG=675089 TEST=Run mojo_public_bindings_unittests Review-Url: https://codereview.chromium.org/2608783003 Cr-Commit-Position: refs/heads/master@{#441981}
-
bauerb authored
The UI is hidden behind a feature flag that enables a menu item (which uses innovative string compression techniques to avoid bloat due to i18n) to open the standalone content suggestions UI. While the activity and menu item are not meant to be shipped in an enabled state, this will allow iterating on a content suggestions UI outside of the NTP. Review-Url: https://codereview.chromium.org/2593523005 Cr-Commit-Position: refs/heads/master@{#441980}
-
xing.xu authored
These properties provide the author with the ability to control layout through logical, rather than physical, direction and dimension mappings. Intent to Implement and Ship: CSS Logical Properties, Inline/Block size, https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4qEXWptfVHs. This intent is a followup for "Intent to Deprecate and Remove: -webkit-{min-,max-}logical-{width,height}", https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/VbPI65jBMIc. When entire css-logical-props are implemented, will review these -webkit-{min-,max-}logical-{width,height} and see if it is necessary to remove them. Spec: https://drafts.csswg.org/css-logical-props-1/#logical-dimension-properties https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical BUG=538475 Review-Url: https://codereview.chromium.org/2577363002 Cr-Commit-Position: refs/heads/master@{#441979}
-
tonikitoo authored
Past [1], 'ash/*' became a dependency tiedly coupled with 'is_chromeos'. This, for various reasons, helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build and run Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 Review-Url: https://codereview.chromium.org/2620503002 Cr-Commit-Position: refs/heads/master@{#441978}
-
dewittj authored
InstantExtendedTest.SearchDoesntReuseInstantTab (run #2): [ RUN ] InstantExtendedTest.SearchDoesntReuseInstantTab [4616:1072:0106/014942.591:ERROR:variations_util.cc(88)] Missing Worker Pool Configuration: Background [1156:5048:0106/014942.680:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported. [4616:4776:0106/014943.002:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico [4616:1072:0106/014943.047:INFO:CONSOLE(1)] "Uncaught ReferenceError: onMostVisitedChangedCalls is not defined", source: (1) BUG=678975 TBR=treib@chromium.org Review-Url: https://codereview.chromium.org/2613273002 Cr-Commit-Position: refs/heads/master@{#441977}
-
jwd authored
Reland of https://codereview.chromium.org/2614443002, which was reverted due to static initializer. end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group. This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one. BUG=677976 Review-Url: https://codereview.chromium.org/2612243003 Cr-Commit-Position: refs/heads/master@{#441976}
-
braveyao authored
Since OSX Sierra, when we ask for the CGImage of a cursor image, it will return a double-size CGImage with Retina display, which can't pass the sanity check. =========================(deprecated)================================== In this cl, we try to pass a half-size Rect hint to get CGImage with original cursor size on both Retina and non-Retina display. Also it fixs another issue that we render the cursor based on window coordinate to a target in physical coordinate. ====================================================================== In this cl, we implemented a new common base class, CursorRenderer , to merge the two implementations. Then we can handle the scaling and rendering of cursor same on all platforms, also with other advantages: caching scaled cursor image for better performance and only caring about view coordinates (same handling to Retina and non-Retina). BUG=659183 Review-Url: https://codereview.chromium.org/2553763002 Cr-Commit-Position: refs/heads/master@{#441975}
-
domenic authored
This incorporates the spec and test changes at: - https://github.com/whatwg/streams/commit/0745219ca7b7f02ef104145b78ebebd99c0fd12c - https://github.com/whatwg/streams/commit/872188a984722861020ae773a5ee558892797c33 - https://github.com/whatwg/streams/commit/591a6eda9ea0b84881a370519d6aca53fab9e256 - https://github.com/whatwg/streams/commit/551489c68d1f9c582a3a7334fbb88a85500d5867 - https://github.com/whatwg/streams/commit/68aa48c5e463bdc15c43944cd561ce6fcec5441c - https://github.com/whatwg/streams/commit/43c4b00d440b3c391a48fb761c3967c2e77d6cd1 - https://github.com/whatwg/streams/commit/22b3f03bf803868bf65d9b57f862cc7e3cc80188 BUG=671958 Review-Url: https://codereview.chromium.org/2596883002 Cr-Commit-Position: refs/heads/master@{#441974}
-
dewittj authored
Flaky on ChromeOS and in the CQ on linux_chromium_asan_rel_ng. BUG=678976 TBR=mattcary@chromium.org Review-Url: https://codereview.chromium.org/2615113004 Cr-Commit-Position: refs/heads/master@{#441973}
-
skau authored
This reverts commit 194dc32c. With https://codereview.chromium.org/2610373003/ enabling printing in incognito, we can reenable printer setup in Guest Mode. BUG=667395 Review-Url: https://codereview.chromium.org/2616003002 Cr-Commit-Position: refs/heads/master@{#441972}
-
amaralp authored
The Ime test, testPastePopupShowAndHide, was flaking because of a race condition where the paste popup menu was shown before the insertion handle was shown. This is a problem because it allows the scenario: 1) Paste menu shown 2) Set composition 3) Insertion handle is shown This causes the paste menu to not be hidden since setting the composition only clears the menu by clearing the insertion handle. This CL makes setting the composition wait for the insertion handle to be shown to guarantee this sequence: 1) Paste menu and insertion handle shown 2) Set composition 3) Insertion handle cleared 4) Paste menu hidden BUG=661572 Review-Url: https://codereview.chromium.org/2617583003 Cr-Commit-Position: refs/heads/master@{#441971}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9e6944a8f310..fa1926f937dc $ git log 9e6944a8f..fa1926f93 --date=short --no-merges --format='%ad %ae %s' 2017-01-06 sullivan Update perf dashboard tooltips to use logdog logs and show status pages. 2017-01-06 charliea Undo unnecessary disables from http://crrev.com/2236493003/ 2017-01-05 simonhatch Dashboard - Add some extra logging info for failed auto-bisect. 2017-01-05 nednguyen Revert of Asserting telemetry story display name length for filename creation. (patchset #3 id:40001 of https://codereview.chromium.org/2488743006/ ) 2017-01-05 dtu [pinpoint] Fix error message for missing parameters in /isolated. 2017-01-05 benjhayden Update UserModel to an ES6 class. 2017-01-05 benjhayden Configure chai to include stack traces. 2017-01-05 achuith Revert retries for DNS failures. 2017-01-05 benjhayden Finish renaming InteractionRecords to UserExpectations. 2017-01-05 sullivan Add a cached last_row_timestamp to StoppageAlert. 2017-01-05 eakuefner [Dashboard] Factor business logic in AddPointHandler out into AddData method 2017-01-05 simonhatch Dashboard - Bisect output should include percent change if possible. 2017-01-05 jessimb Changing group reports to use an id for multiple keys. 2017-01-05 charliea Replace iterItems() with Object.entries() in a few files 2017-01-05 charliea Use individual power sample for story:power metric 2017-01-05 eakuefner [Dashboard] Eliminate redundancy in AddPointHandler.post 2017-01-05 mikecase Add logcat markers to begin and end of each story. 2017-01-05 charliea Migrate more files from iterItems() to Object methods 2017-01-05 simonhatch Dashboard - Refactor output and clarify bisect failures. 2017-01-04 charliea [catapult android trybot] Make Telemetry tests run on Android 2017-01-04 eyaich Asserting telemetry story display name length for filename creation. 2017-01-04 achuith Browser startup timeout 4 min on ChromeOS, 1 min elsewhere. 2017-01-04 aiolos Unit refactor cl 1: Rename UnitScale to UnitPrefixScale. BUG=662941,546625,665439,678282,665439,662941,676742 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2613243002 Cr-Commit-Position: refs/heads/master@{#441970}
-
pilgrim authored
As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/platform/. There are too many references to change them all at once, so this CL is part 14 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2615813003 Cr-Commit-Position: refs/heads/master@{#441969}
-
sczs authored
HistoryPage_EntryLinkClick HistoryPage_InitClearBrowsingData HistoryPage_RemoveSelected HistoryPage_Search HistoryPage_SearchResultClick BUG=676121 Review-Url: https://codereview.chromium.org/2592843002 Cr-Commit-Position: refs/heads/master@{#441968}
-
olivierrobin authored
Reset the scrollview delegate before releasing the WKWebView. Move the |scrollview setDelegate:| to static_html_native_content.mm for symetry. BUG=678118 Review-Url: https://codereview.chromium.org/2616633003 Cr-Commit-Position: refs/heads/master@{#441967}
-
dewittj authored
Revert of Add CHECKs to ResourceLoader to investigate crashes (patchset #1 id:1 of https://codereview.chromium.org/2619513002/ ) Reason for revert: This seems to be causing WebKit Linux Trusty Leak to fail reliably, perhaps you don't need to test in the wild with a CHECK after all? 04:10:44.200 6804 worker/0 http/tests/htmlimports/import-async-previous-async.html crashed, (stderr lines): 04:10:44.200 6804 [1:1:0106/041043.551773:1549663839:FATAL:ResourceLoader.cpp(70)] Check failed: !m_loader. 04:10:44.200 6804 #0 0x0000014b22ce base::debug::StackTrace::StackTrace() 04:10:44.200 6804 #1 0x0000014c110b logging::LogMessage::~LogMessage() 04:10:44.200 6804 #2 0x000002832215 blink::FinalizerTrait<>::finalize() 04:10:44.200 6804 #3 0x000000f0fae0 blink::NormalPage::sweep() 04:10:44.200 6804 #4 0x000000f0dd29 blink::BaseArena::completeSweep() 04:10:44.200 6804 #5 0x000000f12edc blink::ThreadState::completeSweep() 04:10:44.200 6804 #6 0x000000f14c40 blink::ThreadState::collectGarbage() 04:10:44.200 6804 #7 0x00000241a36f blink::V8GCController::gcEpilogue() 04:10:44.200 6804 #8 0x000000a85b05 v8::internal::Heap::PerformGarbageCollection() 04:10:44.200 6804 #9 0x000000a849bc v8::internal::Heap::CollectGarbage() 04:10:44.200 6804 #10 0x000000a83943 v8::internal::Heap::CollectAllGarbage() 04:10:44.200 6804 #11 0x00000241aa0b blink::V8GCController::collectAllGarbageForTesting() 04:10:44.200 6804 #12 0x0000023a11c7 blink::(anonymous namespace)::WebLeakDetectorImpl::collectGarbageAndReport() 04:10:44.200 6804 #13 0x00000148c109 _ZN3IPC8MessageTI34ShellViewMsg_TryLeakDetection_MetaSt5tupleIJEEvE8DispatchIN7content15BlinkTestRunnerES7_vMS7_FvvEEEbPKNS_7MessageEPT_PT0_PT1_T2_ 04:10:44.200 6804 #14 0x00000148b980 content::BlinkTestRunner::OnMessageReceived() 04:10:44.201 6804 #15 0x0000020f3da2 content::RenderViewImpl::OnMessageReceived() 04:10:44.201 6804 #16 0x0000016616d5 IPC::ChannelProxy::Context::OnDispatchMessage() 04:10:44.201 6804 #17 0x000001525b0e base::debug::TaskAnnotator::RunTask() 04:10:44.201 6804 #18 0x00000231a9b2 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() 04:10:44.201 6804 #19 0x0000023195f4 blink::scheduler::TaskQueueManager::DoWork() 04:10:44.201 6804 #20 0x000001525b0e base::debug::TaskAnnotator::RunTask() 04:10:44.201 6804 #21 0x0000014c631d base::MessageLoop::RunTask() 04:10:44.201 6804 #22 0x0000014c6a65 base::MessageLoop::DoWork() 04:10:44.201 6804 #23 0x0000014c7a4a base::MessagePumpDefault::Run() 04:10:44.201 6804 #24 0x0000014c6047 base::MessageLoop::RunHandler() 04:10:44.201 6804 #25 0x0000014dfc5e base::RunLoop::Run() 04:10:44.201 6804 #26 0x000002110b80 content::RendererMain() 04:10:44.201 6804 #27 0x000000fc5887 content::RunZygote() 04:10:44.201 6804 #28 0x000000fc67fc content::ContentMainRunnerImpl::Run() 04:10:44.201 6804 #29 0x000000fbf760 content::ContentMain() 04:10:44.201 6804 #30 0x00000043ecf1 main 04:10:44.201 6804 #31 0x7f6e80c02f45 __libc_start_main 04:10:44.201 6804 #32 0x00000043ebd1 <unknown> Original issue's description: > Add CHECKs to ResourceLoader to investigate crashes > > There are crash reports that |m_resource| is broken in > ResourceLoader::didReceiveResponse. It is strange as ResourceLoader::m_resource > is constant after its construction. To investigate the issue, this CL adds some > CHECKs in ResourceLoader. > > BUG=675947 > R=tyoshino@chromium.org > > Review-Url: https://codereview.chromium.org/2619513002 > Cr-Commit-Position: refs/heads/master@{#441919} > Committed: https://chromium.googlesource.com/chromium/src/+/0ff2bff5863ccfdc069ed54794104dc126c6daf9 TBR=tyoshino@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675947 Review-Url: https://codereview.chromium.org/2615993005 Cr-Commit-Position: refs/heads/master@{#441966}
-
svaldez authored
BUG=677326 Review-Url: https://codereview.chromium.org/2607193002 Cr-Commit-Position: refs/heads/master@{#441965}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/f80f115dd5ae..8c8cb5bfc547 $ git log f80f115dd..8c8cb5bfc --date=short --no-merges --format='%ad %ae %s' 2017-01-06 mtklein simplify by removing _d stages 2017-01-06 brianosman Revert "Revert "Hard code bicubic coefficients in the shader"" Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@google.com Review-Url: https://codereview.chromium.org/2615013004 Cr-Commit-Position: refs/heads/master@{#441964}
-
sky authored
I also removed some ifdefs that are no longer necessary and some windows code that isn't needed. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2611253002 Cr-Commit-Position: refs/heads/master@{#441963}
-
mlamouri authored
Using an interface makes the usage of MediaImage needlessly more complicated than needed. A dictionary should keep the feature working roughly the same way and improve developer's ergonomics. Spec change: https://github.com/WICG/mediasession/pull/162 BUG=676995 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2612003002 Cr-Commit-Position: refs/heads/master@{#441962}
-
tedchoc authored
TBR=yusufo@chromium.org BUG=671797 Review-Url: https://codereview.chromium.org/2611163005 Cr-Commit-Position: refs/heads/master@{#441961}
-
eseckler authored
Adds BeginFrameAck struct and updates the signature and callsites of BeginFrameSource::DidFinishFrame(). This is split off from https://codereview.chromium.org/2527283003/. Observers will be required to use BeginFrameAcks to indicate the result of a BeginFrame message. The acknowledgments will be used by the DisplayScheduler to determine when all updates for a BeginFrame have been received and trigger an early deadline. A BeginFrame acknowledgment indicates: 1) completion of a specific BeginFrame by the observer, 2) whether or not the observer produced updates, and 3) the oldest frame that was incorporated into the last update from the observer. 2) and 3) are in preparation for DevTool's BeginFrameControl, see http://bit.ly/bfc-v1 and https://codereview.chromium.org/2411793008/. Follow-up patches will add: - correct calculation of |latest_confirmed_frame| in Scheduler/DisplayScheduler. - missing DidFinishFrame() calls in observers - integration of acks into CompositorFrame submission (to allow ack propagation from services / renderer compositor) - modification of DisplayScheduler to rely on BeginFrameAcks. BUG=646774, 401331 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2591013004 Cr-Commit-Position: refs/heads/master@{#441960}
-
wangxianzhu authored
This can be used to disable SlimmingPaintInvalidation when it is enabled by default. BUG=646176 TBR=achuith@chromium.org (for chrome/browser/chromeos/login/chrome_restart_request.cc) R=pdr@chromium.org,creis@chromium.org,holte@chromium.org Review-Url: https://codereview.chromium.org/2612323002 Cr-Commit-Position: refs/heads/master@{#441959}
-
stanisc authored
The DCHECK could be triggered if sampling of results by SharedSampler on background thread took longer than refresh cycle (1 second) and at the same time user added or removed one of TaskManager columns handled by SharedSampler. This DCHECK was an errorneous assumption. I removed it and added a comment explaining this situation. BUG=678471 Review-Url: https://codereview.chromium.org/2612773004 Cr-Commit-Position: refs/heads/master@{#441958}
-