- 15 Nov, 2019 40 commits
-
-
Adrian Taylor authored
Some changes to the online HTML documentation based on discussions and external feedback. Bug: 955102 Change-Id: Ia9ad3bc0e33db17516eba5f0bd77c94ef067a26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577845 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#715919}
-
Robert Iannucci authored
> This is reserved for people that are comfortable with Chromium builders > and understand the implications of changing their configurations. I'm not really any of these things any more :). R=agable@chromium.org, jbudorick@chromium.org Change-Id: Ie38a25240e24a09ca87582a3a81584e3e8ca55b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919999 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715918}
-
Matt Menke authored
It was failing with ERR_ABORTED, but this error code is only intended for user-initiated aborts, and the renderer treats it as a magic error code (cancels the navigation instead of showing an error page). Bug: 941651 Change-Id: I5968e90728994566c83df0a905dbbfbb11f4f088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913876 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#715917}
-
Min Qin authored
OMA download on Q needs to be published to media store Currently because the file path is set to null, copying it to media store will fail. This CL fixes the bug by passing the file path after querying the Android DownloadManager. Bug: 978424 Change-Id: Iabf7358de1096a12632eb9546068b3622d377152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917749Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715916}
-
Clark DuVall authored
This was reverted because it caused startup crashes on non-monochrome bundle APKs (http://crbug.com/953932). The reason for the crash was that the ProductConfig.UNCOMPRESSED_LOCALES was empty for non-monochrome APKs. The only reason this worked on monochrome was because monochrome happens to include webview resources uncompressed. Now we make sure to add locale paks to bundle APKs uncompressed, which correctly fills out ProductConfig.UNCOMPRESSED_LOCALES. In addition, I added a task to clean up the old extracted files if we detect they are no longer needed. Diffs from original patch are from Patchset 1 on. Original change's description: > android: Do not compress locale .pak files inside bundle splits. > > This CL ensures that the locale-related pak files stored in > app bundle splits are stored uncompressed inside the language-based > splits (e.g. base-fr.apk for the French language), and are read > directly from it. > > Benefits include: > - Less disk i/o during Chrome startup for bundles. > > - Reduced overall install size, since the corresponding files > need not be extracted. I.e. since the compression ratio is > roughly 50% for locale .pak files, we have something like. > > Before: compressed 50 kiB (APK) + uncompressed 100 kiB (/data) > After: uncompressed 100 kiB (APK) > > However, this increases the size of the base and split apks slightly. > > In more details: > > - Modify create_app_bundle.py to ensure that the split-specific > locale .pak files are never compressed. > > Also, move the en-GB.pak file location from fallback-locales/ > to the split-specific locales#lang_en/, this ensures that the > file will end up in the English-based split (base-en.apk) > instead. > > - Modify ResourceExtractor.java to only extract the locale .pak > files in regular APKs, ignoring the ones from bundles. Also make > the log messages disappear unless the DEBUG final variable is > set to true (less logs are always better for startup time). > > - Modify ResourceBundle.java to check for the presence of > split-specific locale .pak files as well, and to also check > that the corresponding file path being returned actually > exists inside the apk or bundle. > > - Modify ResourceBundle::LoadLocaleResources() to try loading > the split-specific locale pak files before the extracted version > if available, and add a technical note explaining what the code > is trying to do (it is sufficiently subtle to be explained). > > - Add missing dependencies to the vr_android_unittests and > shell_dialogs_unittest targets. They otherwise fail to > build due to http://crbug.com/951419. > > BUG=933943,933962, 951419 > R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,benmason@chromium.org,dtrainor@chromium.org,jaekyun@chromium.org > TBR=sky@chromium.org > > Change-Id: I02c1688b8f8ed8f62cfdaa1f12c2ea15f8198e4a > Binary-Size: Increments overall bundle size by 100 kiB, but reduces overall install size by about 50% of that. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514684 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650753} Bug: 933943, 933962 Binary-Size: Increments overall bundle size by 100 kiB, but reduces overall install size by about 50% of that. Change-Id: If85211fa83809d814eb55fe66d81becc1723d9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918367 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715915}
-
Dale Curtis authored
Almost every DemuxerStream::Read() test was using a bare base::RunLoop::Run() and later posting as deprecated quit closure for the current loop. This updates all the tests to use a helper method which properly sets the RunLoop and explicit QuitClosure. It also cleans up some log spam and clang warnings at the same time. I'm not sure this actually resolves the linked bug though, I think that was actually a bug in ffmpeg which has subsequently been fixed in a later ffmpeg roll. BUG=996040 R=xhwang Change-Id: I91e2221da5bb95017c82a255a2676a2a6ce5f944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919722 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715914}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/83ca1b9af5cc..aba1020d3914 git log 83ca1b9af5cc..aba1020d3914 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 bclayton@google.com Remove the now unused sw::Event. 2019-11-15 bclayton@google.com VkQueryPool: Migrate from sw sync to marl 2019-11-15 bclayton@google.com VkDevice: Migrate to using marl::Event::any() 2019-11-15 bclayton@google.com VkFence: Migrate to marl::Event 2019-11-15 bclayton@google.com Merge changes Ifb21caa2,Iaca5897d Created with: gclient setdep -r src/third_party/swiftshader@aba1020d3914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140546382,chromium:b/140546382,chromium:b/144388391,chromium:b/144388391 Change-Id: I06e4475a1a5a751fa68d78ee73af61fccbf20b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715913}
-
Ahmed Mehfooz authored
Bug: 1025278 Change-Id: I011cf937cab3a3e41eed93ecae8e768def4ae27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919564Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715912}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aee0c115ad21..e2835ec9385d git log aee0c115ad21..e2835ec9385d --date=short --no-merges --format='%ad %ae %s' 2019-11-15 lalitm@google.com Merge "trace_processor: revamp sorting algorithm" Created with: gclient setdep -r src/third_party/perfetto@e2835ec9385d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3c40f7945cb9c812cab0cfaa74d3324186b0de4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919780Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/428e7aff..295649fd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib642dbb8a5327f2c20a7ee3dd5b6599c0a33ac51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715910}
-
Takumi Fujimoto authored
Record whether the icon is ephemeral or pinned. Bug: 1023623 Change-Id: Iff2d49c16cbc58bb0853d08cb0b0b6e7c194be2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910803 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715909}
-
Sarthak Shah authored
Changes for new fling animation curve are still ongoing. Thus extending the expiry milestone of "enable-experimental-fling-animation" flag to M81. Change-Id: Ia2ef834ff1bc88a46b2ff979a94ff981f55d7306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918144Reviewed-by:
-
Takashi Toyoshima authored
For now, the OOR-CORS launch for WebView is planned on m80. So, we want to wait for the m80 reaching the stable before removing the flag. That says the expiry_milestone would be extended to be m82. Change-Id: Id2ff25200e2a11257b7967bae57c3c8a2cf803d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918918 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#715907}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ce2f6cfa67a4..df1d0b0a33e1 git log ce2f6cfa67a4..df1d0b0a33e1 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 vapier@chromium.org cros lint: fix func/class docstring checker Created with: gclient setdep -r src/third_party/chromite@df1d0b0a33e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib86bc9317b2429d226d8186268faae95266b32eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919577Reviewed-by:
-
Chris Cunningham authored
This is just the blink-side of the change. A follow up CL will do the real work in the media layer. For now attribute is behind a flag. To enable use --enable-blink-features=MediaLatencyHint Bug: 1018908 Change-Id: I8f9b1eb8911db77d68d2774a85715e3a315f85a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903540Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#715905}
-
David Tseng authored
This change is mostly mecanical though it does contain some cleanup of ChromeVox Classic logic. It is a prerequisite to modernization of ChromeVox sources. A taste of what the modern ChromeVox looks like is here: https://chromium-review.googlesource.com/c/chromium/src/+/1917948/1 In addition, this will eventually allow for extraction of a shared accessibility module, harvesting useful pieces of ChromeVox for other accessibility component extensions. Bug: none Test: manual and browser_tests. Change-Id: I1fc3198ce9fac8f96d9b7fd0f829cc3be4848bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918325Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715904}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77c16a79405b..0db19efecac9 Created with: gclient setdep -r src-internal@0db19efecac9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I930144772cd28dc55e028ced76e299fdb4c2ffb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918665Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715903}
-
Pavel Yatsuk authored
BUG=1023566 Change-Id: Ie4ea9b81a70f5a383a2b5f486919d9a17cd909c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917467 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#715902}
-
Greg Thompson authored
This change introduces RelaunchIgnoreUnloadHandlers and uses it in RelaunchNotificationController when the deadline for a forced relaunch is reached. This new function is to AttemptRelaunch as ExitIgnoreUnloadHandlers is to AttemptExit. This also introduces browser_shutdown::ShouldIgnoreUnloadHandlers(), which is a convenience for code that needs to know whether or not an in-progress shutdown should ignore unload handlers. BUG=958865 Change-Id: I91a9832d745e95b7436b176d78f5e39ed14addd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914380 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#715901}
-
Manu Cornet authored
The shelf layout manager currently calculates and sets the bounds of all the shelf-related widgets (navigation, hotseat, status area). The bound calculation logic should remain in this class, but the actual setting of the bounds and managing animations can be done by each widget at their leisure without requiring a full relayout of all other widgets. For that to happen, the shelf layout manager can be the central place from which widgets can ask their target bounds, but they can then be responsible for setting them themselves at their own pace. This CL makes the target bounds a field so that other classes can query them at any time (through getters that will be added subsequently as other classes need them). This has no expected user-visible effect. Bug: 1021698 Change-Id: I6214d21315aec42e01d44f9f8ace4b041e970704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919603Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#715900}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/deae1fce2cc5..e4aa7235b859 git log deae1fce2cc5..e4aa7235b859 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 timvp@google.com Vulkan: Update Expectations with GLES 3.1 Conformance Failures Created with: gclient setdep -r src/third_party/angle@e4aa7235b859 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I65bc939c82ae31736d7e54fdae77520891bd9e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919576Reviewed-by:
-
Chris Lu authored
Creates InfobarManagerAppInterface to allow for retrieval of InfobarManager state. Bug: 987646 Change-Id: Ic518fe7ffaaeec27b08f6a3e4a37a12dc84387fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914535 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#715898}
-
chrome://flagsAlexander Timin authored
Fix chrome://flags behaviour for bfcache flag forcing caching: - Ensure that all parameters are correctly captured - Rename the mode to "Force caching all pages" to be more clear - Extend timeout to 1 hour for easier testing. R=carlscab@google.com Change-Id: I7df177abccea0fa849a5834c13b75464553c5cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919759 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#715897}
-
Anastasia Helfinstein authored
When the accessibility tree changes, events are fired on the automation API. This change updates the Switch Access tree when those events are received. Bug: 1023035 Change-Id: I88e208b8ed9d10653db2395dd4424194c3ef3248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907550 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715896}
-
Brian Sheedy authored
Switches the win10_intel_hd_630_experimental mixin to trigger tests on driver version 26.20.100.7323. TBR=ynovikov@chromium.org Bug: 1016459 Change-Id: I68059fafe2ffd5b855f51b540ec4653ab40b9e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918386Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715895}
-
Tina Wang authored
Bug: 1025369 Tbr: grt@chromium.org Change-Id: If745b038e44a67c9cd48ad3a3bd361f05e5ea811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918348Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715894}
-
Daniel Hosseinian authored
Place the functionality under the enable-custom-mac-paper-sizes feature flag. Bug: 1020350 Change-Id: Ia577351f33151446ef8864fd99e0301d5d13d5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898946 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#715893}
-
Martin Kreichgauer authored
This default-enables FIDO2 fingerprint enrollment UI in chrome://settings/securityKeys Bug: 974046 Change-Id: I2c707943a10c588798b6704aa1416e246fe6d3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895310 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715892}
-
Matt Wolenetz authored
Already disabled on WIN/MAC/CHROMEOS, these tests have been heavily flaky on various linux bots. This change fully disables these tests (a subset of the PreviewsLitePageRedirectServerTimeoutBrowserTests). TBR=tbansal@chromium.org BUG=1024824 Change-Id: I686c928b085677c267fc8298e6f9e756ad32bcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919802Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715891}
-
Brian Sheedy authored
Marks monochrome_public_bundle_fake_modules_smoke_test as experimental since it currently does not work properly on component builds, which is blocking some CLs. Bug: 1025316 Change-Id: Ica40093e3b6134871a9aa04695343ed2344f20b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918271Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715890}
-
Kaan Alsan authored
Removing a snap container (i.e. making it unscrollable) should reassign its snap areas to the next scrollable ancestor. Bug: 1007456 Change-Id: Ic3ebea990a25a36020d278a33fb3c67dea708db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899189Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Kaan Alsan <alsan@google.com> Cr-Commit-Position: refs/heads/master@{#715889}
-
Hitoshi Yoshida authored
We didn't have non readonly attributes that have [CachedAttribute], and unfortunately, generated code for that have problems. This CL fixes the compile errors found in non readonly [CachedAttribute] attributes. Bug: 715418, 1025322 Change-Id: I5cd42c94adaa552521bc1f734d5afcbc832a122a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919521 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#715888}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/90c88f097366..46689b09c559 git log 90c88f097366..46689b09c559 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 apolito@google.com Fix CMDUploadTestCase in presubmit Created with: gclient setdep -r src/third_party/depot_tools@46689b09c559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1025293 Change-Id: I6b3fa6ec46adc2674efa7a08d899672eb5fda77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919701Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1025313 Change-Id: I87631cc98eb6bb4e5dd11ba1a66bd3868c55865e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918269Reviewed-by:
-
Demetrios Papadopoulos authored
Most of these have been fixed automatically with ESLint's --fix flag. This is in preparation of turning on presubmit checks for no-var and prefer-const for components/. Bug: 792774,720034 Change-Id: I482ed8577bf260a6190fb646891194f8d533debc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914496 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715885}
-
Kevin Marshall authored
Update README.md how-to docs to use the new `--fuchsia-out-dir` flag. Update the debugging how-to in README.md to incorporate improvements with Chromium package/symbol installation and the "fx debug" entrypoint. Change-Id: I95f99c37c5afedb06db5229eae820d06353b45cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913573 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715884}
-
Xiaoqian Dai authored
When dragging a window quickly up into the drag-to-snap split area, the overview windows are getting relayouted and while the animations are still going on, fling the window to homescreen. So OverviewItem::OnItemBoundsAnimationEnded() can be called when overview is in shutting down process, which should not happen. Bug: 1025267, 997885 Change-Id: Ia40f3fce589554672f2134f78ac4ddd8147d0910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918834 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715883}
-
Sasha McIntosh authored
Add field trial entry for decoding JPEG 4:2:0 images to YUV. Bug: 919627 Change-Id: Ie8dc6378cccf27527da9ea05d060ba218fb69bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898548Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715882}
-
Tina Wang authored
Bug: 1025291 Tbr: yangguo@chromium.org Change-Id: I5edde51c20744d4b0f69cd8b9fb31ab2ff604b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918278 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
BUG=1024850 TBR=adithyas@chromium.org,agrieve@chromium.org Change-Id: Ib99f9a64f4bea821efc5bab831233aa9e8928680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919726Reviewed-by:
-
