- 10 May, 2018 40 commits
-
-
Bence Béky authored
|request_info| argument to ValidatePushedStream() is the client request. I accidentally misnamed the variables and misplaced the comments when I originally wrote this code. This CL clears up the confusion. Since both the client and pushed request must have a range header, and they must match, this is no functional change. The only confusing thing is that one request is available as an HttpRequestInfo object, the other one as a SpdyHeaderBlock object, so the syntax for extracting this header is different. SpdyStream: :request_headers() is the pushed request headers. Change-Id: I4752b6021492bcdc30f85e672a0036a0e4cb272b Reviewed-on: https://chromium-review.googlesource.com/1050193Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557523}
-
Bence Béky authored
Run git cl lint on //net/spdy/chromium and fix all complaints (except for one about rand_r and thread safety). Change-Id: Ie51085fb03f640a11dd2c7681d571e7bc6163ace Reviewed-on: https://chromium-review.googlesource.com/1050189Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557522}
-
Ryan Landay authored
This CL adds logging for two UMA events in the Android tab switcher: MobileStackViewNormalMode when a user switches from incognito mode to normal mode, and MobileStackViewIncognitoMode when a user switches from normal mode to incognito mode. The logging only records mode switches that happen while the tab switcher is open (i.e., swiping between stacks, and opening a new tab while inside the tab switcher that causes the other stack to become active, and also if we add a toolbar button for toggling normal/incognito mode). It does *not* log mode switches that happen outside the tab switcher (e.g. opening an incognito tab while in normal mode while the tab switcher is not active). Bug: 828224 Change-Id: I8f4f20dd290c59ccf261c39380388165c0fed408 Reviewed-on: https://chromium-review.googlesource.com/1050738Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#557521}
-
Matthew Jones authored
This patch disables animations when the bottom sheet is clearing its requests and hiding. This prevents an issue in EoC where new content is requested prior to the sheet being completely hidden. This results in suggestions being visible without reverse scrolling. Bug: 834923 Change-Id: I8bed11c87e24ab3b16d95d91329723eeb2a188e5 Reviewed-on: https://chromium-review.googlesource.com/1048705Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#557520}
-
Anna Malova authored
Bug: 837631 Change-Id: Ia2f2d7f23e23b64114ae29538feb24027c94f137 Reviewed-on: https://chromium-review.googlesource.com/1050345Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#557519}
-
Ryan Landay authored
This is a reland of fd312950. The original CL did not update the tools/metrics/actions/actions.xml file. Original change's description: > Add UMA event for entering Android tab switcher by toolbar swipe > > We currently don't have any UMA events for entering the Android tab switcher by > swiping down on the toolbar. In > https://chromium-review.googlesource.com/c/chromium/src/+/1048042, I am updating > the MobileToolbarShowStackView logging to include this case. In this CL, I am > adding a new MobileToolbarSwipeOpenStackView event specifically for this case so > we can measure how many people are entering the tab switcher by swiping on the > toolbar. > > Bug: 828224 > Change-Id: I2b2f7e4dafd08192355618273d7069a03b4d9e4e > Reviewed-on: https://chromium-review.googlesource.com/1048308 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556954} Bug: 828224 Change-Id: I2e717a946a8405aa180f9b1d96d72ad38985f092 Reviewed-on: https://chromium-review.googlesource.com/1052587Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#557518}
-
Adam Rice authored
The histograms Extensions.OffStoreInstallAllowReason and Extensions.OffStoreInstallDecisionHard have never been included in histograms.xml and so no-one has ever looked at the data they produce. Remove them. BUG=641289 Change-Id: I30e03c52d88bb456bd6aef8318d6e136f8218cc5 Reviewed-on: https://chromium-review.googlesource.com/1053667Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#557517}
-
xlai authored
TBR=junov@chromium.org,bajones@chromium.org Bug: 776826 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idacc96a19591ae2c5bfc0911243e6a38dcf8a402 Reviewed-on: https://chromium-review.googlesource.com/1052490Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#557516}
-
Roger McFarlane authored
This CL adds feature flags that causes Chrome to suppress suggestions, votes and quality metrics based on profile data which has been flagged as likely invalid. This will allow Chrome Team to evaluate the utility of attempting to filter out this data. Bug: 835984 Change-Id: I986020fcdc1319ffcab9a8fd998862c27ba645f7 Reviewed-on: https://chromium-review.googlesource.com/1053597Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#557515}
-
Adam Rice authored
Histogram Extension.ExternalProvidersReadyAfter has existed since at least 2012, but never been mapped. This implies that no-one has ever been interested enough to look at the data, and so it is providing no value to users. Remove it. BUG=643540 Change-Id: I472e5e515469a084fcb1b0ad6ce18826f40ad7ea Reviewed-on: https://chromium-review.googlesource.com/1053669Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#557514}
-
Emily Stark authored
When an error message has recurred several times, show a message on the interstitial. This CL adds the CSS for the recurrent error message. See https://bugs.chromium.org/p/chromium/issues/detail?id=839969#c3 for a current screenshot. Bug: 839969 Change-Id: I4a3ce380563d7053bf6d241ae18a380f67d22300 Reviewed-on: https://chromium-review.googlesource.com/1052918 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#557513}
-
Douglas Creager authored
We weren't including the `include-subdomains` field of each endpoint group in the data we were handing over to the net-internals page. (The net-internals code that reads this field is already there; we just weren't filling in a value.) Bug: 829353 Change-Id: Ic1f81241c40de063e68c56ee2f2e10ba0b8da7a6 Reviewed-on: https://chromium-review.googlesource.com/1052851Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#557512}
-
Daniel Nicoara authored
Have DrmDevice read the properties and cache them during initialization. Update SetColorCorrection() to use the cached properties rather than query them every time the properties are set. BUG=839487 TEST=Ran on eve and verified the CTM is set correctly. Change-Id: I5efd4f4d83d0458a29dc1e7b588f708e0b04912a Reviewed-on: https://chromium-review.googlesource.com/1042277 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#557511}
-
Max Morin authored
CleanUp may not be called (it may happen that the frame owning the stream is destroyed before the signal to clean up the stream is received from the renderer), so move key press stuff from there to the destructor. Bug: 836226 Change-Id: I141b5942296c268b43a82934ec01c744931df65d Reviewed-on: https://chromium-review.googlesource.com/1052697Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557510}
-
Koji Ishii authored
Following bot results are included. 5308 5309 5312 5316 5324 5325 5328 5333 5336 120 lines were removed and 21 lines were deflaked by consecutive results since 5265. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7ebbeee62eec646d22e3aa6070295ae296208ad4 Reviewed-on: https://chromium-review.googlesource.com/1051466 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557509}
-
Tibor Goldschwendt authored
This change lets us scroll one page in the tabs view. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I72d4bc22a73c0c871c8d233d69335ee58a10e93e Reviewed-on: https://chromium-review.googlesource.com/1050845Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557508}
-
Justin Novosad authored
This CL is a step towards removing OffscreenCanvasResourceProvider BUG=788439 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I78972f67aa8849de59690f591d69c534bdc08a42 Reviewed-on: https://chromium-review.googlesource.com/1053173Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557507}
-
Ryan Landay authored
We currently log the UMA event MobileTabSwitched when a user switches tabs in the Android tab switcher, but we don't log one if the user stays on the same tab. This CL starts logging a new MobileTabReturnedToCurrentTab event for this case. Bug: 828224 Change-Id: Iaeedf9f0c7493e68ae2fde335eaba5ad6bd0405d Reviewed-on: https://chromium-review.googlesource.com/1050926Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#557506}
-
Ryan Landay authored
This CL adds logging for a new UMA event MobileToolbarStackViewButtonInStackView to log when a user in the Android tab switcher taps on the tab switcher button on the toolbar to exit the tab switcher. Bug: 828224 Change-Id: I1b7528544daba0c2f23746f309d4b97cf98ef826 Reviewed-on: https://chromium-review.googlesource.com/1050965Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#557505}
-
Noel Gordon authored
Tbr: slangley Bug: 841659 Change-Id: I2f7e55e103f91c563600a29632c59fade44fba3b Reviewed-on: https://chromium-review.googlesource.com/1053676Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557504}
-
Sam McNally authored
Bug: 823956 Change-Id: I6dbb43bb2a9af2723798f00f5ee1cd0cdc1dfa95 Reviewed-on: https://chromium-review.googlesource.com/1039114 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557503}
-
Roger Tawa authored
Bug: 834939 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaa64d4a386da00914b0f69a33573f8e049833b82 Reviewed-on: https://chromium-review.googlesource.com/1035805Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#557502}
-
Nick Harper authored
Bug: 841685 Change-Id: I1deb65b345058cf9317122ffb5bb4a236dd5446c Reviewed-on: https://chromium-review.googlesource.com/1053787 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557501}
-
Bence Béky authored
Some SpdyStream methods are conceptually const, mark them as such. Change-Id: I89935beec587771045554e30dffdb998195e5e64 Reviewed-on: https://chromium-review.googlesource.com/1050190Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557500}
-
Ethan Kuefner authored
This is the OBBS-side version of https://chromium-review.googlesource.com/c/chromium/tools/build/+/1052920 Bug: 841351 Change-Id: Ie863c647ecd93ebeda326b00ebcad1543db0f7ef Reviewed-on: https://chromium-review.googlesource.com/1053048Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#557499}
-
Robert Phillips authored
The dependent Skia CL is: https://skia-review.googlesource.com/c/skia/+/127125 (Fix clipping of SkMatrixImageFilter input (take 2)) Change-Id: I971081aebfe333bbaa3b6a6d209038e198c118ff Reviewed-on: https://chromium-review.googlesource.com/1052850Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#557498}
-
Jinho Bang authored
This patch adds a use counter to count invalid currency code. The data will be used later when deprecating/removing the member. Bug: 839402 Change-Id: Idbb4f305cf453a3ddddf19983ecfb45bec69d22d Reviewed-on: https://chromium-review.googlesource.com/1053027Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#557497}
-
Greg Kraynov authored
Bug: 841735 Change-Id: I38872f08a406c208b65f15845293b2ad55d20b19 Reviewed-on: https://chromium-review.googlesource.com/1053767Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#557496}
-
Tsuyoshi Horo authored
When this feature is enabled: - The Accept header of navigation requests will have "application/signed-exchange;v=b0". - If the response HTTP header has a valid Origin-Trial header for "SignedHTTPExchange", and the Content-Type header is "application/signed-exchange;v=b0", Chrome handles the response as SignedHTTPExchange. - Otherwise, the navigation loading will fail. Bug: 827939 Change-Id: Ib4906388cd6939df51244478d3e7a31df6c43652 Reviewed-on: https://chromium-review.googlesource.com/985993Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#557495}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47084bae. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17237 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes TBR=markdittmer No-Export: true Change-Id: I08f07061ebc283afb41038664889d579a07c4ce6 Reviewed-on: https://chromium-review.googlesource.com/1053575 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557494}
-
Bence Béky authored
Currently when SpdyStream::Delegate calls SpdyStream::Cancel(), that calls SpdySession::ResetStream(), which calls SpdySession::ResetStreamIterator(), which calls SpdySession::CloseActiveStreamIterator() with ERR_SPDY_PROTOCOL_ERROR, which calls SpdySession::DeleteStream() with ERR_SPDY_PROTOCOL_ERROR, which calls SpdyStream::OnClose() with ERR_SPDY_PROTOCOL_ERROR, which calls SpdyStream::Delegate::OnClose() with ERR_SPDY_PROTOCOL_ERROR. After this CL, SpdyStream::Cancel() takes an int error argument, which is passed to SpdySession::ResetStream() then to SpdySession::ResetStreamIterator() then to SpdySession::CloseActiveStreamIterator() then to SpdySession::DeleteStream() then to SpdyStream::OnClose() then to SpdyStream::Delegate::OnClose(). This way Delegate can directly control what error its own OnClose() method will be called with. This will be useful if I end up moving HTTP/2 pushed header validation to SpdyHttpStream, so that it can use a dedicated error code to signal to HttpNetworkTransaction if the pushed stream does not match. Bug: 554220 Change-Id: Id6395d834395d182b7af4a45e1bb1186c1b82feb Reviewed-on: https://chromium-review.googlesource.com/1051007Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557493}
-
Max Morin authored
It checks that the stream is allowed and forwards the request to the relevant ForwardingAudioOutputStreamFactory if so. This will cause the stream to be served by the audio service. The old RenderFrameAudioOutputStreamFactory which creates streams living in content/ is renamed to OldRenderFrameAudioOutputStreamFactory. Since the class was renamed, the files were moved (by adding "old_" to the beginning). No need to review those files. Also note that replacement is diffed against the previous implementation. It's probably best to just ignore the diff and review render_frame_audio_output_stream_factory{.cc,.h,_unittest.cc} as new files. A flag is added to switch between the old factory and the new one. Approximate diagram of stuff: https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit Tbr since there was a "verbal" LGTM in cl comments. Tbr: nasko Bug: 830493 Change-Id: I38887bb97c817cc9182d71edd89d5ff0193b2504 Reviewed-on: https://chromium-review.googlesource.com/1032751 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557492}
-
Max Morin authored
We cannot retry anything yet, so make sure the renderer knows we're gone. Drive-by remove handling of navigations, since it was crashing. Bug: 787806, 840345 Change-Id: Icbaf49dda9ca12094ada2e9decc57622cd1feff6 Reviewed-on: https://chromium-review.googlesource.com/1047209 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557491}
-
Takashi Toyoshima authored
Current PreflightController implementation uses an existing error code to report disallowed preflight redirects tentatively, and results in wrong console messages. This change defines a dedicated error code and use GetErrorString() to generate a console message even for legacy code path. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1af9b8570c2811a9a575e4504b88d6b37db688ea Bug: 803766 Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1027558Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#557490}
-
Yutaka Hirano authored
This reverts commit 189d1033. Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. Original change's description: > Cancel parallel download request if server doesn't send partial response > > If the server doesn't support partial responses, Chrome should cancel > parallel download requests. > These requests result in the wrong write offset and makes the file larger > than the original > > BUG=838627 > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > Reviewed-on: https://chromium-review.googlesource.com/1048130 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557252} TBR=qinmin@chromium.org,xingliu@chromium.org Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627, 841666 Reviewed-on: https://chromium-review.googlesource.com/1053470Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#557489}
-
Stuart Langley authored
Some cleanup work for chrome/browser/chromeos/file_manager/ briging it in line with recomended practices/c++ modernization. Modernize clang-tidy checks that were used: -- modernize-use-default -- modernize-make-unique -- modernize-raw-string-literal -- modernize-use-emplace -- modernize-use-nullptr This CL introduces NO logic changes. Bug: 841659 Change-Id: Icb8803941bd7f2230cb0174c8e307d712ed0e10a Reviewed-on: https://chromium-review.googlesource.com/1053668Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557488}
-
Mohamed Amir Yosef authored
The functionality of handling remote creation of bookmarks has been introduced in this patch https://chromium-review.googlesource.com/c/chromium/src/+/1017201 which supports remote creation of bookmarks as well as folders in the bookmark tree. This CL 1- Enables DownloadBookmarkFolder test for USS. 2- Removes the redudant DownloadBookmark test. It has been recently introduced however it tests the same behavior as InjectedBookmark test case. 3- Enables InjectedBookmark test for USS instead of the removed DownloadBookmark test. Bug: 516866 Change-Id: Ida235e4817fab122448b88f063dbabdbe7ef7712 Reviewed-on: https://chromium-review.googlesource.com/1052247Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#557487}
-
Anita Woodruff authored
- Enables the mojo pathway by default and removes the legacy IPC code path for persistent notifications. - Removes the NotificationsWithMojo feature flag which previously guarded this code-path during incremental development. R=kinuko@chromium.org Bug: 796991 Change-Id: Ia4dac0ab4b98b7a6df342b7df1b424e3af67bf05 Reviewed-on: https://chromium-review.googlesource.com/1027843Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#557486}
-
Mikel Astiz authored
The patch adds a button in chrome://sync-internals that triggers logic to get updates from the sync server, similar to the time-based polls in place (in case invalidations don't work as expected). This is primarily expected to help testing teams. Bug: 839836 Change-Id: I1060026a6e019d0531b4489331294efb6e5aff9c Reviewed-on: https://chromium-review.googlesource.com/1047868 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#557485}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 830489 Change-Id: I465769461f4db57031e49c391f0efe715e2dc067 Reviewed-on: https://chromium-review.googlesource.com/1046730 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557484}
-