- 31 Jul, 2019 40 commits
-
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I1bf1b1bd6e86bc32aa49c3ea7e5a37b6a53fc580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728266 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682907}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 968047 Change-Id: Ifd4fc0f8ebd8082c821ddb40e42a888388a2971f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729076 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#682906}
-
Yi Gu authored
The metrics should not expire until VizHitTesting V2 is shipped (77) and stablized. Other change: riajiang@chromium.org has left chromium. Update the owner according. Bug: 988799 Change-Id: Ie086bd1b2a0ddb4ec57bda15e0086fbc873129ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726295Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682905}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3e493c48d2da..eb1b1646aebe git log 3e493c48d2da..eb1b1646aebe --date=short --no-merges --format='%ad %ae %s' 2019-07-31 jmadill@chromium.org Capture/Replay: Fix capture-enabled libs build. Created with: gclient setdep -r src/third_party/angle@eb1b1646aebe The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ibab6ac84d556ffd0f0126ae2b42ac4f028806627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682904}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ic175a770aa5e213f476e310b27094922480641c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728181 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#682903}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/38037fb44311..f5b14d8843e6 git log 38037fb44311..f5b14d8843e6 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 senorblanco@chromium.org Dawn: update to onSupportedReadColorType(). 2019-07-31 egdaniel@google.com Don't have GrVk*CommandBuffer derive from GrVkResource. Created with: gclient setdep -r src/third_party/skia@f5b14d8843e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I421acd9cca88aad6f99271914c12520800fe5b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728422Reviewed-by:
-
Christopher Cameron authored
We are seeing very long delays during tab-switch, which may be due to metal calls. Also add trace events for IOSurface-backed shared images. Bug: 988964 Change-Id: I6cad2aa3dbd700b5f795cec07b9d7538015a46e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729073Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#682901}
-
Fabrice de Gans-Riberi authored
Bug: 979049 Change-Id: Ifa277e8cf1a76ddd00d76abbf8ac392eb7d0b9f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704692Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#682900}
-
Patrick Monette authored
It has been running on stable at 1% without any issues Bug: 921746 Change-Id: Icd6eaffef7313d01f18c59b5a137fba3e66e06f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724607 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#682899}
-
Maksim Ivanov authored
This CL fixes compilation errors caused when passing const-refs or non-const-refs as value arguments for the UMA macros. Before this CL, an attempt to pass a const-ref as a value resulted in errors like this: base/metrics/histogram_macros_internal.h:30:5: error: static_assert failed due to requirement 'sizeof(const TestEnum &) == 0' "enumerator must define kMaxValue enumerat or to use this macro!" static_assert( ^ base/metrics/histogram_macros_unittest.cc:63:3: note: in instantiation of member function 'base::internal::EnumSizeTraits<const TestEnum &, void>::Count' requested here UMA_HISTOGRAM_ENUMERATION("Test.ScopedEnumeration3", value_ref); ^ base/metrics/histogram_macros.h:84:7: note: expanded from macro 'UMA_HISTOGRAM_ENUMERATION' INTERNAL_UMA_HISTOGRAM_ENUMERATION_DEDUCE_BOUNDARY) \ ^ In file included from ../../base/metrics/histogram_macros_unittest.cc:5: In file included from ../../base/metrics/histogram_macros.h:10: base/metrics/histogram_macros_internal.h:33:12: error: reference to type 'const TestEnum' requires an initializer return Enum(); Bug: none Change-Id: I875ff783bda12cc30079bcf6188ff843b9b55a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729593Reviewed-by: -
Erik Luo authored
Inspector currently relies on Element::matches() to compute matching selector indices. This does not support all selectors, for example ":host". This CL removes StaticCSSRuleList (only used by Inspector), and gets selector indices from RuleData (computed by CSS parsing engine) instead of forcing Inspector to compute them. Old Explainer: https://docs.google.com/document/d/1rBOWjHqNpkyvMj4pz-nCW-jxKgEqeRVQLsDwvR5b9Kc/edit?usp=sharing Bug: 952440, 976062 Change-Id: I846fae5e80d30d9b3fee64d10cbbe01e1b80b751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703542 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682897}
-
Ian Kilpatrick authored
This renames: IsFixedSizeInline -> IsFixedInlineSize IsFixedSizeBlock -> IsFixedBlockSize "inline-size" / "block-size" words should be kept together. (other possibilities: HasFixedInlineSize, IsInlineSizeFixed). And renames: FixedSizeBlockIsDefinite -> IsFixedBlockSizeIndefinite - "block-size" is kept together. - Flips the bool (definite to indefinite) as NG cares more about something being indefinite (and is a top level-concept kIndefiniteSize). (This was difficult for me to read if (!somethingDefinite) ) The only unfortunate thing here is that it is the opposite of what Legacy cares about - but arguably should be biasing towards NG. (other possibilities: HasIndefiniteFixedBlockSize but only if we go with HasFixedBlockSize as above). Change-Id: I76e050f4cb06fb2b86055fff5f800515f938b20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709691Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682896}
-
Owen Min authored
This reverts commit 5351d11f. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/39025 Original change's description: > [Fuchsia] Update to new FIDL string and vector APIs > > This removes usages of the old API that will become build failures when > deprecation warnings are turned on. > > See: https://fuchsia-review.googlesource.com/c/fuchsia/+/304389 > Change-Id: Ie5db014401d79787101b2b4b6e7585fd7a23b1ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727375 > Commit-Queue: Ian McKellar <ianloic@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682796} TBR=wez@chromium.org,ianloic@chromium.org Change-Id: Ie266c435355009b8846ed2368fc2c97195f24d6c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729476Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682895}
-
Amr Aboelkher authored
Show the high contrast accessibility feature only if one of the following conditions have meet : -Its not being controlled by any policy -Its being controlled by a policy and the value of the policy is force on Bug: 552439 Change-Id: Ia96b797ad9d1ea839b1e8cb74f597dbdfc8cc86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725911 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682894}
-
Adam Langley authored
This trial is switching to being four legged: 1) CECPQ2: HRSS-SXY (structured-lattice) exchange. 2) CECPQ2b: SIKE p434 exchange. 3) Control: a group equally sized to the first two to allow measurements at the server as well as at the client. 4) Disabled: The no-change group. Different from Control because Control clients still signal to the server that they're in the trial. Also adds add histogram to capture latency when the server supports these post-quantum algorithms. Bug: 930812 Change-Id: I5a56c86d6fa98b007b1efe01ea5af0becef64e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709961 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:David Benjamin <davidben@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#682893}
-
manuk authored
1) The drive server may intermittently provide a particular suggestion while typing. E.g. the input 'fluffy' may suggest a doc titled 'fluffy kitten', while the input 'fluffy k' may not. 2) Drive suggests return asynchronously. As a consequence of the above 2, when the drive server and bookmark or history providers suggest the same document, the suggestion displayed flickers between the preferred drive format (e.g. 'title - date - doc_type') and the typical URL format (e.g. 'title - url'). This CL caches the 20 most recent drive suggestions to alleviate the issue. Cached suggestions are scored 0 to avoid affecting the autocomplete results displayed and their rankings. I.e., this CL is cosmetic. Bug: 941548 Change-Id: I8498642b89db463c968c66e3f2181da83e7b623f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576177 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#682892}
-
Anastasia Helfinstein authored
This is step 3 in the migration of Switch Access options into an official settings page. While the first two steps created the settings page and added plumbing for the updated event type, this change modifies where the Switch Access extension finds the preference values, and what page opens for Switch Access settings. Bug: 958081 Change-Id: Id88c6ba1f54444af5cd817222c521121187310cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670272 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#682891}
-
Yang Guo authored
R=alph@chromium.org Bug: chromium:985454 Change-Id: I1a9b7953b1d7bdd9e9de715c3a999cd8997240db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719006 Commit-Queue: Alexei Filippov <alph@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#682890}
-
Kevin Ellis authored
This patch fixes the calculation of when the compositor state needs synchronization. Ordering is important in the calculation of play state, and some idle and pause states were being misclassified as pending. Bug: 988471, 988607 Change-Id: Ie73c57a3101f07bc44d5c353328d7e17d4fb1a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728074Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682889}
-
Jeremy Chinsen authored
Currently in PDFiumEngine::FillPageSides() the logic for handling the bottom gaps of pages on the right side is in the FillPageSides(). This CL moves that logic to draw_utils::AdjustBottomGapForRightSidePage(), making it testable. Bug: 51472 Change-Id: I5c5d0929c46745ee315f3b7ce77dc4cb0b44e5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726757Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#682888}
-
Owen Min authored
This reverts commit f9763b52. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/55348 Original change's description: > Convert content::CommitNavigationParams to mojom. > > Bug: 984550 > Change-Id: Ic966c764e7fb52a9fb8d2ea44d9777bd8c1e4011 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725096 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682795} TBR=avi@chromium.org,nasko@chromium.org,scottmg@chromium.org,lfg@chromium.org Change-Id: Ibc3e06f427783c760970b5deb8f2bf6a6581b610 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729577Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 968047 Change-Id: If31471ee0f29bdeed0639192d1bdba1e75197c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729590 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682886}
-
John Rummell authored
Adds more logging to log the player state with each event, and adds readyState and networkState to the values output. Bug: 986021 Test: Modified tests pass Change-Id: Ib733fea0d75d39bd3e1b763ac39168fe9e47157c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728334Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682885}
-
Koji Ishii authored
This patch removes now unused |AtomicString::DeprecatedLower()|. The 6 calls to it were converted to |LowerASCII()| recently. |String::DeprecatedLower()| still has 37 usages, and that the underlying function is still needed. Bug: 627682 Change-Id: I081be03de495712a2b252e30e95ff5f79c5d1e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724153 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#682884}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8fd585ed. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I55605da90660cc9e7b0a0ed1d93f8c621c41bb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729570Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682883}
-
Owen Min authored
Disable virtual/omt-worker-fetch/external/wpt/resource-timing/resource_timing_buffer_full_eventually.html The test is timeout on Win and Linux. Bug: 989665 Change-Id: I6a805c5c47293cf767c924594f92e5a7e1d7a6a8 Tbr: skym@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729398Reviewed-by:
-
Mason Freed authored
The CL in [1] disabled the use of the mask_resource_id when that mask was for backdrop-filter use. However, in skia_renderer, the mask is applied correctly for both backdrop and regular masks. [1] https://chromium.googlesource.com/chromium/src/+/310cae44aff889a75fc85ce5ec89d9341eccc665 Bug: 981207 Change-Id: Iabb65b145968800d4c17bc3b0e5a01996046c144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724278 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#682881}
-
Owen Min authored
This reverts commit e6af1df2. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/27665?blamelist=1#blamelist-tab Original change's description: > Previews: Check for data saver state at navigation start > > This CL makes the data saver checks more resilient. > > Moving the checks to the very beginning at the navigation start also > prevents recording of some of the Previews histograms for > non-DRP users. > > Change-Id: I26c96d654180a2202eef5f0899c89c37bf4c6da5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716121 > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682836} TBR=tbansal@chromium.org,dougarnett@chromium.org Change-Id: I53b53e652139c9dde2be2b382266ee1778dd3657 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729576Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 968047 Change-Id: Iff33707395af8d9edff34551ba90787c2bf8cdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729079 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: -
Avi Drissman authored
BUG=817024 Change-Id: I60d8e6b269c0c8f565e689508789713f73703e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729470Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682878}
-
Wez authored
The script was looking in the wrong place for the legacy SDK files. Bug: 977018, 989335 Change-Id: Ibd7d3f8e35633af579c27f282e47487a8fc20f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726959 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682877}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5588ed40788d..fee597729b1d Created with: gclient setdep -r src-internal@fee597729b1d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ia4d7a81322d60444d4aa7c144eb7c07c047b6723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729557Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682876}
-
Josh Nohle authored
Bug: 951969 Change-Id: I102d0cfe3de99276eb157f7b0c00f1b48a74b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728544 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#682875}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f99c5871..748b4c7b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I83467dffe1f180cd5240fee91b5b4d154cca4976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729472Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682874}
-
Clark DuVall authored
This should help debug the Clank renderer hangs with network service. Bug: 934317 Change-Id: I78f69d5fafd05e4b8984601bc652b1d086d0ca49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726911 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#682873}
-
Ben Kirchman authored
This is a reland of 5a08e77e Revert of this CL was due to a build failure. Fix the build failure by adding the dependency for the new utils target to the Java Cronet implementation's package target. Original change's description: > Move Java classes needed by all Java Cronet implementations to utils. > > To minimize code duplication, code that can be shared between the > JavaUrlRequest and the FakeUrlRequest should be moved to a new shared > file: JavaUrlRequestUtils. > > Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325 > > Bug: 669707 > Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Benjamin Kirchman <kirchman@google.com> > Cr-Commit-Position: refs/heads/master@{#681835} Bug: 669707 Change-Id: Ifd4f6118e1bc3f41a151f942199e69451d5ac5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724502Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#682872}
-
Wez authored
The test is supposed to create a new sub-job of its parent job, so that it can watch for the job becoming empty. Instead it was just duplicating the handle to its existing job, causing the test to flake if any other test batch process happened to be running in that job at the time. Bug: 989085 Change-Id: I17a287dcb6e5b0a7351294f6297ed355eb3e15ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728440 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682871}
-
Adrienne Walker authored
Currently, gpu::CommandBufferHelper::GetLastState locks a mutex to check the latest token state for every outstanding block in the transfer buffer. Instead, take the lock once, and reuse the cached value when looping over all the blocks. On vmiura's "300 invalidation" repaint test in callgrind on Linux, the number of cycles spent per library changed like this, filtered to RasterBufferImpl::Playback and CommandBufferService::Flush: | gpur | oopr | % diff -------------+--------+--------+------- total cycles | 256.2m | 235.3m | 8.1% libbase.so | 19.9m | 13.1m | 34.3% libgpu.so | 16.1m | 8.7m | 45.9% libpthread | 5.7m | 1.5m | 72.8% The callstack this avoids is: gpu::FencedAllocator::GetLargestFreeSize -> gpu::FencedAllocator::FreeUnused -> gpu::CommandBufferHelper::HasTokenPassed -> gpu::ComamndBufferProxyImpl::GetLastState -> base::internal::LockImpl::Lock -> pthread_mutex_lock Change-Id: Ic7d7a93ff6b6833ce978318d3ad406afeca76c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725030Reviewed-by:Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#682870}
-
Owen Min authored
The test is flaky. Bug: 986904 Change-Id: I670a6b99b5ec6448b4cc8cbf7f1569112d2d8bcb Tbr: tbansal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729396Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682869}
-
Robert Ogden authored
Bug: 988679 Change-Id: Ifaee6742dc098c1c2fb90aceb8a4ef97766e52bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728433 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
