- 09 Nov, 2018 40 commits
-
-
Bin Wu authored
Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look." This reverts commit 683a3487. In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/steps/net_unittests/0/stdout The msan error goes away after I changed the following bzero(s) into memset(s): diff --git a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h index 94f055f35564..198e266dfdf2 100644 --- a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h +++ b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h @@ -102,7 +102,7 @@ class QuicMMsgHdr { } storage_.reset(new char[StorageSize()]); - bzero(&storage_[0], StorageSize()); + memset(&storage_[0], 0, StorageSize()); int i = -1; for (auto it = first; it != last; ++it) { diff --git a/net/third_party/quic/platform/impl/quic_socket_utils.cc b/net/third_party/quic/platform/impl/quic_socket_utils.cc index c25f4697dbef..1f252e50f953 100644 --- a/net/third_party/quic/platform/impl/quic_socket_utils.cc +++ b/net/third_party/quic/platform/impl/quic_socket_utils.cc @@ -78,7 +78,7 @@ void* QuicMsgHdr::GetNextCmsgDataInternal(int cmsg_level, if (cmsg_ == nullptr) { DCHECK_EQ(nullptr, hdr_.msg_control); - bzero(cbuf_, cbuf_size_); + memset(cbuf_, 0, cbuf_size_); hdr_.msg_control = cbuf_; cmsg_ = CMSG_FIRSTHDR(&hdr_); } else { R=rch@chromium.org Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106 Reviewed-on: https://chromium-review.googlesource.com/c/1329348 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#606891}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Change-Id: Ia0a6622596753d87888e480401e38f7ef61ae539 Reviewed-on: https://chromium-review.googlesource.com/c/1326013Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#606890}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/827de2c806ba..5fa11106b909 Created with: gclient setdep -r src-internal@5fa11106b909 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie1b9b04d41e2a6dfe8e4fa45f0d25892052660e1 Reviewed-on: https://chromium-review.googlesource.com/c/1329503Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606889}
-
Fady Samuel authored
viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an allocation time for that viz::LocalSurfaceId. The purpose of this allocation time is to determine how long it takes for a surface to get embedded once an ID has been allocated for it. There was some concern raised about drift between LocalSurfaceIds and allocation times and so a previous CL bundled the two together in a class. This CL plumbs LocalSurfaceIdAllocation to more places to ensure the two quantities remain in sync with one another. This CL plumbs removes various accessors on ChildLocalSurfaceIdAllocator and ParentLocalSurfaceIdAllocator that return an allocation time or LocalSurfaceId independent of the other. This is to encourage future plumbing of LocalSurfaceIdAllocation instead. Bug: 655231 Change-Id: I3118cc06e0afa04914a0e2e7457ffdfd5ad5778d Reviewed-on: https://chromium-review.googlesource.com/c/1327573Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606888}
-
Joe DeBlasio authored
This CL modifies fixes a bug in which metrics were not being recorded on Android when notification permissions were revoked. It adds a missing ScopedRevocationReporter for Chrome-visible changes, and adds detection code for when notification permissions are revoked in Android O+ system channel settings. Bug: 782126 Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75 Reviewed-on: https://chromium-review.googlesource.com/c/1324394 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606887}
-
Sky Malice authored
Bug: 901179 Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615 Reviewed-on: https://chromium-review.googlesource.com/c/1315358 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#606886}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s' 2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles" Created with: gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958 Reviewed-on: https://chromium-review.googlesource.com/c/1329505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606885}
-
https://crrev.com/c/1272937Hayato Ito authored
Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target can be null when GetElement() returns nullptr. Bug: 892970, 893449, 902287 Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1322177 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606884}
-
Mathias Carlen authored
Before this patch the payment request UI did not properly handle cancel and back button. This patch notifies the Autofill Assistant controller to shut down gracefully with a 'give up' message whenever the payment request UI has been canceled. Bug: 806868 Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1326499 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606883}
-
Lan Wei authored
After we expose test_driver.Actions API to web users, we add their implementation in our testdriver file, and fix the wpt tests of Actions API. Bug: 893480 Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c Reviewed-on: https://chromium-review.googlesource.com/c/1289119 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606882}
-
Becky Zhou authored
Bug: 891877 Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b Reviewed-on: https://chromium-review.googlesource.com/c/1325082 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This adds the command line option, --natvie_input, that VEA unittest passes DMABuf-backed video frame to VEA. DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on Chrome OS, it needs to set up Ozone environment properly. Therefore, this change also makes VEA unittest dependent on Ozone. BUG=chromium:895230 TEST=VEA unittest on eve w/wo --native_input TBR=posciak@chromium.org Change-Id: I2998f0695813e5e1b77ae2136140eebc385636bf Reviewed-on: https://chromium-review.googlesource.com/c/1329121Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606880}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/31b2546b..f6ed3c5d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ida402fad2dfa8556ea7ae1c22d42058bfb90fa6f Reviewed-on: https://chromium-review.googlesource.com/c/1329301Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606879}
-
Denis Bessonov authored
WebRange default constructor is both inline and BLINK_EXPORT. Using WebRange() in different blink modules (for example, blink_core and blink_controller) results in duplicate symbols during linking. This CL out-of-lines this constructor to ensure that exported constructor has only one implementation. Bug: 903712 Change-Id: Ifdc947c4d0001a4be7404950a6a1639bc9877372 Reviewed-on: https://chromium-review.googlesource.com/c/1328964Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606878}
-
Steve Kobes authored
We prolong the lifetime of UkmPageLoadMetricsObserver to permit jank score reporting at session end for tabs that start or become hidden, but avoid extra reporting of other metrics by checking was_hidden_. The OnFinalLayoutStabilityUpdate hook is removed in favor of passing PageRenderData to existing hooks through PageLoadExtraInfo. This lets the observer decide when to report. UKM collection review doc: go/lsukmrev Bug: 581518 Change-Id: I2983dff155872f3080474e09df784d20b3cb08d3 Reviewed-on: https://chromium-review.googlesource.com/c/1299917 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Lily Chen authored
This change allows the priority of an SSLConnectJob to be changed. If the reprioritization occurs while the job is establishing its underlying connection, the priority change is also passed down to the lower-level socket pool. Bug: 166689 Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a Reviewed-on: https://chromium-review.googlesource.com/c/1327423 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606876}
-
Tatiana Buldina authored
Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1 Reviewed-on: https://chromium-review.googlesource.com/c/1327168Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#606875}
-
Philip Rogers authored
PaintPropertyTreeNode::Changed is used for in-layer raster invalidation, and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed to account for the case when non-transient paint controllers in GraphicsLayers would clear property tree changed values before the values could be used for damage. As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a non-transient paint controller, and at the end of painting a transient paint controller is created and each GraphicsLayer's cc::Layer is inserted as a foreign layer into the transient paint controller. This patch changes BGPT to clear all property tree changed bits after damage has been calculated in PaintArtifactCompositor. It is implemented with a recursive walk of the GraphicsLayer tree. Bug: 899628 Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308 Reviewed-on: https://chromium-review.googlesource.com/c/1327804 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606874}
-
Sky Malice authored
native. Bug: 901331 Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3 Reviewed-on: https://chromium-review.googlesource.com/c/1315929 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
-
Scott Graham authored
Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb Reviewed-on: https://chromium-review.googlesource.com/c/1329506 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606872}
-
Dave Tapuska authored
Feature first shipped in M57. BUG=611276 Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128 Reviewed-on: https://chromium-review.googlesource.com/c/1323628Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606871}
-
Mathias Carlen authored
This patch is the first step to integrate the payment request UI into the autofill assistant sheet. The patch has and leaves a few rough edges but we'll deal with that piece by piece. In particular, the dismiss logic needs to be handled differently, so does the error view logic. Note: The DimmingDialog is reverted to package default visibility since the dependency from autofill assistant is removed here. Bug: 806868 Change-Id: I25b83b804e13bbdec5d2a1688dd01cd085615b38 Reviewed-on: https://chromium-review.googlesource.com/c/1324451 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
David Jean authored
Bug: 845472 Change-Id: Ie26e9022b60612b5ef90c7e9b2bde4202e6e745c Reviewed-on: https://chromium-review.googlesource.com/c/1319594 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606869}
-
Lei Zhang authored
Windows archives extract out into a directory called chrome-win. There is no chrome-winp directory. TBR=robertocn@chromium.org Change-Id: Ia5ee2725e107f32c44105ca396e28a4c0a06844c Reviewed-on: https://chromium-review.googlesource.com/c/1313731 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#606868}
-
Yi Su authored
iOS9 is not supported by Chrome iOS and iGSA anymore, the presubmit check for risky ES6 grammar(const/let/lambda) can be removed now. Change-Id: I5a35d54097dbd215393aaba78868107befdc93b6 Reviewed-on: https://chromium-review.googlesource.com/c/1329249Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606867}
-
David 'Digit' Turner authored
This CL fixes a bug in the logic used to locate locale .pak files inside bundle splits. The reason for the bug is that bundletool wants to use deprecated language names (i.e. 'iw' instead of 'he') to store asset files. As an example, for Hebrew, Chrome was looking at: assets/locales#lang_he/he.pak While the file was really stored under: assets/locales#lang_iw/he.pak The CL fixes the issue for Hebrew, Yiddish and Indonesian and Filipino. BUG=902915 R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org Change-Id: I420158c30ba33c6203495af9453877722271e104 Reviewed-on: https://chromium-review.googlesource.com/c/1327203 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f Reviewed-on: https://chromium-review.googlesource.com/c/1325393Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606865}
-
Antonio Gomes authored
... and remove the later. This is a follow up of mmenke's request in [1]. [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70 TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc) TBR=jam@chromium.org (content/browser/loader/resource_loader.cc) BUG=773295 Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1 Reviewed-on: https://chromium-review.googlesource.com/c/1320769 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
When PasswordGenerationAgent copies the password value from the password field to "Confirm Password" filed, a blur event is generated. It hides the currently open generation prompt. Those events are just side-effects of how the class works and should be ignored. Bug: 899756,850079 Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444 Reviewed-on: https://chromium-review.googlesource.com/c/1327205 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#606863}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s' 2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process" Created with: gclient setdep -r src/third_party/perfetto@cf90797ef05a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f Reviewed-on: https://chromium-review.googlesource.com/c/1329362Reviewed-by:
-
Fernando Serboncini authored
Otherwise we get weird behavior on filters while transforming. TBR= Bug: 901759 Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251 Reviewed-on: https://chromium-review.googlesource.com/c/1329342Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#606861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8 git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs Created with: gclient setdep -r src/third_party/skia@c244c2fbbbf8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155 Reviewed-on: https://chromium-review.googlesource.com/c/1329045Reviewed-by:
-
Nico Weber authored
Reverts parts of https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should no longer be needed after https://chromium-review.googlesource.com/c/1304441 Bug: 870584 Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27 Reviewed-on: https://chromium-review.googlesource.com/c/1328823Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606859}
-
Nektarios Paisios authored
Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file In case the files are somehow not found or unreadable on the bots, the tests should fail. R=dmazzoni@chromium.org Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171 Reviewed-on: https://chromium-review.googlesource.com/c/1324232Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba Created with: gclient setdep -r src-internal@827de2c806ba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab Reviewed-on: https://chromium-review.googlesource.com/c/1329361Reviewed-by:
-
Guido Urdaneta authored
This CL adds resizeMode support for MediaStreamTrack.getConstraints() and marks resizeMode as a supported constrainable property. Support for getUserMedia(), applyConstraints() and getCapabilities() will be added in follow-up CLs in this series. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE Bug: 854980 Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3 Reviewed-on: https://chromium-review.googlesource.com/c/1309749Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#606856}
-
Eugene But authored
Before this CL PageLoaded was called right from didFailProvisionalNavigation:, where URL may still represent the previous page. Bug: 903497 Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a Reviewed-on: https://chromium-review.googlesource.com/c/1327608Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606855}
-
Eugene But authored
SadTabTabHelper now calls sadTabTabHelperDidHide: and sadTabTabHelper:didShowForRepeatedFailure: Bug: 901563 Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5 Reviewed-on: https://chromium-review.googlesource.com/c/1327167Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606854}
-
Pavel Shmakov authored
The code is restructured according to the high-level MVC picture, but low-level details such as view binding mechanism are not used, as it seems to be an overkill at this point. We can easily install those mechanisms in future should the model become more complicated. Verification is extracted to TrustedWebActivityVerifier in the controller layer. Several controllers observe verification and update the model. Several independent Views are observing the changes in the model and updating themselves accordingly. Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113 Reviewed-on: https://chromium-review.googlesource.com/c/1323069Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606853}
-
Tim Volodine authored
The idea of this CTS filter is similar to the filter we have for instrumentation tests, i.e. mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains failing tests and their corresponding issues / root causes. The current filter contains results from a local run for a subset of tests (the actual CTS is not running yet). The CTS filter also augments the instrumentation test filter for test coverage that is missing from instrumentation tests. BUG=903822,902330,841556 Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d Reviewed-on: https://chromium-review.googlesource.com/c/1319677 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#606852}
-
