- 19 Jan, 2018 29 commits
-
-
Bill Budge authored
- Raises the limit of direct mapped allocations. WASM needs to be able to allocate 2GiB regions. Bug: chromium:801604 Change-Id: I77e905ff4ae6f5ca66de9daf30f19bb6f7b54089 Reviewed-on: https://chromium-review.googlesource.com/875301Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#530380}
-
Brandon Jones authored
Allows exclusive XRSessions to submit frames to the XR compositor, which enables the most basic end-to-end usage of the API. Bug: 670510 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I704aaac3325538e2db8f8b6d6f8d341492835a14 Reviewed-on: https://chromium-review.googlesource.com/871790 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#530379}
-
George Burgess IV authored
Without this, you need to change the AFDO filename every time if you want the world to be rebuilt. Bug: 794750 Test: touched an AFDO profile; ninja tried rebuilding ~21K files. Change-Id: I802feac51c52d66072860d2f341d7f88d10fdef1 Reviewed-on: https://chromium-review.googlesource.com/875137Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#530378}
-
Ken Rockot authored
This was disabled on Chrome OS + ASAN due to flakiness. I suspect the flakiness is caused by use of fork() in a multithreaded environment, via base::GetAppOutputAndError. This CL changes the offending test to not use the ContentBrowserTest fixture and instead simply call base::GetAppOutputAndError from a single-threaded unit test. The manually launched browser test in the launched subprocess remains unchanged. Renames the browser test fixture to ServiceManagerContentBrowserTest to disambiguate from the new non-browser-test test case. Bug: 803188 Change-Id: I5d1be42cb35ccc6ec79ed1cbda83018291aecaa2 TBR=jam Change-Id: I5d1be42cb35ccc6ec79ed1cbda83018291aecaa2 Reviewed-on: https://chromium-review.googlesource.com/875269 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#530377}
-
Thomas Guilbert authored
MediaPlayerRendererClient owns a StreamTextureWrapper via a unique_ptr with a custom deleter. The STW owns a StreamTextureProxy, which periodically calls back to the MPRC on the compositor thread. The STW's custom deleter starts by clearing the STP's callback into the MPRC. However, it is possible for the STP to start running the callback, just as the MPRC is being destroyed. The STW's unique_ptr is nulled, and the custom deleter blocks on the lock protecting the STP's callback. Simultaneously, the STP calls back in the MPRC, and tries to use a null STW pointer. This CL fixes the issue by making sure that the first thing that happens during the MPRC's destruction is clearing the STP's callback. This means that if there is simultaneously a call to the MPRC's dtor and the STP's callback, one of two things will happen: - The STP acquires the lock, the MPRC's destruction blocks, the callback completes successfully, the MPRC acquires the lock, the STP's callback is cleared and the MPRC is destroyed. - The MPRC acquires the lock, the STP blocks, the MPRC clears the STP's callback and continues its destruction, the STP acquires the lock and does not run the callback. Bug: 688466 Test: Manual sanity check Change-Id: I12904a788b8a8e9c7238fb952c497b41dd8f7d6b Reviewed-on: https://chromium-review.googlesource.com/875300Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#530376}
-
edchin authored
This CL achieves several objectives: 1) Removes the use of |rootViewController| to present UI. 2) Separates launching from the policy decider logic. The tab helper holds the policy decider logic. The app launcher coordinator does the actual app launching. 3) Better naming: "ExternalAppLauncher" was renamed to "AppLauncher". It is more concise, and "external" did not provide any value as there is no "internal app". 4) Better folder structure: the tab helper was pulled out to it's own folder /chrome/browser/app_launcher. The app launcher coordinator lives in /chrome/browser/ui/app_launcher. 5) Unit tests were added to the coordinator and tab helper. Bug: 791792 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I53ab441db05b85211102df169a264f0fcf53195c Reviewed-on: https://chromium-review.googlesource.com/837725 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530375}
-
Sorin Jianu authored
TBR: kenrb@chromium.org Bug: 798476, 802828 Change-Id: I62f25924477f4d281483063bfb0a56b93252db90 Reviewed-on: https://chromium-review.googlesource.com/875294Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530374}
-
Peter Kasting authored
This applies the Harmony "toast" spacing values, using margins (a la the find bar). BUG=686285 TEST=none Change-Id: I6e60008ec44030661dabcd4d959229d76ee8f833 Reviewed-on: https://chromium-review.googlesource.com/875140Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#530373}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e871d8f. With Chromium commits locally applied on WPT: e8a79119 "Fixed wpt csp reporting tests and moved over chrome internal ones" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10312 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I78df91b1009dc663433d267f7d12aa8d1afbdfd1 Reviewed-on: https://chromium-review.googlesource.com/874798 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530372}
-
Jian Li authored
Thee're some differences between RFC 2047 which we should be used to encode header value and RFC 2045 for body: 1) Use CRLF+SPACE for soft line break. 2) SPACE and TAB should always be encoded. 3) Multiple encoded text should be used Did manual test with FAR file manager w/ Observer plugin and 7-Zip w/ eDecoder plugin. Bug: 794835 Change-Id: I5b87b7392d2208dd58bf512c7ee59c87bc32a85a Reviewed-on: https://chromium-review.googlesource.com/835009Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#530371}
-
Conley Owens authored
This change replaces the NewTabPageInterceptorService with a NewTabPageNavigationThrottle. The throttle reduces complexity, but it is also neutral regarding the network stack / network service, so it fixes the NewTabPageInterceptorServiceTests that were broken with the NetworkService feature enabled. These tests are now renamed NewTabPageNavigationThrottleTest. BUG=802926 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iec0664df33e79d6bcc18f60aecc4017de7f65858 Reviewed-on: https://chromium-review.googlesource.com/868994 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530370}
-
Eric Stevenson authored
This makes errors more readable and easier to debug. Bug: 771347 Change-Id: I4203e1fb4c9dbe76b58928369d6fc373590f6980 Reviewed-on: https://chromium-review.googlesource.com/874951Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#530369}
-
Artur Khachatryan authored
Test testGoBackAndGoForward appears to be flaky for Linux and mac platforms. Disabling test execution for those platforms. Test fails with the following error: UnknownError: unknown error: session deleted because of page crash from unknown error: cannot determine loading status from tab crashed (Session info: chrome=65.0.3324.0) (Driver info: chromedriver=2.35.530041 (c39e772a),platform=Linux 4.4.0-109-generic x86_64) Bug: chromium:803678 Change-Id: I7a4f0c5fd5cb9255b57e2e3e248e7d51787c0939 Reviewed-on: https://chromium-review.googlesource.com/875303Reviewed-by:John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#530368}
-
Bailey Berro authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/15e1a468124f..1b879ee32f68 $ git log 15e1a4681..1b879ee32 --date=short --no-merges --format='%ad %ae %s' 2018-01-16 baileyberro smbprovider: Add DeleteEntryOptions protobuf to systemapi Created with: roll-dep src/third_party/cros_system_api Change-Id: Ib6852f507035e874f326e834c89be5a856a5286f Reviewed-on: https://chromium-review.googlesource.com/875232Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#530367}
-
erikchen authored
There's currently no mechanism to wait until profiling has started. This means that the results are racy, and sometimes don't contain heap dumps for the respective processes. Bug: 803568 Change-Id: I28b4ba5f741daaec7a8933cfd6c028abb8f83822 Reviewed-on: https://chromium-review.googlesource.com/874796Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530366}
-
Ted Meyer authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/b64dedac9d1d..3e444ad8860b $ git log b64dedac9..3e444ad88 --date=short --no-merges --format='%ad %ae %s' 2018-01-17 tmathmeyer avcodec/arm/sbrdsp_neon: Use a free register instead of putting 2 things in one 2018-01-17 tmathmeyer Revert "Temporary fix for crbug/796028" Created with: roll-dep src/third_party/ffmpeg Change-Id: I007811a3f579db47dab19734c3e781d7103c82ac Reviewed-on: https://chromium-review.googlesource.com/871503Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#530365}
-
Victor Costan authored
Bug: 803669 Change-Id: Ia7368424b310f58883a9d76ec4abba711a26464c Reviewed-on: https://chromium-review.googlesource.com/875267 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#530364}
-
Scott Violet authored
This avoids a PostTask and is needed for moving loading of local state earlier (when ResourceBundle won't be loaded). BUG=800358 TEST=covered by tests Change-Id: I7336dbec6474b0d29aa8596110f9c13ad5128148 Reviewed-on: https://chromium-review.googlesource.com/868735 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#530363}
-
Kent Tamura authored
The first CL generated by the tool is expected to break build, and the second CL generated by the tool is too large. We should fix build issues rather than reverting the CL. Bug: 578345 Change-Id: Ieee3f3a4a085759b345a844010c02664a3f45d1e Reviewed-on: https://chromium-review.googlesource.com/872814Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#530362}
-
Daniel Cheng authored
This is simlar to base::LazyInstance<T>::Leaky but intended for use in function-local scope. This is intended to be a drop-in replacement for: - CR_DEFINE_STATIC_LOCAL(...); in function scope - static T* x = new X; in function scope - static T& x = *new X; in function scope - base::LazyInstance<T> x; in global scope and should be preferred in new code. Change-Id: I75eda47e7dca8205f4086bd298839c261454a3e7 Reviewed-on: https://chromium-review.googlesource.com/869351 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#530361}
-
Yuichiro Hanada authored
When seeing a reserved keyboard shortcut, exo display server sends keyboard leave/enter event with pressed keys information instead of key events. only one IME is enabled. Bug: 801088 Test: Manual. Confirm that Ctrl-Space is sent to Android apps when Change-Id: I207434b45690f231601cb6187e35a806f8c69f89 Reviewed-on: https://chromium-review.googlesource.com/866655Reviewed-by:David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#530360}
-
Renee Wright authored
Bug: 775360 Change-Id: I27ee051b48ca02cd6021638fb6a269a584b41384 Reviewed-on: https://chromium-review.googlesource.com/872692Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#530359}
-
Sorin Jianu authored
TBR: creis Bug: 803641 Change-Id: I72aec7f22a7e9af818e9b27576a378095b8d4f46 Reviewed-on: https://chromium-review.googlesource.com/875189Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530358}
-
Daniel Bratell authored
The GetLocalState() method in cryptauth clashes with another GetLocalState() in jumbo builds, and since there is only one caller off this one, it might as well be inlined. Bug: 746957 Change-Id: I63e33c5c94930cd0dfeaa27c1421ce81c9865feb Reviewed-on: https://chromium-review.googlesource.com/873922Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#530357}
-
Eric Lawrence authored
Update entries in the HSTS preload list. TBR=palmer@chromium.org Change-Id: Idee0e0204f0027747fab7db2f45e7338a7c00bd3 Reviewed-on: https://chromium-review.googlesource.com/874600Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#530356}
-
Patti authored
r530031 converted all the icons used in Page Info to vectors. Delete all the unused permissions icons that were previously used. Bug: 535074, 647551 Change-Id: Ic4e6648f61751ffa16a7afeb6f61f8a9088cdd3b Reviewed-on: https://chromium-review.googlesource.com/872471Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#530355}
-
Hector Carmona authored
This will make the code/error association very explicit by keeping the code snippet near the stack trace inside the error that is being investigated. See bug for screenshots/video. Bug: 800994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a781bd304b498edf2a5b19d58635824a54a575b Reviewed-on: https://chromium-review.googlesource.com/861915 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530354}
-
Anna Maria authored
Adds UKMs for how a user landed on a webpage in VR browsing, and whether they used fullscreen functionality while there. Bug: 795967 Change-Id: Id7968a622b12bbea4365e77f0956c0d566b2b25f Reviewed-on: https://chromium-review.googlesource.com/861224Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#530353}
-
Findit authored
Revert "cros: Manual revert rename TabletPowerButtonController to ConvertiblePowerButtonController and create PowerButtonUtil." This reverts commit 790d637d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 530295 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc5MGQ2MzdkZDk4MWEwNTJhY2MxYTNmNDNhYzU0OWEwMjY0M2IwM2EM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3814 Original change's description: > cros: Manual revert rename TabletPowerButtonController to > ConvertiblePowerButtonController and create PowerButtonUtil. > > changes in this cl, > Since we will put the logic of power button menu in > TabletPowerButtonController instead of creating a new controller. > Reverting related previous cls, > 1. Revert rename TabletPowerButtonController to ConvertiblePowerButtonController. > Related cl, > https://chromium-review.googlesource.com/c/chromium/src/+/852518 > 2. Revert the creating of PowerButtonUtil. > Related cl, > https://chromium-review.googlesource.com/c/chromium/src/+/852905 > > Bug: 799524 > Change-Id: I4883c7eb9f4b73fad9e8d862fbc106aee22072d4 > Reviewed-on: https://chromium-review.googlesource.com/874911 > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: min c <minch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530295} Change-Id: I973eeb163c50b1eab4ace70f0171d5f3f948a16d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799524 Reviewed-on: https://chromium-review.googlesource.com/874952 Cr-Commit-Position: refs/heads/master@{#530352}
-
- 18 Jan, 2018 11 commits
-
-
Christopher Cameron authored
Re-wrapping the CVPixelBufferRefs's IOSurface in pristine CVPixelBufferRefs makes a bug where frames repeatly flash incorrect content go away. There is no clear or documented reason why this should be required. Rather, it seems more intuitive to use the VTDecompressionSession CVPixelbufferRefs directly. This was observed only in a single fairly consistent repro case, so it is not clear that this indeed fixes the issue -- there was still occasionally a single flashed incorrect frame even with this fix in place. It may be that this fix makes the underlying issue less frequent, or it may be that this fix makes it so that a single "bad" CVPixelBuffer that we inevitably encounter (say, due to some peculiarity of the decoder) does not get repeatedly reused. This fix to increases fullscreen hardware decode video power consumption from 1.57W to 1.65W, entirely due to an increase in CPU power consumption. If this does indeed fix the bug, I consider this to be an acceptable price. This fix has no appreciable effect on non-fullscreen video power consumption. Bug: 702369 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd5f937695bbd7bb9c16084c3b23dc1968ee83c4 Reviewed-on: https://chromium-review.googlesource.com/867413 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530351}
-
Wei-Yin Chen (陳威尹) authored
Larger margin between controls, larger touchable area of seeker, and fixed drop-down menu with all items. Bug: 803117 Change-Id: Ic8b5b534aa684f09a5e28ad20685387fabc3eb23 Reviewed-on: https://chromium-review.googlesource.com/874753 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#530350}
-
Sammie Quon authored
Steps to reproduce in bug. Caused because the calculation is correct, but no relayout when minimized window gets reactivated. This cl will relayout the non client view which will layout the client view with the correct bounds. Also replaced some duplicate code in the test file with an already made function. Test: CustomFrameViewAshTest.* Bug: 802920 Change-Id: I0ca99fb837a5ddb0d6b78d2c22d1fb00e7b62230 Reviewed-on: https://chromium-review.googlesource.com/872095Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#530349}
-
Joel Hockey authored
Change-Id: Idba043f64ba464ca16ea72facac1a01d31574e7f Reviewed-on: https://chromium-review.googlesource.com/874972Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#530348}
-
Albert J. Wong authored
Also clean up some of the flag descriptions. Bug: 801006 Change-Id: I0641961e896db4af7f92171fa8bc78080c9e6f28 Reviewed-on: https://chromium-review.googlesource.com/874815 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530347}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4aadb7086420..27d718ebb298 $ git log 4aadb7086..27d718ebb --date=short --no-merges --format='%ad %ae %s' 2018-01-18 thestig Add jumbo build support for fxge and pwl. 2018-01-18 dsinclair Move XFA_IsCreateWidget to CXFA_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I98a691c3127b6a6fcd74637383b98c32c89217c6 Reviewed-on: https://chromium-review.googlesource.com/875135 Commit-Queue: <pdfium-deps-roller@chromium.org> Reviewed-by: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530346}
-
Maksim Ivanov authored
When extracting flags from command line, use the last occurrence of the end sentinel instead of the first one. This bulletproofs against potential injection of extra sentinel switches (although these should be sanitized by session_manager now), which could fool Chrome into not restarting when it's necessary due to extra flags. Also avoid crash/UB in case the sentinels come in reversed order. BUG=707539 TEST=new unit tests Change-Id: I5c20b1990e0b71e07076ec89285fccd52f1dc190 Reviewed-on: https://chromium-review.googlesource.com/844776 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#530345}
-
Daniel Bratell authored
Two files both used identical helper functions, GetBrowser(). This patch moves that function to a common utility file so that there is only one. This was noticed while doing jumbo compilation experiments, where the double GetBrowser() ended up in the same translation unit. Bug: 746957 Change-Id: I8ceaab0d4bd08395821b296dbd1bbda13c1aef78 Reviewed-on: https://chromium-review.googlesource.com/873921Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#530344}
-
Yuri Wiitala authored
FrameSinkVideoCaptureDevice is the glue between VIZ screen video capture and the video capture stack. Later changes will use this as the common base implementation to provide VIZ-based tab, desktop, and browser window capture. This change only introduces new implementation, but it is not activated/ connected to anything yet (other than content_unittests). Bug: 754872 Change-Id: Ib1648d61ec87adea042b29178eb3b0c7652008b2 Reviewed-on: https://chromium-review.googlesource.com/872390 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530343}
-
Tom Sepez authored
General-purpose (e.g. server_manager) switches can remain in zygote. Bug: 781334 Change-Id: I9750fb85fd7a2368c2d66b109e3afd07807d2d61 Reviewed-on: https://chromium-review.googlesource.com/875126Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#530342}
-
Bill Budge authored
This reverts commit be714803. Reason for revert: breaks unit test https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20(32)%20Tests/29093 Original change's description: > [partition_alloc] Allow 2 GiB direct mapped allocations. > > - Raises the limit of direct mapped allocations. WASM needs > to be able to allocate 2GiB regions. > > Bug: chromium:801604 > Change-Id: I559e55d2474623805eabae64f5b1f3dfe35a7acb > Reviewed-on: https://chromium-review.googlesource.com/868844 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530294} TBR=palmer@chromium.org,bbudge@chromium.org,haraken@chromium.org Change-Id: Ic9335529ebdb824b3f9e6ae972cb0489f6dc24ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:801604 Reviewed-on: https://chromium-review.googlesource.com/875151Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#530341}
-