GitLab

The message is deleted on the following line. (And GetReplyDeserializer() does
nothing other than release and return a scoped_ptr member. And yes, Messages
have virtual destructors.)


Review URL: https://chromiumcodereview.appspot.com/11720005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175243 0039d316-1c4b-4281-b951-d872f2087c98

Don't access owner() in the constructor; eventually doing this won't work, because InfoBarDelegates won't be owned at creation.  (It's fine right now, but this is more efficient anyway, since the caller already has a Browser*.)

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11740035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175242 0039d316-1c4b-4281-b951-d872f2087c98

Rename HungPluginTabHelper::InfoBarDelegate to HungPluginInfoBarDelegate for consistency with other infobars, and because the style guide pushes people away from member classes when not necessary.

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11748027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168210
TEST=Before any client connects, "xdpyinfo -display :20|grep -A1 dimensions" shows ~96dpi.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11782006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175240 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11696010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11748024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11778004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175237 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Builder&number=15352

> Add trace event Pepper API
> 
> This facilitates adding trace data to chrome://tracing from plugins.
> 
> - broke out trace_event.h into trace_event.h/trace_event_internal.h
>   for easier transplanting to plugin code by eliminating dependence on base/.
> - inlined trace_event.cc methods (4 total) so the trace_event_internal
>   implementation is contained in headers.
> - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side)
> 
> BUG=none
> TEST=base unittests, manual for plugin testing
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11464005

TBR=elijahtaylor@chromium.org
Review URL: https://codereview.chromium.org/11782008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175236 0039d316-1c4b-4281-b951-d872f2087c98

glXGetSyncValuesOML gives us a count of the number of refreshes that have occurred (media stream counter). We can use this and the time between successive UST counters to measure the period of the screen refresh.

BUG=none
TEST=by hand on stumpy and alex using xrandr to force different refresh rates


Review URL: https://chromiumcodereview.appspot.com/11752002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175234 0039d316-1c4b-4281-b951-d872f2087c98

This facilitates adding trace data to chrome://tracing from plugins.

- broke out trace_event.h into trace_event.h/trace_event_internal.h
  for easier transplanting to plugin code by eliminating dependence on base/.
- inlined trace_event.cc methods (4 total) so the trace_event_internal
  implementation is contained in headers.
- added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side)

BUG=none
TEST=base unittests, manual for plugin testing


Review URL: https://chromiumcodereview.appspot.com/11464005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162829
R=dhollowa@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11779004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175231 0039d316-1c4b-4281-b951-d872f2087c98

Restructured this code quite a bit to use the new shortcut magic.

Added tests which turned out to expose edge cases that I think weren't covered by the previous implementation (i.e. would potentially update shortcuts when unecessary -- flashing the desktop in the process -- or not do it when necessary).

BUG=142980
TEST=Pin Desktop shortcut to Start Screen or pin chrome.exe directly to the start screen via context menu.
Notice that there are now multiple shortcuts of Chrome (non-tiled; 1 for each "Pin to Start" action; upon launching Chrome those should all be merged down to one Chrome tile shortcut (not on the file system, but visually on the Start Screen itself).
Note: if you do try this; there is an intentional 15s delay before the migration kicks in to avoid delaying Chrome startup; so be patient, it will work ;)!

Review URL: https://chromiumcodereview.appspot.com/11712003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167811

Review URL: https://codereview.chromium.org/11787009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175229 0039d316-1c4b-4281-b951-d872f2087c98

Note that Google Chrome will continue to use bundled re2.
The option is off by default, and is intended for Linux distros.

BUG=165264
TEST=none

Review URL: https://codereview.chromium.org/11366051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175227 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175225 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp

BUG=136110

Review URL: https://codereview.chromium.org/11783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175224 0039d316-1c4b-4281-b951-d872f2087c98

This undoes the change r139605.

The only reported failure of this test on Windows was the exit status
0xc000008f problem, which was a problem with all NaCl tests on 32-bit
Windows (not just this test) and has since been fixed.

BUG=130349
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3227
TEST=browser_tests

Review URL: https://codereview.chromium.org/11778002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175223 0039d316-1c4b-4281-b951-d872f2087c98

Also remove an excess empty line.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11669021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175222 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11745025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175221 0039d316-1c4b-4281-b951-d872f2087c98

Currently when the avatar button is clicked a second time the avatar bubble closes then immediately opens again.

The problem is that the same mouse event that closes the bubble also causes to open again.

To fix this I've changed AvatarMenuBubbleView to track it's current instance. If a caller tries to show the bubble while an instance is already being shown then the show request is ignored.

BUG=107876
TEST=Clicked on the avatar button a second time and verified that the avatar bubble stayed closed.

Review URL: https://chromiumcodereview.appspot.com/11646008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175220 0039d316-1c4b-4281-b951-d872f2087c98

> Separate apk_info and jar_info and move to utils dir.
> 
> This is in preparation for adding uiautomator test runner
> which runs tests without an apk.
> 
> BUG=167331
> 
> Review URL: https://codereview.chromium.org/11741025

TBR=craigdh@chromium.org

These will be replaced with concept of test packages.
Review URL: https://codereview.chromium.org/11780003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175218 0039d316-1c4b-4281-b951-d872f2087c98

There are memory leaks in this patch in RebuildTableFromDelegate

BUG=
TBR=brettw@chromium.org,joi@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11784006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175217 0039d316-1c4b-4281-b951-d872f2087c98

R=gab@chromium.org
BUG=158785, 151676


Review URL: https://chromiumcodereview.appspot.com/11776003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175216 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175215 0039d316-1c4b-4281-b951-d872f2087c98

r94: Don't fail on ID overlap for 0th offset when 'offset' attribute is used.
r95 - r99: wiki page updates
r100: Support generating English strings.xml files in android2grd.

TBR=joi@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11780002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175214 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/chromeos/proxy_cros_settings_parser.cc:85 The port
number's final value comes from either the one specified in the Host
field or the one specified in the Port field.  Which one it would be
depends on which field is the last updated field, so the
overriding-it-whatever logic will be no longer necessary, and we
removed it.

chrome/browser/resources/options/chromeos/internet_detail.js:524 Add a
new function called "updateProxySetting", it is used to update the
proxy setting dialog's UI.  Whenever the internal data storing the
proxy information is changed, this function is called to update the UI
instantly.

chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:167
When the proxy data settings changed, make sure the view is updated
properly by calling JS function - updateProxySettings.

This patch was contributed by keenepan@linpus.com, and originally
reviewed in CL 

TBR=pastarmovj@chromium.org
BUG=chromium-os:26554
TEST=Setting manual proxy with "http://" prefix AND ":<port>" suffix, the proxy settings dialog UI will update and values will in right TEXTVIEW


Review URL: https://chromiumcodereview.appspot.com/11737038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175213 0039d316-1c4b-4281-b951-d872f2087c98

When running a custom xsession (such as ~/.xsession), execute it with
/bin/sh -c, which copes better with scripts that have the executable
permission set, but don't have a she-bang line, for example.

BUG=167409
TEST=Verify with ~/.xsession executable but no she-bang. Also verify with default unity-2d session on Precise.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11715003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175212 0039d316-1c4b-4281-b951-d872f2087c98

The D3D image processing code from AcceleratedPresenter moves to its own class, "ui/surface/accelerated_surface_transformer_win.h". This split allows the image processing code to be tested independently of the present-scheduling system, and so we add unit tests doing exactly that. Utility functions (loading d3d, creating temp surfaces) doing things commonly required by test, transform, and present code -- these functions are moved to a third location, "ui/surface/d3d9_utils_win.h"

The new unit tests -- which live in the ui_unittests binary -- make extensive use of pseudorandom image content, which I think is kind of neat. The tests use D3D HAL devices; I tried to use REF, but it didn't work, as StretchRect+LINEAR is not supported by refrast. So as a result we may have a GPU vendor dependency in these results.

BUG=161537
TEST=new ui_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174028

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174338

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174943

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175152

Review URL: https://codereview.chromium.org/11464017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175211 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11740038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175210 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=tdanderson
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11745029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175208 0039d316-1c4b-4281-b951-d872f2087c98

poll() returns 0 on a timeout, and doesn't set errno in that case,
so it makes no sense to use PLOG on a timeout.

Also, this change prints the number of bytes already read, to help distinguish
between a case where we never receive anything from the server, and a case
where we do receive response but not all of it, and the rest gets stuck
for some reason (buffering?).

BUG=96594

Review URL: https://codereview.chromium.org/11784004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175204 0039d316-1c4b-4281-b951-d872f2087c98

Loads bypassing the cache were counting as misses; this was bad for two reasons. Firstly, we were overcounting misses. Secondly, this was making misses look too performant.

This fix was actually uploaded in https://codereview.chromium.org/11637007/ , but in all the debate about the histograms in that patch, this fix got missed. Here it is again, all by itself.

R=rvargas@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11741034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175203 0039d316-1c4b-4281-b951-d872f2087c98

As per VideoDecoder API, "After this (Reset) call, the decoder is back to an
initialized clean state", which means that the render should be able to call
decoder->Read() again. To achieve this, the decoder should be initialized with
the new config even if it's in a pending reset.

BUG=168128
TEST=Added unittest to cover this.


Review URL: https://chromiumcodereview.appspot.com/11745012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175202 0039d316-1c4b-4281-b951-d872f2087c98

ANGLE doesn't need this loaded anymore.

Review URL: https://chromiumcodereview.appspot.com/11737027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168243


Review URL: https://chromiumcodereview.appspot.com/11741035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175200 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168292
TEST=tools/perf/run_multipage_benchmarks --browser=android-chrome-dev spaceport tools/perf/page_sets/spaceport.json

Review URL: https://codereview.chromium.org/11774002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167694
TEST=manually verified

Review URL: https://codereview.chromium.org/11746032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175198 0039d316-1c4b-4281-b951-d872f2087c98

The change was included by accident and possibly causing memory bots
failures.

BUG=

Review URL: https://codereview.chromium.org/11774003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175197 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11742043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175196 0039d316-1c4b-4281-b951-d872f2087c98