- 03 Jun, 2020 40 commits
-
-
Daniel Libby authored
Remote frames in CAP can end up incorrectly sized 0,0 on initial render which makes the iframes content not show up. The initial RenderFrameProxy::SynchronizeVisualProperties can come in before the RemoteFrameView has updated its compositing rect, which leaves the created SurfaceLayer with a 0,0 size. The RemoteFrameView compositing rect is only updated after Paint in the document lifecycle (see LocalFrameView::UpdateLifecyclePhasesInternal) and RenderFrameProxy::SynchronizeVisualProperties is called during intersection observer steps (also after paint). Since the synchronized properties have changed, a new SurfaceLayer is created at the correct size. When setting this SurfaceLayer on RemoteFrame, the existing invalidation of SetNeedsCompositingUpdate is not sufficient in CAP to have a new frame generated with the updated layer. In pre-CAP, this is not an issue - the oopif content appears with the first frame produced due to the ContentsLayer size update via CompositedLayerMapping::UpdateContentsRect in the compositing phase of the document lifecycle. To fix this for CAP, we add a SetNeedsPaint on the frame owner element's paint layer, and schedule another frame to ensure this gets picked up, since these updates typically will come in outside of the document lifecycle. R=pdr@chromium.org Bug: 1078255 Change-Id: I7333a79b3cfbca303fe388bea6d7df176b0e1f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227897Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774868}
-
Tomasz Wiszkowski authored
This change makes the EditUrl processor work like any other suggestions processor. Bug: 982818 Change-Id: I4edb1fb0b14be3599ec5f06ce37e28f7e3aa42fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225530Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#774867}
-
Matt Menke authored
The NetworkIsolationKey determine's what site's DNS cache shard is used for DNS lookups, and what requests can share a socket when using an H2/QUIC proxy. Also make Jingle and GCM pass in a NetworkIsolationKey that matches the URL they're connecting to. This will currently only leak DNS of the host they're looking up to top frames navigated to that same host, which seems fine (though once WebRTC is using NIKs, too, this will mean web-initiated WebRTC tunnels and GCM/Jingle tunnels to the same hos will share H2/QUIC proxy connections, which allows more interesting, but not too concerning leaks) Bug: 1082280 Change-Id: I4625327940dc3b2ec4022f7e0937a5fec51634b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209407Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#774866}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b711c4303271..0a6d1c0a60fe 2020-06-03 beaufort.francois@gmail.com Show warning when app shortcut icon size is too small and not square If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:955497 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I823417b0b56ac4d0f70a3c16414208818a189469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229269Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774865}
-
Mounir Lamouri authored
Bug: 1086776 Change-Id: I90070ae55c0f6b9ee790ac4df9af1722b75f2489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225746 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#774864}
-
Xiaocheng Hu authored
The feature has been tested in Beta for a while but doesn't have a field trial entry. This patch adds the entry for sanity, and as a preparation to roll out testing in Stable. Bug: 441925, 1088373 Change-Id: Id7b903ea83783fcee6158fafd142feb46341389c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209539Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#774863}
-
Torne (Richard Coles) authored
Move AwFeatures to org.chromium.android_webview.common to match AwSwitches and allow it to be used from ProductionSupportedFlagList. Change-Id: I5e8a1a4c584ef041be6b3903f6200ed9cb41edd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229585 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774862}
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: If0facfe1357ac0801658f2ab33d72a523b3e2392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181462 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774861}
-
Mustafa Emre Acer authored
This CL ignores messages marked as `translateable="false"` from the _CheckStrings presubmit. Bug: 1085611 Change-Id: I0ba74ef04a3b78ae39107989da34d3df7c1ba922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226070Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#774860}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib800e7cefd57b522de975963e16cf0c15cd0cae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229431Reviewed-by:
-
Johann authored
Bluetooth does not need the Observer part of the class as there is no cleanup done OnContextDestroyed. Add a Member<LocalDOMWindow> for the cases which need ExecutionContext. This also allows removing some To<LocalDOMWindow> casts. Change-Id: I7fac59360b213d869e9f1e19fab116d5309dc24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192465Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#774858}
-
Ted Meyer authored
Fixed: 1090966 Change-Id: I31b89f55341b364ae4a299f56abba3c996246441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228051Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774857}
-
Eric Roman authored
A similar change is not needed for POSIX platforms, as they log the SPN as part of the AUTH_LIBRARY_IMPORT_NAME event. Bug: 924746 Change-Id: I8cc1c8e5fb95334fa3ad078adeac3dff96f8d0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227176 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#774856}
-
Olivier Yiptong authored
Add a new method, FontMetadata::blob, which returns the contents of a valid font file as a Blob. FontMetadata::getTables returns the tables from a font file. However, developers have to synthesize the tables into a full font file before using the data. Returning the full font bytes saves developer effort, computational resources for merging the tables and increases the font byte throughput by a median of 4+X on a benchmark on my machine. This CL also fragments the tests for fonts for easier management. Large font table tests are skipped for now because they are flaky and sometimes cause crashes of content_shell on older versions of MacOS. Bug: 1087669 Fixed: 1076467, 1087669 Change-Id: Ia45037778aff3942335d7e4575d2d4174b5b00c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199987Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#774855}
-
Matt Menke authored
When there's an Expect-CT failure, a new URLRequest will be created to report the failure, and that request needs to have a NetworkIsolationKey to prevent cross-site information leakage. Bug: 969893, 1082280 Change-Id: I9260d6ed93e94e9409949ae8a395b6dcaf214a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219035 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#774854}
-
Dana Fried authored
Returns hover cards to (correct) margins in use before: https://chromium.googlesource.com/chromium/src/+/0733475c7252dbb36f94f8156f5a4248d92976f1 Did some other small changes for readability, including a tweak to the TabController::ShowDomainInHoverCards() function, which is not actually tab-specific (as its previous signature suggested), but rather tabstrip/ browser-specific. Bug: 1087759 Change-Id: Ie2e494d1f6d8eff69012b166e7e6a2c1c28506f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229398 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#774853}
-
Katie D authored
Bug: 1085442 Change-Id: Ied77b2c37dde8b27ca5f6068feb81d609c3453ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229432 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774852}
-
Hiroki Nakagawa authored
This CL adds following UMAs for navigation requests. PageLoad.Experimental.NavigationTiming.* - NavigationStartToFinalRequestStart - NavigationStartToFinalResponseStart - NavigationStartToFinalLoaderCallback - FinalRequestStartToFinalResponseStart - FinalResponseStartToFinalLoaderCallback - FinalLoaderCallbackToNavigationCommitSent See comments in navigation_handle_timing.h for the meaning of each milestone, and the design doc for details of these UMAs: https://docs.google.com/document/d/16oqu9lyPbfgZIjQsRaCfaKE8r1Cdlb3d4GVSdth4AN8/edit?usp=sharing Bug: 1068843 Change-Id: I766f318010dd5ce1b51f63537e878c78e11f5b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210176Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#774851}
-
Jonathan Ross authored
This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2222881 Adding an additional flake to the list TBR=ynovikov@chromium.org TEST=conformance2/textures/image_data/tex-2d-rgb8ui-rgb_integer-unsigned_byte.html Bug:1087993 Change-Id: I2c2829540060d954c796c736a449e16d4cb84870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229480Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774850}
-
Alexander Surkov authored
Extend property filtering capabilities by allowing to whitelist accessible objects the property should be called for. Format is: :LINE_NUM_0,...,LINE_NUM_N Bug: 1086610 AX-Relnotes: n/a Change-Id: Iea938c3ea1a6f766d40bec20a6e54be8d2bf5520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218610Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
chrome://settings/passwords/deviceVictor Hugo Vianna Silva authored
This CL prepares for the introduction of the new page, in order to make the diff smaller when the page functionality is actually added. It adds the necessary strings, the new '/device' route and the settings-subpage component where the new page will be injected. The route only exists for users with the kEnablePasswordsAccountStorage feature enabled. The page is not searchable from settings. This is to avoid users who are not eligible/opted-in to b4p accessing it by mistake. The page can still be accessed by those users if they type the URL on the omnibar, as happens for other pages in Settings. Bug: 1049141 Change-Id: I726549953b28abf9da0d764629d0fab529d9b877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228618 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#774848}
-
Muyao Xu authored
Bug: b/156816905, 1087003 Change-Id: I703a7b6f100c54081d016768885012bb7e981ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218550 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#774847}
-
Theresa Wellington authored
Add additional histograms to measure how long it takes to retrieve application restrictions from the OS when the returned Bundle is empty vs not empty. BUG=1086945 Change-Id: I7d1a32372810dfa2ac6c5d55f42a5b2fbbe57455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223370Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: I0e83dd3966c88bb9d5dda4744596bfa3729a606d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159789 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Dominic Farolino authored
Bug: 1079372 Change-Id: Ie1a116405cf89a4fa07e1716ec36170c75ba55fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190034 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Create a viz::ToMTLPixelFormat helper function, and use it in the shared image factory, and in the output surface allocation. Update the default gfx::BufferFormat for SkiaOutputDeviceBufferQueue for macOS, and add a TODO noting that the correct value should be determined at the Reshape call, and not at initialization. This is enough to get --enable-features=SkiaRenderer,Metal to draw the browser and some simple pages. Bug: 894929 Change-Id: I3fde39349fecaea856293609e5b877c49e46d0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225485 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#774843}
-
Yi Gu authored
Bug: 1088687, 1088689 Change-Id: Ifbbd3e69bb6c777df08667a1000fb25945592f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225748Reviewed-by:
-
Mike Wittman authored
The assertion is implemented with DCHECK so is non-reentrant. It cannot be safely invoked from the GetItems() functions since they are invoked while the target thread is suspended. Independent of that the assertion does not work in general on Android because the checking done by base::Lock::AssertAcquired() is too restrictive. Bug: 1004855 Change-Id: Ia2b390283844adf640077e7ee34650bf610cca09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225784 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#774841}
-
Wei Li authored
Author: pkasting@chromium.org Examples: tluk@chromium.org Markdown: weili@chromium.org Bug: none Change-Id: Ibb81c34929b33479124d49aa2654468fc89564bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224604 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774840}
-
Matt Wolenetz authored
Changes the keyframeness verification to use a StrictMock. Previously, an unexpected call on the non-strict Mock would not always result in a test failure. Discovered while working on bug 1079034. BUG: 1079034 Change-Id: I4071fa5da4c2f349254e6bad4c01d67fc7e3935c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229157 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#774839}
-
Rakina Zata Amni authored
For FindInPageBestEffortPriority experiment. Bug: 1063199 Change-Id: I9ca7f639cf4d15937b5dbd024e9a61e606a7a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227713Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#774838}
-
Hazem Ashmawy authored
No change to logic, just moving some files around. Both of nonembedded UMA recorder and replayer classes are just used in a particular place and are not shared (or "common") between webview code. So This moves them closer to where they are actually used: - AwNonembeddedUmaRecorder is only used in nonembedded processes so it's moved to nonembedded dir. - AwNonembeddedUmaReplayer is only used in the browser process so it's moved alongside the AwMetricsServiceClient. This should align better with the scope of the current webview subdirectories structure and help having better OWNERs scope for each class. Bug: N/A Test: N/A Change-Id: I34d8984956e8d657c8e70874f28de25cdc199bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228149 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a4dfe24d7696..f84ab8e2ddfa 2020-06-03 steveanton@webrtc.org Add publicly visible mock for PeerConnectionFactoryInterface 2020-06-03 steveanton@webrtc.org Mark mock_peerconnectioninterface.h as publicly visible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I94ea6e02ee2b713a8f5f4dc0c56a75e3c4bce487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229351Reviewed-by:
-
dstockwell authored
Bug: 1089736,1088568,1088567,1088566,1088565 Bug: 1088564,1088563,1088562,1088561,1088560 Bug: 975722,975448 Change-Id: Icb1104cc5db2f636fa4e794329b4477daffb6894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224419Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
Bug: 1063144 Change-Id: Iea6a7b5ecf1089eef11237c401433ca9a59e9e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166360 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#773852} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227239 Cr-Commit-Position: refs/heads/master@{#774834}
-
Marcus Pasell authored
Update the enums used by the BrowsingDataRemover to be 64bit unsigned to make room for future additions. Update usages and bitmasks to also reflect this change. Bug: 668114 Change-Id: I4279e1a2f0ab90e580e47d384d7d75d9be5c8b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200460Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Marcus Pasell <mapasell@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774833}
-
Henrique Ferreiro authored
On Aura platforms, calling display::screen::GetDisplayNearestView() with a nullptr as the native view always results in the primary display being returned. Use this fact to implement GetDefaultScreenInfo() in terms of GetNativeViewScreenInfo(). Change-Id: I51275e03449f73450d4aa20629a674beb7298182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228531Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#774832}
-
Sunny Sachanandani authored
This partially reverts commit 403648e2. The reason for limiting this change to SkiaRenderer, and using the old path for GLRenderer is to minimize risk for merging this fix to M84. Once merged, this CL will be reverted so that we use the same code path for both GLRenderer and SkiaRenderer. Bug: 1078551 Change-Id: Ia058a476c3503546a910c6c61e6f126d257c8ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229155 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#774831}
-
Xi Han authored
Bug: 1072499 Change-Id: I9494b99cc0dbbe29c9b8f3741b753b58b3a9259c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225285Reviewed-by:
-
Ionel Popescu authored
This CL updates the date and select behavior so that Enter submits the form. The new behavior consistent across platforms is: - Enter submits the form - Space opens the popup Bug: 1087503 Change-Id: I84b28ef5f4ab0c6209852bc9c6707dc26299c336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227120 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#774829}
-
